[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335365#comment-14335365 ] Yongjun Zhang commented on HDFS-7280: - Hi [~wheat9], Thanks for your work on this jira. I have some questions, in general, what impact it is if there is any on user side when we change from using netty3 to netty4? Anything special users need to do? any compatibility issue with tools that interface with hadoop? Thanks. Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.7.0 Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188274#comment-14188274 ] Hudson commented on HDFS-7280: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #727 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/727/]) HDFS-7280. Use netty 4 in WebImageViewer. Contributed by Haohui Mai. (wheat9: rev 675bca2968700d3627449700b827c3771827cef8) * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/WebImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/pom.xml Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.7.0 Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188340#comment-14188340 ] Hudson commented on HDFS-7280: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1941 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1941/]) HDFS-7280. Use netty 4 in WebImageViewer. Contributed by Haohui Mai. (wheat9: rev 675bca2968700d3627449700b827c3771827cef8) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/WebImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.7.0 Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188383#comment-14188383 ] Hudson commented on HDFS-7280: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1916 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1916/]) HDFS-7280. Use netty 4 in WebImageViewer. Contributed by Haohui Mai. (wheat9: rev 675bca2968700d3627449700b827c3771827cef8) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java * hadoop-hdfs-project/hadoop-hdfs/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/WebImageViewer.java Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.7.0 Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187761#comment-14187761 ] Hudson commented on HDFS-7280: -- SUCCESS: Integrated in Hadoop-trunk-Commit #6376 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6376/]) HDFS-7280. Use netty 4 in WebImageViewer. Contributed by Haohui Mai. (wheat9: rev 675bca2968700d3627449700b827c3771827cef8) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java * hadoop-hdfs-project/hadoop-hdfs/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/WebImageViewer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForAcl.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Fix For: 2.7.0 Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[ https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185937#comment-14185937 ] Jing Zhao commented on HDFS-7280: - +1 after addressing the comments. Use netty 4 in WebImageViewer - Key: HDFS-7280 URL: https://issues.apache.org/jira/browse/HDFS-7280 Project: Hadoop HDFS Issue Type: Improvement Reporter: Haohui Mai Assignee: Haohui Mai Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch, HDFS-7280.002.patch, HDFS-7280.003.patch This jira changes WebImageViewer to use netty 4 instead of netty 3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185936#comment-14185936
]
Jing Zhao commented on HDFS-7280:
-
The patch looks good to me. Some minor and nits:
# The following code needs some cleanup.
{code}
+ServerBootstrap b = new ServerBootstrap();
+b.group(bossGroup, workerGroup)
+.channel(NioServerSocketChannel.class);
+
+this.bootstrap = b;new ServerBootstrap();
{code}
# It may be better to catch the InterrupttedException in WebImageViewer#start.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
HDFS-7280.002.patch, HDFS-7280.003.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186237#comment-14186237
]
Hadoop QA commented on HDFS-7280:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12677444/HDFS-7280.004.patch
against trunk revision a16d022.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestLeaseRecovery2
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8559//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8559//console
This message is automatically generated.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
HDFS-7280.002.patch, HDFS-7280.003.patch, HDFS-7280.004.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14181847#comment-14181847
]
Hadoop QA commented on HDFS-7280:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676620/HDFS-7280.001.patch
against trunk revision d71d40a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8497//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/8497//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8497//console
This message is automatically generated.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
HDFS-7280.002.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14181920#comment-14181920
]
Hadoop QA commented on HDFS-7280:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676631/HDFS-7280.002.patch
against trunk revision d71d40a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerForAcl
org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8498//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/8498//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8498//console
This message is automatically generated.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
HDFS-7280.002.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14182243#comment-14182243
]
Hadoop QA commented on HDFS-7280:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676767/HDFS-7280.003.patch
against trunk revision 828429d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/8512//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8512//console
This message is automatically generated.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch, HDFS-7280.001.patch,
HDFS-7280.002.patch, HDFS-7280.003.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7280) Use netty 4 in WebImageViewer
[
https://issues.apache.org/jira/browse/HDFS-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14180869#comment-14180869
]
Hadoop QA commented on HDFS-7280:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12676498/HDFS-7280.000.patch
against trunk revision f729ecf.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8490//console
This message is automatically generated.
Use netty 4 in WebImageViewer
-
Key: HDFS-7280
URL: https://issues.apache.org/jira/browse/HDFS-7280
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Haohui Mai
Assignee: Haohui Mai
Attachments: HDFS-7280.000.patch
This jira changes WebImageViewer to use netty 4 instead of netty 3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
