[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378823#comment-14378823 ] Haohui Mai commented on HDFS-7713: -- +1. I'll commit it shortly. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch, HDFS-7713.07.patch, HDFS-7713.08.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378513#comment-14378513
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706938/HDFS-7713.08.patch
against trunk revision 6413d34.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestReplication
org.apache.hadoop.hdfs.server.datanode.TestDnRespectsBlockReportSplitThreshold
org.apache.hadoop.tracing.TestTracing
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10052//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10052//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch,
HDFS-7713.06.patch, HDFS-7713.07.patch, HDFS-7713.08.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376674#comment-14376674 ] Ravi Prakash commented on HDFS-7713: I've patched HDFS-7968. Could you please review and commit that JIRA too? Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch, HDFS-7713.07.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372343#comment-14372343 ] Ravi Prakash commented on HDFS-7713: I just noticed that browsing that directory leads to a bad request. I'll file a new JIRA for fixing that. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch, HDFS-7713.07.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372493#comment-14372493
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706095/HDFS-7713.07.patch
against trunk revision fe5c23b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.tracing.TestTracing
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10015//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10015//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch,
HDFS-7713.06.patch, HDFS-7713.07.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371788#comment-14371788
]
Haohui Mai commented on HDFS-7713:
--
The patch looks pretty good to me.
{code}
+var url = '/webhdfs/v1' + append_path(current_directory,
+ $('#new_directory').val()) + '?op=MKDIRS';
{code}
The path need to be encoded when constructing the path. The current patch will
fail when creating a directory whose name is {{asdf#df+1}}.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14368152#comment-14368152 ] Ravi Prakash commented on HDFS-7713: These test failures are most likely spurious because I never touched JAVA code in this patch. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366091#comment-14366091
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12705125/HDFS-7713.06.patch
against trunk revision 487374b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.util.TestByteArrayManager
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9938//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9938//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch, HDFS-7713.06.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359143#comment-14359143 ] Haohui Mai commented on HDFS-7713: -- ping... I think it is pretty close. [~raviprak] can you please update the patch if you want to get it in 2.7? Thanks. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345830#comment-14345830
]
Haohui Mai commented on HDFS-7713:
--
{code}
+button type=button class=close
+ data-dismiss=modal aria-hidden=truetimes;/button
+h4 class=modal-title id=dir-create-titleCreate Directory/h4
+ /div
{code}
The id {{dir-create-title}} are unnecessary, so as things like
{{dir-create-body}}. Only elements that are accessed by JavaScript need IDs.
{code}
+ div class=col-sm-10
{code}
It is unnecessary.
{code}
+ input type=text class=form-control id=new_directory
+placeholder=New Directory Name
{code}
It has to be a closed tag to meet the XHTML standard.
{code}
+divnbsp;/div
+div
+ button type=button class=btn btn-default data-toggle=modal
+data-target=#create-directoryCreate Directory
+ /button
+/div
{code}
It breaks the row layout in bootstrap. You can put the button on the same row
using:
{code}
div class=row
div class=col-xs-11
form onsubmit=return false;
div class=input-group
input type=text class=form-control id=directory/
span class=input-group-btn
button class=btn btn-default type=button
id=btn-nav-directoryGo!/button
/span
/div
/form
/div
div class=col-xs-1
button type=button class=btn btn-default data-toggle=modal
aria-label=New Directory
data-target=#create-directory span class=glyphicon
glyphicon-folder-open/span
/button
/div
/div
{code}
{code}
+ $('#create-directory').on('show.bs.modal', function(event) {
+var modal = $(this)
+$('#new_directory_pwd').html(current_directory);
+$('#create-directory-button').on('click', function () {
{code}
The click handler should be registered outside and should use the {{click()}}
method directly, otherwise you'll end up with registering multiple click
handlers and issue multiple webhdfs request.
It also makes sense to ID the button with consistent naming style, e.g.
{{btn-create-directory}}
{code}
+ $.ajax(url,
+{ type: 'PUT'
+}
{code}
It might make sense to put it in one line.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343909#comment-14343909 ] Ravi Prakash commented on HDFS-7713: Hi [~wheat9] Could you please review the latest patch? Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344211#comment-14344211 ] Haohui Mai commented on HDFS-7713: -- Thanks for the ping. Will do it today or tomorrow. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333624#comment-14333624 ] Ravi Prakash commented on HDFS-7713: Hi [~wheat9]! Could you please review the latest patch? Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334023#comment-14334023 ] Haohui Mai commented on HDFS-7713: -- Sorry for the delay. Will take a look at it today or tomorrow. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334104#comment-14334104
]
Haohui Mai commented on HDFS-7713:
--
{code}
+div class=dirCommands id=dirCommands
+ button type=button class=btn btn-primary data-toggle=modal
+data-target=#create-directoryCreate Directory
+ /button
+/div
{code}
It is unnecessary to define the class and the id. It might also make sense to
stick with the current look and feel (i.e., using {{btn-default}} instead of
{{btn-primary}}). It might also make sense to replace it with a icon as well.
{code}
- var path = $(this).attr('inode-path');
+ var path = $(this).closest('tr').attr('inode-path');
{code}
Doesn't seem necessary.
{code}
+ crossDomain: true
{code}
As {{MKDIR}} is only a metadata operation, there should be no need for allowing
the request to cross origin.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334505#comment-14334505
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12700327/HDFS-7713.05.patch
against trunk revision faaddb6.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9652//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9652//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch, HDFS-7713.05.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334054#comment-14334054
]
Haohui Mai commented on HDFS-7713:
--
Thanks for updating the patch. There are still a lot of unnecessary changes in
the patch. For example:
{code}
- a href=# class=dropdown-toggle data-toggle=dropdownUtilities
b class=caret/b/a
+ a href=# class=dropdown-toggle data-toggle=dropdownUtilities
b class=caret caret-white/b/a
{code}
{code}
-div class=modal id=file-info tabindex=-1 role=dialog
aria-hidden=true
- div class=modal-dialog
- div class=modal-content
- div class=modal-headerbutton type=button class=close
data-dismiss=modal aria-hidden=truetimes;/button
- h4 class=modal-title id=file-info-titleFile information/h4
- /div
- div class=modal-body id=file-info-body
- a id=file-info-downloadDownload/a
-!--a id=file-info-preview style=cursor:pointerTail the file
(last 32K)/a--
- hr /
- div class=panel panel-success id=file-info-blockinfo-panel
- div class=panel-heading
- Block information --
- select class=btn btn-default id=file-info-blockinfo-list
- /select
- /div
- div class=panel-body id=file-info-blockinfo-body/div
- /div
- div class=panel panel-info id=file-info-tail
style=display:none
- div class=panel-headingFile contents/div
- div class=panel-body
- div class=input-group-sm
- textarea class=form-control style=height: 150px
id=file-info-preview-body/textarea
- /div
- /div
- /div
- /div
- div class=modal-footerbutton type=button class=btn
btn-success
-
data-dismiss=modalClose/button/div
- /div
+
+ div class=modal id=file-info tabindex=-1 role=dialog
aria-hidden=true
+div class=modal-dialog
+ div class=modal-content
+div class=modal-header
+ button type=button class=close data-dismiss=modal
aria-hidden=truetimes;/button
+ h4 class=modal-title id=file-info-titleFile information/h4
+/div
+div class=modal-body id=file-info-body
+ a id=file-info-downloadDownload/a
+ !--a id=file-info-preview style=cursor:pointerTail the file
(last 32K)/a--
+ hr/
+ div class=panel panel-success id=file-info-blockinfo-panel
+div class=panel-heading
+ Block information --
+ select class=btn btn-default id=file-info-blockinfo-list
+ /select
+/div
+div class=panel-body id=file-info-blockinfo-body/div
+ /div
+ div class=panel panel-info id=file-info-tail
style=display:none
+div class=panel-headingFile contents/div
+div class=panel-body
+ div class=input-group-sm
+textarea class=form-control style=height: 150px
id=file-info-preview-body/textarea
+ /div
+/div
+ /div
+/div
+div class=modal-footer
+ button type=button class=btn btn-success
data-dismiss=modalClose/button
+/div
{code}
{code}
- div class=row
-hr /
-div class=col-xs-2pHadoop, 2014./p/div
+div class=row
+ div class=col-12
+div id=panel/div
/div
+/div
+div class=row
+ hr /
+ div class=col-xs-2pHadoop, 2014./p/div
/div
{code}
There are more throughout the patch. For example, I also think that the changes
to the CSS is unnecessary.
I'll separate the feedbacks of the functionality in a new comment.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch
This sub-task JIRA is for improving the NN HTML5 UI to allow the user to
create directories. It uses WebHDFS and adds to the great work done in
HDFS-6252
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325119#comment-14325119 ] Ravi Prakash commented on HDFS-7713: The jenkins build doesn't show any test failures. Hadoop QA is cuckoo Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories. It uses WebHDFS and adds to the great work done in HDFS-6252 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319100#comment-14319100
]
Haohui Mai commented on HDFS-7713:
--
Looks like the indentation is off in many places. And things like
{code}
- div class=row
-hr /
-div class=col-xs-2pHadoop, 2014./p/div
+div class=row
+ div class=col-12
+div id=panel/div
/div
+/div
+div class=row
+ hr/
+ div class=col-2pHadoop, 2015./p/div
/div
{code}
Could be separated into different patches. Can you please go through the patch
and try to minimize it?
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch
This JIRA is for improving the NN UI (everything except file uploads)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319212#comment-14319212
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698512/HDFS-7713.03.patch
against trunk revision 58cb9f5.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9562//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9562//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch
This JIRA is for improving the NN UI (everything except file uploads)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319479#comment-14319479
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698569/HDFS-7713.04.patch
against trunk revision 99f6bd4.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The test build failed in
hadoop-hdfs-project/hadoop-hdfs
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/9566//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9566//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch,
HDFS-7713.03.patch, HDFS-7713.04.patch
This JIRA is for improving the NN UI (everything except file uploads)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[
https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317264#comment-14317264
]
Hadoop QA commented on HDFS-7713:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698220/HDFS-7713.02.patch
against trunk revision fe689d3.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9549//console
This message is automatically generated.
Improve the HDFS Web UI browser to allow creating dirs
--
Key: HDFS-7713
URL: https://issues.apache.org/jira/browse/HDFS-7713
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Ravi Prakash
Assignee: Ravi Prakash
Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch
This JIRA is for improving the NN UI (everything except file uploads)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317354#comment-14317354 ] Allen Wittenauer commented on HDFS-7713: I think if the patch is generated with git format-patch, it will work. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch This JIRA is for improving the NN UI (everything except file uploads) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317347#comment-14317347 ] Ravi Prakash commented on HDFS-7713: The patch doesn't apply because its a binary patch (Including icon images) Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch This JIRA is for improving the NN UI (everything except file uploads) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
[ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317588#comment-14317588 ] Haohui Mai commented on HDFS-7713: -- I don't see why this patch requires bringing in yet another bootstrap as the current UI is using bootstrap already. Improve the HDFS Web UI browser to allow creating dirs -- Key: HDFS-7713 URL: https://issues.apache.org/jira/browse/HDFS-7713 Project: Hadoop HDFS Issue Type: Sub-task Reporter: Ravi Prakash Assignee: Ravi Prakash Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch This JIRA is for improving the NN UI (everything except file uploads) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
