[jira] [Commented] (HDFS-8176) Provide information about the snapshots compared in audit log
[
https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510707#comment-14510707
]
J.Andreina commented on HDFS-8176:
--
Thanks [~jingzhao] for reviewing the patch.
I have updated the patch as per your comments.
Please review.
Provide information about the snapshots compared in audit log
-
Key: HDFS-8176
URL: https://issues.apache.org/jira/browse/HDFS-8176
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: J.Andreina
Assignee: J.Andreina
Attachments: HDFS-8176.1.patch, HDFS-8176.2.patch
Provide information about the snapshots compared in audit log.
In current code value null is been passed.
{code}
logAuditEvent(diffs != null, computeSnapshotDiff, null, null, null);
{code}
{noformat}
2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true ugi=Rex
(auth:SIMPLE) ip=/Xcmd=computeSnapshotDiff src=null
dst=nullperm=null proto=rpc
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8176) Provide information about the snapshots compared in audit log
[
https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511003#comment-14511003
]
Hadoop QA commented on HDFS-8176:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 2s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 49s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 5m 34s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 10s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 16s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 167m 14s | Tests failed in hadoop-hdfs. |
| | | 214m 33s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate |
| Timed out tests | org.apache.hadoop.hdfs.TestParallelUnixDomainRead |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727864/HDFS-8176.2.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c8d7290 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10368/artifact/patchprocess/checkstyle-result-diff.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10368/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10368/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10368/console |
This message was automatically generated.
Provide information about the snapshots compared in audit log
-
Key: HDFS-8176
URL: https://issues.apache.org/jira/browse/HDFS-8176
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: J.Andreina
Assignee: J.Andreina
Attachments: HDFS-8176.1.patch, HDFS-8176.2.patch
Provide information about the snapshots compared in audit log.
In current code value null is been passed.
{code}
logAuditEvent(diffs != null, computeSnapshotDiff, null, null, null);
{code}
{noformat}
2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true ugi=Rex
(auth:SIMPLE) ip=/Xcmd=computeSnapshotDiff src=null
dst=nullperm=null proto=rpc
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8176) Provide information about the snapshots compared in audit log
[
https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507562#comment-14507562
]
Jing Zhao commented on HDFS-8176:
-
Thanks for working on this, [~andreina]! The patch looks good to me overall.
Just one minor: currently the parameter {{fromSnapshot}}/{{toSnapshot}} can be
null or empty, which indicates the current path (i.e., the non-snapshot path).
Thus we need to check this case when computing the src/dst for audit log.
Provide information about the snapshots compared in audit log
-
Key: HDFS-8176
URL: https://issues.apache.org/jira/browse/HDFS-8176
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: J.Andreina
Assignee: J.Andreina
Attachments: HDFS-8176.1.patch
Provide information about the snapshots compared in audit log.
In current code value null is been passed.
{code}
logAuditEvent(diffs != null, computeSnapshotDiff, null, null, null);
{code}
{noformat}
2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true ugi=Rex
(auth:SIMPLE) ip=/Xcmd=computeSnapshotDiff src=null
dst=nullperm=null proto=rpc
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8176) Provide information about the snapshots compared in audit log
[
https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504533#comment-14504533
]
Hadoop QA commented on HDFS-8176:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726157/HDFS-8176.1.patch
against trunk revision d52de61.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10328//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10328//console
This message is automatically generated.
Provide information about the snapshots compared in audit log
-
Key: HDFS-8176
URL: https://issues.apache.org/jira/browse/HDFS-8176
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: J.Andreina
Assignee: J.Andreina
Attachments: HDFS-8176.1.patch
Provide information about the snapshots compared in audit log.
In current code value null is been passed.
{code}
logAuditEvent(diffs != null, computeSnapshotDiff, null, null, null);
{code}
{noformat}
2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true ugi=Rex
(auth:SIMPLE) ip=/Xcmd=computeSnapshotDiff src=null
dst=nullperm=null proto=rpc
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
