[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512566#comment-14512566 ] Hudson commented on HDFS-8191: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512542#comment-14512542 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512465#comment-14512465 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512447#comment-14512447 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512418#comment-14512418 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/908/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512400#comment-14512400 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511626#comment-14511626 ] Zhe Zhang commented on HDFS-8191: - Thanks Andrew for reviewing and taking care of the commit. > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511557#comment-14511557 ] Hudson commented on HDFS-8191: -- FAILURE: Integrated in Hadoop-trunk-Commit #7665 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7665/]) HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510379#comment-14510379 ] Hadoop QA commented on HDFS-8191: - (!) The patch artifact directory on has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10364/ may provide some hints. > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[
https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510366#comment-14510366
]
Hadoop QA commented on HDFS-8191:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 5m 11s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 37s | There were no new javac warning
messages. |
| {color:green}+1{color} | release audit | 0m 20s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 5m 27s | There were no new checkstyle
issues. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 5s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 1m 21s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 165m 15s | Tests passed in hadoop-hdfs.
|
| | | 190m 24s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727467/HDFS-8191.003.patch |
| Optional Tests | javac unit findbugs checkstyle |
| git revision | trunk / ac281e3 |
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10363/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10363/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10363/console |
This message was automatically generated.
> Fix byte to integer casting in SimulatedFSDataset#simulatedByte
> ---
>
> Key: HDFS-8191
> URL: https://issues.apache.org/jira/browse/HDFS-8191
> Project: Hadoop HDFS
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
>Priority: Minor
> Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch,
> HDFS-8191.002.patch, HDFS-8191.003.patch, HDFS-8191.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510048#comment-14510048 ] Andrew Wang commented on HDFS-8191: --- I kicked the precommit, dunno why it didn't run. https://builds.apache.org/job/PreCommit-HDFS-Build/10363/ > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508144#comment-14508144 ] Andrew Wang commented on HDFS-8191: --- Missed that injection change, +1 again. Thanks for working on this Zhe, let's see what the shiny new test-patch says. > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch, HDFS-8191.003.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507991#comment-14507991 ] Andrew Wang commented on HDFS-8191: --- testInjectionNonEmpty I think still is using the 3-arg when it could use the 2-arg addSomeBlocks. Might also consider reordering the addSomeBlock functions so it reads downwards in terms of what calls what, e.g. 1-arg then 2-arg then 3-arg. +1 anyway, these are pretty nitty. > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, > HDFS-8191.002.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507882#comment-14507882 ] Andrew Wang commented on HDFS-8191: --- Couple notes: * Rather than adding another argument to addSomeBlocks, let's keep the one-arg form of addSomeBlocks and have it default negativeBlocks to false. Have a two-arg form just for testWriteRead. I'm not very happy with this test in general. Not exactly related to this change, but if you don't mind let's do a few small cleanups: * Make addSomeBlocks and blockIdToLen static * testWriteRead's "read" function, let's break it out into a new static function "readSomeBlocks" and put it by addSomeBlocks. The logic is heavily interlinked. > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[
https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504672#comment-14504672
]
Hadoop QA commented on HDFS-8191:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726801/HDFS-8191.001.patch
against trunk revision d52de61.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10330//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10330//console
This message is automatically generated.
> Fix byte to integer casting in SimulatedFSDataset#simulatedByte
> ---
>
> Key: HDFS-8191
> URL: https://issues.apache.org/jira/browse/HDFS-8191
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
>Priority: Minor
> Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[
https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504258#comment-14504258
]
Hadoop QA commented on HDFS-8191:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726721/HDFS-8191.000.patch
against trunk revision 44872b7.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager
org.apache.hadoop.hdfs.server.datanode.TestSimulatedFSDataset
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10325//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10325//console
This message is automatically generated.
> Fix byte to integer casting in SimulatedFSDataset#simulatedByte
> ---
>
> Key: HDFS-8191
> URL: https://issues.apache.org/jira/browse/HDFS-8191
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
>Priority: Minor
> Attachments: HDFS-8191.000.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8191) Fix byte to integer casting in SimulatedFSDataset#simulatedByte
[ https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504029#comment-14504029 ] Andrew Wang commented on HDFS-8191: --- Thanks Zhe, this looks good, explanation makes sense too. Could we add a unit test though? > Fix byte to integer casting in SimulatedFSDataset#simulatedByte > --- > > Key: HDFS-8191 > URL: https://issues.apache.org/jira/browse/HDFS-8191 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Zhe Zhang >Assignee: Zhe Zhang >Priority: Minor > Attachments: HDFS-8191.000.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
