[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512647#comment-14512647 ] Chris Nauroth commented on HDFS-8231: - For some reason, this patch didn't get a Jenkins run, and none of us caught it before the commit. HDFS-8247 tracks a test failure that was introduced. > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511061#comment-14511061 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511022#comment-14511022 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510919#comment-14510919 ] Hudson commented on HDFS-8231: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/907/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510880#comment-14510880 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510861#comment-14510861 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510844#comment-14510844 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510606#comment-14510606 ] Hudson commented on HDFS-8231: -- FAILURE: Integrated in Hadoop-trunk-Commit #7661 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7661/]) HDFS-8231. StackTrace displayed at client while QuotaByStorageType exceeds (Contributed by J.Andreina and Xiaoyu Yao) (vinayakumarb: rev c8d72907ff5a4cb9ce1effca8ad9b69689d11d1d) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 2.8.0 > > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510600#comment-14510600 ] Vinayakumar B commented on HDFS-8231: - Committed to trunk and branch-2 Thanks [~andreina] for reporting and Contribution. Thanks [~xyao] for the initial work. Thanks [~cnauroth] for reviews > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina >Priority: Minor > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510591#comment-14510591 ] Chris Nauroth commented on HDFS-8231: - +1 from me also. [~andreina], thank you for reporting the issue and contributing the patch. [~vinayrpet], thank you for doing the code review. These were good suggestions to try, even if it didn't work out that way in the end. I'll plan to commit this tomorrow unless Vinay beats me to it. :-) > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina >Priority: Minor > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510578#comment-14510578 ] Vinayakumar B commented on HDFS-8231: - Latest patch looks good to me. +1 [~cnauroth], Would you like to take a look? > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina >Priority: Minor > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch, HDFS-8231.2.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510533#comment-14510533
]
Vinayakumar B commented on HDFS-8231:
-
Thanks for the latest patch.
bq. Though logically this is correct, but it will not avoid logging stacktrace.
Because RemoteException#unwrapRemoteException(..) compares just the classnames,
not instanceof.
Along with the above fix suggested by Chris Nauroth, Still I recommend to
extend QuotaByStorageTypeExceededException from DSQuotaExceededException and
remove call to super.getMessage() in
QuotaByStorageTypeExceededException#getMessage() to get the correct message.
I see some problems with getting the right message after extending.
Since the exceptions are not carrying all the arguments from server-client,
other than message and trace, if {{getMessage()}} gets updated will get NPE at
client side, because {{type}} will be null.
So conclusion is, *NOT* to extend, and keep it to Earlier suggestion by
[~cnauroth].
Apologies for all noice :)
[~andreina], can you re-upload the patch by removing changes in
{{QuotaByStorageTypeExceededException.java}} ?
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
> Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510530#comment-14510530 ] Xiaoyu Yao commented on HDFS-8231: -- Thanks [~vinayrpet] for review the patch and providing detailed feedback. bq. RemoteException#unwrapRemoteException(..) compares just the classnames not instanceof.. I thought the same when started and soon found the same limitation of unwrapRemoteException. bq. Still I recommend to extend QuotaByStorageTypeExceededException from DSQuotaExceededException and remove call to super.getMessage() in QuotaByStorageTypeExceededException#toString() to get the correct message. +1 for this and I will update the patch. bq. QuotaByStorageTypeExceededException should be added to Terse exception list to avoid traces at NameNode side. Changes to be done at NameNodeRPCServer constructor at following point. +1 for this and I will update the patch. > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina >Priority: Minor > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510513#comment-14510513 ] J.Andreina commented on HDFS-8231: -- Thanks [~cnauroth] and [~vinayrpet] for your comments. I have given an initial patch . Please review. > StackTrace displayed at client while QuotaByStorageType exceeds > --- > > Key: HDFS-8231 > URL: https://issues.apache.org/jira/browse/HDFS-8231 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Reporter: J.Andreina >Assignee: J.Andreina >Priority: Minor > Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch > > > StackTrace displayed at client while QuotaByStorageType exceeds. > With reference to HDFS-2360, feel better to fix this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510503#comment-14510503
]
J.Andreina commented on HDFS-8231:
--
Doiii in ur comment
{{QuotaByStorageTypeExceededException#toString()}}
Iam not able to find this..
You mean below code in should remove and return by default the "Quota by
storage type : " message?
@Override
public String getMessage() {
String msg = super.getMessage();
if (msg == null) {
return "Quota by storage type : " + type.toString() +
" on path : " + (pathName==null ? "": pathName) +
" is exceeded. quota = " + long2String(quota, "B", 2) +
" but space consumed = " + long2String(count, "B", 2);
} else {
return msg;
}
}
Carrier Software & Core Networks
Huawei Technologies India Pvt. Ltd.
Level 3,4 &5 Leela Galleria, The Leela Palce
23, Airport Road, Bangalore - 560008
Mobile: +91 9945028374
Extn:7537
www.huawei.com
-
This e-mail and its attachments contain confidential information from HUAWEI,
which
is intended only for the person or entity whose address is listed above. Any
use of the
information contained herein in any way (including, but not limited to, total
or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify
the sender by
phone or email immediately and delete it!
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
> Attachments: HDFS-8231.00.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510493#comment-14510493
]
Vinayakumar B commented on HDFS-8231:
-
bq. I think the correct fix is to extend QuotaByStorageTypeExceededException
from DSQuotaExceededException. As StorageType is only applicable for the disk
usage,
Oops. This wont work. ;), Though logically this is correct, but it will not
avoid logging stacktrace. Because {{RemoteException#unwrapRemoteException(..)}}
compares just the classnames, not {{instanceof}}.
Along with the above fix suggested by [~cnauroth], Still I recommend to extend
{{QuotaByStorageTypeExceededException}} from {{DSQuotaExceededException}} and
remove call to {{super.getMessage()}} in
{{QuotaByStorageTypeExceededException#toString()}} to get the correct message.
{{QuotaByStorageTypeExceededException}} should be added to Terse exception list
to avoid traces at NameNode side. Changes to be done at {{NameNodeRPCServer}}
constructor at following point.
{code}// Set terse exception whose stack trace won't be logged
clientRpcServer.addTerseExceptions(SafeModeException.class,
FileNotFoundException.class,
HadoopIllegalArgumentException.class,
FileAlreadyExistsException.class,
InvalidPathException.class,
ParentNotDirectoryException.class,
UnresolvedLinkException.class,
AlreadyBeingCreatedException.class,
QuotaExceededException.class,
RecoveryInProgressException.class,
AccessControlException.class,
InvalidToken.class,
LeaseExpiredException.class,
NSQuotaExceededException.class,
DSQuotaExceededException.class,
AclException.class,
FSLimitException.PathComponentTooLongException.class,
FSLimitException.MaxDirectoryItemsExceededException.class,
UnresolvedPathException.class);{code}
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
> Attachments: HDFS-8231.00.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510465#comment-14510465
]
Vinayakumar B commented on HDFS-8231:
-
bq. The fix is likely to track down the various points in DFSClient that call
RemoteException#unwrapRemoteException on DSQuotaExceededException.class and add
QuotaByStorageTypeExceededException.class to the list.
I think the correct fix is to extend {{QuotaByStorageTypeExceededException}}
from {{DSQuotaExceededException}}. As {{StorageType}} is only applicable for
the disk usage,
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
> Attachments: HDFS-8231.00.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509383#comment-14509383
]
Chris Nauroth commented on HDFS-8231:
-
[~andreina], thank you for reporting the bug. The fix is likely to track down
the various points in {{DFSClient}} that call
{{RemoteException#unwrapRemoteException}} on {{DSQuotaExceededException.class}}
and add {{QuotaByStorageTypeExceededException.class}} to the list.
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508993#comment-14508993
]
J.Andreina commented on HDFS-8231:
--
Observation:
==
Following exception is thrown at client side
{noformat}
15/04/23 18:12:07 WARN hdfs.DFSClient: DataStreamer Exception
org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hdfs.protocol.QuotaByStorageTypeExceededException):
Quota by storage type : ARCHIVE on path : /Folder1 is exceeded. quota = 10 B
but space consumed = 384 MB
at
org.apache.hadoop.hdfs.server.namenode.DirectoryWithQuotaFeature.verifyQuotaByStorageType(DirectoryWithQuotaFeature.java:227)
at
org.apache.hadoop.hdfs.server.namenode.DirectoryWithQuotaFeature.verifyQuota(DirectoryWithQuotaFeature.java:240)
at
org.apache.hadoop.hdfs.server.namenode.FSDirectory.verifyQuota(FSDirectory.java:874)
at
org.apache.hadoop.hdfs.server.namenode.FSDirectory.updateCount(FSDirectory.java:707)
at
org.apache.hadoop.hdfs.server.namenode.FSDirectory.updateCount(FSDirectory.java:666)
at
org.apache.hadoop.hdfs.server.namenode.FSDirectory.addBlock(FSDirectory.java:491)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.saveAllocatedBlock(FSNamesystem.java:3562)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.storeAllocatedBlock(FSNamesystem.java:3140)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:3019)
at
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:727)
at
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:489)
at
org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:636)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2142)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2138)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2136)
at org.apache.hadoop.ipc.Client.call(Client.java:1492)
at org.apache.hadoop.ipc.Client.call(Client.java:1423)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:229)
at com.sun.proxy.$Proxy14.addBlock(Unknown Source)
at
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.addBlock(ClientNamenodeProtocolTranslatorPB.java:418)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:186)
at
org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:101)
at com.sun.proxy.$Proxy15.addBlock(Unknown Source)
at
org.apache.hadoop.hdfs.DataStreamer.locateFollowingBlock(DataStreamer.java:1540)
at
org.apache.hadoop.hdfs.DataStreamer.nextBlockOutputStream(DataStreamer.java:1334)
at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:425)
put: Quota by storage type : ARCHIVE on path : /Folder1 is exceeded. quota = 10
B but space consumed = 384 MB
{noformat}
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
>Reporter: J.Andreina
>Assignee: J.Andreina
>Priority: Minor
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
