[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618409#comment-14618409 ] Vinayakumar B commented on HDFS-8711: - Cherry picked this to branch-2 as well. To keep the diff between trunk and branch-2 minimal. setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Improvement Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618382#comment-14618382 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618396#comment-14618396 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/980/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618559#comment-14618559 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #248 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/248/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Improvement Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Fix For: 2.8.0 Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618585#comment-14618585 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2196 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2196/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Improvement Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Fix For: 2.8.0 Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618656#comment-14618656 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Improvement Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Fix For: 2.8.0 Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618707#comment-14618707 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Improvement Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Fix For: 2.8.0 Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617480#comment-14617480 ] Hudson commented on HDFS-8711: -- FAILURE: Integrated in Hadoop-trunk-Commit #8128 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8128/]) HDFS-8711. setSpaceQuota command should print the available storage type when input storage type is wrong. Contributed by Brahma Reddy Battula. (xyao: rev b68701b7b2a9597b4183e0ba19b1551680d543a1) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestQuota.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Labels: reviewed Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14613646#comment-14613646 ] Hadoop QA commented on HDFS-8711: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 21m 12s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 8m 30s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 42s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 28s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 3m 0s | The applied patch generated 1 new checkstyle issues (total was 228, now 228). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 2m 23s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 4m 50s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | native | 4m 25s | Pre-build of native portion | | {color:red}-1{color} | hdfs tests | 84m 51s | Tests failed in hadoop-hdfs. | | | | 142m 6s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.hdfs.server.datanode.TestRefreshNamenodes | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12743457/HDFS-8711-01.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 2eae130 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/11570/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11570/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11570/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11570/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11570/console | This message was automatically generated. setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612894#comment-14612894 ] Surendra Singh Lilhore commented on HDFS-8711: -- Thanks [~xyao] for reviewing. Attached new patch with unit test , Please review ... setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: HDFS-8711-01.patch, HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611759#comment-14611759 ] Surendra Singh Lilhore commented on HDFS-8711: -- Attached patch, Please review... setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HDFS-8711) setSpaceQuota command should print the available storage type when input storage type is wrong
[ https://issues.apache.org/jira/browse/HDFS-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612024#comment-14612024 ] Xiaoyu Yao commented on HDFS-8711: -- Patch LGTM. A few comments: 1. Available storage type are should be Available storage types are 2. Can you add a unit test for the change? setSpaceQuota command should print the available storage type when input storage type is wrong -- Key: HDFS-8711 URL: https://issues.apache.org/jira/browse/HDFS-8711 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.7.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: HDFS-8711.patch If input storage type is wrong then currently *setSpaceQuota* give exception like this. {code} ./hdfs dfsadmin -setSpaceQuota 1000 -storageType COLD /testDir setSpaceQuota: No enum constant org.apache.hadoop.fs.StorageType.COLD {code} It should be {code} setSpaceQuota: Storage type COLD not available. Available storage type are [SSD, DISK, ARCHIVE] {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)