[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262559=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262559
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 18:56
Start Date: 18/Jun/19 18:56
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-503197062
Test failures look's not related to this patch.
I will commit this to the trunk. Thank You @vivekratnavel for the
contribution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262559)
Time Spent: 5h 10m (was: 5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262403=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262403
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 15:52
Start Date: 18/Jun/19 15:52
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-503197062
Test failures look related to this patch.
I will commit this to the trunk. Thank You @vivekratnavel for the
contribution.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262403)
Time Spent: 5h (was: 4h 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262401=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262401
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 15:51
Start Date: 18/Jun/19 15:51
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-503197062
Test failures look related to this patch.
I will commit this to the trunk.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262401)
Time Spent: 4h 40m (was: 4.5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262402
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 15:51
Start Date: 18/Jun/19 15:51
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262402)
Time Spent: 4h 50m (was: 4h 40m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262012
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 03:58
Start Date: 18/Jun/19 03:58
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294601234
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ContainerDBServiceProvider.java
##
@@ -70,13 +70,23 @@ Integer getCountForForContainerKeyPrefix(
throws IOException;
/**
- * Get a Map of containerID, containerMetadata of all Containers.
+ * Get a Map of containerID, containerMetadata of all the Containers.
*
* @return Map of containerID -> containerMetadata.
* @throws IOException
*/
Map getContainers() throws IOException;
Review comment:
We can remove this method, in your further jira for considering the start
parameter.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262012)
Time Spent: 4.5h (was: 4h 20m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262011
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 03:56
Start Date: 18/Jun/19 03:56
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-502935978
+1, pending CI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262011)
Time Spent: 4h 20m (was: 4h 10m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=262010=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-262010
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 03:54
Start Date: 18/Jun/19 03:54
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294600693
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
##
@@ -181,6 +182,12 @@ public Integer getCountForForContainerKeyPrefix(
Long containerID = keyValue.getKey().getContainerId();
Integer numberOfKeys = keyValue.getValue();
+ // break the loop if limit has been reached
+ // and one more new entity needs to be added to the containers map
+ if (containers.size() == limit && !containers.containsKey(containerID)) {
Review comment:
Got it..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 262010)
Time Spent: 4h 10m (was: 4h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261974
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 02:20
Start Date: 18/Jun/19 02:20
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294586933
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ContainerDBServiceProvider.java
##
@@ -70,13 +70,23 @@ Integer getCountForForContainerKeyPrefix(
throws IOException;
/**
- * Get a Map of containerID, containerMetadata of all Containers.
+ * Get a Map of containerID, containerMetadata of all the Containers.
*
* @return Map of containerID -> containerMetadata.
* @throws IOException
*/
Map getContainers() throws IOException;
Review comment:
Minor: I see the only new method being used.
Old method is not being used from the API. I have assumed this will be
called from service.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261974)
Time Spent: 4h (was: 3h 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261968
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 02:18
Start Date: 18/Jun/19 02:18
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294586933
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/ContainerDBServiceProvider.java
##
@@ -70,13 +70,23 @@ Integer getCountForForContainerKeyPrefix(
throws IOException;
/**
- * Get a Map of containerID, containerMetadata of all Containers.
+ * Get a Map of containerID, containerMetadata of all the Containers.
*
* @return Map of containerID -> containerMetadata.
* @throws IOException
*/
Map getContainers() throws IOException;
Review comment:
Minor: I see the only new method being used.
Old method is not being used from the API.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261968)
Time Spent: 3h 50m (was: 3h 40m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261959
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 18/Jun/19 01:40
Start Date: 18/Jun/19 01:40
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-502911684
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| 0 | reexec | 106 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 591 | trunk passed |
| +1 | compile | 293 | trunk passed |
| +1 | checkstyle | 84 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 925 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 197 | trunk passed |
| 0 | spotbugs | 352 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 556 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 485 | the patch passed |
| +1 | compile | 307 | the patch passed |
| +1 | javac | 307 | the patch passed |
| +1 | checkstyle | 87 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 692 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 163 | the patch passed |
| +1 | findbugs | 562 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 215 | hadoop-hdds in the patch failed. |
| -1 | unit | 2013 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 52 | The patch does not generate ASF License warnings. |
| | | 7506 | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.ozone.container.common.impl.TestHddsDispatcher
|
| | hadoop.ozone.client.rpc.TestBlockOutputStream |
| | hadoop.ozone.client.rpc.TestCommitWatcher |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/954 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux d49263eaa075 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6822193 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/2/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/2/testReport/ |
| Max. process+thread count | 4372 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-recon U: hadoop-ozone/ozone-recon |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261959)
Time Spent: 3h 40m (was: 3.5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261880
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 22:34
Start Date: 17/Jun/19 22:34
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294545140
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
##
@@ -181,6 +182,12 @@ public Integer getCountForForContainerKeyPrefix(
Long containerID = keyValue.getKey().getContainerId();
Integer numberOfKeys = keyValue.getValue();
+ // break the loop if limit has been reached
+ // and one more new entity needs to be added to the containers map
+ if (containers.size() == limit && !containers.containsKey(containerID)) {
Review comment:
Without the second condition, the last container ID will have incorrect
number of keys in its containerMetadata. Even when containers limit is reached,
the next iteration could contain the same container ID with a different key
prefix. To handle this situation, we should not break the iterator until the
second condition is also met.
I don't think we need to add any check for any other negative values since
none of them match the condition `containers.size() == limit` at any time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261880)
Time Spent: 3.5h (was: 3h 20m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261853=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261853
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 22:02
Start Date: 17/Jun/19 22:02
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294536580
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
Review comment:
Okay. Then I feel we can have 2 methods, getContainers(), getContainers(int
limit)
In this way, we don't need any special considerations in underlying
implementation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261853)
Time Spent: 3h 20m (was: 3h 10m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261831=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261831
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:34
Start Date: 17/Jun/19 21:34
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294527606
##
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##
@@ -200,56 +201,67 @@ protected void configure() {
@Test
public void testGetKeysForContainer() {
-Response response = containerKeyService.getKeysForContainer(1L);
+Response response = containerKeyService.getKeysForContainer(1L, 2);
Collection keyMetadataList =
(Collection) response.getEntity();
-assertTrue(keyMetadataList.size() == 2);
+assertEquals(keyMetadataList.size(), 2);
Review comment:
Can we add tests with default value of limit also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261831)
Time Spent: 2h 50m (was: 2h 40m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261832=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261832
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:34
Start Date: 17/Jun/19 21:34
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294527606
##
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##
@@ -200,56 +201,67 @@ protected void configure() {
@Test
public void testGetKeysForContainer() {
-Response response = containerKeyService.getKeysForContainer(1L);
+Response response = containerKeyService.getKeysForContainer(1L, 2);
Collection keyMetadataList =
(Collection) response.getEntity();
-assertTrue(keyMetadataList.size() == 2);
+assertEquals(keyMetadataList.size(), 2);
Review comment:
Can we add tests with default value of limit also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261832)
Time Spent: 3h (was: 2h 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261833
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:34
Start Date: 17/Jun/19 21:34
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294527750
##
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##
@@ -200,56 +201,67 @@ protected void configure() {
@Test
public void testGetKeysForContainer() {
-Response response = containerKeyService.getKeysForContainer(1L);
+Response response = containerKeyService.getKeysForContainer(1L, 2);
Review comment:
Can we add tests with default value of limit also?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261833)
Time Spent: 3h 10m (was: 3h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261829=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261829
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:32
Start Date: 17/Jun/19 21:32
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294527046
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
Review comment:
Yes, that's correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261829)
Time Spent: 2h 40m (was: 2.5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261827=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261827
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:31
Start Date: 17/Jun/19 21:31
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294526542
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
##
@@ -181,6 +182,12 @@ public Integer getCountForForContainerKeyPrefix(
Long containerID = keyValue.getKey().getContainerId();
Integer numberOfKeys = keyValue.getValue();
+ // break the loop if limit has been reached
+ // and one more new entity needs to be added to the containers map
+ if (containers.size() == limit && !containers.containsKey(containerID)) {
Review comment:
Not understood the reason for the 2nd condition.
And this method can be called with limit -1, Can you update java doc with
description, what happens in that case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261827)
Time Spent: 2h 20m (was: 2h 10m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261828
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:31
Start Date: 17/Jun/19 21:31
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294526542
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
##
@@ -181,6 +182,12 @@ public Integer getCountForForContainerKeyPrefix(
Long containerID = keyValue.getKey().getContainerId();
Integer numberOfKeys = keyValue.getValue();
+ // break the loop if limit has been reached
+ // and one more new entity needs to be added to the containers map
+ if (containers.size() == limit && !containers.containsKey(containerID)) {
Review comment:
Not understood the reason for the 2nd condition.
And this method can be called with limit -1, Can you update java doc with
description, what happens in that case. And do we need to add any check for
other negative values for this limit?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261828)
Time Spent: 2.5h (was: 2h 20m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261825=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261825
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:29
Start Date: 17/Jun/19 21:29
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294525907
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
Review comment:
Default value of the query param limit is -1.
So, in the case of -1, it behaves like normal, it lists all the containers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261825)
Time Spent: 2h (was: 1h 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261826=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261826
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:29
Start Date: 17/Jun/19 21:29
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294525907
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
Review comment:
Default value of the query param limit is -1.
So, in the case of -1, it behaves like normal, it lists all the containers?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 261826)
Time Spent: 2h 10m (was: 2h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259970=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259970
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 22:34
Start Date: 13/Jun/19 22:34
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293602190
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
} catch (IOException ioEx) {
Review comment:
Adding total count to response and supporting "start" query param is tracked
via https://issues.apache.org/jira/browse/HDDS-1685 and will be implemented
soon.
This PR only adds "limit" support to the APIs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259970)
Time Spent: 1h 50m (was: 1h 40m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259927=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259927
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 21:30
Start Date: 13/Jun/19 21:30
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293584974
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
} catch (IOException ioEx) {
Review comment:
If we have support for continuation, in the next call we shall not require
to fetch limit + 50, we can fetch next 50.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259927)
Time Spent: 1h 40m (was: 1.5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259899=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259899
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 20:49
Start Date: 13/Jun/19 20:49
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-501873419
The acceptance and unit test failures are unrelated to this patch.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259899)
Time Spent: 1.5h (was: 1h 20m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259833
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 18:58
Start Date: 13/Jun/19 18:58
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293530930
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
} catch (IOException ioEx) {
Review comment:
@bharatviswa504 This PR only supports limit param and I don't see the need
for skip param support in the near feature. I will explain how the UI will
consume this API to show containers and keys to the users. UI will fetch this
API with an initial limit of 50 (arbitrary number or could be x% of
totalCount). When the user scrolls to the end of the list, UI will trigger
another call to the same API with limit + 50 to get 100 items. In a similar
fashion, UI will keep loading results with infinite scroll like something
similar to this demo - https://infinite-scroll.com/demo/full-page/ . Since, the
results are not going to be paginated, there is no need for skip param support
here in my opinion.
The only thing missing is the totalCount in the response of these APIs and
that will be implemented as part of another JIRA if needed in the future.
Infinite scroll could be implemented without total count but having total count
in the UI will give better user experience.
Please let me know if you have any more questions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259833)
Time Spent: 1h 20m (was: 1h 10m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259825=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259825
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 18:38
Start Date: 13/Jun/19 18:38
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293522345
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -92,8 +95,10 @@ public Response getContainers() {
*/
@GET
@Path("/{id}")
- public Response getKeysForContainer(@PathParam("id") Long containerId) {
-Map keyMetadataMap = new HashMap<>();
+ public Response getKeysForContainer(
+ @PathParam("id") Long containerId,
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Review comment:
Same as above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259825)
Time Spent: 1h 10m (was: 1h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259823
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 18:37
Start Date: 13/Jun/19 18:37
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r293522160
##
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerKeyService.java
##
@@ -72,10 +74,11 @@
* @return {@link Response}
*/
@GET
- public Response getContainers() {
+ public Response getContainers(
+ @DefaultValue("-1") @QueryParam("limit") int limit) {
Map containersMap;
try {
- containersMap = containerDBServiceProvider.getContainers();
+ containersMap = containerDBServiceProvider.getContainers(limit);
} catch (IOException ioEx) {
Review comment:
I see the API to limit.
But how we shall get the list of containers from the last returned result,
will be there be an API support for that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259823)
Time Spent: 1h (was: 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259791
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 17:32
Start Date: 13/Jun/19 17:32
Worklog Time Spent: 10m
Work Description: avijayanhwx commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-501803643
LGTM +1.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259791)
Time Spent: 50m (was: 40m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259201
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 13/Jun/19 01:02
Start Date: 13/Jun/19 01:02
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-501509057
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| 0 | reexec | 32 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 499 | trunk passed |
| +1 | compile | 280 | trunk passed |
| +1 | checkstyle | 69 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 831 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 178 | trunk passed |
| 0 | spotbugs | 333 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 522 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 477 | the patch passed |
| +1 | compile | 291 | the patch passed |
| +1 | javac | 291 | the patch passed |
| +1 | checkstyle | 81 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 681 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 180 | the patch passed |
| +1 | findbugs | 524 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 145 | hadoop-hdds in the patch failed. |
| -1 | unit | 1001 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 59 | The patch does not generate ASF License warnings. |
| | | 6070 | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.ozone.container.common.impl.TestHddsDispatcher
|
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.TestMiniChaosOzoneCluster |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestWatchForCommit |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/954 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 0fed6fc1333e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 205dd2d |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/1/testReport/ |
| Max. process+thread count | 5211 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-recon U: hadoop-ozone/ozone-recon |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-954/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259201)
Time Spent: 40m (was: 0.5h)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259155=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259155
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 12/Jun/19 23:21
Start Date: 12/Jun/19 23:21
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-501489332
@avijayanhwx @swagle @hanishakoneru Pl review when you find time
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259155)
Time Spent: 0.5h (was: 20m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259153
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 12/Jun/19 23:20
Start Date: 12/Jun/19 23:20
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954
This PR adds support for limit query param to limit the results of
/api/containers and /api/containers/{id} endpoints. This will help the UI to
load and show results faster with infinite scrolling.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259153)
Time Spent: 10m
Remaining Estimate: 0h
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1670) Add limit support to /api/containers and /api/containers/{id} endpoints
[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=259154=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259154
]
ASF GitHub Bot logged work on HDDS-1670:
Author: ASF GitHub Bot
Created on: 12/Jun/19 23:20
Start Date: 12/Jun/19 23:20
Worklog Time Spent: 10m
Work Description: vivekratnavel commented on issue #954: HDDS-1670. Add
limit support to /api/containers and /api/containers/{id} endpoints
URL: https://github.com/apache/hadoop/pull/954#issuecomment-501489155
/label ozone
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 259154)
Time Spent: 20m (was: 10m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> ---
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
>Affects Versions: 0.4.0
>Reporter: Vivek Ratnavel Subramanian
>Assignee: Vivek Ratnavel Subramanian
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
