[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=280010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280010 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 20/Jul/19 00:43 Start Date: 20/Jul/19 00:43 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513419761 Test failures are not related to this patch. For failure related to TestSecureOzoneContainer and TestSecureOzoneContainer, this will be taken care in HDDS-1840 and HDDS-1841. I will try to open jiras for other issues. Thank You @arp7 for the review. I will commit this to the trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 280010) Time Spent: 3h 10m (was: 3h) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=280011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280011 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 20/Jul/19 00:43 Start Date: 20/Jul/19 00:43 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 280011) Time Spent: 3h 20m (was: 3h 10m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=280009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280009 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 20/Jul/19 00:38 Start Date: 20/Jul/19 00:38 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513419278 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 35 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 12 | Maven dependency ordering for branch | | +1 | mvninstall | 503 | trunk passed | | +1 | compile | 273 | trunk passed | | +1 | checkstyle | 75 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 873 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 151 | trunk passed | | 0 | spotbugs | 344 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 557 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 469 | the patch passed | | +1 | compile | 270 | the patch passed | | +1 | javac | 270 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 637 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 165 | the patch passed | | +1 | findbugs | 534 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 283 | hadoop-hdds in the patch passed. | | -1 | unit | 1532 | hadoop-ozone in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 6658 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestReadRetries | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1097 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 7d2b98bcb45f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 69a46a9 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/5/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/5/testReport/ | | Max. process+thread count | 5329 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/5/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (wa
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279950 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 19/Jul/19 20:45 Start Date: 19/Jul/19 20:45 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513371794 /retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279950) Time Spent: 2h 50m (was: 2h 40m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279946 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 19/Jul/19 20:31 Start Date: 19/Jul/19 20:31 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513367797 /retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279946) Time Spent: 2h 40m (was: 2.5h) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279944
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:30
Start Date: 19/Jul/19 20:30
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1097:
HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305514532
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+// TODO: Do we need to enforce the bucket rules in this code path?
+// https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+// For now only checked the length.
+int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
Updated to use constants.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279944)
Time Spent: 2h 20m (was: 2h 10m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
>
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279945 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 19/Jul/19 20:30 Start Date: 19/Jul/19 20:30 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513367472 Thank You @arp7 for the review. Addressed the review comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279945) Time Spent: 2.5h (was: 2h 20m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279943
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:29
Start Date: 19/Jul/19 20:29
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1097:
HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305514231
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
Review comment:
Done. Removed Precondition check.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279943)
Time Spent: 2h 10m (was: 2h)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Implement S3 Bucket write requests to use OM Cache, double buffer.
>
> In this Jira will add the changes to implement S3 bucket operations, and
> HA/Non-HA will have a different code path, but once all requests are
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279937
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:01
Start Date: 19/Jul/19 20:01
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1097: HDDS-1795.
Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305505903
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+// TODO: Do we need to enforce the bucket rules in this code path?
+// https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+// For now only checked the length.
+int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279937)
Time Spent: 2h (was: 1h 50m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-av
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279936
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:01
Start Date: 19/Jul/19 20:01
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1097: HDDS-1795.
Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305505870
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
Review comment:
We will get NPE on the next line. We should not add asserts for references
we will dereference soon. Not a blocker to commit, something we can clean up
later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279936)
Time Spent: 1h 50m (was: 1h 40m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Implement S3 Bucket write requests to use OM Cache, double buffer.
>
> In this Jira will add th
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279935
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 20:00
Start Date: 19/Jul/19 20:00
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1097:
HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305505474
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+// TODO: Do we need to enforce the bucket rules in this code path?
+// https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+// For now only checked the length.
+int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
This is to give the error to the user, S3 does not accept bucket requests
with length less than 3 and greater than 64. This is to match AWS S3 behavior.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279935)
Time Spent: 1h 40m (was: 1.5h)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone M
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279934
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 19:59
Start Date: 19/Jul/19 19:59
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1097:
HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305505264
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
Review comment:
Intention here is to catch if some one is calling S3BucketDeleteRequest with
OMRequest which does not have S3BucketDeleteRequest set.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279934)
Time Spent: 1.5h (was: 1h 20m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Implement S3 Bucket write requests to use OM Cache, double buffer.
>
> In this Jira will add the changes to implem
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279932
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 19:57
Start Date: 19/Jul/19 19:57
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1097: HDDS-1795.
Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305504491
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+// TODO: Do we need to enforce the bucket rules in this code path?
+// https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+// For now only checked the length.
+int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
Do we need to have this check for delete bucket request? If the bucket does
not exist we will get the correct error later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279932)
Time Spent: 1h 20m (was: 1h 10m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat V
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279931
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 19:55
Start Date: 19/Jul/19 19:55
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1097: HDDS-1795.
Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305503939
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
+
+// TODO: Do we need to enforce the bucket rules in this code path?
+// https://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html
+
+// For now only checked the length.
+int bucketLength = s3DeleteBucketRequest.getS3BucketName().length();
+if (bucketLength < 3 || bucketLength >= 64) {
Review comment:
Can you use the constants here instead of magic numbers?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279931)
Time Spent: 1h 10m (was: 1h)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Prior
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[
https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279929
]
ASF GitHub Bot logged work on HDDS-1795:
Author: ASF GitHub Bot
Created on: 19/Jul/19 19:54
Start Date: 19/Jul/19 19:54
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1097: HDDS-1795.
Implement S3 Delete Bucket request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1097#discussion_r305503603
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/bucket/S3BucketDeleteRequest.java
##
@@ -0,0 +1,193 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.s3.bucket;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.apache.hadoop.ozone.audit.OMAction;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.om.request.volume.OMVolumeRequest;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.s3.bucket.S3BucketDeleteResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMRequest;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.OMResponse;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+.S3DeleteBucketRequest;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.apache.hadoop.utils.db.cache.CacheKey;
+import org.apache.hadoop.utils.db.cache.CacheValue;
+
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.S3_BUCKET_LOCK;
+
+/**
+ * Handle Create S3Bucket request.
+ */
+public class S3BucketDeleteRequest extends OMVolumeRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(S3BucketDeleteRequest.class);
+
+ public S3BucketDeleteRequest(OMRequest omRequest) {
+super(omRequest);
+ }
+
+ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+S3DeleteBucketRequest s3DeleteBucketRequest =
+getOmRequest().getDeleteS3BucketRequest();
+Preconditions.checkNotNull(s3DeleteBucketRequest);
Review comment:
Is this checkNotNull for findbugs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 279929)
Time Spent: 1h (was: 50m)
> Implement S3 Delete Bucket request to use Cache and DoubleBuffer
>
>
> Key: HDDS-1795
> URL: https://issues.apache.org/jira/browse/HDDS-1795
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Implement S3 Bucket write requests to use OM Cache, double buffer.
>
> In this Jira will add the changes to implement S3 bucket operations, and
> HA/Non-HA will have a different code path, but once all requests are
> implemented w
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279697 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 19/Jul/19 12:11 Start Date: 19/Jul/19 12:11 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-513205733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 30 | Maven dependency ordering for branch | | +1 | mvninstall | 529 | trunk passed | | +1 | compile | 259 | trunk passed | | +1 | checkstyle | 74 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 881 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 152 | trunk passed | | 0 | spotbugs | 306 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 500 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 456 | the patch passed | | +1 | compile | 247 | the patch passed | | +1 | javac | 247 | the patch passed | | +1 | checkstyle | 68 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 626 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 143 | the patch passed | | +1 | findbugs | 521 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 274 | hadoop-hdds in the patch passed. | | -1 | unit | 1783 | hadoop-ozone in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 6793 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1097 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d13df8489eaf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 4e66cb9 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/3/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/3/testReport/ | | Max. process+thread count | 4768 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279697) Time Spent: 50m (was: 40m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > >
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279353 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 18/Jul/19 21:16 Start Date: 18/Jul/19 21:16 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-512990741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 5 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for branch | | +1 | mvninstall | 472 | trunk passed | | +1 | compile | 258 | trunk passed | | +1 | checkstyle | 74 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 847 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 147 | trunk passed | | 0 | spotbugs | 312 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 504 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 410 | the patch passed | | +1 | compile | 244 | the patch passed | | +1 | javac | 244 | the patch passed | | +1 | checkstyle | 62 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 616 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 148 | the patch passed | | +1 | findbugs | 514 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 286 | hadoop-hdds in the patch failed. | | -1 | unit | 1921 | hadoop-ozone in the patch failed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 6769 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory | | | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.container.server.TestSecureContainerServer | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1097 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 4013f1963c43 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9838a47 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/2/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/2/testReport/ | | Max. process+thread count | 5285 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=279268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-279268 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 18/Jul/19 19:23 Start Date: 18/Jul/19 19:23 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-512952595 This is ready for review. Rebased with the latest trunk, as now HDDS-1689 got checked in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 279268) Time Spent: 0.5h (was: 20m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=277036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277036 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 15/Jul/19 22:43 Start Date: 15/Jul/19 22:43 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097#issuecomment-511597049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 38 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 8 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 71 | Maven dependency ordering for branch | | +1 | mvninstall | 535 | trunk passed | | +1 | compile | 254 | trunk passed | | +1 | checkstyle | 70 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 858 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 154 | trunk passed | | 0 | spotbugs | 315 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 509 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for patch | | +1 | mvninstall | 435 | the patch passed | | +1 | compile | 257 | the patch passed | | +1 | cc | 257 | the patch passed | | +1 | javac | 257 | the patch passed | | +1 | checkstyle | 69 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 644 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 148 | the patch passed | | +1 | findbugs | 518 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 277 | hadoop-hdds in the patch passed. | | -1 | unit | 2411 | hadoop-ozone in the patch failed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 7473 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestWatchForCommit | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestReadRetries | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.client.rpc.TestCommitWatcher | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1097 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 99ad7ab1df68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 1411513 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/1/testReport/ | | Max. process+thread count | 5184 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-ozone/common hadoop-ozone/ozone-manager U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1097/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 277036) Time Spent: 20m (was: 10m) > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > U
[jira] [Work logged] (HDDS-1795) Implement S3 Delete Bucket request to use Cache and DoubleBuffer
[ https://issues.apache.org/jira/browse/HDDS-1795?focusedWorklogId=276937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276937 ] ASF GitHub Bot logged work on HDDS-1795: Author: ASF GitHub Bot Created on: 15/Jul/19 19:06 Start Date: 15/Jul/19 19:06 Worklog Time Spent: 10m Work Description: bharatviswa504 commented on pull request #1097: HDDS-1795. Implement S3 Delete Bucket request to use Cache and DoubleBuffer. URL: https://github.com/apache/hadoop/pull/1097 This PR is dependent on HDDS-1689. To get Jenkins run posted this along with HDDS-1689 PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 276937) Time Spent: 10m Remaining Estimate: 0h > Implement S3 Delete Bucket request to use Cache and DoubleBuffer > > > Key: HDDS-1795 > URL: https://issues.apache.org/jira/browse/HDDS-1795 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager >Reporter: Bharat Viswanadham >Assignee: Bharat Viswanadham >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Implement S3 Bucket write requests to use OM Cache, double buffer. > > In this Jira will add the changes to implement S3 bucket operations, and > HA/Non-HA will have a different code path, but once all requests are > implemented will have a single code path. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
