[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319218=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319218
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 21:01
Start Date: 26/Sep/19 21:01
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on issue #1526: HDDS-2180. Add 
Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535684699
 
 
   > None that I know of. However we should not commit a patch without CI on 
principle.
   
   This has been broken for quite a while; So I rely on Jenkins/Yetus and hand 
building before apply the commits. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319218)
Time Spent: 2h 10m  (was: 2h)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319209
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 20:50
Start Date: 26/Sep/19 20:50
Worklog Time Spent: 10m 
  Work Description: arp7 commented on issue #1526: HDDS-2180. Add Object ID 
and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535680717
 
 
   None that I know of. However we should not commit a patch without CI on 
principle.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319209)
Time Spent: 2h  (was: 1h 50m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319205
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 20:36
Start Date: 26/Sep/19 20:36
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on issue #1526: HDDS-2180. Add 
Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535675877
 
 
   > Was this committed without a pre-commit run from Anzix?
   
   Looks like it was not run. I did look at the yetus output but the output is 
too noisy to make any sense.
   
   Is this commit causing any issues ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319205)
Time Spent: 1h 50m  (was: 1h 40m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319204=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319204
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 20:36
Start Date: 26/Sep/19 20:36
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on issue #1526: HDDS-2180. Add 
Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535675877
 
 
   > Was this committed without a pre-commit run from Anzix?
   
   Looks like it was not run. I did look at the yetus output but the output is 
too noisy to make any sense.
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319204)
Time Spent: 1h 40m  (was: 1.5h)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319107
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 17:55
Start Date: 26/Sep/19 17:55
Worklog Time Spent: 10m 
  Work Description: arp7 commented on issue #1526: HDDS-2180. Add Object ID 
and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535617334
 
 
   Was this committed without a pre-commit run from Anzix?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319107)
Time Spent: 1.5h  (was: 1h 20m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=319072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319072
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 26/Sep/19 16:41
Start Date: 26/Sep/19 16:41
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 319072)
Time Spent: 1h 20m  (was: 1h 10m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318651=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318651
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 23:08
Start Date: 25/Sep/19 23:08
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on issue #1526: HDDS-2180. Add 
Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535258351
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 5 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for branch |
   | -1 | mvninstall | 30 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 24 | hadoop-ozone in trunk failed. |
   | -1 | compile | 20 | hadoop-hdds in trunk failed. |
   | -1 | compile | 15 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 49 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 843 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 22 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 20 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 943 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 33 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 20 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | -1 | mvninstall | 36 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 30 | hadoop-ozone in the patch failed. |
   | -1 | compile | 24 | hadoop-hdds in the patch failed. |
   | -1 | compile | 19 | hadoop-ozone in the patch failed. |
   | -1 | cc | 24 | hadoop-hdds in the patch failed. |
   | -1 | cc | 19 | hadoop-ozone in the patch failed. |
   | -1 | javac | 24 | hadoop-hdds in the patch failed. |
   | -1 | javac | 19 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 57 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 722 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 21 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 20 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 32 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 20 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 28 | hadoop-hdds in the patch failed. |
   | -1 | unit | 24 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 32 | The patch does not generate ASF License warnings. |
   | | | 2356 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1526 |
   | Optional Tests | dupname asflicense compile cc mvnsite javac unit javadoc 
mvninstall shadedclient findbugs checkstyle |
   | uname | Linux becb47a90b3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / bdaaa3b |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-findbugs-hadoop-hdds.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/2/artifact/out/branch-findbugs-hadoop-ozone.txt
 |
   | mvninstall |

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318633
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 22:27
Start Date: 25/Sep/19 22:27
Worklog Time Spent: 10m 
  Work Description: hadoop-yetus commented on issue #1526: HDDS-2180. Add 
Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535248354
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 43 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 5 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for branch |
   | -1 | mvninstall | 30 | hadoop-hdds in trunk failed. |
   | -1 | mvninstall | 26 | hadoop-ozone in trunk failed. |
   | -1 | compile | 21 | hadoop-hdds in trunk failed. |
   | -1 | compile | 15 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 49 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 834 | branch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 21 | hadoop-hdds in trunk failed. |
   | -1 | javadoc | 19 | hadoop-ozone in trunk failed. |
   | 0 | spotbugs | 930 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | -1 | findbugs | 31 | hadoop-hdds in trunk failed. |
   | -1 | findbugs | 19 | hadoop-ozone in trunk failed. |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 18 | Maven dependency ordering for patch |
   | -1 | mvninstall | 35 | hadoop-hdds in the patch failed. |
   | -1 | mvninstall | 29 | hadoop-ozone in the patch failed. |
   | -1 | compile | 24 | hadoop-hdds in the patch failed. |
   | -1 | compile | 19 | hadoop-ozone in the patch failed. |
   | -1 | cc | 24 | hadoop-hdds in the patch failed. |
   | -1 | cc | 19 | hadoop-ozone in the patch failed. |
   | -1 | javac | 24 | hadoop-hdds in the patch failed. |
   | -1 | javac | 19 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 56 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 738 | patch has no errors when building and testing 
our client artifacts. |
   | -1 | javadoc | 21 | hadoop-hdds in the patch failed. |
   | -1 | javadoc | 20 | hadoop-ozone in the patch failed. |
   | -1 | findbugs | 31 | hadoop-hdds in the patch failed. |
   | -1 | findbugs | 20 | hadoop-ozone in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 28 | hadoop-hdds in the patch failed. |
   | -1 | unit | 24 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 33 | The patch does not generate ASF License warnings. |
   | | | 2364 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/1526 |
   | Optional Tests | dupname asflicense compile cc mvnsite javac unit javadoc 
mvninstall shadedclient findbugs checkstyle |
   | uname | Linux 19a38fab1e05 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / bdaaa3b |
   | Default Java | 1.8.0_222 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-compile-hadoop-hdds.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-javadoc-hadoop-hdds.txt
 |
   | javadoc | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-javadoc-hadoop-ozone.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-findbugs-hadoop-hdds.txt
 |
   | findbugs | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-1526/1/artifact/out/branch-findbugs-hadoop-ozone.txt
 |
   | mvninstall |

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318626
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 22:13
Start Date: 25/Sep/19 22:13
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328362976
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
 ##
 @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList 
volumeList,
 }
 
 List prevVolList = new ArrayList<>();
+long objectID = 100;
 if (volumeList != null) {
   prevVolList.addAll(volumeList.getVolumeNamesList());
+  objectID = volumeList.getObjectID();
 
 Review comment:
   Yes, for some reason, when we replace a VolumeList, we do it like this. We 
read the current list, remove or add a new volume, create a new object and then 
write it back. This is reality nothing but a small change in the list of 
volumes. So I keep the same object ID as if Object is same.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318626)
Time Spent: 50m  (was: 40m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318625
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 22:12
Start Date: 25/Sep/19 22:12
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328362600
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
 ##
 @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList 
volumeList,
 }
 
 List prevVolList = new ArrayList<>();
+long objectID = 100;
 
 Review comment:
   No, thanks I will fix that, I discovered it from a test code path, and left 
over from the fix. I will get this fixed.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318625)
Time Spent: 40m  (was: 0.5h)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318623
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 22:09
Start Date: 25/Sep/19 22:09
Worklog Time Spent: 10m 
  Work Description: xiaoyuyao commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328361911
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
 ##
 @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList 
volumeList,
 }
 
 List prevVolList = new ArrayList<>();
+long objectID = 100;
 if (volumeList != null) {
   prevVolList.addAll(volumeList.getVolumeNamesList());
+  objectID = volumeList.getObjectID();
 
 Review comment:
   Here we always use the objectID of the new volumeList to replace the 
existing one on line 113, is this expected?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318623)
Time Spent: 0.5h  (was: 20m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318619=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318619
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 22:00
Start Date: 25/Sep/19 22:00
Worklog Time Spent: 10m 
  Work Description: xiaoyuyao commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328359463
 
 

 ##
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
 ##
 @@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList 
volumeList,
 }
 
 List prevVolList = new ArrayList<>();
+long objectID = 100;
 
 Review comment:
   Is there a reason for initialize objectID to 100 here for new volume?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318619)
Time Spent: 20m  (was: 10m)

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

[jira] [Work logged] (HDDS-2180) Add Object ID and update ID on VolumeList Object

2019-09-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318615=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318615
 ]

ASF GitHub Bot logged work on HDDS-2180:


Author: ASF GitHub Bot
Created on: 25/Sep/19 21:47
Start Date: 25/Sep/19 21:47
Worklog Time Spent: 10m 
  Work Description: anuengineer commented on pull request #1526: HDDS-2180. 
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526
 
 
   https://issues.apache.org/jira/browse/HDDS-2180
   Adds Object ID and Update ID to VolumeList object.
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318615)
Remaining Estimate: 0h
Time Spent: 10m

> Add Object ID and update ID on VolumeList Object
> 
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Anu Engineer
>Assignee: Anu Engineer
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org