[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658791
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 01/Oct/21 07:36
Start Date: 01/Oct/21 07:36
Worklog Time Spent: 10m
Work Description: adamantal commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-931984140
Merged to trunk, thanks for the contribution @Neilxzn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 658791)
Time Spent: 3.5h (was: 3h 20m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Assignee: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658790=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658790
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 01/Oct/21 07:35
Start Date: 01/Oct/21 07:35
Worklog Time Spent: 10m
Work Description: adamantal merged pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 658790)
Time Spent: 3h 20m (was: 3h 10m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658525=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658525
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 18:08
Start Date: 30/Sep/21 18:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-931548719
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 23m 54s | | trunk passed |
| +1 :green_heart: | compile | 23m 9s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 19m 41s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 3m 52s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 9s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 8s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 6s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 5m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 41s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 13s | | the patch passed |
| +1 :green_heart: | compile | 22m 19s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 22m 19s | | the patch passed |
| +1 :green_heart: | compile | 19m 34s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 19m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 44s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 3s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 5s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 14s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 6m 17s | | the patch passed |
| +1 :green_heart: | shadedclient | 24m 52s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 9s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 324m 27s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 58s | | The patch does not
generate ASF License warnings. |
| | | 551m 34s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests |
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/5/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 6df1b7d57b2d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18
19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / fcfc7e79c84722a3ef9f31cfcaa81e07d4fdd6e5 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658466
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 16:12
Start Date: 30/Sep/21 16:12
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-931465342
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 41s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 20m 47s | | trunk passed |
| +1 :green_heart: | compile | 21m 6s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 18m 36s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 3m 45s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 14s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 19s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 25s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 5m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 57s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 8s | | the patch passed |
| +1 :green_heart: | compile | 20m 34s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 20m 34s | | the patch passed |
| +1 :green_heart: | compile | 18m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 18m 28s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 36s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 16s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 22s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 6m 5s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 0s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 21s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 224m 41s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 11s | | The patch does not
generate ASF License warnings. |
| | | 439m 19s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 9048bd49350e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 06babcb9153fc23108f985b501ff815ef59e40e9 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/4/testReport/ |
| Max. process+thread count | 3104 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U:
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658201
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 08:59
Start Date: 30/Sep/21 08:59
Worklog Time Spent: 10m
Work Description: Neilxzn commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r719203502
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -280,8 +299,7 @@ public void testJournal() throws Exception {
assertTrue(lastJournalTimestamp > beginTimestamp);
}
-
-
+
Review comment:
Thank you for your review!
Good suggestion! I have removed unrelated change. Please review it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 658201)
Time Spent: 2h 50m (was: 2h 40m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658166=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658166
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 08:20
Start Date: 30/Sep/21 08:20
Worklog Time Spent: 10m
Work Description: adamantal commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r719172038
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -280,8 +299,7 @@ public void testJournal() throws Exception {
assertTrue(lastJournalTimestamp > beginTimestamp);
}
-
-
+
Review comment:
Sorry to bother you, but there's still some change here. Any unrelated
change could cause cherry-picking complicated due to the unnecessary whitespace
conflicts, that's why I'm suggesting to fix it before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 658166)
Time Spent: 2h 40m (was: 2.5h)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=658076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658076
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 02:50
Start Date: 30/Sep/21 02:50
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-930706485
The fail tests is due to java.lang.OutOfMemoryError. It is unrelated.
```
java.lang.OutOfMemoryError: unable to create new native thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 658076)
Time Spent: 2.5h (was: 2h 20m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657929=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657929
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:38
Start Date: 30/Sep/21 00:38
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929771633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657929)
Time Spent: 2h 20m (was: 2h 10m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657869
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:32
Start Date: 30/Sep/21 00:32
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-930262554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657869)
Time Spent: 2h 10m (was: 2h)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657861
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:31
Start Date: 30/Sep/21 00:31
Worklog Time Spent: 10m
Work Description: Neilxzn commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r718305614
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -281,7 +300,6 @@ public void testJournal() throws Exception {
}
-
@Test(timeout=10)
Review comment:
There were tow empty lines so I remove one empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657861)
Time Spent: 2h (was: 1h 50m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657755=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657755
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 30/Sep/21 00:22
Start Date: 30/Sep/21 00:22
Worklog Time Spent: 10m
Work Description: adamantal commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r718248005
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -281,7 +300,6 @@ public void testJournal() throws Exception {
}
-
@Test(timeout=10)
Review comment:
Could you please readd the line here?
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
##
@@ -99,6 +100,11 @@ String getName() {
return "Journal-" + journal.getJournalId();
}
+ @Metric(value={"JournalId", "Current JournalId"}, type= Type.TAG)
Review comment:
```suggestion
@Metric(value={"JournalId", "Current JournalId"}, type=Type.TAG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657755)
Time Spent: 1h 50m (was: 1h 40m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657449=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657449
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 18:15
Start Date: 29/Sep/21 18:15
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-930426461
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 0s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 31s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 39s | | trunk passed |
| +1 :green_heart: | compile | 31m 52s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 29m 21s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 5m 18s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 37s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 7s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 4m 16s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 8m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 30m 23s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | | the patch passed |
| +1 :green_heart: | compile | 30m 43s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 30m 43s | | the patch passed |
| +1 :green_heart: | compile | 26m 33s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 26m 33s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 38s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 51s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 44s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 40s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 7m 21s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 55s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 18s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 276m 24s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| -1 :x: | asflicense | 1m 5s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/artifact/out/results-asflicense.txt)
| The patch generated 11 ASF License warnings. |
| | | 558m 50s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.TestFileCreationClient |
| | hadoop.hdfs.TestFileConcurrentReader |
| | hadoop.hdfs.server.balancer.TestBalancer |
| | hadoop.hdfs.server.balancer.TestBalancerRPCDelay |
| | hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy |
| | hadoop.hdfs.TestHDFSFileSystemContract |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux f65dbf31e849 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18
19:21:19 UTC 2021 x86_64 x86_64 x86_64
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657301
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 15:03
Start Date: 29/Sep/21 15:03
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-930262554
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 9s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 35s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 28s | | trunk passed |
| +1 :green_heart: | compile | 28m 29s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 24m 3s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 4m 27s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 26s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 32s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 7m 32s | | trunk passed |
| +1 :green_heart: | shadedclient | 29m 27s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 48s | | the patch passed |
| +1 :green_heart: | compile | 27m 45s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 27m 45s | | the patch passed |
| +1 :green_heart: | compile | 24m 19s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 24m 19s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 4m 9s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 13s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 8s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 33s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 7m 56s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 27s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 16s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 98m 9s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +0 :ok: | asflicense | 0m 47s | | ASF License check generated no
output? |
| | | 362m 46s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.TestEncryptionZonesWithKMS |
| | hadoop.hdfs.TestDecommission |
| | hadoop.hdfs.web.TestWebHdfsFileSystemContract |
| | hadoop.hdfs.TestReconstructStripedFileWithValidator |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 3f80de784e3f 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14
16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 1d4e1b1177fad0d5f720616a7278aa61830088a1 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657070
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 09:06
Start Date: 29/Sep/21 09:06
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929985819
Thank you for your review. @adamantal
I commit it again to fix checkstyle error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657070)
Time Spent: 1h 20m (was: 1h 10m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657067
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 09:03
Start Date: 29/Sep/21 09:03
Worklog Time Spent: 10m
Work Description: Neilxzn commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r718305614
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -281,7 +300,6 @@ public void testJournal() throws Exception {
}
-
@Test(timeout=10)
Review comment:
There were tow empty lines so I remove one empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657067)
Time Spent: 1h 10m (was: 1h)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=657047=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-657047
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 07:56
Start Date: 29/Sep/21 07:56
Worklog Time Spent: 10m
Work Description: adamantal commented on a change in pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#discussion_r718248005
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java
##
@@ -281,7 +300,6 @@ public void testJournal() throws Exception {
}
-
@Test(timeout=10)
Review comment:
Could you please readd the line here?
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
##
@@ -99,6 +100,11 @@ String getName() {
return "Journal-" + journal.getJournalId();
}
+ @Metric(value={"JournalId", "Current JournalId"}, type= Type.TAG)
Review comment:
```suggestion
@Metric(value={"JournalId", "Current JournalId"}, type=Type.TAG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 657047)
Time Spent: 1h (was: 50m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656978=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656978
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 29/Sep/21 02:28
Start Date: 29/Sep/21 02:28
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929771633
cc @aajisaka @adamantal . Would you take some time to review this patch?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 656978)
Time Spent: 50m (was: 40m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656665=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656665
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 28/Sep/21 20:09
Start Date: 28/Sep/21 20:09
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929498362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 53s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 14s | | trunk passed |
| +1 :green_heart: | compile | 23m 44s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 21m 49s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 4m 20s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 16s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 24s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 28s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 5m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 45s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 8s | | the patch passed |
| +1 :green_heart: | compile | 20m 26s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 20m 26s | | the patch passed |
| +1 :green_heart: | compile | 18m 29s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 18m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 33s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 17s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 6m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 8s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 225m 5s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 10s | | The patch does not
generate ASF License warnings. |
| | | 449m 58s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ec622a565571 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 84f3331ed7d67d3310a1372451f93f96d57ceaad |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/testReport/ |
| Max. process+thread count | 3106 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U:
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656472=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656472
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 28/Sep/21 19:52
Start Date: 28/Sep/21 19:52
Worklog Time Spent: 10m
Work Description: Neilxzn opened a new pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494
### Description of PR
https://issues.apache.org/jira/browse/HDFS-16242
JournalMetrics should add JournalId MetricTag to distinguish different
nameservice journal metrics when JournalNode use ganglia sink or prometheus
sink.
JMX
Before this patch, journal' jmx :
// jmx json
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
"Syncs60sNumOps" : 0,
...
},
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
"Syncs60sNumOps" : 0,
...
}
After this patch, journal' jmx :
// jmx json
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
"tag.JournalId" : "nntest1", // add this tag
"Syncs60sNumOps" : 0,
...
},
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
"tag.JournalId" : "nntest2",
"Syncs60sNumOps" : 0,
...
}
PrometheusSink
Before this patch, journal' prometheus export :
journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
After this patch, journal' prometheus export :
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
2
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
75
### How was this patch tested?
add test testJournalMetricTags
### For code changes:
add JournalMetrics$getJournalId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 656472)
Time Spent: 0.5h (was: 20m)
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656301=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656301
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 28/Sep/21 18:04
Start Date: 28/Sep/21 18:04
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494#issuecomment-929498362
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 53s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 14s | | trunk passed |
| +1 :green_heart: | compile | 23m 44s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 21m 49s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 4m 20s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 16s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 24s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 28s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 5m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 45s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 8s | | the patch passed |
| +1 :green_heart: | compile | 20m 26s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 20m 26s | | the patch passed |
| +1 :green_heart: | compile | 18m 29s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 18m 29s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 33s | | the patch passed |
| +1 :green_heart: | mvnsite | 3m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 17s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 3m 28s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 6m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 8s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 17m 15s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 225m 5s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 10s | | The patch does not
generate ASF License warnings. |
| | | 449m 58s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3494 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux ec622a565571 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 84f3331ed7d67d3310a1372451f93f96d57ceaad |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3494/1/testReport/ |
| Max. process+thread count | 3106 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs U:
[jira] [Work logged] (HDFS-16242) JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.
[
https://issues.apache.org/jira/browse/HDFS-16242?focusedWorklogId=656079=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656079
]
ASF GitHub Bot logged work on HDFS-16242:
-
Author: ASF GitHub Bot
Created on: 28/Sep/21 10:33
Start Date: 28/Sep/21 10:33
Worklog Time Spent: 10m
Work Description: Neilxzn opened a new pull request #3494:
URL: https://github.com/apache/hadoop/pull/3494
### Description of PR
https://issues.apache.org/jira/browse/HDFS-16242
JournalMetrics should add JournalId MetricTag to distinguish different
nameservice journal metrics when JournalNode use ganglia sink or prometheus
sink.
JMX
Before this patch, journal' jmx :
// jmx json
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
"Syncs60sNumOps" : 0,
...
},
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
"Syncs60sNumOps" : 0,
...
}
After this patch, journal' jmx :
// jmx json
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
"tag.JournalId" : "nntest1", // add this tag
"Syncs60sNumOps" : 0,
...
},
{
"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
"tag.JournalId" : "nntest2",
"Syncs60sNumOps" : 0,
...
}
PrometheusSink
Before this patch, journal' prometheus export :
journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
After this patch, journal' prometheus export :
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
2
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
75
### How was this patch tested?
add test testJournalMetricTags
### For code changes:
add JournalMetrics$getJournalId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 656079)
Remaining Estimate: 0h
Time Spent: 10m
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics.
>
>
> Key: HDFS-16242
> URL: https://issues.apache.org/jira/browse/HDFS-16242
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
>Affects Versions: 3.4.0
>Reporter: Max Xie
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> JournalMetrics should add JournalId MetricTag to distinguish different
> nameservice journal metrics when JournalNode use ganglia sink or prometheus
> sink.
> *JMX*
> Before this patch, journal' jmx :
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "Syncs60sNumOps" : 0,
> ...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
>"Syncs60sNumOps" : 0,
>...
>}
> {code}
>
> After this patch, journal' jmx :
>
> {code:java}
> // jmx json
> {
> "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
> "tag.JournalId" : "nntest1", // add this tag
> "Syncs60sNumOps" : 0,
>...
> },
> {
>"name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
> "tag.JournalId" : "nntest2",
>"Syncs60sNumOps" : 0,
> ...
> }
> {code}
>
> *PrometheusSink*
> Before this patch, journal' prometheus export :
>
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
> {code}
> After this patch, journal' prometheus export :
> {code:java}
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"}
> 2
> journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"}
> 75
> {code}
>
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
