Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Steve Ebersole
I'm not sure what else to tell you.  Sure some things have been removed.

I'm not going to go through all of these right now.  If there are some in
particular you are interested please bring those of specifically.


On Thu, Feb 15, 2018 at 6:48 PM Gail Badner  wrote:

> Hi Steve,
>
> The list I provided contains removals from your fork in wip/6.0 branch.
>
> IIUC, integrating changes from master will not restore what was deleted
> or moved to a different package.  After integrating from master and
> resolving conflicts, we'll have the same incompatibilities.
>
> Am I missing something? Is there some other branch I should be comparing?
>
> Regards,
> Gail
>
> On Thu, Feb 15, 2018 at 9:13 AM, Steve Ebersole 
> wrote:
>
>> We have not integrated changes from master into 6.0 for a long time.  And
>> we probably won't for some time yet either.  So comparisons between 5.2 or
>> 5.3 and 6.0 right now are pointless
>>
>> On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:
>>
>>> I sent this last night with a huge report file, and it seems that it
>>> didn't
>>> get out.
>>>
>>> I'm re-sending without the report file...
>>>
>>> I ran japi-compliance-checker to compare differences in APIs
>>> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
>>> SNAPSHOT.jar.
>>>
>>> I ran it last week, so it may not include updates made since that time.
>>>
>>> Differences in Envers shown in the report should be disregarded because
>>> it
>>> only reflects that hibernate-envers was merged into hibernate-core. A
>>> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
>>> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>>>
>>> Chris will provide details about Envers differences in a separate email.
>>>
>>> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
>>> documented are the only non-Envers API changes that could affect
>>> applications. They all involve removed classes/methods.
>>>
>>> My intention here is just to get this information out, so we have some
>>> solid examples to discuss.
>>>
>>> Regards,
>>> Gail
>>>
>>> 
>>> --
>>>
>>> Custom types: I am not familiar with how this will work in 6.0. Steve,
>>> please fill in details about any incompatibilities.
>>>
>>> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>>>
>>> In 5.0/5.1/5.2:
>>> * user guides say, "This appendix covers the legacy Hibernate
>>> org.hibernate.Criteria API, which should be considered deprecated. New
>>> development should focus on the JPA
>>> javax.persistence.criteria.CriteriaQuery
>>> API. Eventually, Hibernate-specific criteria features will be ported as
>>> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For
>>> details
>>> on the JPA APIs, see Criteria."
>>>
>>> In 5.2/5.3:
>>> * Criteria and DetachedCriteria are not deprecated;
>>> * all SharedSessionContract#createCriteria methods are deprecated;
>>> * public static methods in DetachedCriteria are not deprecated;
>>>
>>> In 6.0:
>>> * Criteria and DetachedCriteria are removed along with other classes in
>>> org.hibernate.criterion.
>>>
>>> Incompatibilities migrating from 5.3 -> 6.0:
>>> 1) Existing applications using legacy org.hibernate.Criteria will need to
>>> be updated to use javax.persistence.criteria.CriteriaQuery;
>>> 2) If Hibernate's implementation of
>>> javax.persistence.criteria.CriteriaQuery
>>> does not include the Hibernate-specific extensions that were available
>>> using org.hibernate.Criteria, applications may not have a straightforward
>>> way to change their applications to work.
>>>
>>> org.hibernate.Query
>>>
>>> In 5.1:
>>> * SharedSessionContract#createQuery returns org.hibernate.Query
>>> (org.hibernate.Session extends SharedSessionContract);
>>>
>>> In 5.2/5.3:
>>> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
>>> used instead; org.hibernate.query.Query extends org.hibernate.Query;
>>> * SharedSessionContract#createQuery moved to
>>> org.hibernate.query.QueryProducer#createQuery,
>>> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
>>> (org.hibernate.Session extends QueryProducer);
>>>
>>> In 6.0:
>>> * org.hibernate.Query was removed.
>>>
>>> Incompatibilities migrating from 5.3 -> 6.0:
>>> 1) Existing applications that explicitly use org.hibernate.Query
>>> (including
>>> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
>>> be changed to use org.hibernate.query.Query.
>>>
>>> org.hibernate.SQLQuery:
>>>
>>> In 5.1:
>>> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
>>> (org.hibernate.Session extends SharedSessionContract);
>>>
>>> In 5.2/5.3:
>>> * SQLQuery was deprecated; NativeQuery should be used instead;
>>> NativeQuery
>>> extends SQLQuery;
>>> * 

Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Gail Badner
Hi Steve,

The list I provided contains removals from your fork in wip/6.0 branch.

IIUC, integrating changes from master will not restore what was deleted or
moved to a different package.  After integrating from master and resolving
conflicts, we'll have the same incompatibilities.

Am I missing something? Is there some other branch I should be comparing?

Regards,
Gail

On Thu, Feb 15, 2018 at 9:13 AM, Steve Ebersole  wrote:

> We have not integrated changes from master into 6.0 for a long time.  And
> we probably won't for some time yet either.  So comparisons between 5.2 or
> 5.3 and 6.0 right now are pointless
>
> On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:
>
>> I sent this last night with a huge report file, and it seems that it
>> didn't
>> get out.
>>
>> I'm re-sending without the report file...
>>
>> I ran japi-compliance-checker to compare differences in APIs
>> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
>> SNAPSHOT.jar.
>>
>> I ran it last week, so it may not include updates made since that time.
>>
>> Differences in Envers shown in the report should be disregarded because it
>> only reflects that hibernate-envers was merged into hibernate-core. A
>> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
>> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>>
>> Chris will provide details about Envers differences in a separate email.
>>
>> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
>> documented are the only non-Envers API changes that could affect
>> applications. They all involve removed classes/methods.
>>
>> My intention here is just to get this information out, so we have some
>> solid examples to discuss.
>>
>> Regards,
>> Gail
>>
>> 
>> --
>>
>> Custom types: I am not familiar with how this will work in 6.0. Steve,
>> please fill in details about any incompatibilities.
>>
>> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>>
>> In 5.0/5.1/5.2:
>> * user guides say, "This appendix covers the legacy Hibernate
>> org.hibernate.Criteria API, which should be considered deprecated. New
>> development should focus on the JPA javax.persistence.criteria.Cri
>> teriaQuery
>> API. Eventually, Hibernate-specific criteria features will be ported as
>> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For
>> details
>> on the JPA APIs, see Criteria."
>>
>> In 5.2/5.3:
>> * Criteria and DetachedCriteria are not deprecated;
>> * all SharedSessionContract#createCriteria methods are deprecated;
>> * public static methods in DetachedCriteria are not deprecated;
>>
>> In 6.0:
>> * Criteria and DetachedCriteria are removed along with other classes in
>> org.hibernate.criterion.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing applications using legacy org.hibernate.Criteria will need to
>> be updated to use javax.persistence.criteria.CriteriaQuery;
>> 2) If Hibernate's implementation of javax.persistence.criteria.Cri
>> teriaQuery
>> does not include the Hibernate-specific extensions that were available
>> using org.hibernate.Criteria, applications may not have a straightforward
>> way to change their applications to work.
>>
>> org.hibernate.Query
>>
>> In 5.1:
>> * SharedSessionContract#createQuery returns org.hibernate.Query
>> (org.hibernate.Session extends SharedSessionContract);
>>
>> In 5.2/5.3:
>> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
>> used instead; org.hibernate.query.Query extends org.hibernate.Query;
>> * SharedSessionContract#createQuery moved to
>> org.hibernate.query.QueryProducer#createQuery,
>> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
>> (org.hibernate.Session extends QueryProducer);
>>
>> In 6.0:
>> * org.hibernate.Query was removed.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing applications that explicitly use org.hibernate.Query
>> (including
>> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
>> be changed to use org.hibernate.query.Query.
>>
>> org.hibernate.SQLQuery:
>>
>> In 5.1:
>> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
>> (org.hibernate.Session extends SharedSessionContract);
>>
>> In 5.2/5.3:
>> * SQLQuery was deprecated; NativeQuery should be used instead; NativeQuery
>> extends SQLQuery;
>> * SharedSessionContract#createSQLQuery moved to
>> QueryProducer#createSQLQuery, returning  NativeQuery (which extends
>> SQLQuery); Session extends QueryProducer;
>> * QueryProducer#createSQLQuery is deprecated;
>> QueryProducer#createNativeQuery
>> should be used instead
>>
>> In 6.0:
>> * SQLQuery and org.hibernate.query.QueryProducer#createSQLQuery are
>> removed.
>>
>> Incompatibilities migrating from 5.3 -> 6.0:
>> 1) Existing 

Re: [hibernate-dev] Starting 5.3 release

2018-02-15 Thread Sanne Grinovero
You mean the tag of the release will be wrong? That's not so nice.

And what about Vlad's commits, are they included or not in the release
and changelogs?

On 15 February 2018 at 18:12, Steve Ebersole  wrote:
> Actually I'll just rebase mine to the end.  History will be wrong for a few
> commits, but it is what it is at this point
>
> On Thu, Feb 15, 2018 at 12:10 PM Steve Ebersole  wrote:
>
>> Well someone pushed.  Now I'm going to have to force push.  Grr
>>
>>
>> On Thu, Feb 15, 2018 at 8:50 AM Steve Ebersole 
>> wrote:
>>
>>> Per subject.  Please do not push to master for the time being...
>>>
>>
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] Hibernate ORM 5.3.0.CR1 released

2018-02-15 Thread Steve Ebersole
First release fully passing the standalone JPA TCK.

See http://in.relation.to/2018/02/15/hibernate-orm-530-cr1-release/
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Starting 5.3 release

2018-02-15 Thread Steve Ebersole
Actually I'll just rebase mine to the end.  History will be wrong for a few
commits, but it is what it is at this point

On Thu, Feb 15, 2018 at 12:10 PM Steve Ebersole  wrote:

> Well someone pushed.  Now I'm going to have to force push.  Grr
>
>
> On Thu, Feb 15, 2018 at 8:50 AM Steve Ebersole 
> wrote:
>
>> Per subject.  Please do not push to master for the time being...
>>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Starting 5.3 release

2018-02-15 Thread Steve Ebersole
Well someone pushed.  Now I'm going to have to force push.  Grr


On Thu, Feb 15, 2018 at 8:50 AM Steve Ebersole  wrote:

> Per subject.  Please do not push to master for the time being...
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] API incompatibilities between Hibernate ORM 5.3 and 6.0

2018-02-15 Thread Steve Ebersole
We have not integrated changes from master into 6.0 for a long time.  And
we probably won't for some time yet either.  So comparisons between 5.2 or
5.3 and 6.0 right now are pointless

On Wed, Feb 14, 2018 at 12:09 PM Gail Badner  wrote:

> I sent this last night with a huge report file, and it seems that it didn't
> get out.
>
> I'm re-sending without the report file...
>
> I ran japi-compliance-checker to compare differences in APIs
> between hibernate-core-5.3.0-SNAPSHOT.jar and hibernate-core-6.0.0-
> SNAPSHOT.jar.
>
> I ran it last week, so it may not include updates made since that time.
>
> Differences in Envers shown in the report should be disregarded because it
> only reflects that hibernate-envers was merged into hibernate-core. A
> separate comparison between hibernate-envers-5.3.0-SNAPSHOT.jar and
> hibernate-core-6.0.0-SNAPSHOT.jar needs to be done to see Envers changes.
>
> Chris will provide details about Envers differences in a separate email.
>
> The report is huge; it took me 3 to 4 hours to scan it. AFAICT, what I've
> documented are the only non-Envers API changes that could affect
> applications. They all involve removed classes/methods.
>
> My intention here is just to get this information out, so we have some
> solid examples to discuss.
>
> Regards,
> Gail
>
> 
> --
>
> Custom types: I am not familiar with how this will work in 6.0. Steve,
> please fill in details about any incompatibilities.
>
> org.hibernate.Criteria and org.hibernate.criterion.DetachedCriteria:
>
> In 5.0/5.1/5.2:
> * user guides say, "This appendix covers the legacy Hibernate
> org.hibernate.Criteria API, which should be considered deprecated. New
> development should focus on the JPA
> javax.persistence.criteria.CriteriaQuery
> API. Eventually, Hibernate-specific criteria features will be ported as
> extensions to the JPA javax.persistence.criteria.CriteriaQuery. For details
> on the JPA APIs, see Criteria."
>
> In 5.2/5.3:
> * Criteria and DetachedCriteria are not deprecated;
> * all SharedSessionContract#createCriteria methods are deprecated;
> * public static methods in DetachedCriteria are not deprecated;
>
> In 6.0:
> * Criteria and DetachedCriteria are removed along with other classes in
> org.hibernate.criterion.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications using legacy org.hibernate.Criteria will need to
> be updated to use javax.persistence.criteria.CriteriaQuery;
> 2) If Hibernate's implementation of
> javax.persistence.criteria.CriteriaQuery
> does not include the Hibernate-specific extensions that were available
> using org.hibernate.Criteria, applications may not have a straightforward
> way to change their applications to work.
>
> org.hibernate.Query
>
> In 5.1:
> * SharedSessionContract#createQuery returns org.hibernate.Query
> (org.hibernate.Session extends SharedSessionContract);
>
> In 5.2/5.3:
> * org.hibernate.Query was deprecated; org.hibernate.query.Query should be
> used instead; org.hibernate.query.Query extends org.hibernate.Query;
> * SharedSessionContract#createQuery moved to
> org.hibernate.query.QueryProducer#createQuery,
> returning  org.hibernate.query.Query (which extends org.hibernate.Query);
> (org.hibernate.Session extends QueryProducer);
>
> In 6.0:
> * org.hibernate.Query was removed.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications that explicitly use org.hibernate.Query (including
> javax.persistence.Query.unwrap( org.hibernate.Query.class )) will have to
> be changed to use org.hibernate.query.Query.
>
> org.hibernate.SQLQuery:
>
> In 5.1:
> * SharedSessionContract#createSQLQuery returns org.hibernate.SQLQuery
> (org.hibernate.Session extends SharedSessionContract);
>
> In 5.2/5.3:
> * SQLQuery was deprecated; NativeQuery should be used instead; NativeQuery
> extends SQLQuery;
> * SharedSessionContract#createSQLQuery moved to
> QueryProducer#createSQLQuery, returning  NativeQuery (which extends
> SQLQuery); Session extends QueryProducer;
> * QueryProducer#createSQLQuery is deprecated;
> QueryProducer#createNativeQuery
> should be used instead
>
> In 6.0:
> * SQLQuery and org.hibernate.query.QueryProducer#createSQLQuery are
> removed.
>
> Incompatibilities migrating from 5.3 -> 6.0:
> 1) Existing applications using Session#createSQLQuery will need to be
> updated to use Session#createNativeQuery.
> 2) Existing applications that explicitly use org.hibernate.SQLQuery
> (including javax.persistence.Query.unwrap( SQLQuery.class )) will have to
> be changed to use NativeQuery.
>
> org.hibernate.SynchronizeableQuery
>
> In 5.2/5.3:
> * org.hibernate.SynchronizeableQuery is not deprecated;
> * SQLQuery, NativeQuery and ProcedureCall extend org.hibernate.
> SynchronizeableQuery
>
> In 6.0:
> * org.hibernate.SynchronizeableQuery is moved to org.hibernate.query.
> 

[hibernate-dev] Starting 5.3 release

2018-02-15 Thread Steve Ebersole
Per subject.  Please do not push to master for the time being...
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] JDK 10: First Release Candidate - JDK 10 b43

2018-02-15 Thread Rory O'Donnell
Thanks for the update Sanne!

Rgds,Rory


On 14/02/2018 20:48, Sanne Grinovero wrote:
> Hi Rory,
>
> thanks for the update!
>
> I've updated our ci.hibernate.org infrastructure and installed the
> JDK10 Release Candidate 1.
>
> We still have problems with several Maven plugins but we're now able
> to work around them. Ideally for full test coverage we also need
> Byteman, which in turn requires ASM to release 6.1, but at least it's
> good to see that the (many) other tests which we can now run are fine.
>
> Just to remind, some of the tools we'd normally use aren't running on
> JDK9 yet either, but at least we're able to verify that people
> consuming any Hibernate libraries should have no issues.
>
> All : please create new jobs on ci.hibernate.org using "JDK 10 CR1",
> now available in the drop down menu on the Jenkins job configuration;
> so far we only have Hibernate Search testing.
>
> Regards and thanks,
> Sanne
>
>
> On 13 February 2018 at 10:23, Rory O'Donnell  wrote:
>> Hi Sanne,
>>
>> *JDK 10 build 43 is our first JDK 10 Release Candidate [1]*
>>
>>* JDK 10 Early Access  build 43 is available at : - jdk.java.net/10/
>>
>> Notable changes since previous email.**
>>
>> *build 43
>> *
>>
>>* JDK-8194764  -
>>  javac incorrectly flags deprecated for removal imports
>>* JDK-8196678  -
>>  avoid printing uninitialized buffer in os::print_memory_info on AIX
>>* JDK-8195837  -
>>  (tz) Upgrade time-zone data to tzdata2018c
>>
>> **
>>
>> *Bug fixes reported by Open Source Projects  :*
>>
>>* JDK-8196296 
>>  Lucene test crashes C2 compilation
>>
>> *Security Manager Survey
>> *
>>
>> If you have written or maintain code that uses the SecurityManager or
>> related APIs such as the AccessController,
>> then we would appreciate if you would complete this survey:
>> https://www.surveymonkey.com/r/RSGMF3K
>> More info on the survey  [2]
>>
>>
>> Regards,
>> Rory
>>
>> [1] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-February/000742.html
>> [2] http://mail.openjdk.java.net/pipermail/jdk-dev/2018-February/000649.html
>>
>> --
>> Rgds,Rory O'Donnell
>> Quality Engineering Manager
>> Oracle EMEA , Dublin, Ireland
>>
>> ___
>> hibernate-dev mailing list
>> hibernate-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev

-- 
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland

___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev