Hi Lionel, Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-Add-support-for-multi-context-perf-queries/20200505-060720 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> New smatch warnings: drivers/gpu/drm/i915/i915_perf.c:1457 i915_oa_stream_destroy() error: uninitialized symbol 'err'. Old smatch warnings: drivers/gpu/drm/i915/i915_perf.c:1383 oa_get_render_ctx_ids() error: double unlocked 'ctx->engines_mutex' (orig line 1351) drivers/gpu/drm/i915/i915_perf.c:3044 i915_oa_stream_init() error: uninitialized symbol 'timeline'. drivers/gpu/drm/i915/i915_perf.c:3664 i915_perf_open_ioctl_locked() error: uninitialized symbol 'ret'. # https://github.com/0day-ci/linux/commit/dc9d77b54dfbfd0de4e30e59d29d5216b80a51b2 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout dc9d77b54dfbfd0de4e30e59d29d5216b80a51b2 vim +/err +1457 drivers/gpu/drm/i915/i915_perf.c 307ca63ef54097 Lionel Landwerlin 2020-05-04 1441 d79651522e89c4 Robert Bragg 2016-11-07 1442 static void i915_oa_stream_destroy(struct i915_perf_stream *stream) d79651522e89c4 Robert Bragg 2016-11-07 1443 { 8f8b1171e1a514 Chris Wilson 2019-10-07 1444 struct i915_perf *perf = stream->perf; 307ca63ef54097 Lionel Landwerlin 2020-05-04 1445 int err; ^^^^^^^ d79651522e89c4 Robert Bragg 2016-11-07 1446 8f8b1171e1a514 Chris Wilson 2019-10-07 1447 BUG_ON(stream != perf->exclusive_stream); d79651522e89c4 Robert Bragg 2016-11-07 1448 19f81df2859eb1 Robert Bragg 2017-06-13 1449 /* f89823c212246d Lionel Landwerlin 2017-08-03 1450 * Unset exclusive_stream first, it will be checked while disabling f89823c212246d Lionel Landwerlin 2017-08-03 1451 * the metric set on gen8+. a5af081d012e8b Chris Wilson 2020-02-27 1452 * a5af081d012e8b Chris Wilson 2020-02-27 1453 * See i915_oa_init_reg_state() and lrc_configure_all_contexts() 19f81df2859eb1 Robert Bragg 2017-06-13 1454 */ a5af081d012e8b Chris Wilson 2020-02-27 1455 WRITE_ONCE(perf->exclusive_stream, NULL); dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 1456 dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 @1457 if (!err) { ^^^^^ Uninitialized 307ca63ef54097 Lionel Landwerlin 2020-05-04 1458 err = i915_perf_stream_sync(stream, false /* enable */); 307ca63ef54097 Lionel Landwerlin 2020-05-04 1459 if (err) { 307ca63ef54097 Lionel Landwerlin 2020-05-04 1460 drm_err(&perf->i915->drm, 307ca63ef54097 Lionel Landwerlin 2020-05-04 1461 "Error while disabling OA stream\n"); 307ca63ef54097 Lionel Landwerlin 2020-05-04 1462 } dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 1463 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org _______________________________________________ kbuild mailing list -- kbu...@lists.01.org To unsubscribe send an email to kbuild-le...@lists.01.org _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
