== Series Details ==

Series: drm/i915/gen11: Preempt-to-idle support in execlists. (rev3)
URL   : https://patchwork.freedesktop.org/series/40747/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3492dcf9f1e4 drm/i915/gen11: Preempt-to-idle support in execlists.
-:132: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written 
"!execlists->ctrl_reg"
#132: FILE: drivers/gpu/drm/i915/intel_lrc.c:542:
+               GEM_BUG_ON(execlists->ctrl_reg == NULL);

-:185: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#185: FILE: drivers/gpu/drm/i915/intel_lrc.c:1074:
+                       if ((status & GEN8_CTX_STATUS_IDLE_ACTIVE) &&
+                            (status & GEN11_CTX_STATUS_PREEMPT_IDLE)) {

-:186: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#186: FILE: drivers/gpu/drm/i915/intel_lrc.c:1075:
+                            (status & GEN11_CTX_STATUS_PREEMPT_IDLE)) {
+

-:199: CHECK:BRACES: Unbalanced braces around else statement
#199: FILE: drivers/gpu/drm/i915/intel_lrc.c:1086:
+                       else {

-:203: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#203: FILE: drivers/gpu/drm/i915/intel_lrc.c:1090:
+                                       execlists_set_active(execlists,
+                                                      EXECLISTS_ACTIVE_HWACK);

-:207: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#207: FILE: drivers/gpu/drm/i915/intel_lrc.c:1094:
+                                       execlists_clear_active(execlists,
+                                                      EXECLISTS_ACTIVE_HWACK);

-:229: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#229: FILE: drivers/gpu/drm/i915/intel_lrc.c:1112:
+                           buf[2*head + 1] == 
execlists->preempt_complete_status)) {
                                 ^

total: 0 errors, 0 warnings, 7 checks, 190 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to