Re: [PATCH] drm/dp: correct struct member name in documentation
On Thu, Apr 11, 2024 at 12:55:29PM -0400, Golani, Mitulkumar Ajitkumar wrote: > > > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Wednesday, April 10, 2024 9:49 PM > > To: Golani, Mitulkumar Ajitkumar ; > > tzimmerm...@suse.de; mrip...@kernel.org; > > maarten.lankho...@linux.intel.com > > Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > > Nautiyal, > > Ankit K ; Nikula, Jani ; > > s...@canb.auug.org.au > > Subject: Re: [PATCH] drm/dp: correct struct member name in documentation > > > > On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > > > Correct struct member name to 'mode' instead of 'operation mode' > > > in 'drm_dp_as_sdp' structure description. > > > > > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > > > > Probably good to avoid this 'Fixes:' tag, and only use that for real code > > bugs. > > Thank you for inputs.. I understood and I will take the future note. Please > suggest if required to update the change with new revision or we can take > care while merge.. ? I can remove it while merging. I just need an ack from drm or drm-misc maintainers to merge this through drm-intel-next. Sima, Dave? > > > > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: Thomas Zimmermann > > > > drm-misc folks, ack to get this through drm-intel-next, where the original > > patch > > is? > > > > Thanks, > > Rodrigo > > > > > Cc: Mitul Golani > > > Cc: Ankit Nautiyal > > > Cc: Jani Nikula > > > Signed-off-by: Mitul Golani > > > > > --- > > > include/drm/display/drm_dp_helper.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/drm/display/drm_dp_helper.h > > > b/include/drm/display/drm_dp_helper.h > > > index baf9949ff96f..6799f57d635c 100644 > > > --- a/include/drm/display/drm_dp_helper.h > > > +++ b/include/drm/display/drm_dp_helper.h > > > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > > > * @target_rr: Target Refresh > > > * @duration_incr_ms: Successive frame duration increase > > > * @duration_decr_ms: Successive frame duration decrease > > > - * @operation_mode: Adaptive Sync Operation Mode > > > + * @mode: Adaptive Sync Operation Mode > > > */ > > > struct drm_dp_as_sdp { > > > unsigned char sdp_type; > > > -- > > > 2.25.1 > > >
RE: [PATCH] drm/dp: correct struct member name in documentation
> -Original Message- > From: Vivi, Rodrigo > Sent: Wednesday, April 10, 2024 9:49 PM > To: Golani, Mitulkumar Ajitkumar ; > tzimmerm...@suse.de; mrip...@kernel.org; > maarten.lankho...@linux.intel.com > Cc: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > Nautiyal, > Ankit K ; Nikula, Jani ; > s...@canb.auug.org.au > Subject: Re: [PATCH] drm/dp: correct struct member name in documentation > > On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > > Correct struct member name to 'mode' instead of 'operation mode' > > in 'drm_dp_as_sdp' structure description. > > > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > > Probably good to avoid this 'Fixes:' tag, and only use that for real code > bugs. Thank you for inputs.. I understood and I will take the future note. Please suggest if required to update the change with new revision or we can take care while merge.. ? > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > > drm-misc folks, ack to get this through drm-intel-next, where the original > patch > is? > > Thanks, > Rodrigo > > > Cc: Mitul Golani > > Cc: Ankit Nautiyal > > Cc: Jani Nikula > > Signed-off-by: Mitul Golani > > > --- > > include/drm/display/drm_dp_helper.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/drm/display/drm_dp_helper.h > > b/include/drm/display/drm_dp_helper.h > > index baf9949ff96f..6799f57d635c 100644 > > --- a/include/drm/display/drm_dp_helper.h > > +++ b/include/drm/display/drm_dp_helper.h > > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > > * @target_rr: Target Refresh > > * @duration_incr_ms: Successive frame duration increase > > * @duration_decr_ms: Successive frame duration decrease > > - * @operation_mode: Adaptive Sync Operation Mode > > + * @mode: Adaptive Sync Operation Mode > > */ > > struct drm_dp_as_sdp { > > unsigned char sdp_type; > > -- > > 2.25.1 > >
Re: [PATCH] drm/dp: correct struct member name in documentation
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Probably good to avoid this 'Fixes:' tag, and only use that for real code bugs. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann drm-misc folks, ack to get this through drm-intel-next, where the original patch is? Thanks, Rodrigo > Cc: Mitul Golani > Cc: Ankit Nautiyal > Cc: Jani Nikula > Signed-off-by: Mitul Golani > --- > include/drm/display/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/display/drm_dp_helper.h > b/include/drm/display/drm_dp_helper.h > index baf9949ff96f..6799f57d635c 100644 > --- a/include/drm/display/drm_dp_helper.h > +++ b/include/drm/display/drm_dp_helper.h > @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { > * @target_rr: Target Refresh > * @duration_incr_ms: Successive frame duration increase > * @duration_decr_ms: Successive frame duration decrease > - * @operation_mode: Adaptive Sync Operation Mode > + * @mode: Adaptive Sync Operation Mode > */ > struct drm_dp_as_sdp { > unsigned char sdp_type; > -- > 2.25.1 >
Re: [PATCH] drm/dp: correct struct member name in documentation
Hi Mitul, Thanks. On Fri, 5 Apr 2024 12:21:59 +0530 Mitul Golani wrote: > > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Reported-by: Stephen Rothwell > Cc: Mitul Golani > Cc: Ankit Nautiyal > Cc: Jani Nikula > Signed-off-by: Mitul Golani -- Cheers, Stephen Rothwell pgpNHUX2ouAYk.pgp Description: OpenPGP digital signature
Re: [PATCH] drm/dp: correct struct member name in documentation
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") > Cc: Mitul Golani > Cc: Ankit Nautiyal > Cc: Jani Nikula > Signed-off-by: Mitul Golani > --- > include/drm/display/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry
[PATCH] drm/dp: correct struct member name in documentation
Correct struct member name to 'mode' instead of 'operation mode' in 'drm_dp_as_sdp' structure description. Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Jani Nikula Signed-off-by: Mitul Golani --- include/drm/display/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index baf9949ff96f..6799f57d635c 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -112,7 +112,7 @@ struct drm_dp_vsc_sdp { * @target_rr: Target Refresh * @duration_incr_ms: Successive frame duration increase * @duration_decr_ms: Successive frame duration decrease - * @operation_mode: Adaptive Sync Operation Mode + * @mode: Adaptive Sync Operation Mode */ struct drm_dp_as_sdp { unsigned char sdp_type; -- 2.25.1