Re: [Interest] Contributing to Qt

[Igor Mironchik]

Thank you guys, I've got all necessary information now...


On 30.12.2017 13:53, Thiago Macieira wrote:

On Saturday, 30 December 2017 05:12:04 -02 Igor Mironchik wrote:

Great but now I have a question: how should I correctly push my changes?

Provide a working example please.

Hello Igor

Please see http://wiki.qt.io/Qt_Contribution_Guidelines. One of the first
links in that page is the set up for Gerrit, which will instruct you on
installing the commit hook that will create the Change-Id. Once both those
steps are done (you may need to recreate your commit with "git commit --
amend"), you'll be able to push to Gerrit.



___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt

[Thiago Macieira]

On Saturday, 30 December 2017 05:12:04 -02 Igor Mironchik wrote:
> Great but now I have a question: how should I correctly push my changes?
> 
> Provide a working example please.

Hello Igor

Please see http://wiki.qt.io/Qt_Contribution_Guidelines. One of the first 
links in that page is the set up for Gerrit, which will instruct you on 
installing the commit hook that will create the Change-Id. Once both those 
steps are done (you may need to recreate your commit with "git commit --
amend"), you'll be able to push to Gerrit.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt

[Michael Jabbour]

You need to push to remote "gerrit" to the branch
"refs/for//target-branch/", after running the init-repository script.

The whole process is documented in the Qt wiki:
https://wiki.qt.io/Qt_Contribution_Guidelines
Also, this talk by Thiago Macieira (
https://www.youtube.com/watch?v=bWuOQoY1J78 ) elaborates more on the topic.

On 30/12/2017 9:12 AM, Igor Mironchik wrote:
> Hello,
>
> I want to contribute a little to Qt.
>
> I cloned qtbase from git://code.qt.io/qt/qtbase.git
>
> Created branch with
>
> git branch test
>
> git checkout test
>
> made changes
>
> git commit -a
>
> Great but now I have a question: how should I correctly push my changes?
>
> Provide a working example please.
>
> Thank you.
>
> ___
> Interest mailing list
> Interest@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/interest

___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt

[Sze Howe Koh]

On 30 Dec. 2017 16:12, "Igor Mironchik"  wrote:

Hello,

I want to contribute a little to Qt.

I cloned qtbase from git://code.qt.io/qt/qtbase.git

Created branch with

git branch test

git checkout test

made changes

git commit -a

Great but now I have a question: how should I correctly push my changes?

Provide a working example please.

Thank you.


Hi Igor,

The short version is: You need to set up your Gerrit account, add Git
hooks, and and configure your local repository to use the Gerrit remote
repository. Push your commits to the remote repository.

The exact details are a bit long. To get started, read through
https://wiki.qt.io/Qt_Contribution_Guidelines and
https://wiki.qt.io/Setting_up_Gerrit

Note: If you use the "init-repository" Perl script from qt5.git, it will
automatically set up the Git hooks and the remote repo for all Qt 5 repos
(not just qtbase.git). If you don't use this script, you will need to
manually configure every repo.

Finally, since this thread is about contributing to Qt, let's continue this
discussion at developm...@qt-project.org (remove interest@qt-project.org
when you reply)


Regards,
Sze-Howe
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

[Interest] Contributing to Qt

[Igor Mironchik]

Hello,

I want to contribute a little to Qt.

I cloned qtbase from git://code.qt.io/qt/qtbase.git

Created branch with

git branch test

git checkout test

made changes

git commit -a

Great but now I have a question: how should I correctly push my changes?

Provide a working example please.

Thank you.

___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Jordi Pujol]

 Please start a new thread when you start a new topic ...
 
 But yes, +1
 Frank

Sorry, sorry, sorry.
I know, my mistake !

Jordi.

___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Konstantin Tokarev]

24.01.2013, 16:58, Jordi Pujol pisoengra...@gmail.com:
 Hi all,

 First of all, I'm not a native english speaker/writer so, my apologies
 if it seems I'm ranting ( I can state I'm not ). It's only something
 stumblin in my mind that I want to share with you.

 Today I've read an email in this list that links to this page :

 http://sprogram.com.ua/en/articles/qt-connect-to-oracle-as-sysdba

 This code seems to me a good candidate to add to Qt's Dabatase module. A
 simple and effective way to achieve its goal.

 Some time ago I did a similar request ( to merge some lines of code to
 enable SQLite extension load ) and only Thiago kindly answered me with
 another question. No other answer. :-(

 I'm having a huge workload and didn't have the time to contrib it to Qt
 5.1 ( I have another little contribution for widgets, even being OK,
 that could not be accepted in time for Qt 5.0, and I don't know if I
 have to resubmit it or it will be cherry-picked in a near future, but
 that's another war... ).

 I accept that my contribution are quite small, but a lot of little
 contributions make a bigger one ! And the initial gap to contribute
 makes many of us think twice before spending the time to push our
 changes to Qt project.

 I suspect that I'm not the only one in this situation : people that uses
 Qt and have good knowledge of it and with good ideas/modifications that
 can benefit all the project. And we want to contribute it !

 My question to the community is : it's worth the effort to contribute,
 if you're a little one like me ? I have serious doubts...

 I have to spend a lot of time to remember how the submit process goes.
 Yes, if you contribute once or twice in a year you forgot the
 not-so-simple commands for gerrit ;-)

 It's possible to, simplify that process ? I have no problem to sign a
 disclaimer like I wrote that code, but I give all the rights to i.e.
 digia/Kdab/write_here_your_company and then send my patches to
 someone in that company that evaluates them and pushes it to gerrit in
 behalf of me.

Let's consider imaginary situation when some party claims that Qt contains
copyrighted code, and points to code lines coming from your patches. Who
should be charged? Persons who submitted your patch, because git blame shows
them.


 I have No need for glory, I only want Qt become better and contribute
 with my 2 cents. It's possible to simply cede my code to someone that
 takes care of submit ?



-- 
Regards,
Konstantin
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Koehne Kai]

 -Original Message-
 From: interest-bounces+kai.koehne=digia@qt-project.org
 Subject: Re: [Interest] Contributing to Qt : when you're a spare contributor

 I have similar unpleasant impression. Recently I've reported a bug
 (https://bugreports.qt-project.org/browse/QTBUG-29217) which I find
 severe. If my observations are correct then QSqlTableModel is now in not so
 usable state. But there is still no attention to it.

Hi,

I'm sorry that you both had bad experiences with contributing. I can understand 
it can be quite depressing to get no or little feedback. As it happens you both 
have been trying to contribute to the Sql module, which unfortunately very few 
people have enough knowledge about to review stuff. According to

http://qt-project.org/wiki/Maintainers

Mark Brand has stepped up as the maintainer of the Qt SQL module, so it's not a 
bad idea to also contact him directly. I can't tell you though how responsive 
he is (I don't know him personally).

 While the issue is fixable quite easily (in fact, I've downloaded Qts sources
 and fixed it), but it is not an easy task to make it submitted to the master
 branch, considering all the specifics of contribution procedure of Qt, when
 you have no such experience. Soon, I will try to make it on my own, but in
 case of my failure, I think I will have to attach a patch and leave it off...

I understand that the effort needed to contribute your first patch - while 
nothing compared to the loops you had to hop through before open governance 
started - can be frustrating. Not everyone starts loving git from the start. 
Anyhow, there are legal strings attached, so we just can't accept patches 
coming in via e-mail or JIRA. Apart from this it's also just easier to discuss 
things in a standard manner on codereview. Most patches will require 
iterations, especially if they're coming from new people. What I hope though is 
that we as a  community are helpful and responsive if you've questions 
regarding the setup, or just want someone to 'walk you through' the steps 
necessary. I certainly appreciate anyone trying to contribute, be it only minor 
details, and will also help him if he's asking for help e.g. on IRC.

Regards

Kai
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Jordi Pujol]

  It's possible to, simplify that process ? I have no problem to sign a
  disclaimer like I wrote that code, but I give all the rights to i.e.
  digia/Kdab/write_here_your_company and then send my patches to
  someone in that company that evaluates them and pushes it to gerrit in
  behalf of me.
 
 Let's consider imaginary situation when some party claims that Qt contains
 copyrighted code, and points to code lines coming from your patches. Who
 should be charged? Persons who submitted your patch, because git blame shows
 them.

Sure. Note that I've said I sign a disclaimer saying I'VE wrote that
code...blah, blah. Blames to me ( a simple note on commit, and solved
). I'm not a lawyer, so perhaps I'm absolutely wrong, but we can always
find a simple solution for this case.

P.S. : I've just seen a Tools-Git-Gerrit... option in QtCreator. Is
that a try to integrate gerrit interaction with QtCreator ? It could be
a great solution to simple patches as ours...

Jordi.

___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Konrad Rosenbaum]

Hi,

On Thursday 24 January 2013 16:26:13 Дмитрий Волосных wrote:
 While the issue is fixable quite easily (in fact, I've downloaded Qts
 sources and fixed it), but it is not an easy task to make it submitted
 to the master branch, considering all the specifics of contribution
 procedure of Qt, when you have no such experience. Soon, I will try to
 make it on my own, but in case of my failure, I think I will have to
 attach a patch and leave it off...

Patches attached to bug reports cannot be accepted into Qt for legal reasons 
(something to do with the dual licensing, property rights and liability).

But becoming a contributor is really easy:
http://qt-project.org/wiki/Gerrit-Introduction

You just need GIT and a Gerrit account (you can create it yourself, you just 
have to accept the contributor agreement).


Konrad


signature.asc
Description: This is a digitally signed message part.
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Konstantin Tokarev]

24.01.2013, 21:34, Jordi Pujol pisoengra...@gmail.com:
  It's possible to, simplify that process ? I have no problem to sign a
  disclaimer like I wrote that code, but I give all the rights to i.e.
  digia/Kdab/write_here_your_company and then send my patches to
  someone in that company that evaluates them and pushes it to gerrit in
  behalf of me.
  Let's consider imaginary situation when some party claims that Qt contains
  copyrighted code, and points to code lines coming from your patches. Who
  should be charged? Persons who submitted your patch, because git blame shows
  them.

 Sure. Note that I've said I sign a disclaimer saying I'VE wrote that
 code...blah, blah. Blames to me ( a simple note on commit, and solved
 ). I'm not a lawyer, so perhaps I'm absolutely wrong, but we can always
 find a simple solution for this case.

 P.S. : I've just seen a Tools-Git-Gerrit... option in QtCreator. Is
 that a try to integrate gerrit interaction with QtCreator ? It could be
 a great solution to simple patches as ours...

There is some interaction built-in and it can certainly be extended, but I 
believe
that registration of user account doesn't belong there.

-- 
Regards,
Konstantin
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest

Re: [Interest] Contributing to Qt : when you're a spare contributor

[Thiago Macieira]

On quinta-feira, 24 de janeiro de 2013 18.34.15, Jordi Pujol wrote:
 Sure. Note that I've said I sign a disclaimer saying I'VE wrote that
 code...blah, blah. Blames to me ( a simple note on commit, and solved
 ). I'm not a lawyer, so perhaps I'm absolutely wrong, but we can always
 find a simple solution for this case.

We have such a thing. It's called the Qt Contribution License Agreement. In 
order to put any code of yours under the CLA for use in Qt, you have to push 
it into Gerrit.

Once it's in Gerrit, the contribution will have your name as author and will 
be recorded as such forever. Even if someone touches it up to fix a small issue 
or failing regression.

In other words, we cannot skip the submission to Gerrit. I know it's a bit to 
remember how to do it, but we have a wiki for that. If you need to submit 
twice a year, just open the wiki and keep it open next to your command-line 
while you do it.

[if you're behind a corporate firewall, it will be harder to push. But then 
again, maybe you shouldn't submit code that the corporation in question owns. 
If the corporation is agreeing to the submission, the IT people will help 
getting through the firewall]
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Interest mailing list
Interest@qt-project.org
http://lists.qt-project.org/mailman/listinfo/interest