[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750622#comment-15750622 ] ASF GitHub Bot commented on ARTEMIS-888: Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/917 fixed > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750123#comment-15750123 ] ASF GitHub Bot commented on ARTEMIS-888: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/917 @andytaylor there's a conflict now anyways after a merge I did for @jbertram .. can you fix it? > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750120#comment-15750120 ] ASF GitHub Bot commented on ARTEMIS-883: Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92531732 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -302,108 +301,91 @@ public void send(final ProducerInfo producerInfo, originalCoreMsg.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID.toString(), messageSend.getMessageId().toString()); } - Runnable runnable; - - if (sendProducerAck) { - runnable = new Runnable() { -@Override -public void run() { - try { - ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), messageSend.getSize()); - connection.dispatchSync(ack); - } catch (Exception e) { - ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e); - connection.sendException(e); - } - -} - }; - } else { - final Connection transportConnection = connection.getTransportConnection(); - - if (transportConnection == null) { -// I don't think this could happen, but just in case, avoiding races -runnable = null; - } else { -runnable = new Runnable() { - @Override - public void run() { - transportConnection.setAutoRead(true); - } -}; - } - } - - internalSend(actualDestinations, originalCoreMsg, runnable); - } + boolean shouldBlockProducer = producerInfo.getWindowSize() > 0 || messageSend.isResponseRequired(); - private void internalSend(ActiveMQDestination[] actualDestinations, - ServerMessage originalCoreMsg, - final Runnable onComplete) throws Exception { + final AtomicInteger count = new AtomicInteger(actualDestinations.length); - Runnable runToUse; + final Exception[] anyException = new Exception[] {null}; - if (actualDestinations.length <= 1 || onComplete == null) { - // if onComplete is null, this will be null ;) - runToUse = onComplete; - } else { - final AtomicInteger count = new AtomicInteger(actualDestinations.length); - runToUse = new Runnable() { -@Override -public void run() { - if (count.decrementAndGet() == 0) { - onComplete.run(); - } -} - }; + if (shouldBlockProducer) { + connection.getContext().setDontSendReponse(true); } - SimpleString[] addresses = new SimpleString[actualDestinations.length]; - PagingStore[] pagingStores = new PagingStore[actualDestinations.length]; - - // We fillup addresses, pagingStores and we will throw failure if that's the case for (int i = 0; i < actualDestinations.length; i++) { ActiveMQDestination dest = actualDestinations[i]; - addresses[i] = new SimpleString(dest.getPhysicalName()); - pagingStores[i] = server.getPagingManager().getPageStore(addresses[i]); - if (pagingStores[i].getAddressFullMessagePolicy() == AddressFullMessagePolicy.FAIL && pagingStores[i].isFull()) { -throw new ResourceAllocationException("Queue is full"); - } - } - - for (int i = 0; i < actualDestinations.length; i++) { + SimpleString address = new SimpleString(dest.getPhysicalName()); + PagingStore store = server.getPagingManager().getPageStore(address); ServerMessage coreMsg = originalCoreMsg.copy(); + coreMsg.setAddress(address); - coreMsg.setAddress(addresses[i]); - - PagingStore store = pagingStores[i]; - - if (store.isFull()) { -connection.getTransportConnection().setAutoRead(false); - } + if (shouldBlockProducer) { - if (actualDestinations[i].isQueue()) { -checkAutoCreateQueue(new SimpleString(actualDestinations[i].getPhysicalName()), actualDestinations[i].isTemporary()); - } +if (!store.checkMemory(() -> { + try { + Rout
[jira] [Commented] (ARTEMIS-789) Update Tests
[ https://issues.apache.org/jira/browse/ARTEMIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750115#comment-15750115 ] ASF subversion and git services commented on ARTEMIS-789: - Commit 4424117d6534d452f9a883c428e1f5d911979724 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4424117 ] ARTEMIS-789 fix AMQP SendingAndReceivingTest > Update Tests > > > Key: ARTEMIS-789 > URL: https://issues.apache.org/jira/browse/ARTEMIS-789 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Martyn Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-789) Update Tests
[ https://issues.apache.org/jira/browse/ARTEMIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750113#comment-15750113 ] ASF subversion and git services commented on ARTEMIS-789: - Commit 3af1e5c734df3ac4d19b5e173f55a2a99fa33e8d in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3af1e5c ] ARTEMIS-789 AMQP tests for routing semantics > Update Tests > > > Key: ARTEMIS-789 > URL: https://issues.apache.org/jira/browse/ARTEMIS-789 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Martyn Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-880) Support address prefixing
[ https://issues.apache.org/jira/browse/ARTEMIS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750114#comment-15750114 ] ASF subversion and git services commented on ARTEMIS-880: - Commit 29edd44d244f22423562630771608e20e22a9aa4 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=29edd44 ] ARTEMIS-880 expand prefix support to consumers > Support address prefixing > - > > Key: ARTEMIS-880 > URL: https://issues.apache.org/jira/browse/ARTEMIS-880 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Justin Bertram >Assignee: Justin Bertram > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-789) Update Tests
[ https://issues.apache.org/jira/browse/ARTEMIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750116#comment-15750116 ] ASF subversion and git services commented on ARTEMIS-789: - Commit 10a32481fd277f033dce666ccf4d142164fdbee2 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=10a3248 ] ARTEMIS-789 fix ArtemisTest > Update Tests > > > Key: ARTEMIS-789 > URL: https://issues.apache.org/jira/browse/ARTEMIS-789 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Martyn Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749989#comment-15749989 ] ASF GitHub Bot commented on ARTEMIS-883: Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92525337 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -302,108 +301,91 @@ public void send(final ProducerInfo producerInfo, originalCoreMsg.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID.toString(), messageSend.getMessageId().toString()); } - Runnable runnable; - - if (sendProducerAck) { - runnable = new Runnable() { -@Override -public void run() { - try { - ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), messageSend.getSize()); - connection.dispatchSync(ack); - } catch (Exception e) { - ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e); - connection.sendException(e); - } - -} - }; - } else { - final Connection transportConnection = connection.getTransportConnection(); - - if (transportConnection == null) { -// I don't think this could happen, but just in case, avoiding races -runnable = null; - } else { -runnable = new Runnable() { - @Override - public void run() { - transportConnection.setAutoRead(true); - } -}; - } - } - - internalSend(actualDestinations, originalCoreMsg, runnable); - } + boolean shouldBlockProducer = producerInfo.getWindowSize() > 0 || messageSend.isResponseRequired(); - private void internalSend(ActiveMQDestination[] actualDestinations, - ServerMessage originalCoreMsg, - final Runnable onComplete) throws Exception { + final AtomicInteger count = new AtomicInteger(actualDestinations.length); - Runnable runToUse; + final Exception[] anyException = new Exception[] {null}; - if (actualDestinations.length <= 1 || onComplete == null) { - // if onComplete is null, this will be null ;) - runToUse = onComplete; - } else { - final AtomicInteger count = new AtomicInteger(actualDestinations.length); - runToUse = new Runnable() { -@Override -public void run() { - if (count.decrementAndGet() == 0) { - onComplete.run(); - } -} - }; + if (shouldBlockProducer) { + connection.getContext().setDontSendReponse(true); } - SimpleString[] addresses = new SimpleString[actualDestinations.length]; - PagingStore[] pagingStores = new PagingStore[actualDestinations.length]; - - // We fillup addresses, pagingStores and we will throw failure if that's the case for (int i = 0; i < actualDestinations.length; i++) { ActiveMQDestination dest = actualDestinations[i]; - addresses[i] = new SimpleString(dest.getPhysicalName()); - pagingStores[i] = server.getPagingManager().getPageStore(addresses[i]); - if (pagingStores[i].getAddressFullMessagePolicy() == AddressFullMessagePolicy.FAIL && pagingStores[i].isFull()) { -throw new ResourceAllocationException("Queue is full"); - } - } - - for (int i = 0; i < actualDestinations.length; i++) { + SimpleString address = new SimpleString(dest.getPhysicalName()); + PagingStore store = server.getPagingManager().getPageStore(address); ServerMessage coreMsg = originalCoreMsg.copy(); + coreMsg.setAddress(address); - coreMsg.setAddress(addresses[i]); - - PagingStore store = pagingStores[i]; - - if (store.isFull()) { -connection.getTransportConnection().setAutoRead(false); - } + if (shouldBlockProducer) { - if (actualDestinations[i].isQueue()) { -checkAutoCreateQueue(new SimpleString(actualDestinations[i].getPhysicalName()), actualDestinations[i].isTemporary()); - } +if (!store.checkMemory(() -> { + try { + RoutingSt
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749978#comment-15749978 ] ASF GitHub Bot commented on ARTEMIS-883: Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92524664 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -302,108 +301,91 @@ public void send(final ProducerInfo producerInfo, originalCoreMsg.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID.toString(), messageSend.getMessageId().toString()); } - Runnable runnable; - - if (sendProducerAck) { - runnable = new Runnable() { -@Override -public void run() { - try { - ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), messageSend.getSize()); - connection.dispatchSync(ack); - } catch (Exception e) { - ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e); - connection.sendException(e); - } - -} - }; - } else { - final Connection transportConnection = connection.getTransportConnection(); - - if (transportConnection == null) { -// I don't think this could happen, but just in case, avoiding races -runnable = null; - } else { -runnable = new Runnable() { - @Override - public void run() { - transportConnection.setAutoRead(true); - } -}; - } - } - - internalSend(actualDestinations, originalCoreMsg, runnable); - } + boolean shouldBlockProducer = producerInfo.getWindowSize() > 0 || messageSend.isResponseRequired(); - private void internalSend(ActiveMQDestination[] actualDestinations, - ServerMessage originalCoreMsg, - final Runnable onComplete) throws Exception { + final AtomicInteger count = new AtomicInteger(actualDestinations.length); - Runnable runToUse; + final Exception[] anyException = new Exception[] {null}; - if (actualDestinations.length <= 1 || onComplete == null) { - // if onComplete is null, this will be null ;) - runToUse = onComplete; - } else { - final AtomicInteger count = new AtomicInteger(actualDestinations.length); - runToUse = new Runnable() { -@Override -public void run() { - if (count.decrementAndGet() == 0) { - onComplete.run(); - } -} - }; + if (shouldBlockProducer) { + connection.getContext().setDontSendReponse(true); } - SimpleString[] addresses = new SimpleString[actualDestinations.length]; - PagingStore[] pagingStores = new PagingStore[actualDestinations.length]; - - // We fillup addresses, pagingStores and we will throw failure if that's the case for (int i = 0; i < actualDestinations.length; i++) { ActiveMQDestination dest = actualDestinations[i]; - addresses[i] = new SimpleString(dest.getPhysicalName()); - pagingStores[i] = server.getPagingManager().getPageStore(addresses[i]); - if (pagingStores[i].getAddressFullMessagePolicy() == AddressFullMessagePolicy.FAIL && pagingStores[i].isFull()) { -throw new ResourceAllocationException("Queue is full"); - } - } - - for (int i = 0; i < actualDestinations.length; i++) { + SimpleString address = new SimpleString(dest.getPhysicalName()); + PagingStore store = server.getPagingManager().getPageStore(address); ServerMessage coreMsg = originalCoreMsg.copy(); + coreMsg.setAddress(address); - coreMsg.setAddress(addresses[i]); - - PagingStore store = pagingStores[i]; - - if (store.isFull()) { -connection.getTransportConnection().setAutoRead(false); - } + if (shouldBlockProducer) { - if (actualDestinations[i].isQueue()) { -checkAutoCreateQueue(new SimpleString(actualDestinations[i].getPhysicalName()), actualDestinations[i].isTemporary()); - } +if (!store.checkMemory(() -> { + try { + RoutingSt
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749672#comment-15749672 ] ASF GitHub Bot commented on ARTEMIS-888: Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/917 This change seems to better address the underlying issue that was to be fixed, it does ignore the other fields in the Header which could be an issue if anyone were to apply the same types of checks for those being exactly preserved as opposed to their defaults being assumed. > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6514) Property placeholders do not work in blueprint activemq config
[ https://issues.apache.org/jira/browse/AMQ-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749641#comment-15749641 ] ASF GitHub Bot commented on AMQ-6514: - Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/218 > Property placeholders do not work in blueprint activemq config > -- > > Key: AMQ-6514 > URL: https://issues.apache.org/jira/browse/AMQ-6514 > Project: ActiveMQ > Issue Type: Bug > Components: OSGi/Karaf >Affects Versions: 5.14.1 > Environment: OSGi, blueprint >Reporter: Christian Schneider > Fix For: 5.15.0, 5.14.2 > > > User properties as a placeholder do not work in the blueprint activemq config. > memoryLimit="$example{perTopicMemoryLimit}"> > Java.lang.IllegalArgumentException: Could convert not to a memory size: > $example > {perTopicMemoryLimit} > at > org.apache.activemq.util.MemoryPropertyEditor.setAsText(MemoryPropertyEditor.java:63)[97:org.apache.activemq.activemq-osgi:5.10.0] > See http://apaste.info/nSw3h > This seems to be caused by an error in xbean-blueprint 3.x. Upgrading to 4.2 > fixes the issue. I will create a PR for the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6514) Property placeholders do not work in blueprint activemq config
[ https://issues.apache.org/jira/browse/AMQ-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749637#comment-15749637 ] ASF subversion and git services commented on AMQ-6514: -- Commit bee0904b843129992b9dcbc035aa08f970728750 in activemq's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=bee0904 ] [AMQ-6514] Adding test for activemq blueprint setup and xbean problem > Property placeholders do not work in blueprint activemq config > -- > > Key: AMQ-6514 > URL: https://issues.apache.org/jira/browse/AMQ-6514 > Project: ActiveMQ > Issue Type: Bug > Components: OSGi/Karaf >Affects Versions: 5.14.1 > Environment: OSGi, blueprint >Reporter: Christian Schneider > Fix For: 5.15.0, 5.14.2 > > > User properties as a placeholder do not work in the blueprint activemq config. > memoryLimit="$example{perTopicMemoryLimit}"> > Java.lang.IllegalArgumentException: Could convert not to a memory size: > $example > {perTopicMemoryLimit} > at > org.apache.activemq.util.MemoryPropertyEditor.setAsText(MemoryPropertyEditor.java:63)[97:org.apache.activemq.activemq-osgi:5.10.0] > See http://apaste.info/nSw3h > This seems to be caused by an error in xbean-blueprint 3.x. Upgrading to 4.2 > fixes the issue. I will create a PR for the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749311#comment-15749311 ] ASF GitHub Bot commented on ARTEMIS-888: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/917 @tabish121 can you take a look? > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
[ https://issues.apache.org/jira/browse/ARTEMIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749268#comment-15749268 ] ASF subversion and git services commented on ARTEMIS-890: - Commit 332338d018dbb7a491a669e0b749ea20fd157b7a in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=332338d ] ARTEMIS-890 Improving Paging consistencies with broker.persistent = false. Block, Page and Drop will now work under non persistent > Dropped Messages, Paging and Block are ignored when broker is non persistent > > > Key: ARTEMIS-890 > URL: https://issues.apache.org/jira/browse/ARTEMIS-890 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: clebert suconic >Assignee: clebert suconic > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
[ https://issues.apache.org/jira/browse/ARTEMIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic closed ARTEMIS-890. --- Resolution: Fixed > Dropped Messages, Paging and Block are ignored when broker is non persistent > > > Key: ARTEMIS-890 > URL: https://issues.apache.org/jira/browse/ARTEMIS-890 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: clebert suconic >Assignee: clebert suconic > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
[ https://issues.apache.org/jira/browse/ARTEMIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749271#comment-15749271 ] ASF subversion and git services commented on ARTEMIS-890: - Commit 99a62f75f28c7e7efe325edd7db257bc3f220f96 in activemq-artemis's branch refs/heads/1.x from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=99a62f7 ] ARTEMIS-890 Improving Paging consistencies with broker.persistent = false. Block, Page and Drop will now work under non persistent (cherry picked from commit 332338d018dbb7a491a669e0b749ea20fd157b7a) > Dropped Messages, Paging and Block are ignored when broker is non persistent > > > Key: ARTEMIS-890 > URL: https://issues.apache.org/jira/browse/ARTEMIS-890 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: clebert suconic >Assignee: clebert suconic > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
[ https://issues.apache.org/jira/browse/ARTEMIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749269#comment-15749269 ] ASF GitHub Bot commented on ARTEMIS-890: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/918 > Dropped Messages, Paging and Block are ignored when broker is non persistent > > > Key: ARTEMIS-890 > URL: https://issues.apache.org/jira/browse/ARTEMIS-890 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: clebert suconic >Assignee: clebert suconic > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749246#comment-15749246 ] ASF subversion and git services commented on ARTEMIS-891: - Commit af443d70526989b3f3c759b0aaa9c44b33e69874 in activemq-artemis's branch refs/heads/1.x from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=af443d7 ] ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 (cherry picked from commit 881615e6464c4779917e275c2e9635442ccd77f4) > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic closed ARTEMIS-891. --- Resolution: Fixed > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749243#comment-15749243 ] ASF GitHub Bot commented on ARTEMIS-891: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/919 > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749245#comment-15749245 ] ASF subversion and git services commented on ARTEMIS-891: - Commit af443d70526989b3f3c759b0aaa9c44b33e69874 in activemq-artemis's branch refs/heads/1.x from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=af443d7 ] ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 (cherry picked from commit 881615e6464c4779917e275c2e9635442ccd77f4) > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749239#comment-15749239 ] ASF subversion and git services commented on ARTEMIS-891: - Commit 881615e6464c4779917e275c2e9635442ccd77f4 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=881615e ] ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749238#comment-15749238 ] ASF subversion and git services commented on ARTEMIS-891: - Commit 881615e6464c4779917e275c2e9635442ccd77f4 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=881615e ] ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749225#comment-15749225 ] Timothy Bish commented on ARTEMIS-891: -- Looks like you might want to add a bit more here as I believe Artemis now supports shared subscriptions over AQMP given that it is advertising the "SHARED-SUBS" capability on the Connection open frame. In the same way this patch adds the delayed delivery capability to the link if asked for in the desired capabilities the broker should also inspect the desired capabilities for a broker side sender open and respond with the shared subs capability. Something along the lines of this in ProtonServerSenderContext: {code} Symbol[] remoteDesiredCapabilities = sender.getRemoteDesiredCapabilities(); if (remoteDesiredCapabilities != null) { List list = Arrays.asList(remoteDesiredCapabilities); if (list.contains(AmqpSupport.SHARED_SUBS)) { sender.setOfferedCapabilities(new Symbol[] {AmqpSupport.SHARED_SUBS}); } } {code} > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic updated ARTEMIS-891: Fix Version/s: 2.0.0 1.5.next > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-891) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/ARTEMIS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749055#comment-15749055 ] ASF GitHub Bot commented on ARTEMIS-891: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/919 ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis proton0.16 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/919.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #919 commit 881615e6464c4779917e275c2e9635442ccd77f4 Author: Andy Taylor Date: 2016-12-14T18:11:09Z ARTEMIS-891 - upgrade proton to 0.16 https://issues.apache.org/jira/browse/ARTEMIS-891 > upgrade proton to 0.16 > -- > > Key: ARTEMIS-891 > URL: https://issues.apache.org/jira/browse/ARTEMIS-891 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6468) Fix JSTL tags in the WebConsole
[ https://issues.apache.org/jira/browse/AMQ-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kulp updated AMQ-6468: - Fix Version/s: 5.13.5 > Fix JSTL tags in the WebConsole > --- > > Key: AMQ-6468 > URL: https://issues.apache.org/jira/browse/AMQ-6468 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.14.1 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > Fix For: 5.13.5, 5.15.0, 5.14.2 > > > Some more places in the WebConsole do not use the correct JSTL tags to print > out content and should be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6529) CachedLDAPAuthorizationMap may be queried prior to loading ACL's
[ https://issues.apache.org/jira/browse/AMQ-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Kulp updated AMQ-6529: - Fix Version/s: 5.13.5 > CachedLDAPAuthorizationMap may be queried prior to loading ACL's > > > Key: AMQ-6529 > URL: https://issues.apache.org/jira/browse/AMQ-6529 > Project: ActiveMQ > Issue Type: Bug > Components: security >Affects Versions: 5.14.1 >Reporter: Daniel Kulp >Assignee: Daniel Kulp > Fix For: 5.13.5, 5.14.3 > > > When not using spring, nothing calls the query method (or afterPropertiesSet > method) until the first update call which could occur several seconds or > longer after startup. Thus, early calls to check ACL's could cause denials > for requests that shouldn't be denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6468) Fix JSTL tags in the WebConsole
[ https://issues.apache.org/jira/browse/AMQ-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749024#comment-15749024 ] ASF subversion and git services commented on AMQ-6468: -- Commit e16ed242b2319523608f6ff7e572668b36e6c813 in activemq's branch refs/heads/activemq-5.13.x from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e16ed24 ] https://issues.apache.org/jira/browse/AMQ-6468 Fixing JSTL tags in JSP pages (cherry picked from commit c1157fe1f007ee2344a7f0badefa0794c98817cd) > Fix JSTL tags in the WebConsole > --- > > Key: AMQ-6468 > URL: https://issues.apache.org/jira/browse/AMQ-6468 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.14.1 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > Fix For: 5.15.0, 5.14.2 > > > Some more places in the WebConsole do not use the correct JSTL tags to print > out content and should be fixed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6529) CachedLDAPAuthorizationMap may be queried prior to loading ACL's
[ https://issues.apache.org/jira/browse/AMQ-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749025#comment-15749025 ] ASF subversion and git services commented on AMQ-6529: -- Commit f83bfef6e3252071184e2d3d80a33c294f012e2b in activemq's branch refs/heads/activemq-5.13.x from [~dkulp] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=f83bfef ] [AMQ-6529] Make sure the LDAP ACL's are definitely loaded when needed. > CachedLDAPAuthorizationMap may be queried prior to loading ACL's > > > Key: AMQ-6529 > URL: https://issues.apache.org/jira/browse/AMQ-6529 > Project: ActiveMQ > Issue Type: Bug > Components: security >Affects Versions: 5.14.1 >Reporter: Daniel Kulp >Assignee: Daniel Kulp > Fix For: 5.14.3 > > > When not using spring, nothing calls the query method (or afterPropertiesSet > method) until the first update call which could occur several seconds or > longer after startup. Thus, early calls to check ACL's could cause denials > for requests that shouldn't be denied. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-891) upgrade proton to 0.16
Andy Taylor created ARTEMIS-891: --- Summary: upgrade proton to 0.16 Key: ARTEMIS-891 URL: https://issues.apache.org/jira/browse/ARTEMIS-891 Project: ActiveMQ Artemis Issue Type: Task Reporter: Andy Taylor Assignee: Andy Taylor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (AMQ-6541) upgrade proton to 0.16
[ https://issues.apache.org/jira/browse/AMQ-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Taylor closed AMQ-6541. Resolution: Invalid > upgrade proton to 0.16 > -- > > Key: AMQ-6541 > URL: https://issues.apache.org/jira/browse/AMQ-6541 > Project: ActiveMQ > Issue Type: Task >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-6541) upgrade proton to 0.16
Andy Taylor created AMQ-6541: Summary: upgrade proton to 0.16 Key: AMQ-6541 URL: https://issues.apache.org/jira/browse/AMQ-6541 Project: ActiveMQ Issue Type: Task Reporter: Andy Taylor Assignee: Andy Taylor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
[ https://issues.apache.org/jira/browse/ARTEMIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748868#comment-15748868 ] ASF GitHub Bot commented on ARTEMIS-890: GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/918 ARTEMIS-890 Improving Paging consistencies with broker.persistent = f… …alse. Block, Page and Drop will now work under non persistent You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis artemis-890 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/918.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #918 commit 1ea8fa6b8074ac1cc4c6c3a344b530458e3f9c19 Author: Clebert Suconic Date: 2016-12-14T17:01:16Z ARTEMIS-890 Improving Paging consistencies with broker.persistent = false. Block, Page and Drop will now work under non persistent > Dropped Messages, Paging and Block are ignored when broker is non persistent > > > Key: ARTEMIS-890 > URL: https://issues.apache.org/jira/browse/ARTEMIS-890 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: clebert suconic >Assignee: clebert suconic > Fix For: 1.5.next, 2.0.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-890) Dropped Messages, Paging and Block are ignored when broker is non persistent
clebert suconic created ARTEMIS-890: --- Summary: Dropped Messages, Paging and Block are ignored when broker is non persistent Key: ARTEMIS-890 URL: https://issues.apache.org/jira/browse/ARTEMIS-890 Project: ActiveMQ Artemis Issue Type: Improvement Affects Versions: 1.5.1 Reporter: clebert suconic Assignee: clebert suconic Fix For: 1.5.next, 2.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (AMQ-6540) ActiveMQ and java version "1.6.0_45" 64 bit
[ https://issues.apache.org/jira/browse/AMQ-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish closed AMQ-6540. - Resolution: Invalid This is a question best directed to the users mailing list. > ActiveMQ and java version "1.6.0_45" 64 bit > --- > > Key: AMQ-6540 > URL: https://issues.apache.org/jira/browse/AMQ-6540 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.8.0 > Environment: Windows 8 >Reporter: Jerry Worth >Priority: Critical > > SamtecInc. has changed from java 32bit to java 64bit. We are running > apache-activemq-5.8.0. Active MQ will no longer start from windows service or > command line. what can be done to correct the problem? do I need to upgrade.. > uninstall and reinstall? Running on Windows 8 server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6540) ActiveMQ and java version "1.6.0_45" 64 bit
[ https://issues.apache.org/jira/browse/AMQ-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry Worth updated AMQ-6540: - Description: SamtecInc. has changed from java 32bit to java 64bit. We are running apache-activemq-5.8.0. Active MQ will no longer start from windows service or command line. what can be done to correct the problem? do I need to upgrade.. uninstall and reinstall? Running on Windows 8 server. (was: SamtecInc. has changed from java 32bit to java 64bit and we are running apache-activemq-5.8.0. Active MQ will no longer start from windows service of command line. what can be done to correct the problem? do I need to upgrade.. uninstall and reinstall? Running on Windows 8 server.) > ActiveMQ and java version "1.6.0_45" 64 bit > --- > > Key: AMQ-6540 > URL: https://issues.apache.org/jira/browse/AMQ-6540 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.8.0 > Environment: Windows 8 >Reporter: Jerry Worth >Priority: Critical > > SamtecInc. has changed from java 32bit to java 64bit. We are running > apache-activemq-5.8.0. Active MQ will no longer start from windows service or > command line. what can be done to correct the problem? do I need to upgrade.. > uninstall and reinstall? Running on Windows 8 server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748825#comment-15748825 ] ASF GitHub Bot commented on ARTEMIS-888: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/917 ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/917.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #917 commit 20e10595d55756c520746082139323129e606a6c Author: Andy Taylor Date: 2016-12-14T16:09:36Z ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-6540) ActiveMQ and java version "1.6.0_45" 64 bit
Jerry Worth created AMQ-6540: Summary: ActiveMQ and java version "1.6.0_45" 64 bit Key: AMQ-6540 URL: https://issues.apache.org/jira/browse/AMQ-6540 Project: ActiveMQ Issue Type: Bug Affects Versions: 5.8.0 Environment: Windows 8 Reporter: Jerry Worth Priority: Critical SamtecInc. has changed from java 32bit to java 64bit and we are running apache-activemq-5.8.0. Active MQ will no longer start from windows service of command line. what can be done to correct the problem? do I need to upgrade.. uninstall and reinstall? Running on Windows 8 server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6514) Property placeholders do not work in blueprint activemq config
[ https://issues.apache.org/jira/browse/AMQ-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748805#comment-15748805 ] ASF GitHub Bot commented on AMQ-6514: - GitHub user cschneider opened a pull request: https://github.com/apache/activemq/pull/218 [AMQ-6514] Adding test for activemq blueprint setup and xbean problem This pull request adds a test to create a broker using a blueprint.xml file. This test also covers the xbean problem of the above issue as it uses a config attribute in a bean. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cschneider/activemq AMQ-6514 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #218 commit bee0904b843129992b9dcbc035aa08f970728750 Author: Christian Schneider Date: 2016-12-14T16:18:20Z [AMQ-6514] Adding test for activemq blueprint setup and xbean problem > Property placeholders do not work in blueprint activemq config > -- > > Key: AMQ-6514 > URL: https://issues.apache.org/jira/browse/AMQ-6514 > Project: ActiveMQ > Issue Type: Bug > Components: OSGi/Karaf >Affects Versions: 5.14.1 > Environment: OSGi, blueprint >Reporter: Christian Schneider > Fix For: 5.15.0, 5.14.2 > > > User properties as a placeholder do not work in the blueprint activemq config. > memoryLimit="$example{perTopicMemoryLimit}"> > Java.lang.IllegalArgumentException: Could convert not to a memory size: > $example > {perTopicMemoryLimit} > at > org.apache.activemq.util.MemoryPropertyEditor.setAsText(MemoryPropertyEditor.java:63)[97:org.apache.activemq.activemq-osgi:5.10.0] > See http://apaste.info/nSw3h > This seems to be caused by an error in xbean-blueprint 3.x. Upgrading to 4.2 > fixes the issue. I will create a PR for the change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748775#comment-15748775 ] ASF GitHub Bot commented on ARTEMIS-883: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/907 Summary for the situation of this PR: This PR is about fixing blocking client producers in OpenWire... The implementation is currently using setAutoRead, and there is a test failing Howard was trying to fix it. The PR here is blocking a thread for non persistent, which I -1000 about it. This should really either setAutoRead (false) from Netty, or stop sending confirmation back to clients.. Also there's an issue that I see that if a producer is blocked for a long time connections will drop for TTL. So there should be some check for pending requests and ignore TTL checks on that case. > Fix OpenWire ProducerFlowControlTest Regression > --- > > Key: ARTEMIS-883 > URL: https://issues.apache.org/jira/browse/ARTEMIS-883 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: OpenWire >Affects Versions: 1.5.1 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 1.5.next > > > ProducerFlowControlTest fails due to regression -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748765#comment-15748765 ] ASF GitHub Bot commented on ARTEMIS-883: Github user gtully commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92431065 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -302,108 +301,91 @@ public void send(final ProducerInfo producerInfo, originalCoreMsg.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID.toString(), messageSend.getMessageId().toString()); } - Runnable runnable; - - if (sendProducerAck) { - runnable = new Runnable() { -@Override -public void run() { - try { - ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), messageSend.getSize()); - connection.dispatchSync(ack); - } catch (Exception e) { - ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e); - connection.sendException(e); - } - -} - }; - } else { - final Connection transportConnection = connection.getTransportConnection(); - - if (transportConnection == null) { -// I don't think this could happen, but just in case, avoiding races -runnable = null; - } else { -runnable = new Runnable() { - @Override - public void run() { - transportConnection.setAutoRead(true); - } -}; - } - } - - internalSend(actualDestinations, originalCoreMsg, runnable); - } + boolean shouldBlockProducer = producerInfo.getWindowSize() > 0 || messageSend.isResponseRequired(); - private void internalSend(ActiveMQDestination[] actualDestinations, - ServerMessage originalCoreMsg, - final Runnable onComplete) throws Exception { + final AtomicInteger count = new AtomicInteger(actualDestinations.length); - Runnable runToUse; + final Exception[] anyException = new Exception[] {null}; - if (actualDestinations.length <= 1 || onComplete == null) { - // if onComplete is null, this will be null ;) - runToUse = onComplete; - } else { - final AtomicInteger count = new AtomicInteger(actualDestinations.length); - runToUse = new Runnable() { -@Override -public void run() { - if (count.decrementAndGet() == 0) { - onComplete.run(); - } -} - }; + if (shouldBlockProducer) { + connection.getContext().setDontSendReponse(true); } - SimpleString[] addresses = new SimpleString[actualDestinations.length]; - PagingStore[] pagingStores = new PagingStore[actualDestinations.length]; - - // We fillup addresses, pagingStores and we will throw failure if that's the case for (int i = 0; i < actualDestinations.length; i++) { ActiveMQDestination dest = actualDestinations[i]; - addresses[i] = new SimpleString(dest.getPhysicalName()); - pagingStores[i] = server.getPagingManager().getPageStore(addresses[i]); - if (pagingStores[i].getAddressFullMessagePolicy() == AddressFullMessagePolicy.FAIL && pagingStores[i].isFull()) { -throw new ResourceAllocationException("Queue is full"); - } - } - - for (int i = 0; i < actualDestinations.length; i++) { + SimpleString address = new SimpleString(dest.getPhysicalName()); + PagingStore store = server.getPagingManager().getPageStore(address); ServerMessage coreMsg = originalCoreMsg.copy(); + coreMsg.setAddress(address); - coreMsg.setAddress(addresses[i]); - - PagingStore store = pagingStores[i]; - - if (store.isFull()) { -connection.getTransportConnection().setAutoRead(false); - } + if (shouldBlockProducer) { - if (actualDestinations[i].isQueue()) { -checkAutoCreateQueue(new SimpleString(actualDestinations[i].getPhysicalName()), actualDestinations[i].isTemporary()); - } +if (!store.checkMemory(() -> { + try { + RoutingStatu
[jira] [Commented] (ARTEMIS-883) Fix OpenWire ProducerFlowControlTest Regression
[ https://issues.apache.org/jira/browse/ARTEMIS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748717#comment-15748717 ] ASF GitHub Bot commented on ARTEMIS-883: Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/907#discussion_r92425813 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java --- @@ -302,108 +301,91 @@ public void send(final ProducerInfo producerInfo, originalCoreMsg.putStringProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID.toString(), messageSend.getMessageId().toString()); } - Runnable runnable; - - if (sendProducerAck) { - runnable = new Runnable() { -@Override -public void run() { - try { - ProducerAck ack = new ProducerAck(producerInfo.getProducerId(), messageSend.getSize()); - connection.dispatchSync(ack); - } catch (Exception e) { - ActiveMQServerLogger.LOGGER.warn(e.getMessage(), e); - connection.sendException(e); - } - -} - }; - } else { - final Connection transportConnection = connection.getTransportConnection(); - - if (transportConnection == null) { -// I don't think this could happen, but just in case, avoiding races -runnable = null; - } else { -runnable = new Runnable() { - @Override - public void run() { - transportConnection.setAutoRead(true); - } -}; - } - } - - internalSend(actualDestinations, originalCoreMsg, runnable); - } + boolean shouldBlockProducer = producerInfo.getWindowSize() > 0 || messageSend.isResponseRequired(); - private void internalSend(ActiveMQDestination[] actualDestinations, - ServerMessage originalCoreMsg, - final Runnable onComplete) throws Exception { + final AtomicInteger count = new AtomicInteger(actualDestinations.length); - Runnable runToUse; + final Exception[] anyException = new Exception[] {null}; - if (actualDestinations.length <= 1 || onComplete == null) { - // if onComplete is null, this will be null ;) - runToUse = onComplete; - } else { - final AtomicInteger count = new AtomicInteger(actualDestinations.length); - runToUse = new Runnable() { -@Override -public void run() { - if (count.decrementAndGet() == 0) { - onComplete.run(); - } -} - }; + if (shouldBlockProducer) { + connection.getContext().setDontSendReponse(true); } - SimpleString[] addresses = new SimpleString[actualDestinations.length]; - PagingStore[] pagingStores = new PagingStore[actualDestinations.length]; - - // We fillup addresses, pagingStores and we will throw failure if that's the case for (int i = 0; i < actualDestinations.length; i++) { ActiveMQDestination dest = actualDestinations[i]; - addresses[i] = new SimpleString(dest.getPhysicalName()); - pagingStores[i] = server.getPagingManager().getPageStore(addresses[i]); - if (pagingStores[i].getAddressFullMessagePolicy() == AddressFullMessagePolicy.FAIL && pagingStores[i].isFull()) { -throw new ResourceAllocationException("Queue is full"); - } - } - - for (int i = 0; i < actualDestinations.length; i++) { + SimpleString address = new SimpleString(dest.getPhysicalName()); + PagingStore store = server.getPagingManager().getPageStore(address); ServerMessage coreMsg = originalCoreMsg.copy(); + coreMsg.setAddress(address); - coreMsg.setAddress(addresses[i]); - - PagingStore store = pagingStores[i]; - - if (store.isFull()) { -connection.getTransportConnection().setAutoRead(false); - } + if (shouldBlockProducer) { - if (actualDestinations[i].isQueue()) { -checkAutoCreateQueue(new SimpleString(actualDestinations[i].getPhysicalName()), actualDestinations[i].isTemporary()); - } +if (!store.checkMemory(() -> { + try { + Rout
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748693#comment-15748693 ] ASF GitHub Bot commented on ARTEMIS-888: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/916 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748692#comment-15748692 ] ASF subversion and git services commented on ARTEMIS-888: - Commit 08e0c5e4f1c34b6fe82bf232ce87fd5bc774def4 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=08e0c5e ] Revert "ARTEMIS-888 - AMQP headers arent always set" This reverts commit d471f6b15fab7d7afad8e34635869df18ac0cef4. > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748573#comment-15748573 ] ASF GitHub Bot commented on ARTEMIS-888: Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/915 Ideally a client would receive what it sends in most cases, though for the header there is scope for change given its a mutable section. The durability and priority wouldnt typically change of course. Theres no logical difference between e.g not having the header section, and having one without the priority field set, or having it set to 4 which is the default when not present. Similarly with the durability (which defaults to false unlike JMS). > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-889) dispositions sent after link is detached with close=false and no error are ignored
Gordon Sim created ARTEMIS-889: -- Summary: dispositions sent after link is detached with close=false and no error are ignored Key: ARTEMIS-889 URL: https://issues.apache.org/jira/browse/ARTEMIS-889 Project: ActiveMQ Artemis Issue Type: Bug Components: AMQP Affects Versions: 1.5.1 Reporter: Gordon Sim See https://issues.apache.org/jira/browse/DISPATCH-595?focusedCommentId=15745826&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15745826 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748477#comment-15748477 ] ASF GitHub Bot commented on ARTEMIS-888: GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/916 ARTEMIS-888 removed a rule, that is inconsistent with these teste, he… …nce I'm removing them You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis artemis-888 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/916.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #916 commit b3e4a90cbd028dabf3a372c48fbb67438be56f78 Author: Clebert Suconic Date: 2016-12-14T14:34:56Z ARTEMIS-888 removed a rule, that is inconsistent with these teste, hence I'm removing them > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748452#comment-15748452 ] ASF GitHub Bot commented on ARTEMIS-888: Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/915 So what are you trying to fix here exactly? If the values are defaults the there isn't actually a need to send the header and incur the overhead of encoding it. Also since Artemis converts all incoming AMQP messages if the original message had no header then it'd be preferable to not add one even though the Header is technically mutable. > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748447#comment-15748447 ] ASF subversion and git services commented on ARTEMIS-888: - Commit d471f6b15fab7d7afad8e34635869df18ac0cef4 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d471f6b ] ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748446#comment-15748446 ] ASF subversion and git services commented on ARTEMIS-888: - Commit d471f6b15fab7d7afad8e34635869df18ac0cef4 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d471f6b ] ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748448#comment-15748448 ] ASF GitHub Bot commented on ARTEMIS-888: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/915 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-780) Improve addressing, routing and JMS configuration in Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748445#comment-15748445 ] ASF subversion and git services commented on ARTEMIS-780: - Commit 8263ef2f98949b34117caad9997a42ca66165429 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8263ef2 ] ARTEMIS-780 fix ReplicationWithDivertTest > Improve addressing, routing and JMS configuration in Artemis > > > Key: ARTEMIS-780 > URL: https://issues.apache.org/jira/browse/ARTEMIS-780 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Martyn Taylor >Assignee: Martyn Taylor > Attachments: Artemis780.odt > > > There are a couple of issues with the way Artemis handles addressing of > various destination types. The core of Artemis is based solely on multicast > and queue semantics. i.e. Artemis core supports the ability to define queues > and associate them to addresses. When a message is received it is forwarded > to all the queues with matching addresses. > This works well for Artemis Core clients, core clients send to addresses and > receive from queues. If an application using the core client want pub/sub > semantics, the client can manage it's own queues, using the Core protocol to > create and delete queues. > However, this model falls down with other protocols, that don't support the > "create", "delete" and "lookup" queue management packets. AMQP for example > struggles with this. > There's also the issue of broker side configuration. Right now users are not > able to configure address space (outside of JMS) to define publish/subscribe > semantics for addresses. It is possible to configure a *special* queue with > certain properties that will give Artemis a hint that this address should > behave as publish/subscribe but this is just a side effect of how JMS Topics > are implemented in the core client. > Instead, we should update the way we are using addresses in Artemis and allow > users to be specific about the semantics they require on certain address > spaces. > One way to do this without diverting from Artemis core concepts would be to > expose Addresses as first class citizens in the management API and > configuration. Properties (such as routing semantics) can be added to > addresses to identify the way in which address spaces should work. This > would also allow users to define addresses consistently across all protocols > including JMS (we can drop the special JMS configuration and allow users to > specify "queues" and "topics" in Artemis CORE concepts. This would also > provide a single view in Artemis management (they'd be no need to have a > special JMS management section). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-877) Update various protocols to deal with new addressing scheme
[ https://issues.apache.org/jira/browse/ARTEMIS-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748443#comment-15748443 ] ASF subversion and git services commented on ARTEMIS-877: - Commit 30b1335614f020e6d8051b6a3b5dd68ded5792bd in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=30b1335 ] ARTEMIS-877 STOMP tests + routing header > Update various protocols to deal with new addressing scheme > --- > > Key: ARTEMIS-877 > URL: https://issues.apache.org/jira/browse/ARTEMIS-877 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Justin Bertram >Assignee: Justin Bertram > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-780) Improve addressing, routing and JMS configuration in Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748444#comment-15748444 ] ASF subversion and git services commented on ARTEMIS-780: - Commit bdc2abf308cdc849897dd65679fc6647641b8621 in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=bdc2abf ] ARTEMIS-780 fix JmsProducerTest > Improve addressing, routing and JMS configuration in Artemis > > > Key: ARTEMIS-780 > URL: https://issues.apache.org/jira/browse/ARTEMIS-780 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Martyn Taylor >Assignee: Martyn Taylor > Attachments: Artemis780.odt > > > There are a couple of issues with the way Artemis handles addressing of > various destination types. The core of Artemis is based solely on multicast > and queue semantics. i.e. Artemis core supports the ability to define queues > and associate them to addresses. When a message is received it is forwarded > to all the queues with matching addresses. > This works well for Artemis Core clients, core clients send to addresses and > receive from queues. If an application using the core client want pub/sub > semantics, the client can manage it's own queues, using the Core protocol to > create and delete queues. > However, this model falls down with other protocols, that don't support the > "create", "delete" and "lookup" queue management packets. AMQP for example > struggles with this. > There's also the issue of broker side configuration. Right now users are not > able to configure address space (outside of JMS) to define publish/subscribe > semantics for addresses. It is possible to configure a *special* queue with > certain properties that will give Artemis a hint that this address should > behave as publish/subscribe but this is just a side effect of how JMS Topics > are implemented in the core client. > Instead, we should update the way we are using addresses in Artemis and allow > users to be specific about the semantics they require on certain address > spaces. > One way to do this without diverting from Artemis core concepts would be to > expose Addresses as first class citizens in the management API and > configuration. Properties (such as routing semantics) can be added to > addresses to identify the way in which address spaces should work. This > would also allow users to define addresses consistently across all protocols > including JMS (we can drop the special JMS configuration and allow users to > specify "queues" and "topics" in Artemis CORE concepts. This would also > provide a single view in Artemis management (they'd be no need to have a > special JMS management section). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-880) Support address prefixing
[ https://issues.apache.org/jira/browse/ARTEMIS-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748441#comment-15748441 ] ASF subversion and git services commented on ARTEMIS-880: - Commit 3150759806b17f3c6d2a59b48cc801d7bc88a05d in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3150759 ] ARTEMIS-880 use built-in prefixing for STOMP > Support address prefixing > - > > Key: ARTEMIS-880 > URL: https://issues.apache.org/jira/browse/ARTEMIS-880 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Justin Bertram >Assignee: Justin Bertram > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set
[ https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748369#comment-15748369 ] ASF GitHub Bot commented on ARTEMIS-888: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/915 ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/915.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #915 commit 2759ddce3d3b03fe77d1d145b2e3f63a3921b92a Author: Andy Taylor Date: 2016-12-14T13:43:19Z ARTEMIS-888 - AMQP headers arent always set https://issues.apache.org/jira/browse/ARTEMIS-888 > AMQP headers arent always set > - > > Key: ARTEMIS-888 > URL: https://issues.apache.org/jira/browse/ARTEMIS-888 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.5.1 >Reporter: Andy Taylor >Assignee: Andy Taylor > > durable header gets ignored when false and priority gets ignored when the > default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-888) AMQP headers arent always set
Andy Taylor created ARTEMIS-888: --- Summary: AMQP headers arent always set Key: ARTEMIS-888 URL: https://issues.apache.org/jira/browse/ARTEMIS-888 Project: ActiveMQ Artemis Issue Type: Bug Components: AMQP Affects Versions: 1.5.1 Reporter: Andy Taylor Assignee: Andy Taylor durable header gets ignored when false and priority gets ignored when the default -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6539) Duplex message across cluster not work on ActiveMQ 5.14.2
[ https://issues.apache.org/jira/browse/AMQ-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748107#comment-15748107 ] Gary Tully commented on AMQ-6539: - you should use masteSlave in place of static failover, see: http://activemq.apache.org/networks-of-brokers.html - MasterSlave Discovery > Duplex message across cluster not work on ActiveMQ 5.14.2 > - > > Key: AMQ-6539 > URL: https://issues.apache.org/jira/browse/AMQ-6539 > Project: ActiveMQ > Issue Type: Bug > Components: AMQP >Affects Versions: 5.14.2 > Environment: Testing >Reporter: Franco Ng > > I upgraded from 5.14.1 to 5.14.2 and publish PTP/PubSub message in Custer MQ > with using duplex feature as following configuration. However, the message > cannot publish across both MQ server but just connected server. Please > analyze and solve. > Re: 5.14.1 works with duplex and can publish a message to both MQ servers. > activemq.xml > > networkTTL="2" uri="static:(failover:(tcp://POC1:61616,tcp://POC2:61616))"> > > > > > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)