[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[ https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375382#comment-16375382 ] ASF GitHub Bot commented on ARTEMIS-1664: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 There are tests that run as part of PR and then separately there are a fuller test suite. Reason for this is the larger test suite takes much longer to complete, as such it’s run periodically or if larger changes are made. See the hackers guide for more info > fix npe bug while getting element in the process of rehash > -- > > Key: ARTEMIS-1664 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1664 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[ https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375306#comment-16375306 ] ASF GitHub Bot commented on ARTEMIS-1664: - Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 @michaelandrepearce hi, i don't get what you mean the test. Why do we need a suit test? And where should the test be put to stop from running by CI buid? > fix npe bug while getting element in the process of rehash > -- > > Key: ARTEMIS-1664 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1664 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375260#comment-16375260
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170407785
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
https://github.com/apache/activemq-artemis/blob/d6d895c558cc104475188d942473771418b5e3e6/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java#L109-L117
@clebertsuconic the comment said we need an executor out side the pool
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[ https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375225#comment-16375225 ] Qihong Xu commented on ARTEMIS-1700: [~nigro@gmail.com] Yes, we just use the default setting here. > Server stopped responding and killed itself while exiting paging state > -- > > Key: ARTEMIS-1700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1700 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Qihong Xu >Priority: Major > Attachments: artemis.log > > > We are currently experiencing this error while running stress test on artemis. > > Basic configuration: > 1 broker ,1 topic, pub-sub mode. > Journal type = MAPPED. > Threadpool max size = 60. > > In order to test the throughput of artemis we use 300 producers and 300 > consumers. However we found that sometimes when artemis exit paging state, it > will stop responding and kill itself. This situatuion happened on some > specific servers. > > Details can be found in attached dump file. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375220#comment-16375220
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user qihongxu commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405758
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
[artemis.log](https://github.com/apache/activemq-artemis/files/1753723/artemis.log)
Please see the thread dump file in attachment.
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375219#comment-16375219
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405747
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
We are running 2.4.0
See https://issues.apache.org/jira/browse/ARTEMIS-1700
There is a artemis.log attached.
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375209#comment-16375209
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405391
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
Can I see a thread dump ? Maybe there is a better fix.
A test would be best. But a thread dump would be ok as long as you tell me
the version (or got commit) it is associated.
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375207#comment-16375207
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405300
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
We believe this happens when
- using fixed thread pool which is the default, and
- an address has many producers, more then thread pool's size, and
- the address is about to exit paging state
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375205#comment-16375205
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user shoukunhuai commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170405082
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
What if the pool is full?
In our case, the pool is a 60 thread fixed pool.
One of the thread is doing page cleanup, and try to exit paging state, it
holds the lock in paging store. All other 59 threads is blocked on the lock,
trying to page.
While cleanup, we need to store bookmark in journal for each page
subscription, then wait until completed.
In log, stored equals to storeLineUp, but there are pending tasks(there are
going to count down latch cleanup thread is waiting on), the deadlock happened.
```
16:44:28,930 AMQ222024: Could not complete operations on IO context
OperationContextImpl [1251391301] [minimalStore=1, storeLineUp=2, stored=2,
minimalReplicated=0, replicationLineUp=0, replicated=0, paged=0, minimalPage=0,
pageLineUp=0, errorCode=-1, errorMessage=null, executorsPending=3,
executor=OrderedExecutor(tasks=[org.apache.activemq.artemis.core.persistence.impl.journal.OperationContextImpl$1@4d09259,
org.apache.activemq.artemis.core.persistence.impl.journal.OperationContextImpl$1@54b73dc4,
org.apache.activemq.artemis.core.persistence.impl.journal.OperationContextImpl$1@640495d4])]
```
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ARTEMIS-1701) Zone ID not stripped properly from IPv6 addresses
[ https://issues.apache.org/jira/browse/ARTEMIS-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-1701: Description: (was: This was reported on Stack Overflow. See https://stackoverflow.com/questions/48870793/wildfly-10-1-jms-lookup-with-ipv6.) > Zone ID not stripped properly from IPv6 addresses > - > > Key: ARTEMIS-1701 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1701 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARTEMIS-1701) Zone ID not stripped properly from IPv6 addresses
Justin Bertram created ARTEMIS-1701: --- Summary: Zone ID not stripped properly from IPv6 addresses Key: ARTEMIS-1701 URL: https://issues.apache.org/jira/browse/ARTEMIS-1701 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.4.0 Reporter: Justin Bertram Assignee: Justin Bertram This was reported on Stack Overflow. See https://stackoverflow.com/questions/48870793/wildfly-10-1-jms-lookup-with-ipv6. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374923#comment-16374923
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170356212
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
Can you please close your PR? The executor factory is providing the same
thing you suggested here. it won't fix anything. .just will create more threads
and problems.
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[
https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374921#comment-16374921
]
ASF GitHub Bot commented on ARTEMIS-1700:
-
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1894#discussion_r170355937
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -1488,7 +1494,13 @@ public synchronized void start() throws Exception {
beforeStart();
- singleThreadExecutor = executorFactory.getExecutor();
+ ThreadFactory tFactory = AccessController.doPrivileged(new
PrivilegedAction() {
+ @Override
+ public ThreadFactory run() {
+return new ActiveMQThreadFactory("ActiveMQ-journal-server-" +
this.toString(), true, ClientSessionFactoryImpl.class.getClassLoader());
+ }
+ });
+ singleThreadExecutor = Executors.newSingleThreadExecutor(tFactory);
--- End diff --
nope.. that's wrong...
executorFactory.getExecutor() is returning on thread executor from the pool.
it won't always be the same thread.. but it will always be the same
context.. this patch is not valid.
in what situation do you see a deadlock.
hornetq it might be different.. I would need a test to be able to accept a
patch here. we should reuse the thread from the pool always.
> Server stopped responding and killed itself while exiting paging state
> --
>
> Key: ARTEMIS-1700
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1700
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: Qihong Xu
>Priority: Major
> Attachments: artemis.log
>
>
> We are currently experiencing this error while running stress test on artemis.
>
> Basic configuration:
> 1 broker ,1 topic, pub-sub mode.
> Journal type = MAPPED.
> Threadpool max size = 60.
>
> In order to test the throughput of artemis we use 300 producers and 300
> consumers. However we found that sometimes when artemis exit paging state, it
> will stop responding and kill itself. This situatuion happened on some
> specific servers.
>
> Details can be found in attached dump file.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[ https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374489#comment-16374489 ] Francesco Nigro commented on ARTEMIS-1700: -- Hi I've noticed in the dump that there is a TimedBuffer running and you're using MAPPED journal, hence I suppose that you have datasync = true. It is correct? > Server stopped responding and killed itself while exiting paging state > -- > > Key: ARTEMIS-1700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1700 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Qihong Xu >Priority: Major > Attachments: artemis.log > > > We are currently experiencing this error while running stress test on artemis. > > Basic configuration: > 1 broker ,1 topic, pub-sub mode. > Journal type = MAPPED. > Threadpool max size = 60. > > In order to test the throughput of artemis we use 300 producers and 300 > consumers. However we found that sometimes when artemis exit paging state, it > will stop responding and kill itself. This situatuion happened on some > specific servers. > > Details can be found in attached dump file. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[ https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374475#comment-16374475 ] ASF GitHub Bot commented on ARTEMIS-1700: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1894 @qihongxu Thanks for the PR! IMO would be better to provide a test or a reproducer that has been fixed by this change. Re the changes: the `ArtemisExecutor` is a `fake` executor that just provide a queue of `Runnable` that can be drained exclusively by one consumer Thread at time, making it a single threaded executor, just not by the same thread. > Server stopped responding and killed itself while exiting paging state > -- > > Key: ARTEMIS-1700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1700 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Qihong Xu >Priority: Major > Attachments: artemis.log > > > We are currently experiencing this error while running stress test on artemis. > > Basic configuration: > 1 broker ,1 topic, pub-sub mode. > Journal type = MAPPED. > Threadpool max size = 60. > > In order to test the throughput of artemis we use 300 producers and 300 > consumers. However we found that sometimes when artemis exit paging state, it > will stop responding and kill itself. This situatuion happened on some > specific servers. > > Details can be found in attached dump file. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARTEMIS-1695) Improve Stomp backwards compatibility with 5.x
[ https://issues.apache.org/jira/browse/ARTEMIS-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon resolved ARTEMIS-1695. - Resolution: Fixed > Improve Stomp backwards compatibility with 5.x > -- > > Key: ARTEMIS-1695 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1695 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker, STOMP >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > As I was testing out STOMP in Artemis vs ActiveMQ 5.x I found a few > improvements to make: > > # ActiveMQ 5.x uses the header named "activemq.subscriptionName" for > supplying a subscription name. We should support that as well so clients > don't need to change their code. > # Artemis doesn't create a session until the first message is published or a > subscription is created. I think we should create a session on connection > after authentication is complete. This is more in line with how CORE works > and also when 5.x creates a session for a STOMP client. > # The Version 10 StompFrameHandler does not properly set the response to > disconnect if there is an authentication error. > > Also in ActiveMQ 5.x the prefixes "/topic/" and "/queue/" are used by default > but this can already be configured by setting prefixes in Artemis so we don't > need to worry about that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMQ-6075) javax.jms.InvalidClientIDException: Broker:… already connected
[ https://issues.apache.org/jira/browse/AMQ-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374284#comment-16374284 ] Rajesh Malla commented on AMQ-6075: --- Can anybody suggest whether there is fix available for this InvalidClientIDException ? We are using activemq 5.12.3 version and facing same exception. Can we apply above solution provided by E[~kudi]. Thank you > javax.jms.InvalidClientIDException: Broker:… already connected > -- > > Key: AMQ-6075 > URL: https://issues.apache.org/jira/browse/AMQ-6075 > Project: ActiveMQ > Issue Type: Bug > Components: activemq-pool >Affects Versions: 5.12.1 > Environment: OS：Windows Server 2012 >Reporter: mq >Priority: Critical > > We have a two node network brokers set up. it can work fine two or three > days. Suddenly, every broker will try to create connection to each other, but > because > There are already has connected to each other, so it will throw a > “javax.jms.InvalidClientIDException”.The brokers will retry after 6 second, > and the same exception will happened. > activemq.log > 1:02:54,925 | INFO | Establishing network connection from > vm://MQServer1?async=false to tcp://MQServer-2:61618 | > org.apache.activemq.network.DiscoveryNetworkConnector | > Notifier-MulticastDiscoveryAgent-listener:DiscoveryNetworkConnector:NC:BrokerService[MQServer1] > 1:02:55,097 | WARN | Failed to add Connection > MQServer1->MQServer2-123456-123456788990-123:1 due to > javax.jms.InvalidClientIDException: Broker: MQServer1 - Client: > NC_MQServer2_inbound_MQServer1 already connected from vm://MQServer1#2 | > org.apache.activemq.broker.TransportConnection | > triggerStartAsyncNetworkBridgeCreation: > remoteBroker=tcp://MQServer-2/190.100.100.11:61618@56430, localBroker= > vm://MQServer1#4 > 1:02:55,097 | INFO | Network connection between vm://MQServer1#4 and > tcp://MQServer-2/190.100.100.11:61618@56430 shutdown due to a local error: > javax.jms.InvalidClientIDException: Broker: MQServer1 - Client: > NC_MQServer2_inbound_MQServer1 already connected from vm://MQServer1#2 | > org.apache.activemq.network.DemandForwardingBridgeSupport | > triggerStartAsyncNetworkBridgeCreation: > remoteBroker=tcp://MQServer-2/190.100.100.11:61618@56430, localBroker= > vm://MQServer1#4 > 1:02:55,144 | INFO | MQServer1 bridge to MQServer2 stopped | > org.apache.activemq.network.DemandForwardingBridgeSupport | ActiveMQ > BrokerService[MQServer1] Task-2043 > wrapper.log > INFO | jvm 1| 1:02:55 | INFO | Establishing network connection from > vm://MQServer1?async=false to tcp://MQServer-2:61618 > INFO | jvm 1| 1:02:55 | WARN | Failed to add Connection > MQServer1->MQServer2-123456-123456788990-123:1 due to > javax.jms.InvalidClientIDException: Broker: MQServer1 - Client: > NC_MQServer2_inbound_MQServer1 already connected from vm://MQServer1#2 > INFO | jvm 1| 1:02:55 | INFO | Network connection between > vm://MQServer1#4 and tcp://MQServer-2/190.100.100.11:61618@56430 shutdown due > to a local error: javax.jms.InvalidClientIDException: Broker: MQServer1 - > Client: NC_MQServer2_inbound_MQServer1 already connected from vm://MQServer1#2 > INFO | jvm 1| 1:02:55 | INFO | MQServer1 bridge to MQServer2 stopped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
[ https://issues.apache.org/jira/browse/ARTEMIS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374280#comment-16374280 ] ASF GitHub Bot commented on ARTEMIS-1700: - GitHub user qihongxu opened a pull request: https://github.com/apache/activemq-artemis/pull/1894 ARTEMIS-1700 Fixed deadlock in paging state JournalStorageManager is not indeed using a `single` thread. We apply this patch to use a simple single thread executor. We have seen similar threads on Internet. This seems to be a remaining problem from hornetQ. You can merge this pull request into a Git repository by running: $ git pull https://github.com/qihongxu/activemq-artemis ARTEMIS-1700 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1894.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1894 commit 53daaa2de6dc8407d6c263493b6a2f50b8f5668d Author: 17060606 <17060606@...> Date: 2018-02-23T12:00:00Z ARTEMIS-1700 Fixed deadlock in paging state JournalStorageManager is not indeed using a `single` thread. We apply this patch to use a simple single thread executor. We have seen similar threads on Internet. This seems to be a remaining problem from hornetQ. > Server stopped responding and killed itself while exiting paging state > -- > > Key: ARTEMIS-1700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1700 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Qihong Xu >Priority: Major > Attachments: artemis.log > > > We are currently experiencing this error while running stress test on artemis. > > Basic configuration: > 1 broker ,1 topic, pub-sub mode. > Journal type = MAPPED. > Threadpool max size = 60. > > In order to test the throughput of artemis we use 300 producers and 300 > consumers. However we found that sometimes when artemis exit paging state, it > will stop responding and kill itself. This situatuion happened on some > specific servers. > > Details can be found in attached dump file. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARTEMIS-1700) Server stopped responding and killed itself while exiting paging state
Qihong Xu created ARTEMIS-1700: -- Summary: Server stopped responding and killed itself while exiting paging state Key: ARTEMIS-1700 URL: https://issues.apache.org/jira/browse/ARTEMIS-1700 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.4.0 Reporter: Qihong Xu Attachments: artemis.log We are currently experiencing this error while running stress test on artemis. Basic configuration: 1 broker ,1 topic, pub-sub mode. Journal type = MAPPED. Threadpool max size = 60. In order to test the throughput of artemis we use 300 producers and 300 consumers. However we found that sometimes when artemis exit paging state, it will stop responding and kill itself. This situatuion happened on some specific servers. Details can be found in attached dump file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[
https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374187#comment-16374187
]
ASF GitHub Bot commented on ARTEMIS-1664:
-
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1851
@wy96f Np you can pick up the master and push a new PR with the new changes
that are more improvements/gardening than fixes.
IMO would be interesting to:
- drop the (completly useless) benchmark on ConcurrentLongHashMapTest
- investigate re lazySet on capacity (probably just an Unsafe::storeFence
would enough)
- investigate re lazySet on size or just making it a plain field and do
something like:
```
public int size() {
int size = 0;
for (Section s : sections) {
//read acquire the lock state and any written size
s.tryOptimisticRead();
size += s.size;
}
return size;
}
```
- [advanced] investigate about padding to avoid false sharing between
Section fields
> fix npe bug while getting element in the process of rehash
> --
>
> Key: ARTEMIS-1664
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1664
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: yangwei
>Priority: Major
> Fix For: 2.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[ https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374171#comment-16374171 ] ASF GitHub Bot commented on ARTEMIS-1664: - Github user wy96f commented on the issue: https://github.com/apache/activemq-artemis/pull/1851 Oops, i deleted the branch :( It seems not possible to reopen. I'll create a new one. > fix npe bug while getting element in the process of rehash > -- > > Key: ARTEMIS-1664 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1664 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[ https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374147#comment-16374147 ] ASF GitHub Bot commented on ARTEMIS-1664: - Github user wy96f closed the pull request at: https://github.com/apache/activemq-artemis/pull/1851 > fix npe bug while getting element in the process of rehash > -- > > Key: ARTEMIS-1664 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1664 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARTEMIS-1699) It should be possible to set filter in address setting
Tom Ross created ARTEMIS-1699: - Summary: It should be possible to set filter in address setting Key: ARTEMIS-1699 URL: https://issues.apache.org/jira/browse/ARTEMIS-1699 Project: ActiveMQ Artemis Issue Type: New Feature Reporter: Tom Ross At the moment it is possible to set filter on an individual core destination. It should be possible to set filter in address setting so that it would apply to all destination that satisfy the match criteria for that -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash
[
https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374054#comment-16374054
]
ASF GitHub Bot commented on ARTEMIS-1664:
-
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1851#discussion_r170185326
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java
---
@@ -457,11 +459,11 @@ private void rehash() {
}
}
- capacity = newCapacity;
keys = newKeys;
values = newValues;
usedBuckets = size;
- resizeThreshold = (int) (capacity * MapFillFactor);
+ capacityUpdater.lazySet(this, newCapacity);
+ resizeThreshold = (int) (newCapacity * MapFillFactor);
--- End diff --
`capacityUpdater.lazySet` is store-releasing `keys` , `values`,
`usedBuckets`, but not `resizeThreshold`: that means that the `resizeThreshold`
store could be happen before the update of the `capacity`, is it correct?
> fix npe bug while getting element in the process of rehash
> --
>
> Key: ARTEMIS-1664
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1664
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.4.0
>Reporter: yangwei
>Priority: Major
> Fix For: 2.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
