[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197971 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:43 Start Date: 13/Feb/19 07:43 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling with out special handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily. RE: JMSXGroupLastForConsumer its not possible to retro-acitvely add a header, because consumers can be added at anypoint, and at that point the group may not have a message to dispatch onwards it would not be possible so it would not be possible to add. Also note for AMQP messages we cannot alter by spec. RE: consumer releasing a message it maybe already processing, again no, any already dispatched messages wont be affected, also there is no scope in JMS api to support such release semantic. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. Obviously if you find a way to add those further enhancements you're always welcome to contribute such features yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197971) Time Spent: 1h 10m (was: 1h) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197979=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197979 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:57 Start Date: 13/Feb/19 07:57 Worklog Time Spent: 10m Work Description: billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463096446 Okay great! You are correct regarding a header for when a group is assigned to a consumer. That's the JMSXGroupFirstForConsumer header in ActiveMQ 5.x, described [here](http://activemq.apache.org/message-groups.html). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197979) Time Spent: 2.5h (was: 2h 20m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197975=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197975 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:46 Start Date: 13/Feb/19 07:46 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you want. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197975) Time Spent: 1h 50m (was: 1h 40m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197976=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197976 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:47 Start Date: 13/Feb/19 07:47 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you want. Contributions are always welcome. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197976) Time Spent: 2h (was: 1h 50m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197978=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197978 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:53 Start Date: 13/Feb/19 07:53 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463095530 So yes i think if you find a way to elegantly achieve that without a performance impact i personally would be open to reviewing it. I like the idea. Another further enhancement could be to add header when a group is assigned to a consumer, for signal of firstmessage in group also, i think there is a jira in backlog for that one already. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197978) Time Spent: 2h 20m (was: 2h 10m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197973 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:44 Start Date: 13/Feb/19 07:44 Worklog Time Spent: 10m Work Description: billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is cooperation between Artemis and the existing consumer assigned for that message group. What if a message group is flagged for rebalancing when the need arises. Then, the next message to arrive in that message group is sent to the existing consumer with a special header that informs the consumer that the message group is being reassigned. That consumer is then expected to "release" all messages it is working on in that message group back to Artemis, which then sends them to the newly assigned consumer for that message group. If no further message turns up, then it's not really a load balancing issue. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197973) Time Spent: 1.5h (was: 1h 20m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197974 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:44 Start Date: 13/Feb/19 07:44 Worklog Time Spent: 10m Work Description: billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is a cooperation between Artemis and the existing consumer assigned for that message group. What if a message group is flagged for rebalancing when the need arises. Then, the next message to arrive in that message group is sent to the existing consumer with a special header that informs the consumer that the message group is being reassigned. That consumer is then expected to "release" all messages it is working on in that message group back to Artemis, which then sends them to the newly assigned consumer for that message group. If no further message turns up, then it's not really a load balancing issue. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197974) Time Spent: 1h 40m (was: 1.5h) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197972=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197972 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:43 Start Date: 13/Feb/19 07:43 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling with out special handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily, and lazily expire out. RE: JMSXGroupLastForConsumer its not possible to retro-acitvely add a header, because consumers can be added at anypoint, and at that point the group may not have a message to dispatch onwards it would not be possible so it would not be possible to add. Also note for AMQP messages we cannot alter by spec. RE: consumer releasing a message it maybe already processing, again no, any already dispatched messages wont be affected, also there is no scope in JMS api to support such release semantic. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. Obviously if you find a way to add those further enhancements you're always welcome to contribute such features yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197972) Time Spent: 1h 20m (was: 1h 10m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197977=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197977 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:48 Start Date: 13/Feb/19 07:48 Worklog Time Spent: 10m Work Description: billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463094268 @michaelandrepearce no worries. I really appreciate all the work you guys are doing and just wanted to check whether something like I proposed would be seen by the team as valuable/worthwhile or not. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197977) Time Spent: 2h 10m (was: 2h) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197970=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197970 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:41 Start Date: 13/Feb/19 07:41 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily. RE: JMSXGroupLastForConsumer its not possible to retro-acitvely add a header, because consumers can be added at anypoint, and at that point the group may not have a message to dispatch onwards it would not be possible so it would not be possible to add. Also note for AMQP messages we cannot alter by spec. RE: consumer releasing a message it maybe already processing, again no, any already dispatched messages wont be affected, also there is no scope in JMS api to support such release semantic. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. Obviously if you find a way to add those further enhancements you're always welcome to contribute such features yourself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197970) Time Spent: 1h (was: 50m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197969=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197969 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:38 Start Date: 13/Feb/19 07:38 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily. RE: JMSXGroupLastForConsumer its not possible to retro-acitvely add a header, because consumers can be added at anypoint, and at that point the group may not have a message to dispatch onwards it would not be possible so it would not be possible to add. Also note for AMQP messages we cannot alter by spec. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197969) Time Spent: 50m (was: 40m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197968 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:37 Start Date: 13/Feb/19 07:37 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily. RE: JMSXGroupLastForConsumer its not possible to retro-acitvely add a header, because consumers can be added at anypoint, and at that point the group may not have a message to dispatch onwards it would not be possible so it would not be possible to add. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197968) Time Spent: 40m (was: 0.5h) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197967=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197967 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 07:36 Start Date: 13/Feb/19 07:36 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load balanced groups but where apps can handle a slight change in which groups they are handling, e.g. this is very usefull where a stateless app that simply needs to process and enrich data, and produces onwards. Any data relating to the group can be loaded lazily. RE: JMSXGroupLastForConsumer Because an consumers can be added at anypoint, when the group may not have a message to dispatch onwards it would not be possible it would not be possible to add. This said if you have the need, you can though listen for notification CONSUMER_ADDED on notifications address, and as such could then if you know that queue is using that feature, could know rebalance will occur. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197967) Time Spent: 0.5h (was: 20m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2118) Enhanced Message Groups Support
[ https://issues.apache.org/jira/browse/ARTEMIS-2118?focusedWorklogId=197888=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197888 ] ASF GitHub Bot logged work on ARTEMIS-2118: --- Author: ASF GitHub Bot Created on: 13/Feb/19 02:09 Start Date: 13/Feb/19 02:09 Worklog Time Spent: 10m Work Description: billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463025385 I have a couple of questions regarding the "support rebalancing groups when a consumer is added" aspect of this change: - When a message group X is rebalanced from consumer A to consumer B, how will consumer A be informed that it is no longer assigned message group X and shouldn't expect any further messages in that message group? Will Artemis send the consumer a message, perhaps with JMSXGroupSeq = -1, or perhaps some kind of special header like JMSXGroupLastForConsumer? - Can consumer A release possession of the messages in message group X that consumer A is still processing (i.e. hasn't yet acknowledged) by acknowledging those messages as "released" (as opposed to accepted/rejected), such that those messages are then resent by Artemis to consumer B? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197888) Time Spent: 20m (was: 10m) > Enhanced Message Groups Support > > > Key: ARTEMIS-2118 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2118 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This ticket is for supporting some Message Group Enhancements. > > Currently Artemis implements message groups in a simple way, equivalent to > SimpleMessageGroupMap in activemq5. > [http://activemq.apache.org/message-groups.html] > "SimpleMessageGroupMap keeps track of every group but suffers from unbounded > memory use." > > For use cases migrating from activemq5 its important artemis supports similar > MessageGroupHashBucked feature. > "MessageGroupHashBucked keeps track of every group and has bounded memory > use." > As such, this JIRA is to add support for being able to enable a semantic > equivalent to MessageGroupHashBucket from activemq5, at the queue level. > > Also currently it is not possible for a specific queue disable grouping, this > can be useful where a shared address by many queues, where some consumers > care for ordering and others do not. > Lastly add an ability to rebalance message groups when a consumer is added, > this is useful where you want groups more evenly balanced when consumers come > online, even after dispatching started. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2251) Large messages might not be deleted when server crashed
[ https://issues.apache.org/jira/browse/ARTEMIS-2251?focusedWorklogId=197887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197887 ] ASF GitHub Bot logged work on ARTEMIS-2251: --- Author: ASF GitHub Bot Created on: 13/Feb/19 02:03 Start Date: 13/Feb/19 02:03 Worklog Time Spent: 10m Work Description: qihongxu commented on pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed URL: https://github.com/apache/activemq-artemis/pull/2549 When deleting large messages, artemis will use storePendingLargeMessage to insert a temporary record in journal for reload, in case server crashed and large messages stayed forever. But in storePendingLargeMessage that appendAddRecord inserts records asynchronously. In this way there are potential risks that tasks in executor get lost due to server crash, which may lead to undeletable large messages. To solve this problem a Boolean is added to storePendingLargeMessage so that it will be forced to use SimpleWaitIOCallback in delete situation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197887) Time Spent: 10m Remaining Estimate: 0h > Large messages might not be deleted when server crashed > --- > > Key: ARTEMIS-2251 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2251 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Qihong Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When deleting large messages, artemis will use storePendingLargeMessage to > insert a temporary record in journal for reload, in case server crashed and > large messages stayed forever. But in storePendingLargeMessage that > appendAddRecord inserts records asynchronously. In this way there are > potential risks that tasks in executor get lost due to server crash, which > may lead to undeletable large messages. To solve this problem a Boolean is > added to storePendingLargeMessage so that it will be forced to use > SimpleWaitIOCallback in delete situation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARTEMIS-2251) Large messages might not be deleted when server crashed
Qihong Xu created ARTEMIS-2251: -- Summary: Large messages might not be deleted when server crashed Key: ARTEMIS-2251 URL: https://issues.apache.org/jira/browse/ARTEMIS-2251 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Qihong Xu When deleting large messages, artemis will use storePendingLargeMessage to insert a temporary record in journal for reload, in case server crashed and large messages stayed forever. But in storePendingLargeMessage that appendAddRecord inserts records asynchronously. In this way there are potential risks that tasks in executor get lost due to server crash, which may lead to undeletable large messages. To solve this problem a Boolean is added to storePendingLargeMessage so that it will be forced to use SimpleWaitIOCallback in delete situation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197625
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 14:47
Start Date: 12/Feb/19 14:47
Worklog Time Spent: 10m
Work Description: onlyMIT commented on pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255985412
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
Although it is possible to add a dedicated address to the SESSION_CREATED
notification when the cluster-connection is created, it is not necessary to do
so.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197625)
Time Spent: 21h 10m (was: 21h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 21h 10m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197622
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 14:43
Start Date: 12/Feb/19 14:43
Worklog Time Spent: 10m
Work Description: onlyMIT commented on pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255983228
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
The inter-cluster notification message needs to specify the routing address
to route the message. Different from the notifications of CONSUMER_CREATE and
BINDING_ADD, the routing address (the address created or consumed by itself)
has been determined before the notification is sent. When sending a
SESSION_CREATED notification, We can't know which address to use, so I chose to
use the `ManagementManagementAddress`, which is consumed by each node in the
cluster-connection.
But the notification message using the `ManagementNotificationAddress`
address is filtered by the filter, so I modified the filter and allow
SESSION_CREATED notification to be routed to other nodes in the cluster.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197622)
Time Spent: 21h (was: 20h 50m)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 21h
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197567=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197567
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 13:52
Start Date: 12/Feb/19 13:52
Worklog Time Spent: 10m
Work Description: onlyMIT commented on pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255960926
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##
@@ -2954,7 +2955,13 @@ public void
onNotification(org.apache.activemq.artemis.core.server.management.No
if (!(notification.getType() instanceof CoreNotificationType))
return;
CoreNotificationType type = (CoreNotificationType)
notification.getType();
- TypedProperties prop = notification.getProperties();
+ if (type == CoreNotificationType.SESSION_CREATED) {
+ TypedProperties props = notification.getProperties();
+ //SESSION_CREATED notification should not be broadcast twice
+ if (props.getIntProperty(ManagementHelper.HDR_DISTANCE) > 0) {
Review comment:
To avoid calling the broadcast twice.The original logical SESSION_CREATED
notification will not be transmitted between cluster nodes, and it is now
required to transfer between cluster nodes. In order to maintain consistency
with the original logic, this code to prevent the node receiving the
SESSION_CREATED notification from making a broadcast call again.
Keep the original logic for other notification messages not judged
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197567)
Time Spent: 20h 50m (was: 20h 40m)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 20h 50m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2239) Zero-copy NIO/MAPPED TimedBuffer
[ https://issues.apache.org/jira/browse/ARTEMIS-2239?focusedWorklogId=197538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197538 ] ASF GitHub Bot logged work on ARTEMIS-2239: --- Author: ASF GitHub Bot Created on: 12/Feb/19 12:31 Start Date: 12/Feb/19 12:31 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462741716 This one should be kinda independent from the rest so can be merged without worrying about any conflicts, thanks!!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197538) Time Spent: 5h 40m (was: 5.5h) > Zero-copy NIO/MAPPED TimedBuffer > > > Key: ARTEMIS-2239 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2239 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.6.4 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > NIO/MAPPED journal types are currently performing the copy of the buffer used > on TimedBuffer to accumulate writes, but this copy (and the zeroing of the > new buffer) could be avoided, reducing dramatically the CPU usage and > latencies during a burst of writes. > An added benefit of this change is that isn't necessary anymore to stress the > thread pool of the file factory, because there is no need to pool the buffer > used to perform the write. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2239) Zero-copy NIO/MAPPED TimedBuffer
[ https://issues.apache.org/jira/browse/ARTEMIS-2239?focusedWorklogId=197513=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197513 ] ASF GitHub Bot logged work on ARTEMIS-2239: --- Author: ASF GitHub Bot Created on: 12/Feb/19 12:00 Start Date: 12/Feb/19 12:00 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462732912 Looking promising. @franz1981 with all the changes youve been working on for journals, im not sure what the merge order is. Can this just be merged OR do we need merge another PR first? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197513) Time Spent: 5.5h (was: 5h 20m) > Zero-copy NIO/MAPPED TimedBuffer > > > Key: ARTEMIS-2239 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2239 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.6.4 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > NIO/MAPPED journal types are currently performing the copy of the buffer used > on TimedBuffer to accumulate writes, but this copy (and the zeroing of the > new buffer) could be avoided, reducing dramatically the CPU usage and > latencies during a burst of writes. > An added benefit of this change is that isn't necessary anymore to stress the > thread pool of the file factory, because there is no need to pool the buffer > used to perform the write. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197512=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197512
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 11:56
Start Date: 12/Feb/19 11:56
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255920956
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##
@@ -2954,7 +2955,13 @@ public void
onNotification(org.apache.activemq.artemis.core.server.management.No
if (!(notification.getType() instanceof CoreNotificationType))
return;
CoreNotificationType type = (CoreNotificationType)
notification.getType();
- TypedProperties prop = notification.getProperties();
+ if (type == CoreNotificationType.SESSION_CREATED) {
+ TypedProperties props = notification.getProperties();
+ //SESSION_CREATED notification should not be broadcast twice
+ if (props.getIntProperty(ManagementHelper.HDR_DISTANCE) > 0) {
Review comment:
Also isnt cyclic between nodes in cluster already avoided, because of filter
in the cluster connection bridge where it does a HDR_DISTANCE < flow.maxHops.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197512)
Time Spent: 20h 40m (was: 20.5h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 20h 40m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[ https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197510=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197510 ] ASF GitHub Bot logged work on ARTEMIS-2226: --- Author: ASF GitHub Bot Created on: 12/Feb/19 11:54 Start Date: 12/Feb/19 11:54 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-462731246 @onlyMIT looking better, i have some questions, which im sure all makes sense if explained, but probably a sign a little java doc might be beneficial, and would help future understanding when this PR is closed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197510) Time Spent: 20.5h (was: 20h 20m) > (MQTT)In the cluster,the last consumer connection should close the previous > consumer connection > --- > > Key: ARTEMIS-2226 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2226 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Shiping Liang >Priority: Major > Time Spent: 20.5h > Remaining Estimate: 0h > > Multiple consumers using the same clientId in the cluster, the last consumer > connection should close the previous consumer connection! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197509=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197509
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 11:47
Start Date: 12/Feb/19 11:47
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255918235
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
Whats this trying to achieve?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197509)
Time Spent: 20h 20m (was: 20h 10m)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 20h 20m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197504=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197504
]
ASF GitHub Bot logged work on ARTEMIS-2226:
---
Author: ASF GitHub Bot
Created on: 12/Feb/19 11:43
Start Date: 12/Feb/19 11:43
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255916966
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##
@@ -2954,7 +2955,13 @@ public void
onNotification(org.apache.activemq.artemis.core.server.management.No
if (!(notification.getType() instanceof CoreNotificationType))
return;
CoreNotificationType type = (CoreNotificationType)
notification.getType();
- TypedProperties prop = notification.getProperties();
+ if (type == CoreNotificationType.SESSION_CREATED) {
+ TypedProperties props = notification.getProperties();
+ //SESSION_CREATED notification should not be broadcast twice
+ if (props.getIntProperty(ManagementHelper.HDR_DISTANCE) > 0) {
Review comment:
Why would this logic specific to just SESSION_CREATED, would this not be
generic to all?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197504)
Time Spent: 20h 10m (was: 20h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> ---
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Shiping Liang
>Priority: Major
> Time Spent: 20h 10m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection
[ https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=197434=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197434 ] ASF GitHub Bot logged work on ARTEMIS-2226: --- Author: ASF GitHub Bot Created on: 12/Feb/19 08:50 Start Date: 12/Feb/19 08:50 Worklog Time Spent: 10m Work Description: onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-462671664 @michaelandrepearce move logic to SESSION_CREATE notification This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 197434) Time Spent: 20h (was: 19h 50m) > (MQTT)In the cluster,the last consumer connection should close the previous > consumer connection > --- > > Key: ARTEMIS-2226 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2226 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Shiping Liang >Priority: Major > Time Spent: 20h > Remaining Estimate: 0h > > Multiple consumers using the same clientId in the cluster, the last consumer > connection should close the previous consumer connection! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1058) Jars in web tmp dir locked on Windows
[ https://issues.apache.org/jira/browse/ARTEMIS-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765809#comment-16765809 ] ASF subversion and git services commented on ARTEMIS-1058: -- Commit 3a25748936d27937000c50c67281cb03d719c2f1 in activemq-artemis's branch refs/heads/2.6.x from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=3a25748 ] ARTEMIS-1058 Fixing testsuite Possible NPE that will happen on ReplicatedFailoverTest only (cherry picked from commit b80a78d885e2568af41fc133b0185399385eda0c) > Jars in web tmp dir locked on Windows > - > > Key: ARTEMIS-1058 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1058 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.3 > Environment: Windows >Reporter: Howard Gao >Assignee: Howard Gao >Priority: Minor > Fix For: unscheduled > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The embedded jetty web server's WebAppClassloader holds up webapp's jar files > and does not release them after close. For that reason the web app's temp dir > cannot be cleaned up on Windows. (Other platforms like Linux doesn't prevent > a force delete of files even they are not released). > As long as this behavior exists we need to have a workaround to let > the tmp dir be cleaned up. > It is possible that we use a 'customized' classloader to replace jetty's > WebAppClassloader, in which we manually iterate every JarFile resources > and close them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1058) Jars in web tmp dir locked on Windows
[ https://issues.apache.org/jira/browse/ARTEMIS-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765806#comment-16765806 ] ASF subversion and git services commented on ARTEMIS-1058: -- Commit b80a78d885e2568af41fc133b0185399385eda0c in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b80a78d ] ARTEMIS-1058 Fixing testsuite Possible NPE that will happen on ReplicatedFailoverTest only > Jars in web tmp dir locked on Windows > - > > Key: ARTEMIS-1058 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1058 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 1.5.3 > Environment: Windows >Reporter: Howard Gao >Assignee: Howard Gao >Priority: Minor > Fix For: unscheduled > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The embedded jetty web server's WebAppClassloader holds up webapp's jar files > and does not release them after close. For that reason the web app's temp dir > cannot be cleaned up on Windows. (Other platforms like Linux doesn't prevent > a force delete of files even they are not released). > As long as this behavior exists we need to have a workaround to let > the tmp dir be cleaned up. > It is possible that we use a 'customized' classloader to replace jetty's > WebAppClassloader, in which we manually iterate every JarFile resources > and close them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
