[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=296988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296988
]
ASF GitHub Bot logged work on ARTEMIS-2437:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 02:25
Start Date: 19/Aug/19 02:25
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #2795: ARTEMIS-2437
Allow extended types in annotations in AMQP to Core
URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-522376709
@tabish121 can you rebase please?
(edit: Never mind: some git-fu and I rebased it myself)
if you could check after merged please.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 296988)
Time Spent: 2h (was: 1h 50m)
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
>
[jira] [Commented] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910135#comment-16910135
]
ASF subversion and git services commented on ARTEMIS-2437:
--
Commit 448f72738b1b7e3f4bc0a757e3905e9c73fb2336 in activemq-artemis's branch
refs/heads/master from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=448f727 ]
ARTEMIS-2437 Allow extended types in annotations in AMQP to Core
When converting from AMQP to core and back again support annotations that
aren't able to be placed into Core message properties by storing the bytes
from encoding the types to AMQP encodings and then decoding them again
when converting back into AMQP messages.
Requires update to proton-j 0.33.2 for encoding fix
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1030)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:53)
>
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=296986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296986
]
ASF GitHub Bot logged work on ARTEMIS-2437:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 02:24
Start Date: 19/Aug/19 02:24
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #2795: ARTEMIS-2437
Allow extended types in annotations in AMQP to Core
URL: https://github.com/apache/activemq-artemis/pull/2795
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 296986)
Time Spent: 1h 50m (was: 1h 40m)
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
>
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[
https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=296975=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296975
]
ASF GitHub Bot logged work on ARTEMIS-2437:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 01:03
Start Date: 19/Aug/19 01:03
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #2795: ARTEMIS-2437
Allow extended types in annotations in AMQP to Core
URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-522376709
@tabish121 can you rebase please?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 296975)
Time Spent: 1h 40m (was: 1.5h)
> AMQP message conversion fails if annotations contain values outwith simple
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server]
> AMQ224046: Exception while browser handled from
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627,
> address=example, size=121, applicationProperties=null,
> properties=Properties{messageId=null, userId=null, to='null', subject='null',
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null,
> absoluteExpiryTime=null, creationTime=null, groupId='null',
> groupSequence=null, replyToGroupId='null'}, extraProperties =
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class
> java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
> [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
> [artemis-server-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_212]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_212]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.9.0.jar:2.9.0]
> Caused by:
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException:
> class java.util.LinkedHashMap is not a valid property type
> at
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
> [artemis-commons-2.9.0.jar:2.9.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
> [artemis-core-client-2.9.0.jar:2.9.0]
> at
>
[jira] [Work logged] (ARTEMIS-2451) eliminate knownDestinations cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=296974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296974 ] ASF GitHub Bot logged work on ARTEMIS-2451: --- Author: ASF GitHub Bot Created on: 19/Aug/19 01:01 Start Date: 19/Aug/19 01:01 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2800: ARTEMIS-2451 eliminate knownDestinations cache URL: https://github.com/apache/activemq-artemis/pull/2800#issuecomment-522376395 Other than that simple / dumb test to be added! +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296974) Time Spent: 6h 10m (was: 6h) > eliminate knownDestinations cache > - > > Key: ARTEMIS-2451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 6h 10m > Remaining Estimate: 0h > > This is the client-side version of ARTEMIS-2449. Simply put, there is no > limit on the destination cache for a core JMS client. For a long-lived > connection sending to lots of different destinations (e.g. in a request-reply > use-case involving temporary queues) this can present a significant problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2451) eliminate knownDestinations cache
[
https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=296973=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296973
]
ASF GitHub Bot logged work on ARTEMIS-2451:
---
Author: ASF GitHub Bot
Created on: 19/Aug/19 01:00
Start Date: 19/Aug/19 01:00
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #2800: ARTEMIS-2451
eliminate knownDestinations cache
URL: https://github.com/apache/activemq-artemis/pull/2800#issuecomment-522376248
@jbertram Can I ask you to add a test with this PR?
One that shows users doing this anti pattern:
```java
int N = 100; // or any arbitrary number > 1
for (int i = 0; i < N; i++) {
Queue queue = session.createQueue("myQueue");
MessageProducer prod = session.createProducer(queue);
prod.send();
prod.close();
}
```
If an user did such anti-pattern, it should suffer the consequences of the
extra roundtrip of course, and we should not optimize for it.
I just want to make sure it wouldn't fail for any reason.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 296973)
Time Spent: 6h (was: 5h 50m)
> eliminate knownDestinations cache
> -
>
> Key: ARTEMIS-2451
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2451
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> This is the client-side version of ARTEMIS-2449. Simply put, there is no
> limit on the destination cache for a core JMS client. For a long-lived
> connection sending to lots of different destinations (e.g. in a request-reply
> use-case involving temporary queues) this can present a significant problem.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?focusedWorklogId=296971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296971 ] ASF GitHub Bot logged work on ARTEMIS-2454: --- Author: ASF GitHub Bot Created on: 19/Aug/19 00:40 Start Date: 19/Aug/19 00:40 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2801: ARTEMIS-2454 Message Body damaged after re-encoding URL: https://github.com/apache/activemq-artemis/pull/2801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296971) Time Spent: 40m (was: 0.5h) > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910095#comment-16910095 ] ASF subversion and git services commented on ARTEMIS-2454: -- Commit 5f75f68129f74d533a59b802112567b747352950 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5f75f68 ] ARTEMIS-2454 Message Body damaged after re-encoding > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?focusedWorklogId=296962=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296962 ] ASF GitHub Bot logged work on ARTEMIS-2454: --- Author: ASF GitHub Bot Created on: 18/Aug/19 21:16 Start Date: 18/Aug/19 21:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2801: ARTEMIS-2454 Message Body damaged after re-encoding URL: https://github.com/apache/activemq-artemis/pull/2801#discussion_r315002693 ## File path: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/TestConversions.java ## @@ -31,14 +33,17 @@ import org.apache.activemq.artemis.protocol.amqp.converter.jms.ServerJMSTextMessage; import org.apache.activemq.artemis.protocol.amqp.util.NettyReadable; import org.apache.activemq.artemis.protocol.amqp.util.NettyWritable; +import org.apache.activemq.artemis.protocol.amqp.util.TLSEncode; Review comment: it's failing on checkstyle right here actually.. fixing it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296962) Time Spent: 0.5h (was: 20m) > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2451) eliminate knownDestinations cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=296959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296959 ] ASF GitHub Bot logged work on ARTEMIS-2451: --- Author: ASF GitHub Bot Created on: 18/Aug/19 20:39 Start Date: 18/Aug/19 20:39 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2796: ARTEMIS-2451 remove need for knownDestination Cache URL: https://github.com/apache/activemq-artemis/pull/2796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296959) Time Spent: 5h 50m (was: 5h 40m) > eliminate knownDestinations cache > - > > Key: ARTEMIS-2451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > This is the client-side version of ARTEMIS-2449. Simply put, there is no > limit on the destination cache for a core JMS client. For a long-lived > connection sending to lots of different destinations (e.g. in a request-reply > use-case involving temporary queues) this can present a significant problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2451) eliminate knownDestinations cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=296958=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296958 ] ASF GitHub Bot logged work on ARTEMIS-2451: --- Author: ASF GitHub Bot Created on: 18/Aug/19 20:39 Start Date: 18/Aug/19 20:39 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2800: ARTEMIS-2451 eliminate knownDestinations cache URL: https://github.com/apache/activemq-artemis/pull/2800#issuecomment-522353528 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296958) Time Spent: 5h 40m (was: 5.5h) > eliminate knownDestinations cache > - > > Key: ARTEMIS-2451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > This is the client-side version of ARTEMIS-2449. Simply put, there is no > limit on the destination cache for a core JMS client. For a long-lived > connection sending to lots of different destinations (e.g. in a request-reply > use-case involving temporary queues) this can present a significant problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?focusedWorklogId=296957=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296957 ] ASF GitHub Bot logged work on ARTEMIS-2454: --- Author: ASF GitHub Bot Created on: 18/Aug/19 20:36 Start Date: 18/Aug/19 20:36 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2801: ARTEMIS-2454 Message Body damaged after re-encoding URL: https://github.com/apache/activemq-artemis/pull/2801#discussion_r315001318 ## File path: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/TestConversions.java ## @@ -31,14 +33,17 @@ import org.apache.activemq.artemis.protocol.amqp.converter.jms.ServerJMSTextMessage; import org.apache.activemq.artemis.protocol.amqp.util.NettyReadable; import org.apache.activemq.artemis.protocol.amqp.util.NettyWritable; +import org.apache.activemq.artemis.protocol.amqp.util.TLSEncode; Review comment: I dont think this needed to be added. I cant see it being used This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296957) Time Spent: 20m (was: 10m) > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910030#comment-16910030 ] clebert suconic edited comment on ARTEMIS-2454 at 8/18/19 6:16 PM: --- This was regressed after https://github.com/apache/activemq-artemis/commit/c1cf9ef12d010cec89d6228b29f3459c3d51ee0d was (Author: clebertsuconic): This was regressed after c1cf9ef12d010cec89d6228b29f3459c3d51ee0d > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910030#comment-16910030 ] clebert suconic commented on ARTEMIS-2454: -- This was regressed after c1cf9ef12d010cec89d6228b29f3459c3d51ee0d > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
[ https://issues.apache.org/jira/browse/ARTEMIS-2454?focusedWorklogId=296947=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296947 ] ASF GitHub Bot logged work on ARTEMIS-2454: --- Author: ASF GitHub Bot Created on: 18/Aug/19 18:11 Start Date: 18/Aug/19 18:11 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2801: ARTEMIS-2454 Message Body damaged after re-encoding URL: https://github.com/apache/activemq-artemis/pull/2801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296947) Time Spent: 10m Remaining Estimate: 0h > AMQPMessage re-encode may damage the message body and application properties. > - > > Key: ARTEMIS-2454 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.9.0 >Reporter: clebert suconic >Assignee: clebert suconic >Priority: Blocker > Fix For: 2.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARTEMIS-2454) AMQPMessage re-encode may damage the message body and application properties.
clebert suconic created ARTEMIS-2454: Summary: AMQPMessage re-encode may damage the message body and application properties. Key: ARTEMIS-2454 URL: https://issues.apache.org/jira/browse/ARTEMIS-2454 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.9.0 Reporter: clebert suconic Assignee: clebert suconic Fix For: 2.10.0 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-601) Add test toolkit for frame based assertions
[ https://issues.apache.org/jira/browse/AMQNET-601?focusedWorklogId=296912=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296912 ] ASF GitHub Bot logged work on AMQNET-601: - Author: ASF GitHub Bot Created on: 18/Aug/19 10:52 Start Date: 18/Aug/19 10:52 Worklog Time Spent: 10m Work Description: Havret commented on issue #9: AMQNET-601: Add test toolkit for frame based assertions URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-522306456 @cjwmorgan-sol Hey, you are right. I came across the same issue during work on https://github.com/apache/activemq-nms-amqp/pull/20. Luckily I think we can address this by, extending amqpnetlite handler api, with option to override settled flag with false value. It should do the trick as for now all our AmqpProducers use sender link with `Unsettled` SettleMode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296912) Time Spent: 0.5h (was: 20m) > Add test toolkit for frame based assertions > > > Key: AMQNET-601 > URL: https://issues.apache.org/jira/browse/AMQNET-601 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > During the work on transactions support, I realized that the current approach > to integration testing is not comprehensive enough, and we will need > something more sophisticated to cover all required scenarios with confidence > that all is working as it is expected to. > The general idea is to build frame based assertion toolkit, the same way as > qpid jms does. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-601) Add test toolkit for frame based assertions
[ https://issues.apache.org/jira/browse/AMQNET-601?focusedWorklogId=296908=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296908 ] ASF GitHub Bot logged work on AMQNET-601: - Author: ASF GitHub Bot Created on: 18/Aug/19 09:38 Start Date: 18/Aug/19 09:38 Worklog Time Spent: 10m Work Description: Havret commented on issue #9: AMQNET-601: Add test toolkit for frame based assertions URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-522306456 @cjwmorgan-sol Hey, you are right. I came across the same issue during work on https://github.com/apache/activemq-nms-amqp/pull/20. Luckily I think we can address this by, extending amqpnetlite handler api, with option to override settled flag with false value. It should do the trick as for now all our AmqpProducers use sender link with `Unsettled` SettleMode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296908) Time Spent: 20m (was: 10m) > Add test toolkit for frame based assertions > > > Key: AMQNET-601 > URL: https://issues.apache.org/jira/browse/AMQNET-601 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 20m > Remaining Estimate: 0h > > During the work on transactions support, I realized that the current approach > to integration testing is not comprehensive enough, and we will need > something more sophisticated to cover all required scenarios with confidence > that all is working as it is expected to. > The general idea is to build frame based assertion toolkit, the same way as > qpid jms does. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-601) Add test toolkit for frame based assertions
[ https://issues.apache.org/jira/browse/AMQNET-601?focusedWorklogId=296907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296907 ] ASF GitHub Bot logged work on AMQNET-601: - Author: ASF GitHub Bot Created on: 18/Aug/19 09:37 Start Date: 18/Aug/19 09:37 Worklog Time Spent: 10m Work Description: Havret commented on issue #9: AMQNET-601: Add test toolkit for frame based assertions URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-522306456 @cjwmorgan-sol Hey, you are right. I came across the same issue during work on https://github.com/apache/activemq-nms-amqp/pull/20. Luckily I think we can address this by, extending amqpnetlite handler api, with option to override settled flag with false. It should do the trick as for now all our AmqpProducers use sender link with `Unsettled` SettleMode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296907) Time Spent: 10m Remaining Estimate: 0h > Add test toolkit for frame based assertions > > > Key: AMQNET-601 > URL: https://issues.apache.org/jira/browse/AMQNET-601 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 10m > Remaining Estimate: 0h > > During the work on transactions support, I realized that the current approach > to integration testing is not comprehensive enough, and we will need > something more sophisticated to cover all required scenarios with confidence > that all is working as it is expected to. > The general idea is to build frame based assertion toolkit, the same way as > qpid jms does. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-602) Performance issue with brokers that respect batchable flag
[ https://issues.apache.org/jira/browse/AMQNET-602?focusedWorklogId=296902=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296902 ] ASF GitHub Bot logged work on AMQNET-602: - Author: ASF GitHub Bot Created on: 18/Aug/19 09:32 Start Date: 18/Aug/19 09:32 Worklog Time Spent: 10m Work Description: Havret commented on pull request #20: AMQNET-602: Set batchable flag to false for amqp transfer URL: https://github.com/apache/activemq-nms-amqp/pull/20 This PR resolves the performance issue with brokers that respect the batchable flag for amqp transfer. https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-517366025 It utilizes new Handel API of amqp net lite, and new testing toolkit, and thus we should wait with merge until https://github.com/Azure/amqpnetlite/commit/2c38af646de695c17f6f6992fbeecd2a0252 is released and https://github.com/apache/activemq-nms-amqp/pull/9 is merged. Moreover it illustrates the problem pointed out by @cjwmorgan-sol https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-521632602. Amqpnet lite sets settled flag to `true` for messages send in a fire and forget manner. **TestSendingMessageNonPersistentSetsBatchableFalse** is failing because of that. I think this issue should be addressed with higher precedence. Prerequisites: - [ ] amqpnetlite release, - [ ] test toolkit merge - [ ] settled issue solves for fire and forget sends - [ ] rebase and history cleanup This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296902) Time Spent: 10m Remaining Estimate: 0h > Performance issue with brokers that respect batchable flag > -- > > Key: AMQNET-602 > URL: https://issues.apache.org/jira/browse/AMQNET-602 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > MessageProducer rate are 1 msg/sec on brokers that respect the batchable flag > for amqp transfers. This has been a long standing issue with amqpnetlite > until it was fixed for synchronous sends, version 2.1.8. The provider > AmqpProducer uses async sends with ManualResetEvent to block. This is bad in > term of amqp protocol as the transfer sent as batchable indicating to the > broker that disposition should not be sent right away so it waits however the > client is also waiting for a response leading to terrible message rates. > Amqpnetlite fixed this issue at least for synchronous sends from a sender > link where the batchable flag is set to false when a send is synchronous > however that means that AmqpProducer must use a different send (see > senderLink.send(msg) and senderLink.send(msg, timeout)) method then its > currently using. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (AMQNET-602) Performance issue with brokers that respect batchable flag
Krzysztof Porebski created AMQNET-602: - Summary: Performance issue with brokers that respect batchable flag Key: AMQNET-602 URL: https://issues.apache.org/jira/browse/AMQNET-602 Project: ActiveMQ .Net Issue Type: Improvement Components: AMQP, NMS Affects Versions: 1.8.0 Reporter: Krzysztof Porebski MessageProducer rate are 1 msg/sec on brokers that respect the batchable flag for amqp transfers. This has been a long standing issue with amqpnetlite until it was fixed for synchronous sends, version 2.1.8. The provider AmqpProducer uses async sends with ManualResetEvent to block. This is bad in term of amqp protocol as the transfer sent as batchable indicating to the broker that disposition should not be sent right away so it waits however the client is also waiting for a response leading to terrible message rates. Amqpnetlite fixed this issue at least for synchronous sends from a sender link where the batchable flag is set to false when a send is synchronous however that means that AmqpProducer must use a different send (see senderLink.send(msg) and senderLink.send(msg, timeout)) method then its currently using. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (AMQNET-589) NMS AMQP Failover implementation
[ https://issues.apache.org/jira/browse/AMQNET-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Porebski closed AMQNET-589. - Resolution: Fixed Fix Version/s: 1.8.0 > NMS AMQP Failover implementation > > > Key: AMQNET-589 > URL: https://issues.apache.org/jira/browse/AMQNET-589 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: ActiveMQ, AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 10.5h > Remaining Estimate: 0h > > Implement failover in NMS AMQP the same way as it is implemented in QpidJMS. > This will involve some major rework, as current design is too rigid to > introduce this feature. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (AMQ-7277) Need to expose an api to extract localCertificates & PeerCertificates during the handshake
rajiv devaraj created AMQ-7277: -- Summary: Need to expose an api to extract localCertificates & PeerCertificates during the handshake Key: AMQ-7277 URL: https://issues.apache.org/jira/browse/AMQ-7277 Project: ActiveMQ Issue Type: New Feature Affects Versions: 5.7.0 Reporter: rajiv devaraj Fix For: 5.15.11, 5.15.9, 5.15.8, 5.7.0 Like in 5.15.11 , where under Tranport interface(org.apache.activemq.transport) there is a way to extract peer certificate exchanged during the handshake , like wise i would need to know the local certificate being exchanged during the handshake . so would require an api to extract both localCerticate & peerCertificate being exchanged during the communication attaching the stack overflow link for more reference : [https://stackoverflow.com/questions/57507718/socket-where-we-have-api-to-fetch-local-certificates-peer-certificates-during?noredirect=1#comment101492217_57507718] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
