[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597104 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:46 Start Date: 15/May/21 04:46 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Im one for consistency, as the saying goes consistency is king. Especially as a user mindset. Like why all other dirs the element value yet here its an empty element value but its an attribute. Having things miss match in style makes it harder as you have to cross check everytime. Its easier to eyeball also when cross checking if there's consistency. Its like codestyle/formatting having it all the same style and format just makes it easier to expect certain things and easier to read. You dont want a code base with different codestyles and formats it very quickly makes it harder to read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597104) Time Spent: 10h (was: 9h 50m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597102=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597102 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:45 Start Date: 15/May/21 04:45 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Im one for consistency, as the saying goes consistency is king. Especially as a user mindset. Like why all other dirs the element value yet here its an empty element value but its an attribute. Having things miss match in style makes it harder as you have to cross check everytime. Its easier to eyeball also when cross checking if there's consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597102) Time Spent: 9h 50m (was: 9h 40m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 9h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597100 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:42 Start Date: 15/May/21 04:42 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Im one for consistency. Especially as a user mindset. Like why all other dirs the element value yet here its an empty element value but its an attribute. Having things miss match in style makes it harder as you have to cross check everytime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597100) Time Spent: 9h 40m (was: 9.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 9h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597099 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:40 Start Date: 15/May/21 04:40 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894507 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Im one for consistency. Especially as a user mindset. Like why all other dirs the element value yet here its an empty element value but its an attribute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597099) Time Spent: 9.5h (was: 9h 20m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 9.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597098 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:38 Start Date: 15/May/21 04:38 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894333 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/dataformat/JournalAddRecord.java ## @@ -30,32 +30,37 @@ protected final byte recordType; - protected final boolean add; + protected final byte journalType; Review comment: Cool just checking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597098) Time Spent: 9h 20m (was: 9h 10m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 9h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597096=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597096
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:37
Start Date: 15/May/21 04:37
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894234
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -1858,6 +1988,8 @@ public synchronized void compact() throws Exception {
journalLock.writeLock().unlock();
}
+ processBackup();
Review comment:
Understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597096)
Time Spent: 9h (was: 8h 50m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597095=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597095
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:37
Start Date: 15/May/21 04:37
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894221
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -2245,6 +2379,155 @@ private synchronized JournalLoadInformation load(final
LoaderCallback loadManage
}
}
+
+ @Override
+ public void processBackupCleanup() {
+ if (journalRetentionFolder != null && (journalRetentionMaxFiles > 0 ||
journalRetentionPeriod > 0)) {
+
+ FilenameFilter fnf = new FilenameFilter() {
+@Override
+public boolean accept(final File file, final String name) {
+ return name != null && name.endsWith("." +
filesRepository.getFileExtension());
+}
+ };
+
+
+ if (journalRetentionPeriod > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+GregorianCalendar calendar = this.calendarThreadLocal.get();
+calendar.setTimeInMillis(System.currentTimeMillis() -
journalRetentionUnit.toMillis(journalRetentionPeriod));
+long timeCutOf = calendar.getTimeInMillis();
+
+for (String fileName : fileNames) {
+ long timeOnFile = getDatePortionMillis(fileName);
+ if (timeOnFile < timeCutOf) {
+ logger.debug("File " + fileName + " is too old and should
go");
+ File fileToRemove = new File(journalRetentionFolder,
fileName);
+ if (!fileToRemove.delete()) {
+ logger.debug("Could not remove " + fileToRemove);
+ }
+ }
+}
+ }
+
+ if (journalRetentionMaxFiles > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+if (fileNames.length > journalRetentionMaxFiles) {
+ int toRemove = fileNames.length - journalRetentionMaxFiles;
+
+ for (String file : fileNames) {
+ logger.debug("Removing " + file);
+ File fileToRemove = new File(journalRetentionFolder, file);
+ fileToRemove.delete();
+ toRemove--;
+ if (toRemove <= 0) {
+ break;
+ }
+ }
+}
+ }
+
+
+ }
+ }
+
+ @Override
+ public void processBackup() {
+ if (journalRetentionFolder != null) {
+ ArrayList filesToMove;
+ synchronized (historyPendingFiles) {
+filesToMove = new ArrayList<>(historyPendingFiles.size());
+filesToMove.addAll(historyPendingFiles);
+historyPendingFiles.clear();
+ }
+
+
+ Calendar calendar = calendarThreadLocal.get();
Review comment:
because of the change i was thinking there was maybe more to it. I
guess just consistency so in future people not double thinking like i just did
why the difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597095)
Time Spent: 8h 50m (was: 8h 40m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597097=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597097 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:37 Start Date: 15/May/21 04:37 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632894284 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java ## @@ -108,6 +115,7 @@ * * */ public static final double UPDATE_FACTOR; + public static final String BKP = ".bkp"; Review comment: Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597097) Time Spent: 9h 10m (was: 9h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 9h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597093=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597093 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:33 Start Date: 15/May/21 04:33 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893681 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Eg to be more consistent `data/retention` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597093) Time Spent: 8h 40m (was: 8.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 8h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597092=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597092
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:31
Start Date: 15/May/21 04:31
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893752
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##
@@ -768,6 +772,45 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
}
}
+
+ private void parseJournalRetention(final Element e, final Configuration
config) {
+ NodeList retention = e.getElementsByTagName("journal-retention");
+
+ if (retention.getLength() != 0) {
+ Element node = (Element) retention.item(0);
+
+ String directory = getAttributeValue(node, "directory");
+ long storageLimit = ByteUtil.convertTextBytes(getAttributeValue(node,
"storage-limit").trim());
+ int period = getAttributeInteger(node, "period", 0,
Validators.GT_ZERO);
+ String unitStr = getAttributeValue(node, "unit");
+
+ TimeUnit unit;
+
+ switch (unitStr) {
+case "DAYS":
+ unit = TimeUnit.DAYS;
+ break;
+case "HOURS":
+ unit = TimeUnit.HOURS;
+ break;
+case "MINUTES":
+ unit = TimeUnit.MINUTES;
+ break;
+case "SECONDS":
+ unit = TimeUnit.SECONDS;
+ break;
+default:
+ unit = TimeUnit.DAYS;
+ }
+
+ config.setJournalRetentionDirectory(directory);
+ config.setJournalRetentionTimeUnit(unit);
Review comment:
I will think about this between tomorrow (Saturday) and Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597092)
Time Spent: 8.5h (was: 8h 20m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597089=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597089 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:31 Start Date: 15/May/21 04:31 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893681 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Eg `data/retention` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597089) Time Spent: 8h (was: 7h 50m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 8h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597091=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597091 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:31 Start Date: 15/May/21 04:31 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893681 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Eg to be more consistent `data/retention` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597091) Time Spent: 8h 20m (was: 8h 10m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 8h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597090=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597090 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:31 Start Date: 15/May/21 04:31 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893707 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: you mean this? ``` data/retention ``` I would have to call it journal-retention-directory.. it wouldn't look as nice IMO. I would probably have to split it into separate elements... I would rather keep the way it is now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597090) Time Spent: 8h 10m (was: 8h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 8h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597088=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597088 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:26 Start Date: 15/May/21 04:26 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632893268 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Yes but other dirs the element value is the directory name... not saying to move attributes for the retention parts. Just saying shouldnt the directory attribute be the element value as like other data dirs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597088) Time Spent: 7h 50m (was: 7h 40m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597086 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:21 Start Date: 15/May/21 04:21 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#issuecomment-841597529 @michaelandrepearce RecoverTest as I added is dealing with Transaction, non TX, Paging, non Paging, large message, non large message, NIO, MAPPED, AIO ... all with combinations.. trying to capture all possible scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597086) Time Spent: 7h 40m (was: 7.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 7h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597084=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597084 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:19 Start Date: 15/May/21 04:19 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#issuecomment-841597351 @michaelandrepearce that's happening on the JournalstorageManager::pageWrite https://github.com/clebertsuconic/activemq-artemis/blob/backup-journal/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java#L410-L427 I'm using the storeAddEvent, using the same record type as the Add Message and addRef. Basically if you recover a message from the "paging area" it will come back to the journal. (at least for now). We could use the same to write to Paging.. or simply do the route to whatever is the best at the time of recovering. But at this version this is always coming back to the journal no matter where it came from. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597084) Time Spent: 7.5h (was: 7h 20m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597083 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:14 Start Date: 15/May/21 04:14 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632892238 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java ## @@ -108,6 +115,7 @@ * * */ public static final double UPDATE_FACTOR; + public static final String BKP = ".bkp"; Review comment: This is for the current journal file. I rename it to BKP, in case the node crashes before the copy is finished, when restarted the copy is finished and the journal name restored. This is for the pending files to be copied from the journal to the BKP area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597083) Time Spent: 7h 20m (was: 7h 10m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597082=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597082
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:13
Start Date: 15/May/21 04:13
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632892149
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -1858,6 +1988,8 @@ public synchronized void compact() throws Exception {
journalLock.writeLock().unlock();
}
+ processBackup();
Review comment:
processBackup() will copy the BKP files to the retention folder.
Before I do the computation I need any BKP files cleared so they can be
treated. So, the backup is before compacting, hence I'm calling processBackup
before compacting here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597082)
Time Spent: 7h 10m (was: 7h)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597080
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:11
Start Date: 15/May/21 04:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632891984
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -2245,6 +2379,155 @@ private synchronized JournalLoadInformation load(final
LoaderCallback loadManage
}
}
+
+ @Override
+ public void processBackupCleanup() {
+ if (journalRetentionFolder != null && (journalRetentionMaxFiles > 0 ||
journalRetentionPeriod > 0)) {
+
+ FilenameFilter fnf = new FilenameFilter() {
+@Override
+public boolean accept(final File file, final String name) {
+ return name != null && name.endsWith("." +
filesRepository.getFileExtension());
+}
+ };
+
+
+ if (journalRetentionPeriod > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+GregorianCalendar calendar = this.calendarThreadLocal.get();
+calendar.setTimeInMillis(System.currentTimeMillis() -
journalRetentionUnit.toMillis(journalRetentionPeriod));
Review comment:
ok.. fair enough.. I can do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597080)
Time Spent: 6h 50m (was: 6h 40m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597081
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 04:11
Start Date: 15/May/21 04:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632892000
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -2245,6 +2379,155 @@ private synchronized JournalLoadInformation load(final
LoaderCallback loadManage
}
}
+
+ @Override
+ public void processBackupCleanup() {
+ if (journalRetentionFolder != null && (journalRetentionMaxFiles > 0 ||
journalRetentionPeriod > 0)) {
+
+ FilenameFilter fnf = new FilenameFilter() {
+@Override
+public boolean accept(final File file, final String name) {
+ return name != null && name.endsWith("." +
filesRepository.getFileExtension());
+}
+ };
+
+
+ if (journalRetentionPeriod > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+GregorianCalendar calendar = this.calendarThreadLocal.get();
+calendar.setTimeInMillis(System.currentTimeMillis() -
journalRetentionUnit.toMillis(journalRetentionPeriod));
+long timeCutOf = calendar.getTimeInMillis();
+
+for (String fileName : fileNames) {
+ long timeOnFile = getDatePortionMillis(fileName);
+ if (timeOnFile < timeCutOf) {
+ logger.debug("File " + fileName + " is too old and should
go");
+ File fileToRemove = new File(journalRetentionFolder,
fileName);
+ if (!fileToRemove.delete()) {
+ logger.debug("Could not remove " + fileToRemove);
+ }
+ }
+}
+ }
+
+ if (journalRetentionMaxFiles > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+if (fileNames.length > journalRetentionMaxFiles) {
+ int toRemove = fileNames.length - journalRetentionMaxFiles;
+
+ for (String file : fileNames) {
+ logger.debug("Removing " + file);
+ File fileToRemove = new File(journalRetentionFolder, file);
+ fileToRemove.delete();
+ toRemove--;
+ if (toRemove <= 0) {
+ break;
+ }
+ }
+}
+ }
+
+
+ }
+ }
+
+ @Override
+ public void processBackup() {
+ if (journalRetentionFolder != null) {
+ ArrayList filesToMove;
+ synchronized (historyPendingFiles) {
+filesToMove = new ArrayList<>(historyPendingFiles.size());
+filesToMove.addAll(historyPendingFiles);
+historyPendingFiles.clear();
+ }
+
+
+ Calendar calendar = calendarThreadLocal.get();
Review comment:
It doesn't make a difference really? the threadLocal is still a
GregorianCalendar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597081)
Time Spent: 7h (was: 6h 50m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597079=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597079 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:10 Start Date: 15/May/21 04:10 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632891935 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/dataformat/JournalAddRecord.java ## @@ -30,32 +30,37 @@ protected final byte recordType; - protected final boolean add; + protected final byte journalType; Review comment: It is... Compatibility tests would be failing if it wasn't. addBytes will write 1 for true, 0 for false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597079) Time Spent: 6h 40m (was: 6.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 6h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597078 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:09 Start Date: 15/May/21 04:09 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632891821 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: the element is journal-retention.. you simply enable it or disable it... I think it is very neat the way it's done now. you just comment this from the xml, and you have it working: ```xml ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597078) Time Spent: 6.5h (was: 6h 20m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 6.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597077 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:07 Start Date: 15/May/21 04:07 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632891635 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + Review comment: it wouldn't be as clear. the XSD is pretty standard.. if you edit the XML with an editor you get auto-completion and self documented. As if you use the schema you use on bytes it would be free form... more error prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597077) Time Spent: 6h 20m (was: 6h 10m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 6h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597076 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:05 Start Date: 15/May/21 04:05 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632891549 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + + + +The location on your file system where the journal-retention will take place. + + + + + + +The amount of time used to keep files. Review comment: I think we should require a period configured. make it large if you wish (365 days e.g) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597076) Time Spent: 6h 10m (was: 6h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 6h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597075 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 04:00 Start Date: 15/May/21 04:00 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#issuecomment-841595400 @clebertsuconic looks good left some comments / queries. On top of that just for my own benefit as i couldnt figure it out, where is it that data that would page is now still written to journal so that we get a pure journal? I see large message was dealt with but couldn't spot records that paged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597075) Time Spent: 6h (was: 5h 50m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 6h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597074 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:53 Start Date: 15/May/21 03:53 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632890542 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java ## @@ -108,6 +115,7 @@ * * */ public static final double UPDATE_FACTOR; + public static final String BKP = ".bkp"; Review comment: If its going to another directory do we really need or even want a suffix on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597074) Time Spent: 5h 50m (was: 5h 40m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 5h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597073
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 03:51
Start Date: 15/May/21 03:51
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632890373
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -1858,6 +1988,8 @@ public synchronized void compact() throws Exception {
journalLock.writeLock().unlock();
}
+ processBackup();
Review comment:
Or am i miss understanding whats going on here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597073)
Time Spent: 5h 40m (was: 5.5h)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597072
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 03:49
Start Date: 15/May/21 03:49
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632890217
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -1858,6 +1988,8 @@ public synchronized void compact() throws Exception {
journalLock.writeLock().unlock();
}
+ processBackup();
Review comment:
I thought during our discussions we want the backup before compaction so
its literally as raw as it gets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597072)
Time Spent: 5.5h (was: 5h 20m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597070
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 03:48
Start Date: 15/May/21 03:48
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632890048
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -2245,6 +2379,155 @@ private synchronized JournalLoadInformation load(final
LoaderCallback loadManage
}
}
+
+ @Override
+ public void processBackupCleanup() {
+ if (journalRetentionFolder != null && (journalRetentionMaxFiles > 0 ||
journalRetentionPeriod > 0)) {
+
+ FilenameFilter fnf = new FilenameFilter() {
+@Override
+public boolean accept(final File file, final String name) {
+ return name != null && name.endsWith("." +
filesRepository.getFileExtension());
+}
+ };
+
+
+ if (journalRetentionPeriod > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+GregorianCalendar calendar = this.calendarThreadLocal.get();
+calendar.setTimeInMillis(System.currentTimeMillis() -
journalRetentionUnit.toMillis(journalRetentionPeriod));
+long timeCutOf = calendar.getTimeInMillis();
+
+for (String fileName : fileNames) {
+ long timeOnFile = getDatePortionMillis(fileName);
+ if (timeOnFile < timeCutOf) {
+ logger.debug("File " + fileName + " is too old and should
go");
+ File fileToRemove = new File(journalRetentionFolder,
fileName);
+ if (!fileToRemove.delete()) {
+ logger.debug("Could not remove " + fileToRemove);
+ }
+ }
+}
+ }
+
+ if (journalRetentionMaxFiles > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+if (fileNames.length > journalRetentionMaxFiles) {
+ int toRemove = fileNames.length - journalRetentionMaxFiles;
+
+ for (String file : fileNames) {
+ logger.debug("Removing " + file);
+ File fileToRemove = new File(journalRetentionFolder, file);
+ fileToRemove.delete();
+ toRemove--;
+ if (toRemove <= 0) {
+ break;
+ }
+ }
+}
+ }
+
+
+ }
+ }
+
+ @Override
+ public void processBackup() {
+ if (journalRetentionFolder != null) {
+ ArrayList filesToMove;
+ synchronized (historyPendingFiles) {
+filesToMove = new ArrayList<>(historyPendingFiles.size());
+filesToMove.addAll(historyPendingFiles);
+historyPendingFiles.clear();
+ }
+
+
+ Calendar calendar = calendarThreadLocal.get();
Review comment:
Why in some places using gregorian and her just plain calendar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597070)
Time Spent: 5h 20m (was: 5h 10m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597069=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597069
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 03:46
Start Date: 15/May/21 03:46
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632889877
##
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##
@@ -2245,6 +2379,155 @@ private synchronized JournalLoadInformation load(final
LoaderCallback loadManage
}
}
+
+ @Override
+ public void processBackupCleanup() {
+ if (journalRetentionFolder != null && (journalRetentionMaxFiles > 0 ||
journalRetentionPeriod > 0)) {
+
+ FilenameFilter fnf = new FilenameFilter() {
+@Override
+public boolean accept(final File file, final String name) {
+ return name != null && name.endsWith("." +
filesRepository.getFileExtension());
+}
+ };
+
+
+ if (journalRetentionPeriod > 0) {
+String[] fileNames = journalRetentionFolder.list(fnf);
+Arrays.sort(fileNames);
+
+GregorianCalendar calendar = this.calendarThreadLocal.get();
+calendar.setTimeInMillis(System.currentTimeMillis() -
journalRetentionUnit.toMillis(journalRetentionPeriod));
Review comment:
Why doing the conversion to ms every time, why not convert to ms just
once all the way up at point of reading config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597069)
Time Spent: 5h 10m (was: 5h)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597066 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:43 Start Date: 15/May/21 03:43 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632889667 ## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/dataformat/JournalAddRecord.java ## @@ -30,32 +30,37 @@ protected final byte recordType; - protected final boolean add; + protected final byte journalType; Review comment: Is this back compatible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597066) Time Spent: 5h (was: 4h 50m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[
https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597065
]
ASF GitHub Bot logged work on ARTEMIS-3297:
---
Author: ASF GitHub Bot
Created on: 15/May/21 03:42
Start Date: 15/May/21 03:42
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632889528
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##
@@ -768,6 +772,45 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
}
}
+
+ private void parseJournalRetention(final Element e, final Configuration
config) {
+ NodeList retention = e.getElementsByTagName("journal-retention");
+
+ if (retention.getLength() != 0) {
+ Element node = (Element) retention.item(0);
+
+ String directory = getAttributeValue(node, "directory");
+ long storageLimit = ByteUtil.convertTextBytes(getAttributeValue(node,
"storage-limit").trim());
+ int period = getAttributeInteger(node, "period", 0,
Validators.GT_ZERO);
+ String unitStr = getAttributeValue(node, "unit");
+
+ TimeUnit unit;
+
+ switch (unitStr) {
+case "DAYS":
+ unit = TimeUnit.DAYS;
+ break;
+case "HOURS":
+ unit = TimeUnit.HOURS;
+ break;
+case "MINUTES":
+ unit = TimeUnit.MINUTES;
+ break;
+case "SECONDS":
+ unit = TimeUnit.SECONDS;
+ break;
+default:
+ unit = TimeUnit.DAYS;
+ }
+
+ config.setJournalRetentionDirectory(directory);
+ config.setJournalRetentionTimeUnit(unit);
Review comment:
So that two args throughout code base dont have to deal with time
conversion and also in more critical code it doesnt have to be converted later
why not convert to ms at point of config load
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 597065)
Time Spent: 4h 50m (was: 4h 40m)
> Journal Retention Feature
> -
>
> Key: ARTEMIS-3297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3297
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Affects Versions: 2.17.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> We should keep historical backup of the journal data, and having tools to
> recover data in case of data loss.
>
> Data loss could mean by unbehaved client's (say you mistakenly acknowledged
> data and your code caused the message to disappear earlier), or even after
> eventual bugs on the broker.
>
> To activate the functionality, you have to specify journal-history-data on
> broker.xml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597064 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:35 Start Date: 15/May/21 03:35 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632888982 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + Review comment: Why is this an attribute but for all other data directories its the element value? Just a consistency thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597064) Time Spent: 4h 40m (was: 4.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597063=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597063 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:33 Start Date: 15/May/21 03:33 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632888143 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + + + +The location on your file system where the journal-retention will take place. + + + + + + +The amount of time used to keep files. Review comment: maybe can use xsd assert to handle more complex checks that at least size or time is set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597063) Time Spent: 4.5h (was: 4h 20m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597062=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597062 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:31 Start Date: 15/May/21 03:31 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632888592 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + Review comment: Also why seperate the unit and the period why not as a single attribute string like for storage where its value and scaler E.g. 2040594944ms360s 4h 7d and if no unit default to ms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597062) Time Spent: 4h 20m (was: 4h 10m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597061=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597061 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:26 Start Date: 15/May/21 03:26 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632888143 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + + + +The location on your file system where the journal-retention will take place. + + + + + + +The amount of time used to keep files. Review comment: maybuscan use xsd assert to handle more complex checks that at least size or time is set and if time that period is set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597061) Time Spent: 4h 10m (was: 4h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597060=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597060 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:21 Start Date: 15/May/21 03:21 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632887693 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + Review comment: Same comment as below what if someone wants to limit just on size -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597060) Time Spent: 4h (was: 3h 50m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597059=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597059 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 15/May/21 03:21 Start Date: 15/May/21 03:21 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632887633 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -675,6 +675,82 @@ + + + + Configuration about the journal retention configuration. + + + + + + +This configures the period type to use on limit. By default it is DAYS. + + + + + + + + + + + + + +The location on your file system where the journal-retention will take place. + + + + + + +The amount of time used to keep files. Review comment: What if someone wants to limit just by size? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597059) Time Spent: 3h 50m (was: 3h 40m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3273) Option to recover messages from the journal
[ https://issues.apache.org/jira/browse/ARTEMIS-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344950#comment-17344950 ] ASF subversion and git services commented on ARTEMIS-3273: -- Commit fe361d3faeba0a8ff12f16a8fed45bb39d4c6cbd in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=fe361d3 ] ARTEMIS-3273 Moving verification of directory > Option to recover messages from the journal > --- > > Key: ARTEMIS-3273 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3273 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > There should be an option on ./artemis data to recover messages from the > journal, ignoring acts, and bringing as many messages as possible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3273) Option to recover messages from the journal
[ https://issues.apache.org/jira/browse/ARTEMIS-3273?focusedWorklogId=597052=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597052 ] ASF GitHub Bot logged work on ARTEMIS-3273: --- Author: ASF GitHub Bot Created on: 15/May/21 02:20 Start Date: 15/May/21 02:20 Worklog Time Spent: 10m Work Description: clebertsuconic merged pull request #3563: URL: https://github.com/apache/activemq-artemis/pull/3563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597052) Time Spent: 1h (was: 50m) > Option to recover messages from the journal > --- > > Key: ARTEMIS-3273 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3273 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > There should be an option on ./artemis data to recover messages from the > journal, ignoring acts, and bringing as many messages as possible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=597004=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597004 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 23:17 Start Date: 14/May/21 23:17 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632855325 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I was going to take it back, but I actually wrote a test to validate the options on the XML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 597004) Time Spent: 3h 40m (was: 3.5h) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596994=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596994 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 23:01 Start Date: 14/May/21 23:01 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632851224 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @michaelandrepearce / @gtully actually.. I take that back... I will do days and hours... I don't have time to test all the options now.. having more code means I would have to test it... If we ever cross a use case of a user needing more granularity we can add it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596994) Time Spent: 3.5h (was: 3h 20m) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-3284) Clarify ordering of elements in broadcast group XML configuration
[
https://issues.apache.org/jira/browse/ARTEMIS-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Étienne Hossack updated ARTEMIS-3284:
-
Summary: Clarify ordering of elements in broadcast group XML configuration
(was: Clarify or remove ordering of elements in broadcast group XML
configuration)
> Clarify ordering of elements in broadcast group XML configuration
> -
>
> Key: ARTEMIS-3284
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3284
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
>Reporter: Étienne Hossack
>Priority: Minor
>
> The XSD requires the elements of the {{}} tags to be in
> order. This is because an {{xsd:sequence}} element is used instead of
> {{xsd:all}}
> It has been so since the HornetQ donation. {{}} [is not
> ordered|https://github.com/apache/activemq-artemis/blob/f491651fdbc911e11c470afb3c0f7f6da1d74063/artemis-server/src/main/resources/schema/artemis-configuration.xsd#L1371].
> Users may encounter cryptic error messages such as the below if they apply
> configuration [as in the
> documentation|https://github.com/apache/activemq-artemis/blame/f491651fdbc911e11c470afb3c0f7f6da1d74063/docs/user-manual/en/clusters.md#L153]
> There are 2 ways forward:
> # Update the documentation, as the current schema is correct.
> We assume the current schema is correct because this allows one to have an
> unbounded number of {{}} elements in broadcast groups
> # Alter the current schema to allow exactly 1 connector ref, and remove the
> ordering constraint.
> I do not have sufficient familiarity with the functionality/intent of
> broadcast groups to recommend the right approach here, but am happy to take
> follow through on either path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARTEMIS-3297) Journal Retention Feature
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-3297: - Summary: Journal Retention Feature (was: Historical Backup of Broker Data) > Journal Retention Feature > - > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596887 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 20:35 Start Date: 14/May/21 20:35 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632787098 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: Hmmm.. this feature could also be used for Disaster and Recovery options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596887) Time Spent: 3h 20m (was: 3h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596879=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596879 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 20:04 Start Date: 14/May/21 20:04 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632767871 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @michaelandrepearce some time ago, I talked to an Architect at my job who wanted to get diffs from the broker and send over to another site from time to time. This kind of feature would be useful for such case maybe? It wouldn't hurt to have it though.. it's just an additional option. I am thinking to have a commented out xml on the broker.xml that will have 7 days, 10G as the config. So if users just uncomment that they will have the 7 days and 10G max disk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596879) Time Spent: 3h 10m (was: 3h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596867 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:37 Start Date: 14/May/21 19:37 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632753627 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: > files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. Initial idea was for it to be coarse as it would be days/weeks retention, intent is to time machine back after say an incident that gets found out after the fact and work out what could have happened. I’m not sure how useful seconds here would be tbh. That said if the value is a long having it just as simple ms like retention is in kafka just simplifies config, everyone is able to convert days/weeks to ms and the we have a simple config, not having to deal with variants -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596867) Time Spent: 3h (was: 2h 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596861 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:34 Start Date: 14/May/21 19:34 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632753627 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: > files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. Initial idea was for it to be coarse as it wood be days/weeks, intent is to time machine back after say an incident that gets found out after the fact and work out what could have happened. I’m not sure how useful seconds here would be tbh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596861) Time Spent: 2h 50m (was: 2h 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596859=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596859 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 19:31 Start Date: 14/May/21 19:31 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632752395 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596859) Time Spent: 2h 40m (was: 2.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596729=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596729 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:58 Start Date: 14/May/21 15:58 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632630456 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: yep, I agree, time and space, probably need both, to limit disk usage in case the time limits is too large. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596729) Time Spent: 2.5h (was: 2h 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596711 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:06 Start Date: 14/May/21 15:06 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item/attribute and a separate files/size based config item/attribute to allow this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596711) Time Spent: 2h 20m (was: 2h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596708=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596708 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:05 Start Date: 14/May/21 15:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item and a files/size based config item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596708) Time Spent: 2h (was: 1h 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596710 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:05 Start Date: 14/May/21 15:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632592880 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: I would suggest a timebased config item and a separate files/size based config item to allow this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596710) Time Spent: 2h 10m (was: 2h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596706=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596706 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 15:03 Start Date: 14/May/21 15:03 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632591760 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: What if you want to limit by files and time at same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596706) Time Spent: 1h 50m (was: 1h 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3296) enable building on Java 16
[ https://issues.apache.org/jira/browse/ARTEMIS-3296?focusedWorklogId=596704=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596704 ] ASF GitHub Bot logged work on ARTEMIS-3296: --- Author: ASF GitHub Bot Created on: 14/May/21 15:01 Start Date: 14/May/21 15:01 Worklog Time Spent: 10m Work Description: gemmellr commented on pull request #3578: URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841298809 Looks like the GitHub Actions build itself is a bit broken (also doing same with a different build, https://github.com/apache/activemq-artemis/actions/runs/842401037). The subjobs were 'starting' (rather than just queued) since I pushed and the 16 job eventually failed seemingly without doing anything. Travis passed for the main repo, and both Travis and GHA and Travis passed for my fork when the the commits were pushed: https://github.com/gemmellr/activemq-artemis/actions/runs/842347976 https://travis-ci.org/github/gemmellr/activemq-artemis/builds/771137254?utm_source=github_status_medium=notification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596704) Time Spent: 1h 20m (was: 1h 10m) > enable building on Java 16 > -- > > Key: ARTEMIS-3296 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3296 > Project: ActiveMQ Artemis > Issue Type: Task >Affects Versions: 2.17.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The maven build currently fails immediately if using Java 16+, first due to > the enforcer plugin not handling the new impl, then various other issues > thereafter. > Many of the build plugins are stale, some being very very old, either from > using the old v18 apache parent or from being explicitly defined in the > artemis root pom. A general refresh should be done to update to more recent > plugin versions, via the current v23 apache parent or otherwise if needing > newer yet versions, and dependencies updated as well as needed to get the > build going on Java 16 (and 17EA). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596701=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596701 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:48 Start Date: 14/May/21 14:48 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632578418 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: period does not work for files: maybe: `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596701) Time Spent: 1h 40m (was: 1.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596700=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596700 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:46 Start Date: 14/May/21 14:46 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632579850 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596700) Time Spent: 1.5h (was: 1h 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596698=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596698 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:44 Start Date: 14/May/21 14:44 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632578418 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: period does not work for files: maybe: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596698) Time Spent: 1h 20m (was: 1h 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596684=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596684 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 14:26 Start Date: 14/May/21 14:26 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632565882 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: files is good if you care about you max disk usage. But I think for time, hours is too coarse. and seconds covers everything up to hours nicely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596684) Time Spent: 1h 10m (was: 1h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344619#comment-17344619 ] ASF subversion and git services commented on ARTEMIS-3295: -- Commit a34d9aad6bb4f19678c12bddedda5a37509e2cf0 in activemq-artemis's branch refs/heads/main from Andy Taylor [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a34d9aa ] ARTEMIS-3295 - do not cluster advisories https://issues.apache.org/jira/browse/ARTEMIS-3295 > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344618#comment-17344618 ] ASF subversion and git services commented on ARTEMIS-3295: -- Commit a34d9aad6bb4f19678c12bddedda5a37509e2cf0 in activemq-artemis's branch refs/heads/main from Andy Taylor [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a34d9aa ] ARTEMIS-3295 - do not cluster advisories https://issues.apache.org/jira/browse/ARTEMIS-3295 > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596678 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 14:08 Start Date: 14/May/21 14:08 Worklog Time Spent: 10m Work Description: clebertsuconic merged pull request #3582: URL: https://github.com/apache/activemq-artemis/pull/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596678) Time Spent: 1h 10m (was: 1h) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3296) enable building on Java 16
[ https://issues.apache.org/jira/browse/ARTEMIS-3296?focusedWorklogId=596667=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596667 ] ASF GitHub Bot logged work on ARTEMIS-3296: --- Author: ASF GitHub Bot Created on: 14/May/21 13:52 Start Date: 14/May/21 13:52 Worklog Time Spent: 10m Work Description: gemmellr commented on pull request #3578: URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841258075 Added another commit with changes to hopefully address that. I dropped the Apache DS dep back 1 version (meaning it went from M15 originally up to 25 now, instead of 26) to remove the more general issue it added that was affecting the multiple existing tests. That issue has been fixed towards the next DS release but they have just removed [1] other functionality the test is using from it, so that release isnt going to be an option and the test will need removed/redone in future. With that problem resolved, there was indeed a test-specific issue remaining with that second kerberos on JDK16 needing addressed, with its access of classes now guarded since JDK16, so I added an export for that to let it run and it now passed locally. [1]https://github.com/apache/directory-server/commit/bb6db861681951c930941ed4bb92fd358fa333ec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596667) Time Spent: 1h 10m (was: 1h) > enable building on Java 16 > -- > > Key: ARTEMIS-3296 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3296 > Project: ActiveMQ Artemis > Issue Type: Task >Affects Versions: 2.17.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The maven build currently fails immediately if using Java 16+, first due to > the enforcer plugin not handling the new impl, then various other issues > thereafter. > Many of the build plugins are stale, some being very very old, either from > using the old v18 apache parent or from being explicitly defined in the > artemis root pom. A general refresh should be done to update to more recent > plugin versions, via the current v23 apache parent or otherwise if needing > newer yet versions, and dependencies updated as well as needed to get the > build going on Java 16 (and 17EA). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596641=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596641 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 13:18 Start Date: 14/May/21 13:18 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3582: URL: https://github.com/apache/activemq-artemis/pull/3582#issuecomment-841238462 This is a tweak on top of #3581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596641) Time Spent: 1h (was: 50m) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596639=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596639 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 13:10 Start Date: 14/May/21 13:10 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #3581: URL: https://github.com/apache/activemq-artemis/pull/3581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596639) Time Spent: 50m (was: 40m) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596638=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596638 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 13:10 Start Date: 14/May/21 13:10 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3581: URL: https://github.com/apache/activemq-artemis/pull/3581#issuecomment-841234165 superseded by #3582 I did a small tweak to the code instead of asking you to do it.. @andytaylor you're still the author of the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596638) Time Spent: 40m (was: 0.5h) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596636 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 13:08 Start Date: 14/May/21 13:08 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request #3582: URL: https://github.com/apache/activemq-artemis/pull/3582 https://issues.apache.org/jira/browse/ARTEMIS-3295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596636) Time Spent: 0.5h (was: 20m) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596633 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:58 Start Date: 14/May/21 12:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508629 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @gtully I thought about using max-files for such cases.. Humans are usually slow to react... .. perhaps we could have this ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596633) Time Spent: 1h (was: 50m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596631=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596631 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:57 Start Date: 14/May/21 12:57 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508629 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: @gtully I thought about using max-files for such cases.. Humans are usually slow to react... .. perhaps we could have this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596631) Time Spent: 40m (was: 0.5h) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 40m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596632 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 12:57 Start Date: 14/May/21 12:57 Worklog Time Spent: 10m Work Description: clebertsuconic commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632508846 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java ## @@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key, */ Configuration setJournalDirectory(String dir); + String getJournalHistory(); + + File getJournalHistoryLocation(); + + /** +* Sets the file system directory used to store historical backup journal. +*/ + Configuration setJournalHistory(String dir); + + int getJournalHistoryMaxDays(); + + Configuration setJournalHistoryMaxDays(int days); Review comment: Oooo... I like the name retention!!! Really nice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596632) Time Spent: 50m (was: 40m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 50m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596622 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 12:44 Start Date: 14/May/21 12:44 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #3581: URL: https://github.com/apache/activemq-artemis/pull/3581#issuecomment-841219815 I am sending a small tweak into this. Instead of passing the List as a reference everywhere, it would be simpler to just read from ClusterManager. The list is passed as a reference and if you change the source you also change on the passed reference. I think it could eventually be confusing. Instead I am just adding a getter on ClusterManager and reading from the source every time is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596622) Time Spent: 20m (was: 10m) > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3038) Investigate CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite
[ https://issues.apache.org/jira/browse/ARTEMIS-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344561#comment-17344561 ] Gary Tully commented on ARTEMIS-3038: - I think unwound and removed is best, there is little point in having untest code in the mix and there is probably a small performance gain on accepting connections to be had with the code removed. > Investigate > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite > --- > > Key: ARTEMIS-3038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3038 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Assignee: Gary Tully >Priority: Major > > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite is > failing because of: > > [https://www.oracle.com/security-alerts/poodlecve-2014-3566.html] > > I set the test with an ignore .. until we investigate what we should do. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3296) enable building on Java 16
[ https://issues.apache.org/jira/browse/ARTEMIS-3296?focusedWorklogId=596611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596611 ] ASF GitHub Bot logged work on ARTEMIS-3296: --- Author: ASF GitHub Bot Created on: 14/May/21 11:55 Start Date: 14/May/21 11:55 Worklog Time Spent: 10m Work Description: gemmellr edited a comment on pull request #3578: URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841196705 Irony..part of the changes made in #3579 (which I just merged) to get some Kerberos tests working on JDK11+, does not work on 16 and an updated dep has also stopped other existing related tests that are in the PR build from succeeding on JDK16 so that bit of the build failed after I rebased this. I shall begin investigating relevant module access config or test exclusion workarounds :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596611) Time Spent: 1h (was: 50m) > enable building on Java 16 > -- > > Key: ARTEMIS-3296 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3296 > Project: ActiveMQ Artemis > Issue Type: Task >Affects Versions: 2.17.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > The maven build currently fails immediately if using Java 16+, first due to > the enforcer plugin not handling the new impl, then various other issues > thereafter. > Many of the build plugins are stale, some being very very old, either from > using the old v18 apache parent or from being explicitly defined in the > artemis root pom. A general refresh should be done to update to more recent > plugin versions, via the current v23 apache parent or otherwise if needing > newer yet versions, and dependencies updated as well as needed to get the > build going on Java 16 (and 17EA). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3296) enable building on Java 16
[ https://issues.apache.org/jira/browse/ARTEMIS-3296?focusedWorklogId=596610=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596610 ] ASF GitHub Bot logged work on ARTEMIS-3296: --- Author: ASF GitHub Bot Created on: 14/May/21 11:54 Start Date: 14/May/21 11:54 Worklog Time Spent: 10m Work Description: gemmellr commented on pull request #3578: URL: https://github.com/apache/activemq-artemis/pull/3578#issuecomment-841196705 Irony..part of the changes made in #3579 (which I just merged) to get some Kerberos tests working on JDK11+, does not work on 16 and an updated dep has also stopped other tests running on JDK16 that are in the PR build.. I shall begin investigating relevant module access config or test exclusion workarounds now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596610) Time Spent: 50m (was: 40m) > enable building on Java 16 > -- > > Key: ARTEMIS-3296 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3296 > Project: ActiveMQ Artemis > Issue Type: Task >Affects Versions: 2.17.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The maven build currently fails immediately if using Java 16+, first due to > the enforcer plugin not handling the new impl, then various other issues > thereafter. > Many of the build plugins are stale, some being very very old, either from > using the old v18 apache parent or from being explicitly defined in the > artemis root pom. A general refresh should be done to update to more recent > plugin versions, via the current v23 apache parent or otherwise if needing > newer yet versions, and dependencies updated as well as needed to get the > build going on Java 16 (and 17EA). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3038) Investigate CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite
[ https://issues.apache.org/jira/browse/ARTEMIS-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344536#comment-17344536 ] Robbie Gemmell commented on ARTEMIS-3038: - I am leaving this Jira open regardless of removing the test though, for consideration of whether any of the (more substantial than expected) non-test-class changes from ARTEMIS-1264 should be left in place as they have so far, or actually be unwound and removed as well considering they are entirely untested, unusable either by default (Java 8) or at all (Java 11+) on any recent JVM, and long not recommended for use. > Investigate > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite > --- > > Key: ARTEMIS-3038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3038 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Assignee: Gary Tully >Priority: Major > > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite is > failing because of: > > [https://www.oracle.com/security-alerts/poodlecve-2014-3566.html] > > I set the test with an ignore .. until we investigate what we should do. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3038) Investigate CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite
[ https://issues.apache.org/jira/browse/ARTEMIS-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344535#comment-17344535 ] Robbie Gemmell commented on ARTEMIS-3038: - I removed the test class and a related exclusion in the above commit just to tidy out ARTEMIS-2813 fully, given the test couldn't be run currently and all discussion here was toward removing it. > Investigate > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite > --- > > Key: ARTEMIS-3038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3038 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Assignee: Gary Tully >Priority: Major > > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite is > failing because of: > > [https://www.oracle.com/security-alerts/poodlecve-2014-3566.html] > > I set the test with an ignore .. until we investigate what we should do. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344534#comment-17344534 ] Robbie Gemmell commented on ARTEMIS-2813: - I tried out and merged your PR changes, worked well. I have additionally now removed the third test which had been excluded via this Jira (for its own separate reasons) since ARTEMIS-3038 discussion had already established it should be removed. > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-3038) Investigate CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite
[ https://issues.apache.org/jira/browse/ARTEMIS-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344532#comment-17344532 ] ASF subversion and git services commented on ARTEMIS-3038: -- Commit a3de3d4c75ba1482706e8c42a5c9b0f9811901eb in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a3de3d4 ] ARTEMIS-3038, ARTEMIS-2813: remove the CoreClientOverOneWaySSLKerb5Test test class - It is already entirely disabled one or more ways depending on what JVM is in use. - If enabled on any modern JVM it would either fail by default or can never work, as the related ciphers it requires have been disabled (8) or entirely removed (11+) due to being considered unsuitable for use. > Investigate > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite > --- > > Key: ARTEMIS-3038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3038 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Assignee: Gary Tully >Priority: Major > > CoreClientOverOneWaySSLKerb5Test#testOneWaySSLWithGoodClientCipherSuite is > failing because of: > > [https://www.oracle.com/security-alerts/poodlecve-2014-3566.html] > > I set the test with an ignore .. until we investigate what we should do. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344533#comment-17344533 ] ASF subversion and git services commented on ARTEMIS-2813: -- Commit a3de3d4c75ba1482706e8c42a5c9b0f9811901eb in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a3de3d4 ] ARTEMIS-3038, ARTEMIS-2813: remove the CoreClientOverOneWaySSLKerb5Test test class - It is already entirely disabled one or more ways depending on what JVM is in use. - If enabled on any modern JVM it would either fail by default or can never work, as the related ciphers it requires have been disabled (8) or entirely removed (11+) due to being considered unsuitable for use. > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-2813. - Resolution: Fixed > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?focusedWorklogId=596584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596584 ] ASF GitHub Bot logged work on ARTEMIS-2813: --- Author: ASF GitHub Bot Created on: 14/May/21 10:07 Start Date: 14/May/21 10:07 Worklog Time Spent: 10m Work Description: gemmellr commented on pull request #3579: URL: https://github.com/apache/activemq-artemis/pull/3579#issuecomment-841148179 Looks good, ran the tests on 8 and 11 without issue. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596584) Time Spent: 0.5h (was: 20m) > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?focusedWorklogId=596583=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596583 ] ASF GitHub Bot logged work on ARTEMIS-2813: --- Author: ASF GitHub Bot Created on: 14/May/21 10:05 Start Date: 14/May/21 10:05 Worklog Time Spent: 10m Work Description: asfgit closed pull request #3579: URL: https://github.com/apache/activemq-artemis/pull/3579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596583) Time Spent: 20m (was: 10m) > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344508#comment-17344508 ] ASF subversion and git services commented on ARTEMIS-2813: -- Commit 9e70b263686ad6f0445eecf0e98dbcbf73833302 in activemq-artemis's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=9e70b26 ] ARTEMIS-2813 Fix SaslKrb5LDAPSecurityTest failing on JDK 11 Fixes issues with SaslKrb5LDAPSecurityTest by updating to latest Apache Directory release which required some updates to the test to fix deprecation warnings and an updates to commons.lang to fix issues with new namespace for StringUtils that will work on JDK 8+ only. > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344507#comment-17344507 ] ASF subversion and git services commented on ARTEMIS-2813: -- Commit 9513405020b413cd182d8b819572bb050223984a in activemq-artemis's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=9513405 ] ARTEMIS-2813 Update MiniKDC and fix Kerberos tests on JDK 11+ Updates the MiniKDC dependency and adds another now needed dep in order to get the Kerberos tests working on JDK 11+ builds. > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated ARTEMIS-2813: Fix Version/s: 2.18.0 > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated ARTEMIS-2813: Affects Version/s: 2.15.0 2.16.0 2.17.0 > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARTEMIS-2813) Kerberos tests failures on Java 11
[ https://issues.apache.org/jira/browse/ARTEMIS-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned ARTEMIS-2813: --- Assignee: Timothy A. Bish > Kerberos tests failures on Java 11 > -- > > Key: ARTEMIS-2813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2813 > Project: ActiveMQ Artemis > Issue Type: Test > Components: AMQP >Affects Versions: 2.14.0 >Reporter: Robbie Gemmell >Assignee: Timothy A. Bish >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Kerberos tests in JMSSaslGssapiTest and SaslKrb5LDAPSecurityTest class > fail on Java 11. It isn't obvious that there is any issue here outside of the > Kerberos test harness bits themselves which are rather old, but not easily > updated as they have changed, so the tests will currently only be run on JDK8 > until such time as they can be made to work elsewhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3295) Openwire advisories are clustered
[ https://issues.apache.org/jira/browse/ARTEMIS-3295?focusedWorklogId=596544=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596544 ] ASF GitHub Bot logged work on ARTEMIS-3295: --- Author: ASF GitHub Bot Created on: 14/May/21 08:14 Start Date: 14/May/21 08:14 Worklog Time Spent: 10m Work Description: andytaylor opened a new pull request #3581: URL: https://github.com/apache/activemq-artemis/pull/3581 https://issues.apache.org/jira/browse/ARTEMIS-3295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596544) Remaining Estimate: 0h Time Spent: 10m > Openwire advisories are clustered > - > > Key: ARTEMIS-3295 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3295 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.17.0 >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > These should not be clustered as they arent in ActiveMQ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596540 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 07:58 Start Date: 14/May/21 07:58 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632352294 ## File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml ## @@ -406,6 +406,9 @@ 17 true somedir2 + history Review comment: this config looks neat, but I think "journal-retention" is a better name, and I think in high volume scenarios second granularity will be necessary to capture use cases less than days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596540) Time Spent: 0.5h (was: 20m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3297) Historical Backup of Broker Data
[ https://issues.apache.org/jira/browse/ARTEMIS-3297?focusedWorklogId=596538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596538 ] ASF GitHub Bot logged work on ARTEMIS-3297: --- Author: ASF GitHub Bot Created on: 14/May/21 07:51 Start Date: 14/May/21 07:51 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3580: URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632350082 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/Configuration.java ## @@ -668,6 +668,25 @@ Configuration addDiscoveryGroupConfiguration(String key, */ Configuration setJournalDirectory(String dir); + String getJournalHistory(); + + File getJournalHistoryLocation(); + + /** +* Sets the file system directory used to store historical backup journal. +*/ + Configuration setJournalHistory(String dir); + + int getJournalHistoryMaxDays(); + + Configuration setJournalHistoryMaxDays(int days); Review comment: This is a neat feature. I think I would call it something else from a configuration perspective. journalRetention or just retention configured with a: int retentionLimit > 0 enum retentionUnit (seconds/days/numFiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 596538) Time Spent: 20m (was: 10m) > Historical Backup of Broker Data > > > Key: ARTEMIS-3297 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3297 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.17.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.18.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We should keep historical backup of the journal data, and having tools to > recover data in case of data loss. > > Data loss could mean by unbehaved client's (say you mistakenly acknowledged > data and your code caused the message to disappear earlier), or even after > eventual bugs on the broker. > > To activate the functionality, you have to specify journal-history-data on > broker.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AMQ-8266) ActiveMQ broker has two master when nfs server restart
[ https://issues.apache.org/jira/browse/AMQ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344357#comment-17344357 ] chenxianpao commented on AMQ-8266: -- Hello [~jbonofre] I use nfs4.1 protocol, it is the lease locker. I have tried the sync mount option, the same problem. > ActiveMQ broker has two master when nfs server restart > -- > > Key: AMQ-8266 > URL: https://issues.apache.org/jira/browse/AMQ-8266 > Project: ActiveMQ > Issue Type: Bug > Components: AMQP >Affects Versions: 5.16.1 > Environment: activeMQ version:5.16.1 > linux OS version：CentOS7 kernel: 3.10.0-1160.21.1.el7.x86_64 > deploy: three server node, one master two slave. >Reporter: chenxianpao >Priority: Major > > we use nfs-ganesha(ceph) to provide shared file system, enable active and > standby nfs-ganesha to provide services through vip. > when we restart active nfs-ganesha server, vip migrate to the standby > nfs-ganesha, one of activemq will become master, but the original master will > not become a slave, so there will be two master activemq, a cluster will be > divided into two. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (AMQ-8266) ActiveMQ broker has two master when nfs server restart
[
https://issues.apache.org/jira/browse/AMQ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenxianpao updated AMQ-8266:
-
Comment: was deleted
(was: [~jbonofre]
Hello!
I use nfs4.1 protocol, it is the lease locker.
I have tried the sync mount option, the same problem.
I have found that the locked flag actually already is false in the original
node, because the timestamp of lock file has changed, but it didn't throw an
exception. Anothoer node can obtain file lock normally.
I don't know Java very well, should the original node throw an exception when
it detects that the lock file timestamp has changed?
{code:java}
//代码占位符
try {
lockFile.lock();
if (warned) {
// ensure lockHolder has released; wait for one keepAlive iteration
try {
TimeUnit.MILLISECONDS.sleep(lockable != null ?
lockable.getLockKeepAlivePeriod() : 0l);
} catch (InterruptedException e1) {
}
}
locked = keepAlive();
break;
} catch (IOException e) {
if (!warned)
{
LOG.info("Database "
+ lockFileName
+ " is locked by another server. This broker is now in
slave mode waiting a lock to be acquired");
warned = true;
}
...
}{code})
> ActiveMQ broker has two master when nfs server restart
> --
>
> Key: AMQ-8266
> URL: https://issues.apache.org/jira/browse/AMQ-8266
> Project: ActiveMQ
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 5.16.1
> Environment: activeMQ version:5.16.1
> linux OS version：CentOS7 kernel: 3.10.0-1160.21.1.el7.x86_64
> deploy: three server node, one master two slave.
>Reporter: chenxianpao
>Priority: Major
>
> we use nfs-ganesha(ceph) to provide shared file system, enable active and
> standby nfs-ganesha to provide services through vip.
> when we restart active nfs-ganesha server, vip migrate to the standby
> nfs-ganesha, one of activemq will become master, but the original master will
> not become a slave, so there will be two master activemq, a cluster will be
> divided into two.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AMQ-8266) ActiveMQ broker has two master when nfs server restart
[
https://issues.apache.org/jira/browse/AMQ-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344353#comment-17344353
]
chenxianpao commented on AMQ-8266:
--
[~jbonofre]
Hello!
I use nfs4.1 protocol, it is the lease locker.
I have tried the sync mount option, the same problem.
I have found that the locked flag actually already is false in the original
node, because the timestamp of lock file has changed, but it didn't throw an
exception. Anothoer node can obtain file lock normally.
I don't know Java very well, should the original node throw an exception when
it detects that the lock file timestamp has changed?
{code:java}
//代码占位符
try {
lockFile.lock();
if (warned) {
// ensure lockHolder has released; wait for one keepAlive iteration
try {
TimeUnit.MILLISECONDS.sleep(lockable != null ?
lockable.getLockKeepAlivePeriod() : 0l);
} catch (InterruptedException e1) {
}
}
locked = keepAlive();
break;
} catch (IOException e) {
if (!warned)
{
LOG.info("Database "
+ lockFileName
+ " is locked by another server. This broker is now in
slave mode waiting a lock to be acquired");
warned = true;
}
...
}{code}
> ActiveMQ broker has two master when nfs server restart
> --
>
> Key: AMQ-8266
> URL: https://issues.apache.org/jira/browse/AMQ-8266
> Project: ActiveMQ
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 5.16.1
> Environment: activeMQ version:5.16.1
> linux OS version：CentOS7 kernel: 3.10.0-1160.21.1.el7.x86_64
> deploy: three server node, one master two slave.
>Reporter: chenxianpao
>Priority: Major
>
> we use nfs-ganesha(ceph) to provide shared file system, enable active and
> standby nfs-ganesha to provide services through vip.
> when we restart active nfs-ganesha server, vip migrate to the standby
> nfs-ganesha, one of activemq will become master, but the original master will
> not become a slave, so there will be two master activemq, a cluster will be
> divided into two.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
