[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645650#comment-16645650 ] ASF GitHub Bot commented on ARTEMIS-2110: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641689#comment-16641689 ] ASF GitHub Bot commented on ARTEMIS-2110: - Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641690#comment-16641690 ] ASF GitHub Bot commented on ARTEMIS-2110: - GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock You can merge this pull request into a Git repository by running: $ git pull https://github.com/gtully/activemq-artemis ARTEMIS-2110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2346 commit 2e96d9b5ccc8fdbf0081ebb0df8c6a4a81663d34 Author: gtully Date: 2018-10-05T11:10:56Z ARTEMIS-1684 - don't build the -web module due to the node and gitbook dependency for travis ci commit 0963c3fd6bda6f8295c3aeeb15764fa99c6d5822 Author: gtully Date: 2018-10-04T15:47:16Z ARTEMIS-2110 allow a lease renew without update to the expiry timestamp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639682#comment-16639682 ] ASF GitHub Bot commented on ARTEMIS-2110: - Github user gtully closed the pull request at: https://github.com/apache/activemq-artemis/pull/2346 > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639683#comment-16639683 ] ASF GitHub Bot commented on ARTEMIS-2110: - GitHub user gtully reopened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock You can merge this pull request into a Git repository by running: $ git pull https://github.com/gtully/activemq-artemis ARTEMIS-2110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2346 commit ddf0cac2d7531dc49484c283a7f4cbe44d8e278e Author: gtully Date: 2018-10-04T15:47:16Z ARTEMIS-2110 allow a lease renew without update to the expiry timestamp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639658#comment-16639658 ] ASF GitHub Bot commented on ARTEMIS-2110: - Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 seems building the web site is the crux. it can be disabled with: mvn -Pfast-tests -Pextra-tests -B install -q -pl '!artemis-web' > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639567#comment-16639567 ] ASF GitHub Bot commented on ARTEMIS-2110: - Github user gtully commented on the issue: https://github.com/apache/activemq-artemis/pull/2346 The ci build failure seems may be related to the doc generation... there is no output for 10 mins and a termination after 42 mins: --- T E S T S --- Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Running org.apache.activemq.cli.test.WebServerComponentTest SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [main] 15:57:20,526 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 15:57:21,519 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 [main] 15:57:21,967 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 15:57:22,496 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.288 sec - in org.apache.activemq.cli.test.WebServerComponentTest Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated -- on a local build that runs to completion I see: [ERROR] Error fetching link: but it does not block for any more than one minute. Something needs to be tweaked, any ideas? --- T E S T S --- Running org.apache.activemq.cli.test.WebServerComponentTest SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. [main] 14:35:40,755 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 14:35:41,098 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 [main] 14:35:41,264 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at http://localhost:0 [main] 14:35:41,524 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server started at https://localhost:0 Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.22 sec - in org.apache.activemq.cli.test.WebServerComponentTest Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-core-client/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-selector/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-jms-client/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-journal/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-server/target/apidocs/package-list. Ignored it. [ERROR] Error fetching link: /Users/gtully/code/activemq-artemis-two/artemis-jms-server/target/apidocs/package-list. Ignored it. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. There may be some insight in that diff as to why the build fails. > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components:
[jira] [Commented] (ARTEMIS-2110) JDBC LeaseLocker repeated renew or renew after aquire can fail in error
[ https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638408#comment-16638408 ] ASF GitHub Bot commented on ARTEMIS-2110: - GitHub user gtully opened a pull request: https://github.com/apache/activemq-artemis/pull/2346 ARTEMIS-2110 allow a lease renew without update to the expiry timesta… …mp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock You can merge this pull request into a Git repository by running: $ git pull https://github.com/gtully/activemq-artemis ARTEMIS-2110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2346 commit ddf0cac2d7531dc49484c283a7f4cbe44d8e278e Author: gtully Date: 2018-10-04T15:47:16Z ARTEMIS-2110 allow a lease renew without update to the expiry timestamp. Fix intermittent failure of org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > JDBC LeaseLocker repeated renew or renew after aquire can fail in error > --- > > Key: ARTEMIS-2110 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2110 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Minor > Fix For: 2.7.0 > > > There is an intermittent failure in: > org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock > (seems to block pr ci, and reproduced for me 20% of the time) > if the db currentTime has not moved on, using the same lease time results in > a failure. A renew immediately after acquiring the lock is a sensible pattern > to verify the aquire. > > The lock renew needs >= in place or > on the WHERE clause to allow an > 'identity' lease to succeed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
