[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892356 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 14:19 Start Date: 27/Nov/23 14:19 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1827924148 I am marking this as draft as I will refactor the journal record where I'm using a JSON object to be reused for other cases. Issue Time Tracking --- Worklog Id: (was: 892356) Time Spent: 1h (was: 50m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892357 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 14:21 Start Date: 27/Nov/23 14:21 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1827928209 hmmm... actually I will not do that.. but I will still change the Address and Queue records to use the JSON object format. Issue Time Tracking --- Worklog Id: (was: 892357) Time Spent: 1h 10m (was: 1h) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[
https://issues.apache.org/jira/browse/ARTEMIS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on ARTEMIS-4187 started by Jelmer Marinus.
---
> SizeAwareMetric attribute inconsistency
> ---
>
> Key: ARTEMIS-4187
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4187
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0
>Reporter: Jelmer Marinus
>Assignee: Jelmer Marinus
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The SizeAwareMetric can be in an inconsistent state due to conflicting
> attribute values.
> [maxSize vs.sizeEnabled]
> sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize
> is set to -1 sizeEnabled is going to be set to false to indicate that no size
> checking is required. However because of the two seperate attributes they are
> inconsistent for a short period of time. This is most prevelant in the follow
> code from the SizeAwareMetric itself:
> {code:java}
> public void setMax(long maxSize, long lowerMarkSize, long maxElements, long
> lowerMarkElements) {
>this.maxSize = maxSize;
>this.lowerMarkSize = lowerMarkSize;
>this.maxElements = maxElements;
>this.lowerMarkElements = lowerMarkElements;
>long currentSize = sizeUpdater.get(this);
>long currentElements = elementsUpdater.get(this);
>checkOver(currentElements, currentSize);
>checkUnder(currentElements, currentSize);
> } {code}
> This code sets the maxSize but leaves sizeEnabled as it is. As a consequence
> the checkOver and checkUnder can be executed with maxSize and sizeEnabled in
> an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected
> over/under conditions and unexpected paging behaviour.
> The same is true for maxElement vs. elementsEnabled.
> [maxSize vs. lowerMarkSize]
> MaxSize is checked >= to the current size and lowerMarkSize is check <=
> current size. When maxSize = lowerMarkSize = current size it is a bit
> "unclear" if there is and under or over situation.
> The same is true for maxElements vs. lowerMarkElements I believe.
> This is a minor/cosmetic issue.
>
> I will issue a PR for both.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work stopped] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[
https://issues.apache.org/jira/browse/ARTEMIS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on ARTEMIS-4187 stopped by Jelmer Marinus.
---
> SizeAwareMetric attribute inconsistency
> ---
>
> Key: ARTEMIS-4187
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4187
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0
>Reporter: Jelmer Marinus
>Assignee: Jelmer Marinus
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The SizeAwareMetric can be in an inconsistent state due to conflicting
> attribute values.
> [maxSize vs.sizeEnabled]
> sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize
> is set to -1 sizeEnabled is going to be set to false to indicate that no size
> checking is required. However because of the two seperate attributes they are
> inconsistent for a short period of time. This is most prevelant in the follow
> code from the SizeAwareMetric itself:
> {code:java}
> public void setMax(long maxSize, long lowerMarkSize, long maxElements, long
> lowerMarkElements) {
>this.maxSize = maxSize;
>this.lowerMarkSize = lowerMarkSize;
>this.maxElements = maxElements;
>this.lowerMarkElements = lowerMarkElements;
>long currentSize = sizeUpdater.get(this);
>long currentElements = elementsUpdater.get(this);
>checkOver(currentElements, currentSize);
>checkUnder(currentElements, currentSize);
> } {code}
> This code sets the maxSize but leaves sizeEnabled as it is. As a consequence
> the checkOver and checkUnder can be executed with maxSize and sizeEnabled in
> an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected
> over/under conditions and unexpected paging behaviour.
> The same is true for maxElement vs. elementsEnabled.
> [maxSize vs. lowerMarkSize]
> MaxSize is checked >= to the current size and lowerMarkSize is check <=
> current size. When maxSize = lowerMarkSize = current size it is a bit
> "unclear" if there is and under or over situation.
> The same is true for maxElements vs. lowerMarkElements I believe.
> This is a minor/cosmetic issue.
>
> I will issue a PR for both.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4187) SizeAwareMetric attribute inconsistency
[
https://issues.apache.org/jira/browse/ARTEMIS-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790117#comment-17790117
]
Jelmer Marinus commented on ARTEMIS-4187:
-
[~jbertram] this PR has been open for a while. Do you expect anymore work from
my side ??
> SizeAwareMetric attribute inconsistency
> ---
>
> Key: ARTEMIS-4187
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4187
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.26.0, 2.27.0, 2.27.1, 2.28.0
>Reporter: Jelmer Marinus
>Assignee: Jelmer Marinus
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The SizeAwareMetric can be in an inconsistent state due to conflicting
> attribute values.
> [maxSize vs.sizeEnabled]
> sizeEnabled is defined as `maxSize >= 0`. This i.e. means that when maxSize
> is set to -1 sizeEnabled is going to be set to false to indicate that no size
> checking is required. However because of the two seperate attributes they are
> inconsistent for a short period of time. This is most prevelant in the follow
> code from the SizeAwareMetric itself:
> {code:java}
> public void setMax(long maxSize, long lowerMarkSize, long maxElements, long
> lowerMarkElements) {
>this.maxSize = maxSize;
>this.lowerMarkSize = lowerMarkSize;
>this.maxElements = maxElements;
>this.lowerMarkElements = lowerMarkElements;
>long currentSize = sizeUpdater.get(this);
>long currentElements = elementsUpdater.get(this);
>checkOver(currentElements, currentSize);
>checkUnder(currentElements, currentSize);
> } {code}
> This code sets the maxSize but leaves sizeEnabled as it is. As a consequence
> the checkOver and checkUnder can be executed with maxSize and sizeEnabled in
> an inconsistent state, i.e. -1 and true. This can in turn lead to unexpected
> over/under conditions and unexpected paging behaviour.
> The same is true for maxElement vs. elementsEnabled.
> [maxSize vs. lowerMarkSize]
> MaxSize is checked >= to the current size and lowerMarkSize is check <=
> current size. When maxSize = lowerMarkSize = current size it is a bit
> "unclear" if there is and under or over situation.
> The same is true for maxElements vs. lowerMarkElements I believe.
> This is a minor/cosmetic issue.
>
> I will issue a PR for both.
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892363 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 15:09 Start Date: 27/Nov/23 15:09 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683#issuecomment-1828019781 I gave up on the idea. I was going to write a meta-record..which would simplify usage, but it would probably increase memory of the broker if those settings are over-used. so I'm giving up the idea. Issue Time Tracking --- Worklog Id: (was: 892363) Time Spent: 1h 20m (was: 1h 10m) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892364
]
ASF GitHub Bot logged work on ARTEMIS-4513:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 15:12
Start Date: 27/Nov/23 15:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406312534
##
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("GC Daemon")) {
return true;
+ } else if
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {
Review Comment:
Isn't this hiding a thread leakage? can't we just close the thread instead?
Issue Time Tracking
---
Worklog Id: (was: 892364)
Time Spent: 20m (was: 10m)
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892365
]
ASF GitHub Bot logged work on ARTEMIS-4513:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 15:13
Start Date: 27/Nov/23 15:13
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406313760
##
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("GC Daemon")) {
return true;
+ } else if
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {
Review Comment:
Or move this test to the isolated tests if you can't figure out how to close
the thread.
Issue Time Tracking
---
Worklog Id: (was: 892365)
Time Spent: 0.5h (was: 20m)
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892366
]
ASF GitHub Bot logged work on ARTEMIS-4513:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 15:15
Start Date: 27/Nov/23 15:15
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406315823
##
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("GC Daemon")) {
return true;
+ } else if
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {
Review Comment:
I don't mean to move the whole test into integration-tests-isolated. but
rather write just this test into the isolated package..
This is definitely causing a thread leakage.. and this thread could be
bothering other tests.
I strongly recommend against it.
Issue Time Tracking
---
Worklog Id: (was: 892366)
Time Spent: 40m (was: 0.5h)
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully reassigned ARTEMIS-4164: --- Assignee: Gary Tully > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Time Spent: 0.5h > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but we can have a autoReload config option > to disable it but it may be sufficient to depend on the file watch period to > disable this feature? > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4514) Make Jetty thread pool configurable
Justin Bertram created ARTEMIS-4514:
---
Summary: Make Jetty thread pool configurable
Key: ARTEMIS-4514
URL: https://issues.apache.org/jira/browse/ARTEMIS-4514
Project: ActiveMQ Artemis
Issue Type: Improvement
Reporter: Justin Bertram
Assignee: Justin Bertram
Allow the thread pool used by Jetty to be configured via {{bootstrap.xml}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892378
]
ASF GitHub Bot logged work on ARTEMIS-4513:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 15:50
Start Date: 27/Nov/23 15:50
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406373246
##
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("GC Daemon")) {
return true;
+ } else if
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {
Review Comment:
The thread is specific to the HTTP request logging from Jetty. Looking at
the Jetty source code there appears to be no way to close it. I'll move the
test into the isolated module.
Issue Time Tracking
---
Worklog Id: (was: 892378)
Time Spent: 50m (was: 40m)
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?focusedWorklogId=892383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892383 ] ASF GitHub Bot logged work on ARTEMIS-4164: --- Author: ASF GitHub Bot Created on: 27/Nov/23 16:26 Start Date: 27/Nov/23 16:26 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4688: URL: https://github.com/apache/activemq-artemis/pull/4688 Issue Time Tracking --- Worklog Id: (was: 892383) Time Spent: 40m (was: 0.5h) > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Time Spent: 40m > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but we can have a autoReload config option > to disable it but it may be sufficient to depend on the file watch period to > disable this feature? > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790164#comment-17790164 ] ASF subversion and git services commented on ARTEMIS-4164: -- Commit 348763e14af4e18c14a835f0f8abe87f3533e740 in activemq-artemis's branch refs/heads/main from Gary Tully [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=348763e14a ] ARTEMIS-4164: add acceptor sslAutoReload option to have the broker watch key and trust store paths for modifications and automatically call reload > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Time Spent: 40m > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but we can have a autoReload config option > to disable it but it may be sufficient to depend on the file watch period to > disable this feature? > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4507) Make critical analyzer logging consistent
[
https://issues.apache.org/jira/browse/ARTEMIS-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790168#comment-17790168
]
ASF subversion and git services commented on ARTEMIS-4507:
--
Commit 7909f4b77f198eb1852156d8051d3a1a24367cc8 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7909f4b77f ]
ARTEMIS-4507 make critical analyzer logging consistent
> Make critical analyzer logging consistent
> --
>
> Key: ARTEMIS-4507
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4507
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently if the {{critical-analyzer-policy}} is {{HALT}} or {{SHUTDOWN}} the
> log message is at {{ERROR}}. However, if the policy is {{LOG}} then the
> message is logged at {{WARN}}. All policies should log at {{ERROR}} to be
> consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4507) Make critical analyzer logging consistent
[
https://issues.apache.org/jira/browse/ARTEMIS-4507?focusedWorklogId=892385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892385
]
ASF GitHub Bot logged work on ARTEMIS-4507:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:34
Start Date: 27/Nov/23 16:34
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4679:
URL: https://github.com/apache/activemq-artemis/pull/4679
Issue Time Tracking
---
Worklog Id: (was: 892385)
Time Spent: 20m (was: 10m)
> Make critical analyzer logging consistent
> --
>
> Key: ARTEMIS-4507
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4507
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently if the {{critical-analyzer-policy}} is {{HALT}} or {{SHUTDOWN}} the
> log message is at {{ERROR}}. However, if the policy is {{LOG}} then the
> message is logged at {{WARN}}. All policies should log at {{ERROR}} to be
> consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?focusedWorklogId=892386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892386
]
ASF GitHub Bot logged work on ARTEMIS-4506:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:44
Start Date: 27/Nov/23 16:44
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678#discussion_r1406453016
##
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##
@@ -137,11 +138,11 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
- public static String convertMqttTopicFilterToCoreAddress(String filter,
WildcardConfiguration wildcardConfiguration) {
- return convertMqttTopicFilterToCoreAddress(null, filter,
wildcardConfiguration);
+ public static String convertMqttTopicFilterToCore(String filter,
WildcardConfiguration wildcardConfiguration) {
+ return convertMqttTopicFilterToCore(null, filter, wildcardConfiguration);
}
- public static String convertMqttTopicFilterToCoreAddress(String
prefixToAdd, String filter, WildcardConfiguration wildcardConfiguration) {
Review Comment:
I liked the older name better.. I thought it was more descriptive.
Or there was another reason for the change?
Issue Time Tracking
---
Worklog Id: (was: 892386)
Time Spent: 20m (was: 10m)
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?focusedWorklogId=892387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892387
]
ASF GitHub Bot logged work on ARTEMIS-4506:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:49
Start Date: 27/Nov/23 16:49
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678#discussion_r1406458780
##
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##
@@ -137,11 +138,11 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
- public static String convertMqttTopicFilterToCoreAddress(String filter,
WildcardConfiguration wildcardConfiguration) {
- return convertMqttTopicFilterToCoreAddress(null, filter,
wildcardConfiguration);
+ public static String convertMqttTopicFilterToCore(String filter,
WildcardConfiguration wildcardConfiguration) {
+ return convertMqttTopicFilterToCore(null, filter, wildcardConfiguration);
}
- public static String convertMqttTopicFilterToCoreAddress(String
prefixToAdd, String filter, WildcardConfiguration wildcardConfiguration) {
Review Comment:
I changed the name because that method is used to convert the name of more
than just the address. It's used to convert the queue name as well. I shortened
it rather than making it `convertMqttTopicFilterToCoreAddressOrQueue`.
Issue Time Tracking
---
Worklog Id: (was: 892387)
Time Spent: 0.5h (was: 20m)
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?focusedWorklogId=892388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892388
]
ASF GitHub Bot logged work on ARTEMIS-4506:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:49
Start Date: 27/Nov/23 16:49
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678#discussion_r1406458780
##
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##
@@ -137,11 +138,11 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
- public static String convertMqttTopicFilterToCoreAddress(String filter,
WildcardConfiguration wildcardConfiguration) {
- return convertMqttTopicFilterToCoreAddress(null, filter,
wildcardConfiguration);
+ public static String convertMqttTopicFilterToCore(String filter,
WildcardConfiguration wildcardConfiguration) {
+ return convertMqttTopicFilterToCore(null, filter, wildcardConfiguration);
}
- public static String convertMqttTopicFilterToCoreAddress(String
prefixToAdd, String filter, WildcardConfiguration wildcardConfiguration) {
Review Comment:
I changed the name because that method is used to convert the name of more
than just the address. It's used to convert the queue name as well. I shortened
it rather than making it something like
`convertMqttTopicFilterToCoreAddressOrQueue`.
Issue Time Tracking
---
Worklog Id: (was: 892388)
Time Spent: 40m (was: 0.5h)
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790176#comment-17790176
]
ASF subversion and git services commented on ARTEMIS-4506:
--
Commit 60200b44e2d66adecebc2988091ba16bb5aed5a8 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=60200b44e2 ]
ARTEMIS-4506 restore MQTT sub queue name syntax
Starting with 2.28.0, the broker doesn't translate the character `/` to
the configured wildcard delimiter (i.e. `.` by default) when creating
subscription queues for MQTT clients.
This commit fixes that regression and restores the proper translation.
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?focusedWorklogId=892389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892389
]
ASF GitHub Bot logged work on ARTEMIS-4506:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:51
Start Date: 27/Nov/23 16:51
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678#discussion_r1406461484
##
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java:
##
@@ -137,11 +138,11 @@ public class MQTTUtil {
public static final int DEFAULT_MAXIMUM_PACKET_SIZE = MAX_PACKET_SIZE;
- public static String convertMqttTopicFilterToCoreAddress(String filter,
WildcardConfiguration wildcardConfiguration) {
- return convertMqttTopicFilterToCoreAddress(null, filter,
wildcardConfiguration);
+ public static String convertMqttTopicFilterToCore(String filter,
WildcardConfiguration wildcardConfiguration) {
+ return convertMqttTopicFilterToCore(null, filter, wildcardConfiguration);
}
- public static String convertMqttTopicFilterToCoreAddress(String
prefixToAdd, String filter, WildcardConfiguration wildcardConfiguration) {
Review Comment:
ok... got it..
it's mixed with the actual fix.. so it's not a related change to the JIRA
itself, but no big deal.. I was just trying to understand.
Issue Time Tracking
---
Worklog Id: (was: 892389)
Time Spent: 50m (was: 40m)
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4506) Restore MQTT subscription queue name syntax
[
https://issues.apache.org/jira/browse/ARTEMIS-4506?focusedWorklogId=892390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892390
]
ASF GitHub Bot logged work on ARTEMIS-4506:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 16:51
Start Date: 27/Nov/23 16:51
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4678:
URL: https://github.com/apache/activemq-artemis/pull/4678
Issue Time Tracking
---
Worklog Id: (was: 892390)
Time Spent: 1h (was: 50m)
> Restore MQTT subscription queue name syntax
> ---
>
> Key: ARTEMIS-4506
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4506
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Starting with 2.28.0, the broker doesn't translate the character {{/}} to the
> configured wildcard delimiter (i.e. {{.}} by default) when creating
> subscription queues for MQTT clients.
> For example, in previous versions, a client configured with the following
> properties
> {noformat}
> clientId: mqtt
> topic: TEST/TOPIC{noformat}
> would consume message from a queue defined like this:
> {code:xml}
>
>
>
>
> {code}
> Now, in the affected versions, this will not work, the client will create (if
> it has permissions to create queues) or will expect (if it doesn't have
> permissions to create queues) a queue with the following format:
> {code:xml}
>
>
>
>
> {code}
> This is breaking clients applications when upgrading the broker from
> versions before than 2.28.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully resolved ARTEMIS-4164. - Fix Version/s: 2.32.0 Resolution: Fixed > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Fix For: 2.32.0 > > Time Spent: 40m > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but we can have a autoReload config option > to disable it but it may be sufficient to depend on the file watch period to > disable this feature? > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully updated ARTEMIS-4164: Description: In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. It would make sense to trigger this automatically by default when a change is detected. We have the file watcher and can register an entry per keystore reference on acceptor creation. I think this should be the default but the jmx op has been the way to manually do this to date. Will make it an option, disabled by default. h1. was: In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. It would make sense to trigger this automatically by default when a change is detected. We have the file watcher and can register an entry per keystore reference on acceptor creation. I think this should be the default but we can have a autoReload config option to disable it but it may be sufficient to depend on the file watch period to disable this feature? h1. > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Fix For: 2.32.0 > > Time Spent: 40m > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but the jmx op has been the way to > manually do this to date. Will make it an option, disabled by default. > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4164) Auto reload acceptor SSL keystores on change
[ https://issues.apache.org/jira/browse/ARTEMIS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully updated ARTEMIS-4164: Description: In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. It would make sense to trigger this automatically by default when a change is detected. We have the file watcher and can register an entry per keystore reference on acceptor creation. I think this should be the default but the jmx op has been the way to manually do this to date. Will make it an option, _*sslAutoReload*_ disabled by default. h1. was: In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. It would make sense to trigger this automatically by default when a change is detected. We have the file watcher and can register an entry per keystore reference on acceptor creation. I think this should be the default but the jmx op has been the way to manually do this to date. Will make it an option, disabled by default. h1. > Auto reload acceptor SSL keystores on change > > > Key: ARTEMIS-4164 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4164 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.27.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Labels: Netty, TLS > Fix For: 2.32.0 > > Time Spent: 40m > Remaining Estimate: 0h > > In ARTEMIS-400 we added a jmx operation to reload ssl context configuration. > It would make sense to trigger this automatically by default when a change is > detected. We have the file watcher and can register an entry per keystore > reference on acceptor creation. > I think this should be the default but the jmx op has been the way to > manually do this to date. Will make it an option, _*sslAutoReload*_ disabled > by default. > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-8464) Implement JMS 2.0 Consumer receiveBody
[ https://issues.apache.org/jira/browse/AMQ-8464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich updated AMQ-8464: Issue Type: New Feature (was: Task) > Implement JMS 2.0 Consumer receiveBody > -- > > Key: AMQ-8464 > URL: https://issues.apache.org/jira/browse/AMQ-8464 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Labels: #jms2 > Fix For: 6.1.0 > > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4501) Clean up MQTT subscription queues when session expires
[ https://issues.apache.org/jira/browse/ARTEMIS-4501?focusedWorklogId=892394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892394 ] ASF GitHub Bot logged work on ARTEMIS-4501: --- Author: ASF GitHub Bot Created on: 27/Nov/23 16:58 Start Date: 27/Nov/23 16:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4673: URL: https://github.com/apache/activemq-artemis/pull/4673#discussion_r1406471606 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTests.java: ## @@ -970,11 +970,17 @@ public void testCleanStartFalseWithNon0SessionExpiryInterval() throws Exception consumer.subscribe(TOPIC, 2); consumer.disconnect(); + // ensure the subscription queue still exists since the session hasn't expired + assertNotNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); + // session should *not* still exist since session expiry interval has passed long start = System.currentTimeMillis(); Wait.assertEquals(0, () -> getSessionStates().size(), EXPIRY_INTERVAL * 1000 * 2, 100); assertTrue(System.currentTimeMillis() - start > (EXPIRY_INTERVAL * 1000)); assertNull(getSessionStates().get(CONSUMER_ID)); + + // ensure the subscription queue is cleaned up when the session expires + assertNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); Review Comment: I just ran this test with repetion until failure, and it failed at the assertTrue on line 979 Issue Time Tracking --- Worklog Id: (was: 892394) Time Spent: 20m (was: 10m) > Clean up MQTT subscription queues when session expires > -- > > Key: ARTEMIS-4501 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4501 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Until now the broker has been using the generic auto-delete address settings > to take care of the queues from abandoned MQTT subscriptions. Rather than > requiring this configuration the broker should just do this automatically > when the MQTT session expires. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-8500) JMS 2.0 support for DeliveryTime and DeliveryDelay in openwire
[ https://issues.apache.org/jira/browse/AMQ-8500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich updated AMQ-8500: Issue Type: New Feature (was: Task) > JMS 2.0 support for DeliveryTime and DeliveryDelay in openwire > -- > > Key: AMQ-8500 > URL: https://issues.apache.org/jira/browse/AMQ-8500 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Labels: #jms2 > Fix For: 6.1.0 > > > Currently, JMSDeliveryDelay and JMSDeliveryTime are not supported in openwire > v12 > Comment added to relevant code: > // TODO: AMQ-8500 - update this when openwire supports JMSDeliveryTime > activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageTransformation.java > [public static void copyProperties(Message fromMessage, Message toMessage) > throws JMSException] > ./activemq-client/src/main/java/org/apache/activemq/ActiveMQSession.java > [protected void send(..)] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9404) Upgrade to Spring 6.0.14
Jean-Baptiste Onofré created AMQ-9404: - Summary: Upgrade to Spring 6.0.14 Key: AMQ-9404 URL: https://issues.apache.org/jira/browse/AMQ-9404 Project: ActiveMQ Issue Type: Dependency upgrade Components: Broker Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4501) Clean up MQTT subscription queues when session expires
[ https://issues.apache.org/jira/browse/ARTEMIS-4501?focusedWorklogId=892399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892399 ] ASF GitHub Bot logged work on ARTEMIS-4501: --- Author: ASF GitHub Bot Created on: 27/Nov/23 17:06 Start Date: 27/Nov/23 17:06 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4673: URL: https://github.com/apache/activemq-artemis/pull/4673#discussion_r1406480880 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTests.java: ## @@ -970,11 +970,17 @@ public void testCleanStartFalseWithNon0SessionExpiryInterval() throws Exception consumer.subscribe(TOPIC, 2); consumer.disconnect(); + // ensure the subscription queue still exists since the session hasn't expired + assertNotNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); + // session should *not* still exist since session expiry interval has passed long start = System.currentTimeMillis(); Wait.assertEquals(0, () -> getSessionStates().size(), EXPIRY_INTERVAL * 1000 * 2, 100); assertTrue(System.currentTimeMillis() - start > (EXPIRY_INTERVAL * 1000)); assertNull(getSessionStates().get(CONSUMER_ID)); + + // ensure the subscription queue is cleaned up when the session expires + assertNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); Review Comment: Looking... Issue Time Tracking --- Worklog Id: (was: 892399) Time Spent: 0.5h (was: 20m) > Clean up MQTT subscription queues when session expires > -- > > Key: ARTEMIS-4501 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4501 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Until now the broker has been using the generic auto-delete address settings > to take care of the queues from abandoned MQTT subscriptions. Rather than > requiring this configuration the broker should just do this automatically > when the MQTT session expires. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4501) Clean up MQTT subscription queues when session expires
[ https://issues.apache.org/jira/browse/ARTEMIS-4501?focusedWorklogId=892400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892400 ] ASF GitHub Bot logged work on ARTEMIS-4501: --- Author: ASF GitHub Bot Created on: 27/Nov/23 17:25 Start Date: 27/Nov/23 17:25 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4673: URL: https://github.com/apache/activemq-artemis/pull/4673#discussion_r1406502833 ## tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTests.java: ## @@ -970,11 +970,17 @@ public void testCleanStartFalseWithNon0SessionExpiryInterval() throws Exception consumer.subscribe(TOPIC, 2); consumer.disconnect(); + // ensure the subscription queue still exists since the session hasn't expired + assertNotNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); + // session should *not* still exist since session expiry interval has passed long start = System.currentTimeMillis(); Wait.assertEquals(0, () -> getSessionStates().size(), EXPIRY_INTERVAL * 1000 * 2, 100); assertTrue(System.currentTimeMillis() - start > (EXPIRY_INTERVAL * 1000)); assertNull(getSessionStates().get(CONSUMER_ID)); + + // ensure the subscription queue is cleaned up when the session expires + assertNull(getSubscriptionQueue(TOPIC, CONSUMER_ID)); Review Comment: I pushed a fix. Issue Time Tracking --- Worklog Id: (was: 892400) Time Spent: 40m (was: 0.5h) > Clean up MQTT subscription queues when session expires > -- > > Key: ARTEMIS-4501 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4501 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Until now the broker has been using the generic auto-delete address settings > to take care of the queues from abandoned MQTT subscriptions. Rather than > requiring this configuration the broker should just do this automatically > when the MQTT session expires. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[
https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892401
]
ASF GitHub Bot logged work on ARTEMIS-3932:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 17:32
Start Date: 27/Nov/23 17:32
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4683:
URL: https://github.com/apache/activemq-artemis/pull/4683#discussion_r1406511051
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##
@@ -3596,6 +3534,41 @@ public void addAddressSettings(final String address,
}
+ @Override
+ public String addAddressSettings(String address, String
addressSettingsConfigurationAsJson) throws Exception {
+ if (AuditLogger.isBaseLoggingEnabled()) {
+ AuditLogger.addAddressSettings(this.server,
addressSettingsConfigurationAsJson);
+ }
+ checkStarted();
+
+ clearIO();
+
+ try {
+ // when the QueueConfiguration is passed through createQueue all of
its defaults get set which we return to the caller
Review Comment:
This comment is incorrect.
Issue Time Tracking
---
Worklog Id: (was: 892401)
Time Spent: 1.5h (was: 1h 20m)
> replace addAddressSettings with JSON param
> --
>
> Key: ARTEMIS-3932
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3932
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Andy Taylor
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Similar to what we did with createQueue deprecate the addAddressSettings in
> ServerControl and add a json version
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4501) Clean up MQTT subscription queues when session expires
[ https://issues.apache.org/jira/browse/ARTEMIS-4501?focusedWorklogId=892402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892402 ] ASF GitHub Bot logged work on ARTEMIS-4501: --- Author: ASF GitHub Bot Created on: 27/Nov/23 17:33 Start Date: 27/Nov/23 17:33 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4673: URL: https://github.com/apache/activemq-artemis/pull/4673 Issue Time Tracking --- Worklog Id: (was: 892402) Time Spent: 50m (was: 40m) > Clean up MQTT subscription queues when session expires > -- > > Key: ARTEMIS-4501 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4501 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Until now the broker has been using the generic auto-delete address settings > to take care of the queues from abandoned MQTT subscriptions. Rather than > requiring this configuration the broker should just do this automatically > when the MQTT session expires. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4501) Clean up MQTT subscription queues when session expires
[ https://issues.apache.org/jira/browse/ARTEMIS-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790191#comment-17790191 ] ASF subversion and git services commented on ARTEMIS-4501: -- Commit 8e68bb1902f0044db36f0c4b99acc74495039585 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8e68bb1902 ] ARTEMIS-4501 clean up MQTT subscription queues when session expires > Clean up MQTT subscription queues when session expires > -- > > Key: ARTEMIS-4501 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4501 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Until now the broker has been using the generic auto-delete address settings > to take care of the queues from abandoned MQTT subscriptions. Rather than > requiring this configuration the broker should just do this automatically > when the MQTT session expires. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
JJ created AMQ-9405:
---
Summary: Supplied jetty.xml fails to load if ssl is enabled
Key: AMQ-9405
URL: https://issues.apache.org/jira/browse/AMQ-9405
Project: ActiveMQ
Issue Type: Bug
Components: Web Console
Affects Versions: 6.0.0
Environment: EL8
java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
Reporter: JJ
Attachments: Jetty SSL Error.txt
Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
jetty.xml the server fails to loads and provides the attached error.
{{}}
{{ }}
{{ }}
{{ }}
{{ }}
{{ }}
{{ }}
{{ }}
{{ }}
{{}}
ERROR | Failed to load: class path resource [activemq.xml], reason: Error
creating bean with name 'invokeConnectors' defined in class path resource
[jetty.xml]: Cannot create inner bean 'SecureConnector' of type
[org.eclipse.jetty.server.ServerConnector] while setting bean property
'arguments' with key [1] (Full error attached)
This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
[
https://issues.apache.org/jira/browse/AMQ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JJ updated AMQ-9405:
Environment:
EL7
java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
was:
EL8
java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
> Supplied jetty.xml fails to load if ssl is enabled
> --
>
> Key: AMQ-9405
> URL: https://issues.apache.org/jira/browse/AMQ-9405
> Project: ActiveMQ
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 6.0.0
> Environment: EL7
> java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
>Reporter: JJ
>Priority: Major
> Attachments: Jetty SSL Error.txt
>
>
> Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
> jetty.xml the server fails to loads and provides the attached error.
> {{ class="org.eclipse.jetty.server.ServerConnector">}}
> {{ }}
> {{ }}
> {{ class="org.eclipse.jetty.util.ssl.SslContextFactory">}}
> {{ />}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{}}
>
> ERROR | Failed to load: class path resource [activemq.xml], reason: Error
> creating bean with name 'invokeConnectors' defined in class path resource
> [jetty.xml]: Cannot create inner bean 'SecureConnector' of type
> [org.eclipse.jetty.server.ServerConnector] while setting bean property
> 'arguments' with key [1] (Full error attached)
> This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?focusedWorklogId=892408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892408 ] ASF GitHub Bot logged work on ARTEMIS-3932: --- Author: ASF GitHub Bot Created on: 27/Nov/23 18:36 Start Date: 27/Nov/23 18:36 Worklog Time Spent: 10m Work Description: jbertram merged PR #4683: URL: https://github.com/apache/activemq-artemis/pull/4683 Issue Time Tracking --- Worklog Id: (was: 892408) Time Spent: 1h 40m (was: 1.5h) > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790210#comment-17790210 ] ASF subversion and git services commented on ARTEMIS-3932: -- Commit 9a7a6f89cf78e25cdd4235e6897f29e1f975fa84 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=9a7a6f89cf ] ARTEMIS-3932 Deprecate and replace addAddressSettings with json version As I worked through implementing a more generic JSON marshaller, I tried using reflection through BeanUtils and other ways however the endresult was always worse as there were a few caveats that were not as easy to accomplish. For that reason I went to a declarative appraoch where I define a meta-data object on AddressSettings and AddressSettingsInfo and reuse the metadata in a few other places. > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790220#comment-17790220
]
ASF subversion and git services commented on ARTEMIS-4513:
--
Commit 36056a5bddeaf431bd282cc0f231f53675549117 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=36056a5bdd ]
ARTEMIS-4513 HTTP request logging not working
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4513) HTTP request logging not working
[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892415
]
ASF GitHub Bot logged work on ARTEMIS-4513:
---
Author: ASF GitHub Bot
Created on: 27/Nov/23 18:54
Start Date: 27/Nov/23 18:54
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686
Issue Time Tracking
---
Worklog Id: (was: 892415)
Time Spent: 1h (was: 50m)
> HTTP request logging not working
>
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
[
https://issues.apache.org/jira/browse/AMQ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré reassigned AMQ-9405:
-
Assignee: Jean-Baptiste Onofré
> Supplied jetty.xml fails to load if ssl is enabled
> --
>
> Key: AMQ-9405
> URL: https://issues.apache.org/jira/browse/AMQ-9405
> Project: ActiveMQ
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 6.0.0
> Environment: EL7
> java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
>Reporter: JJ
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Attachments: Jetty SSL Error.txt
>
>
> Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
> jetty.xml the server fails to loads and provides the attached error.
> {{ class="org.eclipse.jetty.server.ServerConnector">}}
> {{ }}
> {{ }}
> {{ class="org.eclipse.jetty.util.ssl.SslContextFactory">}}
> {{ />}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{}}
>
> ERROR | Failed to load: class path resource [activemq.xml], reason: Error
> creating bean with name 'invokeConnectors' defined in class path resource
> [jetty.xml]: Cannot create inner bean 'SecureConnector' of type
> [org.eclipse.jetty.server.ServerConnector] while setting bean property
> 'arguments' with key [1] (Full error attached)
> This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
[
https://issues.apache.org/jira/browse/AMQ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré updated AMQ-9405:
--
Fix Version/s: 6.0.1
> Supplied jetty.xml fails to load if ssl is enabled
> --
>
> Key: AMQ-9405
> URL: https://issues.apache.org/jira/browse/AMQ-9405
> Project: ActiveMQ
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 6.0.0
> Environment: EL7
> java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
>Reporter: JJ
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.1
>
> Attachments: Jetty SSL Error.txt
>
>
> Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
> jetty.xml the server fails to loads and provides the attached error.
> {{ class="org.eclipse.jetty.server.ServerConnector">}}
> {{ }}
> {{ }}
> {{ class="org.eclipse.jetty.util.ssl.SslContextFactory">}}
> {{ />}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{}}
>
> ERROR | Failed to load: class path resource [activemq.xml], reason: Error
> creating bean with name 'invokeConnectors' defined in class path resource
> [jetty.xml]: Cannot create inner bean 'SecureConnector' of type
> [org.eclipse.jetty.server.ServerConnector] while setting bean property
> 'arguments' with key [1] (Full error attached)
> This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
[
https://issues.apache.org/jira/browse/AMQ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790238#comment-17790238
]
Jean-Baptiste Onofré commented on AMQ-9405:
---
This is due to the packaging refactoring of Jetty 11. We probably need to add
an additional jetty artifact. Let me reproduce and fix.
> Supplied jetty.xml fails to load if ssl is enabled
> --
>
> Key: AMQ-9405
> URL: https://issues.apache.org/jira/browse/AMQ-9405
> Project: ActiveMQ
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 6.0.0
> Environment: EL7
> java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
>Reporter: JJ
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Attachments: Jetty SSL Error.txt
>
>
> Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
> jetty.xml the server fails to loads and provides the attached error.
> {{ class="org.eclipse.jetty.server.ServerConnector">}}
> {{ }}
> {{ }}
> {{ class="org.eclipse.jetty.util.ssl.SslContextFactory">}}
> {{ />}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{}}
>
> ERROR | Failed to load: class path resource [activemq.xml], reason: Error
> creating bean with name 'invokeConnectors' defined in class path resource
> [jetty.xml]: Cannot create inner bean 'SecureConnector' of type
> [org.eclipse.jetty.server.ServerConnector] while setting bean property
> 'arguments' with key [1] (Full error attached)
> This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9406) Upgrade to Camel 4.2.0
Jean-Baptiste Onofré created AMQ-9406: - Summary: Upgrade to Camel 4.2.0 Key: AMQ-9406 URL: https://issues.apache.org/jira/browse/AMQ-9406 Project: ActiveMQ Issue Type: Dependency upgrade Components: Camel Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.1, 6.1.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9405) Supplied jetty.xml fails to load if ssl is enabled
[
https://issues.apache.org/jira/browse/AMQ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré updated AMQ-9405:
--
Fix Version/s: 6.1.0
> Supplied jetty.xml fails to load if ssl is enabled
> --
>
> Key: AMQ-9405
> URL: https://issues.apache.org/jira/browse/AMQ-9405
> Project: ActiveMQ
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 6.0.0
> Environment: EL7
> java-latest-openjdk-18.0.2.0.9-1.rolling.el7.x86_64
>Reporter: JJ
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.1, 6.1.0
>
> Attachments: Jetty SSL Error.txt
>
>
> Using a fresh download of the current AMQ 6.0.0 if you enable SSL within
> jetty.xml the server fails to loads and provides the attached error.
> {{ class="org.eclipse.jetty.server.ServerConnector">}}
> {{ }}
> {{ }}
> {{ class="org.eclipse.jetty.util.ssl.SslContextFactory">}}
> {{ />}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{}}
>
> ERROR | Failed to load: class path resource [activemq.xml], reason: Error
> creating bean with name 'invokeConnectors' defined in class path resource
> [jetty.xml]: Cannot create inner bean 'SecureConnector' of type
> [org.eclipse.jetty.server.ServerConnector] while setting bean property
> 'arguments' with key [1] (Full error attached)
> This works as expected in previous versions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9407) Upgrade to log4j 2.22.0
Jean-Baptiste Onofré created AMQ-9407: - Summary: Upgrade to log4j 2.22.0 Key: AMQ-9407 URL: https://issues.apache.org/jira/browse/AMQ-9407 Project: ActiveMQ Issue Type: Dependency upgrade Components: Broker Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.1, 6.1.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9396) Upgrade to Spring 6.1.1
[ https://issues.apache.org/jira/browse/AMQ-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-9396: -- Summary: Upgrade to Spring 6.1.1 (was: Upgrade to Spring 6.1.0) > Upgrade to Spring 6.1.1 > --- > > Key: AMQ-9396 > URL: https://issues.apache.org/jira/browse/AMQ-9396 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9404) Upgrade to Spring 6.0.14
[ https://issues.apache.org/jira/browse/AMQ-9404?focusedWorklogId=892425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892425 ] ASF GitHub Bot logged work on AMQ-9404: --- Author: ASF GitHub Bot Created on: 27/Nov/23 20:24 Start Date: 27/Nov/23 20:24 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1131: URL: https://github.com/apache/activemq/pull/1131 (no comment) Issue Time Tracking --- Worklog Id: (was: 892425) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Spring 6.0.14 > > > Key: AMQ-9404 > URL: https://issues.apache.org/jira/browse/AMQ-9404 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9406) Upgrade to Camel 4.2.0
[ https://issues.apache.org/jira/browse/AMQ-9406?focusedWorklogId=892426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892426 ] ASF GitHub Bot logged work on AMQ-9406: --- Author: ASF GitHub Bot Created on: 27/Nov/23 20:25 Start Date: 27/Nov/23 20:25 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1132: URL: https://github.com/apache/activemq/pull/1132 (no comment) Issue Time Tracking --- Worklog Id: (was: 892426) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Camel 4.2.0 > -- > > Key: AMQ-9406 > URL: https://issues.apache.org/jira/browse/AMQ-9406 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Camel >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.1, 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9407) Upgrade to log4j 2.22.0
[ https://issues.apache.org/jira/browse/AMQ-9407?focusedWorklogId=892427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892427 ] ASF GitHub Bot logged work on AMQ-9407: --- Author: ASF GitHub Bot Created on: 27/Nov/23 20:26 Start Date: 27/Nov/23 20:26 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1133: URL: https://github.com/apache/activemq/pull/1133 (no comment) Issue Time Tracking --- Worklog Id: (was: 892427) Remaining Estimate: 0h Time Spent: 10m > Upgrade to log4j 2.22.0 > --- > > Key: AMQ-9407 > URL: https://issues.apache.org/jira/browse/AMQ-9407 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.1, 6.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4488) Support "literal" address setting match
[ https://issues.apache.org/jira/browse/ARTEMIS-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790259#comment-17790259 ] ASF subversion and git services commented on ARTEMIS-4488: -- Commit 7c711c04c3aa6951eebcca0b1fd410edb72cd159 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7c711c04c3 ] ARTEMIS-4488 support 'literal' address setting match > Support "literal" address setting match > --- > > Key: ARTEMIS-4488 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4488 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There are use-cases (mainly with MQTT) where wildcard addresses need to be > configured differently from the the addresses which actually match the > wildcard. Currently we have no way to separate these two categories. We need > a new configuration semantic to enable this differentiation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-3932) replace addAddressSettings with JSON param
[ https://issues.apache.org/jira/browse/ARTEMIS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790260#comment-17790260 ] ASF subversion and git services commented on ARTEMIS-3932: -- Commit e1f84ea45b0dd70cad459e4e916f227c020cda1c in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=e1f84ea45b ] ARTEMIS-3932 Fixing DuplciateRecordIdTest > replace addAddressSettings with JSON param > -- > > Key: ARTEMIS-3932 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3932 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Similar to what we did with createQueue deprecate the addAddressSettings in > ServerControl and add a json version -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4488) Support "literal" address setting match
[ https://issues.apache.org/jira/browse/ARTEMIS-4488?focusedWorklogId=892430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892430 ] ASF GitHub Bot logged work on ARTEMIS-4488: --- Author: ASF GitHub Bot Created on: 27/Nov/23 20:54 Start Date: 27/Nov/23 20:54 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4661: URL: https://github.com/apache/activemq-artemis/pull/4661 Issue Time Tracking --- Worklog Id: (was: 892430) Time Spent: 20m (was: 10m) > Support "literal" address setting match > --- > > Key: ARTEMIS-4488 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4488 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > There are use-cases (mainly with MQTT) where wildcard addresses need to be > configured differently from the the addresses which actually match the > wildcard. Currently we have no way to separate these two categories. We need > a new configuration semantic to enable this differentiation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9408) Jolokia throws exception during Windows service startup
Aaron Steigerwald created AMQ-9408: -- Summary: Jolokia throws exception during Windows service startup Key: AMQ-9408 URL: https://issues.apache.org/jira/browse/AMQ-9408 Project: ActiveMQ Issue Type: Bug Affects Versions: 5.18.3 Reporter: Aaron Steigerwald The issue fixed in AMQ-9126 exists in the Windows service wrapper.conf file and causes the same problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)
