[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219709#comment-16219709 ] ASF GitHub Bot commented on ARROW-1721: --- Licht-T commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339501657 @wesm Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219395#comment-16219395 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339448319 Turns out I can push to your branch, so done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219390#comment-16219390 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339447985 Couple flake8 warnings: ``` +flake8 --count /home/travis/build/apache/arrow/python/pyarrow /home/travis/build/apache/arrow/python/pyarrow/tests/test_convert_pandas.py:22:1: F401 'unittest' imported but unused /home/travis/build/apache/arrow/python/pyarrow/tests/test_convert_pandas.py:1115:16: E231 missing whitespace after ',' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219091#comment-16219091 ] ASF GitHub Bot commented on ARROW-1721: --- Licht-T commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339400591 @wesm Now fixed! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219090#comment-16219090 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339400213 Thanks! According to llvm.org, clang-5.0 is still the qualification branch (http://apt.llvm.org/) so whenever 5.0 is promoted to stable we'll upgrade our clang bits to 5.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219085#comment-16219085 ] ASF GitHub Bot commented on ARROW-1721: --- Licht-T commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339399427 @wesm Sorry! I'm using clang-format-5! I'll fix! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219080#comment-16219080 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339398833 I ran clang-format 4.0 locally and got this diff https://github.com/wesm/arrow/commit/7547ac8e70b5279e44fe802bdbd241ad9a8f0d4a This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219051#comment-16219051 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339395625 I'm surprised by some of the formatting changes, are you using clang-format-4.0? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219033#comment-16219033 ] ASF GitHub Bot commented on ARROW-1721: --- Licht-T commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339393634 @wesm Fixed the whole lint issues! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney >Assignee: Licht Takeuchi > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218996#comment-16218996 ] ASF GitHub Bot commented on ARROW-1721: --- wesm commented on issue #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246#issuecomment-339387796 Thank you for doing this! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[
https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218991#comment-16218991
]
ASF GitHub Bot commented on ARROW-1721:
---
wesm commented on a change in pull request #1246: ARROW-1721: [Python]
Implement null-mask check in places where it isn't supported in
numpy_to_arrow.cc
URL: https://github.com/apache/arrow/pull/1246#discussion_r146910978
##
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##
@@ -1029,6 +1033,44 @@ Status LoopPySequence(PyObject* sequence, T func) {
return Status::OK();
}
+template
+Status LoopPySequenceWithMasks(
+PyObject* sequence,
+const Ndarray1DIndexer& mask_values,
+bool have_mask,
+T func
+) {
Review comment:
Can you run clang-format? (`make format` or `ninja format`). This should
also fix the cpplint failure in CI . See
https://github.com/apache/arrow/tree/master/cpp#continuous-integration
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Support null mask in places where it isn't supported in
> numpy_to_arrow.cc
> --
>
> Key: ARROW-1721
> URL: https://issues.apache.org/jira/browse/ARROW-1721
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
>Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> see https://github.com/apache/spark/pull/18664#discussion_r146472109 for
> SPARK-21375
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ARROW-1721) [Python] Support null mask in places where it isn't supported in numpy_to_arrow.cc
[ https://issues.apache.org/jira/browse/ARROW-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218681#comment-16218681 ] ASF GitHub Bot commented on ARROW-1721: --- Licht-T opened a new pull request #1246: ARROW-1721: [Python] Implement null-mask check in places where it isn't supported in numpy_to_arrow.cc URL: https://github.com/apache/arrow/pull/1246 This closes [ARROW-1721](https://issues.apache.org/jira/projects/ARROW/issues/ARROW-1721). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Support null mask in places where it isn't supported in > numpy_to_arrow.cc > -- > > Key: ARROW-1721 > URL: https://issues.apache.org/jira/browse/ARROW-1721 > Project: Apache Arrow > Issue Type: Improvement > Components: Python >Reporter: Wes McKinney > Labels: pull-request-available > Fix For: 0.8.0 > > > see https://github.com/apache/spark/pull/18664#discussion_r146472109 for > SPARK-21375 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
