[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234980=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234980
]
ASF GitHub Bot logged work on BEAM-1542:
Author: ASF GitHub Bot
Created on: 29/Apr/19 23:18
Start Date: 29/Apr/19 23:18
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8404: [BEAM-1542]
Add a possibility to pass a project that hosts Cloud Spanner instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279573315
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+@Description("Project that hosts Spanner instance")
+@Nullable
+String getInstanceProjectId();
Review comment:
We call
https://github.com/apache/beam/blob/ef67378fec2afadbe4a5303e61ac0427ced1faa0/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java#L98
But I think, we don't have a registrar for these options, such as, say:
https://github.com/apache/beam/blob/ef67378fec2afadbe4a5303e61ac0427ced1faa0/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpPipelineOptionsRegistrar.java#L26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234980)
Time Spent: 1h 10m (was: 1h)
> Need Source/Sink for Spanner
>
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
>Reporter: Guy Molinari
>Assignee: Mairbek Khadikov
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234918=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234918
]
ASF GitHub Bot logged work on BEAM-1542:
Author: ASF GitHub Bot
Created on: 29/Apr/19 21:26
Start Date: 29/Apr/19 21:26
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8404: [BEAM-1542]
Add a possibility to pass a project that hosts Cloud Spanner instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279546111
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+@Description("Project that hosts Spanner instance")
+@Nullable
+String getInstanceProjectId();
Review comment:
As long as the PipelineOption interface isn't being registered via a
ServiceLoader automatically, a call to PipelineOptionsFactory.resetCache()
after each test in a `@TearDown` method will remove the pollution of the
namespace. If it is being registered via serviceloader then people have to be
careful around name choices/classpaths.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234918)
Time Spent: 1h (was: 50m)
> Need Source/Sink for Spanner
>
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
>Reporter: Guy Molinari
>Assignee: Mairbek Khadikov
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234912=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234912
]
ASF GitHub Bot logged work on BEAM-1542:
Author: ASF GitHub Bot
Created on: 29/Apr/19 21:16
Start Date: 29/Apr/19 21:16
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8404: [BEAM-1542]
Add a possibility to pass a project that hosts Cloud Spanner instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279542910
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+@Description("Project that hosts Spanner instance")
+@Nullable
+String getInstanceProjectId();
Review comment:
Yes. Do pipeline options defined in ITs pollute the global namespace,
@kennknowles ?
If so, there are other options in this and other tests that this concern
applies to.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234912)
Time Spent: 50m (was: 40m)
> Need Source/Sink for Spanner
>
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
>Reporter: Guy Molinari
>Assignee: Mairbek Khadikov
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234909=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234909
]
ASF GitHub Bot logged work on BEAM-1542:
Author: ASF GitHub Bot
Created on: 29/Apr/19 21:14
Start Date: 29/Apr/19 21:14
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #8404:
[BEAM-1542] Add a possibility to pass a project that hosts Cloud Spanner
instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279542134
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+@Description("Project that hosts Spanner instance")
+@Nullable
+String getInstanceProjectId();
Review comment:
Seems like this is only for integration tests ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234909)
Time Spent: 40m (was: 0.5h)
> Need Source/Sink for Spanner
>
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
>Reporter: Guy Molinari
>Assignee: Mairbek Khadikov
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234902=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234902
]
ASF GitHub Bot logged work on BEAM-1542:
Author: ASF GitHub Bot
Created on: 29/Apr/19 21:02
Start Date: 29/Apr/19 21:02
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #8404:
[BEAM-1542] Add a possibility to pass a project that hosts Cloud Spanner
instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279538225
##
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+@Description("Project that hosts Spanner instance")
+@Nullable
+String getInstanceProjectId();
Review comment:
I am very slightly concerned, because pipeline options are a global
namespace and this option does not have "spanner" in the name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234902)
Time Spent: 0.5h (was: 20m)
> Need Source/Sink for Spanner
>
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
>Reporter: Guy Molinari
>Assignee: Mairbek Khadikov
>Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[ https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234737=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234737 ] ASF GitHub Bot logged work on BEAM-1542: Author: ASF GitHub Bot Created on: 29/Apr/19 17:35 Start Date: 29/Apr/19 17:35 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #8404: [BEAM-1542] Add a possibility to pass a project that hosts Cloud Spanner instance. URL: https://github.com/apache/beam/pull/8404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 234737) Time Spent: 20m (was: 10m) > Need Source/Sink for Spanner > > > Key: BEAM-1542 > URL: https://issues.apache.org/jira/browse/BEAM-1542 > Project: Beam > Issue Type: New Feature > Components: io-java-gcp >Reporter: Guy Molinari >Assignee: Mairbek Khadikov >Priority: Major > Fix For: 2.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Is there a source/sink for Spanner in the works? If not I would gladly give > this a shot. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-1542) Need Source/Sink for Spanner
[ https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234678=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234678 ] ASF GitHub Bot logged work on BEAM-1542: Author: ASF GitHub Bot Created on: 29/Apr/19 17:10 Start Date: 29/Apr/19 17:10 Worklog Time Spent: 10m Work Description: tvalentyn commented on issue #8404: [BEAM-1542] Add a possibility to pass a project that hosts Cloud Spanner instance. URL: https://github.com/apache/beam/pull/8404#issuecomment-487663736 @kennknowles, @chamikaramj could you help with the merge? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 234678) Time Spent: 10m Remaining Estimate: 0h > Need Source/Sink for Spanner > > > Key: BEAM-1542 > URL: https://issues.apache.org/jira/browse/BEAM-1542 > Project: Beam > Issue Type: New Feature > Components: io-java-gcp >Reporter: Guy Molinari >Assignee: Mairbek Khadikov >Priority: Major > Fix For: 2.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Is there a source/sink for Spanner in the works? If not I would gladly give > this a shot. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
