[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=358183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358183 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 11/Dec/19 23:35 Start Date: 11/Dec/19 23:35 Worklog Time Spent: 10m Work Description: amaliujia commented on pull request #9739: [BEAM-8362] Don't use toString() for accessing Enum Types URL: https://github.com/apache/beam/pull/9739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358183) Time Spent: 2h 20m (was: 2h 10m) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Fix For: Not applicable > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=357549=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357549 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 11/Dec/19 01:00 Start Date: 11/Dec/19 01:00 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9739: [BEAM-8362] Don't use toString() for accessing Enum Types URL: https://github.com/apache/beam/pull/9739#issuecomment-564329576 Run JavaPortabilityApi PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 357549) Time Spent: 2h (was: 1h 50m) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=357550=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357550 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 11/Dec/19 01:00 Start Date: 11/Dec/19 01:00 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #9739: [BEAM-8362] Don't use toString() for accessing Enum Types URL: https://github.com/apache/beam/pull/9739#issuecomment-564329612 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 357550) Time Spent: 2h 10m (was: 2h) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=357548=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357548
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 11/Dec/19 01:00
Start Date: 11/Dec/19 01:00
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use toString() for accessing Enum Types
URL: https://github.com/apache/beam/pull/9739#discussion_r356357491
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -661,8 +662,8 @@ private RexNode convertArrayValueToRexNode(ArrayType
arrayType, Value value) {
return rexBuilder().makeCall(SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR,
operands);
}
- private RexNode convertEnumToRexNode(Type type, Value value) {
-if (type.typeName().equals("`zetasql.functions.DateTimestampPart`")) {
+ private RexNode convertEnumToRexNode(EnumType type, Value value) {
+if
("zetasql.functions.DateTimestampPart".equals(type.getDescriptor().getFullName()))
{
Review comment:
I see. So `type.getDescriptor().getFullName()` is a working path to get
fullname in string.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 357548)
Time Spent: 1h 50m (was: 1h 40m)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=357547=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357547
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 11/Dec/19 00:59
Start Date: 11/Dec/19 00:59
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use toString() for accessing Enum Types
URL: https://github.com/apache/beam/pull/9739#discussion_r356357491
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -661,8 +662,8 @@ private RexNode convertArrayValueToRexNode(ArrayType
arrayType, Value value) {
return rexBuilder().makeCall(SqlStdOperatorTable.ARRAY_VALUE_CONSTRUCTOR,
operands);
}
- private RexNode convertEnumToRexNode(Type type, Value value) {
-if (type.typeName().equals("`zetasql.functions.DateTimestampPart`")) {
+ private RexNode convertEnumToRexNode(EnumType type, Value value) {
+if
("zetasql.functions.DateTimestampPart".equals(type.getDescriptor().getFullName()))
{
Review comment:
I see. So `type.getDescriptor().getFullName()` will skip the `toString()`
path.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 357547)
Time Spent: 1h 40m (was: 1.5h)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=356609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356609 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 09/Dec/19 22:08 Start Date: 09/Dec/19 22:08 Worklog Time Spent: 10m Work Description: apilloud commented on issue #9739: [BEAM-8362] Don't use toString() for accessing Enum Types URL: https://github.com/apache/beam/pull/9739#issuecomment-563462708 @amaliujia Removed the error messages from this fix. Please take another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 356609) Time Spent: 1.5h (was: 1h 20m) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=356607=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356607 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 09/Dec/19 22:06 Start Date: 09/Dec/19 22:06 Worklog Time Spent: 10m Work Description: stale[bot] commented on issue #9739: [BEAM-8362] Don't use ZetaSQL's unimplemented functions URL: https://github.com/apache/beam/pull/9739#issuecomment-563462205 This pull request is no longer marked as stale. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 356607) Time Spent: 1h 20m (was: 1h 10m) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=355660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355660 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 07/Dec/19 18:09 Start Date: 07/Dec/19 18:09 Worklog Time Spent: 10m Work Description: stale[bot] commented on issue #9739: [BEAM-8362] Don't use ZetaSQL's unimplemented functions URL: https://github.com/apache/beam/pull/9739#issuecomment-562873449 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the d...@beam.apache.org list. Thank you for your contributions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 355660) Time Spent: 1h 10m (was: 1h) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=325212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325212
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 08/Oct/19 17:52
Start Date: 08/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use ZetaSQL's unimplemented functions
URL: https://github.com/apache/beam/pull/9739#discussion_r332648960
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -517,13 +517,7 @@ public RexNode convertResolvedLiteral(ResolvedLiteral
resolvedLiteral) {
ret = convertValueToRexNode(resolvedLiteral.getType(),
resolvedLiteral.getValue());
break;
default:
-throw new RuntimeException(
-MessageFormat.format(
-"Unsupported ResolvedLiteral type: {0}, kind: {1}, value: {2},
class: {3}",
-resolvedLiteral.getType().typeName(),
-kind,
-resolvedLiteral.getValue(),
-resolvedLiteral.getClass()));
+throw new RuntimeException("Unsupported ResolvedLiteral type.");
Review comment:
I would prefer a mixed approach:
1. give user the unsupported kind.
2. print log info of more information to help development.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 325212)
Time Spent: 1h (was: 50m)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=325210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325210
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 08/Oct/19 17:51
Start Date: 08/Oct/19 17:51
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use ZetaSQL's unimplemented functions
URL: https://github.com/apache/beam/pull/9739#discussion_r332648527
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -517,13 +517,7 @@ public RexNode convertResolvedLiteral(ResolvedLiteral
resolvedLiteral) {
ret = convertValueToRexNode(resolvedLiteral.getType(),
resolvedLiteral.getValue());
break;
default:
-throw new RuntimeException(
-MessageFormat.format(
-"Unsupported ResolvedLiteral type: {0}, kind: {1}, value: {2},
class: {3}",
-resolvedLiteral.getType().typeName(),
-kind,
-resolvedLiteral.getValue(),
-resolvedLiteral.getClass()));
+throw new RuntimeException("Unsupported ResolvedLiteral type.");
Review comment:
It's very useful for development actually. And for users, at least what kind
of ResolvedLiteral should be thrown to remind where could be wrong in user
queries.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 325210)
Time Spent: 50m (was: 40m)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=324683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324683
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 07/Oct/19 23:10
Start Date: 07/Oct/19 23:10
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9739: [BEAM-8362]
Don't use ZetaSQL's unimplemented functions
URL: https://github.com/apache/beam/pull/9739#discussion_r332276355
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -517,13 +517,7 @@ public RexNode convertResolvedLiteral(ResolvedLiteral
resolvedLiteral) {
ret = convertValueToRexNode(resolvedLiteral.getType(),
resolvedLiteral.getValue());
break;
default:
-throw new RuntimeException(
-MessageFormat.format(
-"Unsupported ResolvedLiteral type: {0}, kind: {1}, value: {2},
class: {3}",
-resolvedLiteral.getType().typeName(),
-kind,
-resolvedLiteral.getValue(),
-resolvedLiteral.getClass()));
+throw new RuntimeException("Unsupported ResolvedLiteral type.");
Review comment:
It is certainly less verbose, but I feel almost every error message in this
file could be simplified to `Unsupported type` without affecting the clarity of
the message to our end users.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 324683)
Time Spent: 40m (was: 0.5h)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[
https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=324660=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324660
]
ASF GitHub Bot logged work on BEAM-8362:
Author: ASF GitHub Bot
Created on: 07/Oct/19 22:18
Start Date: 07/Oct/19 22:18
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #9739: [BEAM-8362]
Don't use ZetaSQL's unimplemented functions
URL: https://github.com/apache/beam/pull/9739#discussion_r332262288
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@ -517,13 +517,7 @@ public RexNode convertResolvedLiteral(ResolvedLiteral
resolvedLiteral) {
ret = convertValueToRexNode(resolvedLiteral.getType(),
resolvedLiteral.getValue());
break;
default:
-throw new RuntimeException(
-MessageFormat.format(
-"Unsupported ResolvedLiteral type: {0}, kind: {1}, value: {2},
class: {3}",
-resolvedLiteral.getType().typeName(),
-kind,
-resolvedLiteral.getValue(),
-resolvedLiteral.getClass()));
+throw new RuntimeException("Unsupported ResolvedLiteral type.");
Review comment:
This change makes error message not clear as before, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 324660)
Time Spent: 0.5h (was: 20m)
> Don't use ZetaSQL's unimplemented functions
> ---
>
> Key: BEAM-8362
> URL: https://issues.apache.org/jira/browse/BEAM-8362
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
>Affects Versions: 2.15.0
>Reporter: Andrew Pilloud
>Assignee: Andrew Pilloud
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Unfortunately a bunch of debug functionality is still unimplemented in
> ZetaSQL. We should avoid calling those functions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=324574=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324574 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 07/Oct/19 19:54 Start Date: 07/Oct/19 19:54 Worklog Time Spent: 10m Work Description: apilloud commented on issue #9739: [BEAM-8362] Don't use ZetaSQL's unimplemented functions URL: https://github.com/apache/beam/pull/9739#issuecomment-539176897 R: @amaliujia This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324574) Time Spent: 20m (was: 10m) > Don't use ZetaSQL's unimplemented functions > --- > > Key: BEAM-8362 > URL: https://issues.apache.org/jira/browse/BEAM-8362 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql >Affects Versions: 2.15.0 >Reporter: Andrew Pilloud >Assignee: Andrew Pilloud >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Unfortunately a bunch of debug functionality is still unimplemented in > ZetaSQL. We should avoid calling those functions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8362) Don't use ZetaSQL's unimplemented functions
[ https://issues.apache.org/jira/browse/BEAM-8362?focusedWorklogId=324559=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324559 ] ASF GitHub Bot logged work on BEAM-8362: Author: ASF GitHub Bot Created on: 07/Oct/19 18:57 Start Date: 07/Oct/19 18:57 Worklog Time Spent: 10m Work Description: apilloud commented on pull request #9739: [BEAM-8362] Don't use ZetaSQL's unimplemented functions URL: https://github.com/apache/beam/pull/9739 Unfortunately a bunch of debug functionality that relies on string conversion is currently unimplemented in ZetaSQL and just throws `UnsupportedOperationException`. See all the functions in this file: https://github.com/google/zetasql/blob/master/java/com/google/zetasql/ZetaSQLStrings.java Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[