[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=391860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-391860 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 24/Feb/20 17:51 Start Date: 24/Feb/20 17:51 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10936: [BEAM-9063] migrate docker images to apache - fix postcommit failure URL: https://github.com/apache/beam/pull/10936#issuecomment-590463696 R: @ibzib This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 391860) Time Spent: 6h 40m (was: 6.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: 2.20.0 > > Time Spent: 6h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=390998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390998 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Feb/20 00:51 Start Date: 22/Feb/20 00:51 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10936: [BEAM-9063] migrate docker images to apache - fix postcommit failure URL: https://github.com/apache/beam/pull/10936#issuecomment-589896095 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 390998) Time Spent: 6.5h (was: 6h 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: 2.20.0 > > Time Spent: 6.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=390997=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390997 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Feb/20 00:50 Start Date: 22/Feb/20 00:50 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10936: [BEAM-9063] migrate docker images to apache - fix postcommit failure URL: https://github.com/apache/beam/pull/10936 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [![Build
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=390933=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390933 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Feb/20 21:59 Start Date: 21/Feb/20 21:59 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10612: [BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 390933) Time Spent: 6h 10m (was: 6h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 6h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=390868=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390868 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Feb/20 19:37 Start Date: 21/Feb/20 19:37 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-589803549 @ibzib, could you please take a look to [bed36ef](https://github.com/apache/beam/pull/10612/commits/bed36ef63f8e0b32f4d1be71d42d1f76ef9da9ec)? I merged spark changes to the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 390868) Time Spent: 6h (was: 5h 50m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 6h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=378381=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378381 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 17:58 Start Date: 28/Jan/20 17:58 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r371964232 ## File path: release/src/main/scripts/build_release_candidate.sh ## @@ -45,6 +45,9 @@ PYTHON_ARTIFACTS_DIR=python BEAM_ROOT_DIR=beam WEBSITE_ROOT_DIR=beam-site +DOCKER_IMAGE_DEFAULT_REPO_ROOT=apache +DOCKER_IMAGE_DEFAULT_REPO_PREFIX=beam_ Review comment: Yeap, that's a great idea and I think it's better to have a script which holds all variables and shared by all release scripts, so I haven't used a script this time. I created a ticket to fix it. [BEAM-9207](https://issues.apache.org/jira/browse/BEAM-9207) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378381) Time Spent: 5h 50m (was: 5h 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=378168=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378168 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 11:44 Start Date: 28/Jan/20 11:44 Worklog Time Spent: 10m Work Description: mxm commented on pull request #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r371752615 ## File path: release/src/main/scripts/publish_docker_images.sh ## @@ -24,6 +24,9 @@ set -e +DOCKER_IMAGE_DEFAULT_REPO_ROOT=apache +DOCKER_IMAGE_DEFAULT_REPO_PREFIX=beam_ Review comment: Would it be worth sourcing these from a script? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378168) Time Spent: 5h 40m (was: 5.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=378167=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378167 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 11:44 Start Date: 28/Jan/20 11:44 Worklog Time Spent: 10m Work Description: mxm commented on pull request #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r371752564 ## File path: release/src/main/scripts/build_release_candidate.sh ## @@ -45,6 +45,9 @@ PYTHON_ARTIFACTS_DIR=python BEAM_ROOT_DIR=beam WEBSITE_ROOT_DIR=beam-site +DOCKER_IMAGE_DEFAULT_REPO_ROOT=apache +DOCKER_IMAGE_DEFAULT_REPO_PREFIX=beam_ Review comment: Would it be worth sourcing these from a script? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378167) Time Spent: 5h 40m (was: 5.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=378163=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378163 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 11:38 Start Date: 28/Jan/20 11:38 Worklog Time Spent: 10m Work Description: mxm commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-579205196 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378163) Time Spent: 5.5h (was: 5h 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=377968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377968 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 01:22 Start Date: 28/Jan/20 01:22 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-579035289 :upside_down_face: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377968) Time Spent: 5h 10m (was: 5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=377969=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377969 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 01:22 Start Date: 28/Jan/20 01:22 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-579035289 :upside_down_face: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377969) Time Spent: 5h 20m (was: 5h 10m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h 20m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=377951=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377951 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 01:03 Start Date: 28/Jan/20 01:03 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-579030701 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377951) Time Spent: 5h (was: 4h 50m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=377944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377944 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 28/Jan/20 00:52 Start Date: 28/Jan/20 00:52 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-579028123 @ibzib , can we retrigger the test? I resolved conflicts from master. And about website task, I cannot reproduce the failure locally with head. Let's run it one more time to see if it is still happening. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377944) Time Spent: 4h 50m (was: 4h 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 4h 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375971=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375971 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 23/Jan/20 00:02 Start Date: 23/Jan/20 00:02 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577443564 > I wonder if I just type random text, will it trigger tests? So it does -- that's really weird. Looks like task `:buildSrc:spotlessGroovy` is still failing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375971) Time Spent: 4h 40m (was: 4.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 4h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375969=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375969 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 23:56 Start Date: 22/Jan/20 23:56 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577441958 I wonder if I just type random text, will it trigger tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375969) Time Spent: 4.5h (was: 4h 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 4.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375967=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375967 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 23:34 Start Date: 22/Jan/20 23:34 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [DO NOT MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577436451 @ibzib , the PR needs your magic words to run the tests :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375967) Time Spent: 4h 20m (was: 4h 10m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 4h 20m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375794=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375794 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 18:43 Start Date: 22/Jan/20 18:43 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577327559 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375794) Time Spent: 4h 10m (was: 4h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 4h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375779=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375779
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 22/Jan/20 18:04
Start Date: 22/Jan/20 18:04
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10612: [NOT READY TO
MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369716503
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java
##
@@ -59,10 +59,22 @@ public String getSdkVersion() {
return getProperties().get("sdk_version");
}
+ /** Provides docker image default root (apache). */
+ public String getDefaultDockerRepoRoot() {
+return getProperties().get("docker_image_default_repo_root");
+ }
+
+ /** Provides docker image default repo prefix (beam-). */
Review comment:
```suggestion
/** Provides docker image default repo prefix (beam_). */
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 375779)
Time Spent: 4h (was: 3h 50m)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375778=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375778
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 22/Jan/20 18:04
Start Date: 22/Jan/20 18:04
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10612: [NOT READY TO
MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369716555
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java
##
@@ -59,10 +59,22 @@ public String getSdkVersion() {
return getProperties().get("sdk_version");
}
+ /** Provides docker image default root (apache). */
+ public String getDefaultDockerRepoRoot() {
+return getProperties().get("docker_image_default_repo_root");
+ }
+
+ /** Provides docker image default repo prefix (beam-). */
+ public String getDefaultDockerRepoPrefix() {
+return getProperties().get("docker_image_default_repo_prefix");
+ }
+
/
private static final Logger LOG = LoggerFactory.getLogger(ReleaseInfo.class);
private static final String DEFAULT_NAME = "Apache Beam SDK for Java";
private static final String DEFAULT_VERSION = "Unknown";
+ private static final String DEFAULT_DOCKER_IMAGE_ROOT = "apache";
+ private static final String DEFAULT_DOCKER_IMAGE_PREFIX = "beam-";
Review comment:
```suggestion
private static final String DEFAULT_DOCKER_IMAGE_PREFIX = "beam_";
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 375778)
Time Spent: 4h (was: 3h 50m)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375776=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375776 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 18:03 Start Date: 22/Jan/20 18:03 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577311337 Flink test failure looks related: `Unable to find image 'apache/beam-java_sdk:2.20.0.dev'` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375776) Time Spent: 3h 50m (was: 3h 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3h 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375775=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375775 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 18:02 Start Date: 22/Jan/20 18:02 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577310929 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375775) Time Spent: 3h 40m (was: 3.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375774=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375774 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 22/Jan/20 18:00 Start Date: 22/Jan/20 18:00 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-577310424 @ibzib , can we retest those two failed tasks. though I don't think the failures are due to fix of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375774) Time Spent: 3.5h (was: 3h 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375277=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375277 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 23:07 Start Date: 21/Jan/20 23:07 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576929102 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375277) Time Spent: 3h 20m (was: 3h 10m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3h 20m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375253=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375253 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 22:25 Start Date: 21/Jan/20 22:25 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576914372 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375253) Time Spent: 3h 10m (was: 3h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375207=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375207 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 20:50 Start Date: 21/Jan/20 20:50 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576875279 > I don't think there is any hard coded prefix. I still see many instances of `apache/beam-`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375207) Time Spent: 3h (was: 2h 50m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 3h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375192 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 20:02 Start Date: 21/Jan/20 20:02 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576855960 > >I also want to make sure that you paid additional attention to check if there are some files should be included in the PR? > I think you got all of them (judging by git grep --files-with-matches apachebeam). If not, we can always fix later. Yes, this is what I did when I filter files I need to change. I wondered if it would break some tests etc, not able to catch with grep. Let's run pre commit test, merge it and run post commit tests and see how it goes. > > can you please run retest phase to trigger the test? > > I'll retest after all the prefixes are corrected. I don't think there is any hard coded prefix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375192) Time Spent: 2h 40m (was: 2.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2h 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375193 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 20:02 Start Date: 21/Jan/20 20:02 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576855960 > >I also want to make sure that you paid additional attention to check if there are some files should be included in the PR? > I think you got all of them (judging by git grep --files-with-matches apachebeam). If not, we can always fix later. Yes, this is what I did when I filter files I need to change. I wondered if it would break some tests etc, not able to catch with grep. Let's run pre commit test, merge it and run post commit tests and see how it goes. > > can you please run retest phase to trigger the test? > > I'll retest after all the prefixes are corrected. I don't think there is any hard coded prefix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375193) Time Spent: 2h 50m (was: 2h 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2h 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375189=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375189 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 19:55 Start Date: 21/Jan/20 19:55 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576852929 > I also want to make sure that you paid additional attention to check if there are some files should be included in the PR? I think you got all of them (judging by `git grep --files-with-matches apachebeam`). If not, we can always fix later. > can you please run retest phase to trigger the test? I'll retest after all the prefixes are corrected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375189) Time Spent: 2.5h (was: 2h 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375188 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 19:52 Start Date: 21/Jan/20 19:52 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r369209735 ## File path: gradle.properties ## @@ -27,3 +27,6 @@ version=2.20.0-SNAPSHOT sdk_version=2.20.0.dev javaVersion=1.8 + +docker_image_default_repo_root=apache +docker_image_default_repo_prefix=beam- Review comment: Thanks! Make sure you also change the prefix everywhere it needs to be hard-coded. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375188) Time Spent: 2h 20m (was: 2h 10m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2h 20m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375185 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 19:33 Start Date: 21/Jan/20 19:33 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-576843287 @ibzib , can you please run retest phase to trigger the test? I also want to make sure that you paid additional attention to check if there are some files should be included in the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375185) Time Spent: 2h 10m (was: 2h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375179 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 19:31 Start Date: 21/Jan/20 19:31 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r369199971 ## File path: gradle.properties ## @@ -27,3 +27,6 @@ version=2.20.0-SNAPSHOT sdk_version=2.20.0.dev javaVersion=1.8 + +docker_image_default_repo_root=apache +docker_image_default_repo_prefix=beam- Review comment: changed it to underscore. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375179) Time Spent: 2h (was: 1h 50m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 2h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375158 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 19:13 Start Date: 21/Jan/20 19:13 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r369190980 ## File path: gradle.properties ## @@ -27,3 +27,6 @@ version=2.20.0-SNAPSHOT sdk_version=2.20.0.dev javaVersion=1.8 + +docker_image_default_repo_root=apache +docker_image_default_repo_prefix=beam- Review comment: Ideally we would be able to use a subrepo or a slash in the image name, but since those are not supported by Docker, I don't think mixing hyphens and underscores is a good alternative. I think most users would expect either only hyphens or only underscores (the two are seldom mixed within the same string), so having both makes tags more difficult to use for humans (harder to remember and easy to make typos). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375158) Time Spent: 1h 50m (was: 1h 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 1h 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375156
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 21/Jan/20 19:02
Start Date: 21/Jan/20 19:02
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10612: [NOT READY TO
MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369185959
##
File path: runners/spark/job-server/container/build.gradle
##
@@ -54,9 +54,10 @@ task copyDockerfileDependencies(type: Copy) {
}
docker {
- name containerImageName(name: 'spark-job-server',
+ name containerImageName(name: ${project.docker_image_default_repo_prefix} +
'job-server',
Review comment:
I suppose it should probably use underscores like everywhere else.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 375156)
Time Spent: 1h 40m (was: 1.5h)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375132=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375132
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 21/Jan/20 18:26
Start Date: 21/Jan/20 18:26
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #10612: [NOT
READY TO MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369167223
##
File path: runners/spark/job-server/container/build.gradle
##
@@ -54,9 +54,10 @@ task copyDockerfileDependencies(type: Copy) {
}
docker {
- name containerImageName(name: 'spark-job-server',
+ name containerImageName(name: ${project.docker_image_default_repo_prefix} +
'job-server',
Review comment:
Fixed it.
Is there any reason we used `-` instead of `_` for `spark-job-server`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 375132)
Time Spent: 1.5h (was: 1h 20m)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375131
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 21/Jan/20 18:25
Start Date: 21/Jan/20 18:25
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #10612: [NOT
READY TO MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r369167223
##
File path: runners/spark/job-server/container/build.gradle
##
@@ -54,9 +54,10 @@ task copyDockerfileDependencies(type: Copy) {
}
docker {
- name containerImageName(name: 'spark-job-server',
+ name containerImageName(name: ${project.docker_image_default_repo_prefix} +
'job-server',
Review comment:
Fix it.
Is there any reason we used `-` instead of `_` for `spark-job-server`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 375131)
Time Spent: 1h 20m (was: 1h 10m)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=375130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375130 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 21/Jan/20 18:24 Start Date: 21/Jan/20 18:24 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r369166808 ## File path: gradle.properties ## @@ -27,3 +27,6 @@ version=2.20.0-SNAPSHOT sdk_version=2.20.0.dev javaVersion=1.8 + +docker_image_default_repo_root=apache +docker_image_default_repo_prefix=beam- Review comment: This is intended in order to distinguish project name and image name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375130) Time Spent: 1h 10m (was: 1h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[
https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373871
]
ASF GitHub Bot logged work on BEAM-9063:
Author: ASF GitHub Bot
Created on: 17/Jan/20 21:02
Start Date: 17/Jan/20 21:02
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10612: [NOT READY TO
MERGE][BEAM-9063] migrate docker images to apache
URL: https://github.com/apache/beam/pull/10612#discussion_r368134576
##
File path: runners/spark/job-server/container/build.gradle
##
@@ -54,9 +54,10 @@ task copyDockerfileDependencies(type: Copy) {
}
docker {
- name containerImageName(name: 'spark-job-server',
+ name containerImageName(name: ${project.docker_image_default_repo_prefix} +
'job-server',
Review comment:
Looks like we lost `spark` here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 373871)
Time Spent: 1h (was: 50m)
> Migrate docker images to apache namespace.
> --
>
> Key: BEAM-9063
> URL: https://issues.apache.org/jira/browse/BEAM-9063
> Project: Beam
> Issue Type: Task
> Components: beam-community
>Reporter: Hannah Jiang
>Assignee: Hannah Jiang
>Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> https://hub.docker.com/u/apache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373870=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373870 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 17/Jan/20 21:02 Start Date: 17/Jan/20 21:02 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#discussion_r368133471 ## File path: gradle.properties ## @@ -27,3 +27,6 @@ version=2.20.0-SNAPSHOT sdk_version=2.20.0.dev javaVersion=1.8 + +docker_image_default_repo_root=apache +docker_image_default_repo_prefix=beam- Review comment: Elsewhere, we use underscores in our docker image names (e.g. `java_sdk`). We should use an underscore here to keep it consistent. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373870) Time Spent: 50m (was: 40m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 50m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373787=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373787 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 17/Jan/20 18:56 Start Date: 17/Jan/20 18:56 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-575751659 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373787) Time Spent: 40m (was: 0.5h) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 40m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373273 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 16/Jan/20 21:50 Start Date: 16/Jan/20 21:50 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-575363276 To reviewers, please take additional care to review if I missed any places should be updated but missed from the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373273) Time Spent: 0.5h (was: 20m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 0.5h > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373272 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 16/Jan/20 21:46 Start Date: 16/Jan/20 21:46 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on issue #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612#issuecomment-575362138 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373272) Time Spent: 20m (was: 10m) > Migrate docker images to apache namespace. > -- > > Key: BEAM-9063 > URL: https://issues.apache.org/jira/browse/BEAM-9063 > Project: Beam > Issue Type: Task > Components: beam-community >Reporter: Hannah Jiang >Assignee: Hannah Jiang >Priority: Major > Fix For: Not applicable > > Time Spent: 20m > Remaining Estimate: 0h > > https://hub.docker.com/u/apache -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9063) Migrate docker images to apache namespace.
[ https://issues.apache.org/jira/browse/BEAM-9063?focusedWorklogId=373238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373238 ] ASF GitHub Bot logged work on BEAM-9063: Author: ASF GitHub Bot Created on: 16/Jan/20 20:00 Start Date: 16/Jan/20 20:00 Worklog Time Spent: 10m Work Description: Hannah-Jiang commented on pull request #10612: [NOT READY TO MERGE][BEAM-9063] migrate docker images to apache URL: https://github.com/apache/beam/pull/10612 Migrate docker images to apache. docker image names change from apachebeam/repo:tag to apache/beam-repo:tag. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [