[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=410028=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410028 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 26/Mar/20 02:06 Start Date: 26/Mar/20 02:06 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 410028) Time Spent: 1h (was: 50m) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' > > > Key: BEAM-9214 > URL: https://issues.apache.org/jira/browse/BEAM-9214 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Labels: portability-flink > Time Spent: 1h > Remaining Estimate: 0h > > I've seen this error myself, and had multiple users report it, but I don't > know what causes it. In this case, it happened when using > --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User > reported job worked when retried; I have no idea why that might happen.) > INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8 > INFO:root:Job state changed to STOPPED > INFO:root:Job state changed to RUNNING > Traceback (most recent call last): > File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main > "__main__", mod_spec) > File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code > exec(code, run_globals) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 138, in > run() > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 124, in run > query_result = result.metrics().query(empty_lines_filter) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py", > line 390, in metrics > beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id)) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=410027=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410027 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 26/Mar/20 02:06 Start Date: 26/Mar/20 02:06 Worklog Time Spent: 10m Work Description: ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604185790 Fix for root cause is in #11214, making this not so necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 410027) Time Spent: 50m (was: 40m) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' > > > Key: BEAM-9214 > URL: https://issues.apache.org/jira/browse/BEAM-9214 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Labels: portability-flink > Time Spent: 50m > Remaining Estimate: 0h > > I've seen this error myself, and had multiple users report it, but I don't > know what causes it. In this case, it happened when using > --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User > reported job worked when retried; I have no idea why that might happen.) > INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8 > INFO:root:Job state changed to STOPPED > INFO:root:Job state changed to RUNNING > Traceback (most recent call last): > File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main > "__main__", mod_spec) > File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code > exec(code, run_globals) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 138, in > run() > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 124, in run > query_result = result.metrics().query(empty_lines_filter) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py", > line 390, in metrics > beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id)) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=410002=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410002 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 26/Mar/20 01:04 Start Date: 26/Mar/20 01:04 Worklog Time Spent: 10m Work Description: ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604169079 Tests are failing because in some places, `JobServiceStub` instead of `JobServiceServicer`. `JobServiceStub` does not accept the `context` argument, while `JobServiceServicer` does. (I find this strange, because I assumed that if they have the same methods, those methods would have the same signature. Otherwise it seems like a violation of [LSP](https://en.wikipedia.org/wiki/Liskov_substitution_principle).) Since `JobServiceServicer` will fail anyway because none of its methods are implemented, I suppose it is okay to keep the status quo. Unless there is some Python magic I can use to fix this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 410002) Time Spent: 40m (was: 0.5h) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' > > > Key: BEAM-9214 > URL: https://issues.apache.org/jira/browse/BEAM-9214 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Labels: portability-flink > Time Spent: 40m > Remaining Estimate: 0h > > I've seen this error myself, and had multiple users report it, but I don't > know what causes it. In this case, it happened when using > --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User > reported job worked when retried; I have no idea why that might happen.) > INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8 > INFO:root:Job state changed to STOPPED > INFO:root:Job state changed to RUNNING > Traceback (most recent call last): > File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main > "__main__", mod_spec) > File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code > exec(code, run_globals) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 138, in > run() > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 124, in run > query_result = result.metrics().query(empty_lines_filter) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py", > line 390, in metrics > beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id)) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=409989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409989 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 26/Mar/20 00:29 Start Date: 26/Mar/20 00:29 Worklog Time Spent: 10m Work Description: ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604159640 > Could you elaborate on why this change is needed? @kamilwu Check out the [jira](https://issues.apache.org/jira/browse/BEAM-9214). The current code assumes the `context` argument is optional, but the generated code in the default implementation requires it, meaning instead of getting the correct error (`NotImplementedError`) I was getting a confusing `TypeError`. I will fix that underlying issue in a different PR, however we should change this code so that it provides the proper error message to the next person who runs into it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409989) Time Spent: 0.5h (was: 20m) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' > > > Key: BEAM-9214 > URL: https://issues.apache.org/jira/browse/BEAM-9214 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Labels: portability-flink > Time Spent: 0.5h > Remaining Estimate: 0h > > I've seen this error myself, and had multiple users report it, but I don't > know what causes it. In this case, it happened when using > --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User > reported job worked when retried; I have no idea why that might happen.) > INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8 > INFO:root:Job state changed to STOPPED > INFO:root:Job state changed to RUNNING > Traceback (most recent call last): > File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main > "__main__", mod_spec) > File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code > exec(code, run_globals) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 138, in > run() > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 124, in run > query_result = result.metrics().query(empty_lines_filter) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py", > line 390, in metrics > beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id)) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=409448=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409448 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 25/Mar/20 11:15 Start Date: 25/Mar/20 11:15 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-603783082 Could you elaborate on why this change is needed? I see that proto representation of `GetJobMetricsRequest` hasn't changed recently: https://github.com/apache/beam/blob/af8559da52e9d67bd3a069da4d51698108336723/model/job-management/src/main/proto/beam_job_api.proto#L257-L259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409448) Time Spent: 20m (was: 10m) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' > > > Key: BEAM-9214 > URL: https://issues.apache.org/jira/browse/BEAM-9214 > Project: Beam > Issue Type: Bug > Components: runner-flink >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Labels: portability-flink > Time Spent: 20m > Remaining Estimate: 0h > > I've seen this error myself, and had multiple users report it, but I don't > know what causes it. In this case, it happened when using > --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User > reported job worked when retried; I have no idea why that might happen.) > INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8 > INFO:root:Job state changed to STOPPED > INFO:root:Job state changed to RUNNING > Traceback (most recent call last): > File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main > "__main__", mod_spec) > File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code > exec(code, run_globals) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 138, in > run() > File > "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py", > line 124, in run > query_result = result.metrics().query(empty_lines_filter) > File > "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py", > line 390, in metrics > beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id)) > TypeError: GetJobMetrics() missing 1 required positional argument: 'context' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9214) TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
[ https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=409211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409211 ] ASF GitHub Bot logged work on BEAM-9214: Author: ASF GitHub Bot Created on: 25/Mar/20 00:21 Start Date: 25/Mar/20 00:21 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[