[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383913=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383913 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 08/Feb/20 02:24 Start Date: 08/Feb/20 02:24 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583692833 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383913) Time Spent: 2h (was: 1h 50m) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383914 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 08/Feb/20 02:24 Start Date: 08/Feb/20 02:24 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583692833 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383914) Time Spent: 2h 10m (was: 2h) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383871 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 07/Feb/20 23:21 Start Date: 07/Feb/20 23:21 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383871) Time Spent: 1h 50m (was: 1h 40m) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383843 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 07/Feb/20 21:33 Start Date: 07/Feb/20 21:33 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583623774 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383843) Time Spent: 1h 40m (was: 1.5h) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383778=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383778 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 07/Feb/20 18:40 Start Date: 07/Feb/20 18:40 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583547805 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383778) Time Spent: 1.5h (was: 1h 20m) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383777=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383777 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 07/Feb/20 18:40 Start Date: 07/Feb/20 18:40 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583547660 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383777) Time Spent: 1h 20m (was: 1h 10m) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383623 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 07/Feb/20 14:49 Start Date: 07/Feb/20 14:49 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583422810 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383623) Time Spent: 1h 10m (was: 1h) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[
https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383165=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383165
]
ASF GitHub Bot logged work on BEAM-9262:
Author: ASF GitHub Bot
Created on: 06/Feb/20 21:21
Start Date: 06/Feb/20 21:21
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10789: [BEAM-9262]
Clean-up endpoints.proto to a stable state
URL: https://github.com/apache/beam/pull/10789#discussion_r376088440
##
File path: model/pipeline/src/main/proto/endpoints.proto
##
@@ -28,20 +28,38 @@ option go_package = "pipeline_v1";
option java_package = "org.apache.beam.model.pipeline.v1";
option java_outer_classname = "Endpoints";
+// A description of how to connect to a Beam API endpoint.
message ApiServiceDescriptor {
// (Required) The URL to connect to.
- string url = 2;
+ string url = 1;
Review comment:
Gotcha, sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383165)
Time Spent: 1h (was: 50m)
> Update ApiServiceDescriptor to have open ended authentication method
>
>
> Key: BEAM-9262
> URL: https://issues.apache.org/jira/browse/BEAM-9262
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently the ApiServiceDescriptor uses a oneof field for authentication
> which requires users to add additional types explicitly to the list instead
> of using urn + payload mechanism allowing for anyone to extend this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[
https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383115
]
ASF GitHub Bot logged work on BEAM-9262:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:49
Start Date: 06/Feb/20 19:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10789: [BEAM-9262]
Clean-up endpoints.proto to a stable state
URL: https://github.com/apache/beam/pull/10789#discussion_r376046318
##
File path: model/pipeline/src/main/proto/endpoints.proto
##
@@ -28,20 +28,38 @@ option go_package = "pipeline_v1";
option java_package = "org.apache.beam.model.pipeline.v1";
option java_outer_classname = "Endpoints";
+// A description of how to connect to a Beam API endpoint.
message ApiServiceDescriptor {
// (Required) The URL to connect to.
- string url = 2;
+ string url = 1;
Review comment:
Externally we will be consistent but I'll need to ensure that within Google
I renumber this field atomically which I'm working on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383115)
Time Spent: 40m (was: 0.5h)
> Update ApiServiceDescriptor to have open ended authentication method
>
>
> Key: BEAM-9262
> URL: https://issues.apache.org/jira/browse/BEAM-9262
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the ApiServiceDescriptor uses a oneof field for authentication
> which requires users to add additional types explicitly to the list instead
> of using urn + payload mechanism allowing for anyone to extend this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[
https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383116
]
ASF GitHub Bot logged work on BEAM-9262:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:49
Start Date: 06/Feb/20 19:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10789: [BEAM-9262]
Clean-up endpoints.proto to a stable state
URL: https://github.com/apache/beam/pull/10789#discussion_r376046318
##
File path: model/pipeline/src/main/proto/endpoints.proto
##
@@ -28,20 +28,38 @@ option go_package = "pipeline_v1";
option java_package = "org.apache.beam.model.pipeline.v1";
option java_outer_classname = "Endpoints";
+// A description of how to connect to a Beam API endpoint.
message ApiServiceDescriptor {
// (Required) The URL to connect to.
- string url = 2;
+ string url = 1;
Review comment:
Externally we will be consistent but I'll need to ensure that within Google
I renumber this field atomically which I'm working on.
Many of our internal usages also rely on the textual version of the proto
and not the binary version.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383116)
Time Spent: 50m (was: 40m)
> Update ApiServiceDescriptor to have open ended authentication method
>
>
> Key: BEAM-9262
> URL: https://issues.apache.org/jira/browse/BEAM-9262
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently the ApiServiceDescriptor uses a oneof field for authentication
> which requires users to add additional types explicitly to the list instead
> of using urn + payload mechanism allowing for anyone to extend this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[
https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383099
]
ASF GitHub Bot logged work on BEAM-9262:
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:32
Start Date: 06/Feb/20 19:32
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10789: [BEAM-9262]
Clean-up endpoints.proto to a stable state
URL: https://github.com/apache/beam/pull/10789#discussion_r376032746
##
File path: model/pipeline/src/main/proto/endpoints.proto
##
@@ -28,20 +28,38 @@ option go_package = "pipeline_v1";
option java_package = "org.apache.beam.model.pipeline.v1";
option java_outer_classname = "Endpoints";
+// A description of how to connect to a Beam API endpoint.
message ApiServiceDescriptor {
// (Required) The URL to connect to.
- string url = 2;
+ string url = 1;
Review comment:
I assume this proto message isn't in common use yet, right? Because changing
the field number seems risky otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 383099)
Time Spent: 0.5h (was: 20m)
> Update ApiServiceDescriptor to have open ended authentication method
>
>
> Key: BEAM-9262
> URL: https://issues.apache.org/jira/browse/BEAM-9262
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
>Reporter: Luke Cwik
>Assignee: Luke Cwik
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the ApiServiceDescriptor uses a oneof field for authentication
> which requires users to add additional types explicitly to the list instead
> of using urn + payload mechanism allowing for anyone to extend this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383083 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 06/Feb/20 19:18 Start Date: 06/Feb/20 19:18 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789#issuecomment-583065991 R: @youngoli I'll work on fixing the internal UW code because of the field id rename. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383083) Time Spent: 20m (was: 10m) > Update ApiServiceDescriptor to have open ended authentication method > > > Key: BEAM-9262 > URL: https://issues.apache.org/jira/browse/BEAM-9262 > Project: Beam > Issue Type: Sub-task > Components: beam-model >Reporter: Luke Cwik >Assignee: Luke Cwik >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently the ApiServiceDescriptor uses a oneof field for authentication > which requires users to add additional types explicitly to the list instead > of using urn + payload mechanism allowing for anyone to extend this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9262) Update ApiServiceDescriptor to have open ended authentication method
[ https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383076 ] ASF GitHub Bot logged work on BEAM-9262: Author: ASF GitHub Bot Created on: 06/Feb/20 19:15 Start Date: 06/Feb/20 19:15 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10789: [BEAM-9262] Clean-up endpoints.proto to a stable state URL: https://github.com/apache/beam/pull/10789 Move authentication to follow the urn + payload method of specification. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [