[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064743953 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed Done: https://github.com/apache/bookkeeper/pull/3092 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1064718307 > Merged to master branch. Feel free to add the tests if you want as follow up work. Not strictly needed OK, I will add unit tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1053548491 > > > Do we have tests about DeletedValue and the raw contents of the structures? > > > Is it worth to add some little test? > > > We can use PowerMock/Whitebox or pure java reflection to access the internals > > > > > > @eolivelli Do you mean to add some tests to verify that the count of expansions is actually reduced? > > Yes @eolivelli If I want to verify whether the number of expansions is reduced through unit testing, then I need to add a new configuration, such as: isCleanDeletedStatus=true, to control whether the new logic is enabled, so as to compare whether the number of expansions is reduced before and after it is enabled. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1051833829 > Do we have tests about DeletedValue and the raw contents of the structures? Is it worth to add some little test? We can use PowerMock/Whitebox or pure java reflection to access the internals @eolivelli Didn't understand what you meant? Add a test to verify that the number of expansions has decreased? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1048090266 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047949861 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047760282 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3072: reduce unnecessary expansions for ConcurrentLong map and set
lordcheng10 commented on pull request #3072: URL: https://github.com/apache/bookkeeper/pull/3072#issuecomment-1047451487 @eolivelli @merlimat PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
