[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools
eolivelli commented on a change in pull request #1682: Added BlockingQueue
implementation based on JCtools
URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232418458
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##
@@ -1339,7 +1338,8 @@ public void writeComplete(int rc, long ledgerId, long
entryId,
* This method is idempotent. Once a ledger is fenced, it can
* never be unfenced. Fencing a fenced ledger has no effect.
*/
-public SettableFuture fenceLedger(long ledgerId, byte[]
masterKey) throws IOException, BookieException {
+public SettableFuture fenceLedger(long ledgerId, byte[] masterKey)
+throws IOException, BookieException, InterruptedException {
Review comment:
Same problem here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools
eolivelli commented on a change in pull request #1682: Added BlockingQueue
implementation based on JCtools
URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232077650
##
File path:
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/BusyWait.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.common.collections;
+
+import java.lang.invoke.MethodHandle;
+import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodType;
+
+import lombok.experimental.UtilityClass;
+
+/**
+ * Utility class to use "Thread.onSpinWait()" when available.
+ */
+@UtilityClass
+public class BusyWait {
+
+/**
+ * If available (Java 9+), use intrinsic {@link Thread#onSpinWait} which
will
+ * reduce CPU consumption during the wait, otherwise fallback to regular
+ * spinning.
+ */
+public static void onSpinWait() {
+if (ON_SPIN_WAIT != null) {
+try {
+ON_SPIN_WAIT.invokeExact();
+} catch (Throwable t) {
+// Ignore
+}
+}
+}
+
+private static final MethodHandle ON_SPIN_WAIT;
+
+static {
+MethodHandle handle = null;
+try {
+handle = MethodHandles.lookup().findStatic(Thread.class,
"onSpinWait", MethodType.methodType(void.class));
+} catch (Throwable t) {
+// Ignore
+}
Review comment:
We should log this error, so that it is clear that we are not able to
leverage this feature
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools
eolivelli commented on a change in pull request #1682: Added BlockingQueue
implementation based on JCtools
URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232078181
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java
##
@@ -116,7 +117,7 @@ ByteBuf getExplicitLac() {
* @param journal log the fence entry in the Journal
* @return A future which will be satisfied when add entry to journal
complete
*/
-private SettableFuture logFenceEntryInJournal(Journal journal) {
+private SettableFuture logFenceEntryInJournal(Journal journal)
throws InterruptedException {
Review comment:
This method returns a Future, I wonder if it is okay to throw the
Interrupted Exception or to return a failed Future
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools
eolivelli commented on a change in pull request #1682: Added BlockingQueue
implementation based on JCtools
URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r218301149
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java
##
@@ -236,6 +236,10 @@ protected ReadResponse getReadResponse() {
} catch (IOException e) {
LOG.error("IOException while reading entry: {} from ledger {} ",
entryId, ledgerId, e);
return buildResponse(readResponse, StatusCode.EIO, startTimeSw);
+} catch (InterruptedException e) {
+Thread.currentThread().interrupt();
+LOG.error("InterruptedException while reading entry: {} from
ledger {} ", entryId, ledgerId, e);
+return buildResponse(readResponse, StatusCode.EIO, startTimeSw);
Review comment:
Kill -9 does not set interrupted flag on thread
This is a java artifact, it is a flag on the thread that mean 'please stop'
and it is not a real signal from SO
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
