[jira] [Resolved] (CALCITE-2196) Tweak janino code generation to allow debugging
[ https://issues.apache.org/jira/browse/CALCITE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2196. -- Resolution: Fixed Fixed in [fb3213c3|http://git-wip-us.apache.org/repos/asf/calcite/commit/fb3213c3]; thanks for the PR, [~jinyu.zj]! > Tweak janino code generation to allow debugging > --- > > Key: CALCITE-2196 > URL: https://issues.apache.org/jira/browse/CALCITE-2196 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: jingzhang >Assignee: Julian Hyde >Priority: Trivial > Fix For: 1.16.0 > > > To allow debugging generated code, update codeGen of metadataHandler in > JaninoRelMetadataProvider to include Class definition at begin of dynamic > code. > JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. > The generated classes can not be debugged in interactively using Idea using > the method referenced by http://janino-compiler.github.io/janino/ because > generated code only contains classBody. > If using ISimpleCompiler to compile complete compile unit instead of > classBody, we could step into the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2196) Tweak janino code generation to allow debugging
[ https://issues.apache.org/jira/browse/CALCITE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2196: - Description: To allow debugging generated code, update codeGen of metadataHandler in JaninoRelMetadataProvider to include Class definition at begin of dynamic code. JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. The generated classes can not be debugged in interactively using Idea using the method referenced by http://janino-compiler.github.io/janino/ because generated code only contains classBody. If using ISimpleCompiler to compile complete compile unit instead of classBody, we could step into the code. was: Update codeGen of metadataHandler in JaninoRelMetadataProvider to include Class definition at begin of dynamic code. JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. The generated classes can not be debugged in interactively using Idea using the method referenced by http://janino-compiler.github.io/janino/ because generated code only contains classBody. If using ISimpleCompiler to compile complete compile unit instead of classBody, we could step into the code. > Tweak janino code generation to allow debugging > --- > > Key: CALCITE-2196 > URL: https://issues.apache.org/jira/browse/CALCITE-2196 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: jingzhang >Assignee: Julian Hyde >Priority: Trivial > Fix For: 1.16.0 > > > To allow debugging generated code, update codeGen of metadataHandler in > JaninoRelMetadataProvider to include Class definition at begin of dynamic > code. > JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. > The generated classes can not be debugged in interactively using Idea using > the method referenced by http://janino-compiler.github.io/janino/ because > generated code only contains classBody. > If using ISimpleCompiler to compile complete compile unit instead of > classBody, we could step into the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2196) Tweak janino code generation to allow debugging
[ https://issues.apache.org/jira/browse/CALCITE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2196: - Description: Update codeGen of metadataHandler in JaninoRelMetadataProvider to include Class definition at begin of dynamic code. JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. The generated classes can not be debugged in interactively using Idea using the method referenced by http://janino-compiler.github.io/janino/ because generated code only contains classBody. If using ISimpleCompiler to compile complete compile unit instead of classBody, we could step into the code. was: JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. The generated classes can not be debugged in interactively using Idea using the method referenced by http://janino-compiler.github.io/janino/ because generated code only contains classBody. If using ISimpleCompiler to compile complete compile unit instead of classBody, we could step into the code. > Tweak janino code generation to allow debugging > --- > > Key: CALCITE-2196 > URL: https://issues.apache.org/jira/browse/CALCITE-2196 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: jingzhang >Assignee: Julian Hyde >Priority: Trivial > Fix For: 1.16.0 > > > Update codeGen of metadataHandler in JaninoRelMetadataProvider to include > Class definition at begin of dynamic code. > JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. > The generated classes can not be debugged in interactively using Idea using > the method referenced by http://janino-compiler.github.io/janino/ because > generated code only contains classBody. > If using ISimpleCompiler to compile complete compile unit instead of > classBody, we could step into the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2196) Tweak janino code generation to allow debugging
[ https://issues.apache.org/jira/browse/CALCITE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2196: - Summary: Tweak janino code generation to allow debugging (was: Update codeGen of metadataHandler in JaninoRelMetadataProvider to include Class definition at begin of dynamic code.) > Tweak janino code generation to allow debugging > --- > > Key: CALCITE-2196 > URL: https://issues.apache.org/jira/browse/CALCITE-2196 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: jingzhang >Assignee: Julian Hyde >Priority: Trivial > Fix For: 1.16.0 > > > JaninoRelMetadataProvider uses IClassBodyEvaluator to compile generated code. > The generated classes can not be debugged in interactively using Idea using > the method referenced by http://janino-compiler.github.io/janino/ because > generated code only contains classBody. > If using ISimpleCompiler to compile complete compile unit instead of > classBody, we could step into the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2045) Support "CREATE TYPE" DDL
[ https://issues.apache.org/jira/browse/CALCITE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380943#comment-16380943 ] Julian Hyde commented on CALCITE-2045: -- Reviewing [2add2e4|https://github.com/apache/calcite/pull/638/commits/2add2e4dfd0916aea8061391c91f8148066981db]: * It's a very good start. You've got the design exactly as I'd have done it. * A few places (e.g. the `typeEntry` method, and in `JsonRoot`) you have copy-pasted "table" stuff to "type", but haven't fixed all the comments. * I'd rename `JsonAttribute` to `JsonTypeAttribute` * for completeness we need a `DROP TYPE [IF EXISTS]` statement * I don't like moving `SqlDdlNodes.schema` to `Util`. Maybe you need to create `SqlValidatorUtil.getTypeEntry` similar to `getTableEntry`. And leave `SqlDdlNodes.schema` where it is. * The new error message in SqlValidatorTest.testCastFails is not good enough. Should not contain 'UnsupportedOperationException' * Need more tests in `SqlValidatorTest` (positive and negative, e.g. types qualified by schema, referencing a type attribute * Need a new test `type.iq` similar to `server/src/test/resources/sql/table.iq` * Need some new sections in `model.md` * In `reference.md`, don't use underscores; other identifiers are camel-case > Support "CREATE TYPE" DDL > - > > Key: CALCITE-2045 > URL: https://issues.apache.org/jira/browse/CALCITE-2045 > Project: Calcite > Issue Type: New Feature > Components: core >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2045) Support "CREATE TYPE" DDL
[ https://issues.apache.org/jira/browse/CALCITE-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379730#comment-16379730 ] Shuyi Chen edited comment on CALCITE-2045 at 2/28/18 8:25 AM: -- Hi [~julianhyde], initial [PR|https://github.com/apache/calcite/pull/638] is attached, could you please help take a look? was (Author: suez1224): [~julianhyde], initial [PR|https://github.com/apache/calcite/pull/638], could you please help take a look? > Support "CREATE TYPE" DDL > - > > Key: CALCITE-2045 > URL: https://issues.apache.org/jira/browse/CALCITE-2045 > Project: Calcite > Issue Type: New Feature > Components: core >Reporter: Shuyi Chen >Assignee: Shuyi Chen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
