[jira] [Comment Edited] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

[Zhenqiu Huang (Jira)]

[ 
https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932050#comment-16932050
 ] 

Zhenqiu Huang edited comment on CALCITE-3349 at 9/18/19 4:47 AM:
-

[~suez1224]
Make sense. Explicitly point out the missing implementation is a better idea.  
Added another ticket https://issues.apache.org/jira/browse/CALCITE-3358 as 
follow up task.


was (Author: zhenqiuhuang):
[~suez1224]
Make sense. Explicitly point out the missing implementation is a better idea. 

> Add Function DDL into SqlKind DDL enum
> --
>
> Key: CALCITE-3349
> URL: https://issues.apache.org/jira/browse/CALCITE-3349
> Project: Calcite
>  Issue Type: Improvement
>  Components: core
>Reporter: Zhenqiu Huang
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently, Create Function, Drop Function are not added into SqlKind DDL 
> enum. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

[Shuyi Chen (Jira)]

[ 
https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931726#comment-16931726
 ] 

Shuyi Chen edited comment on CALCITE-3349 at 9/17/19 6:22 PM:
--

Hi [~ZhenqiuHuang], I suggest implement SqlExecutableStatement for 
Sql\{Create/Drop}Function, and throw an exception to expose the problem 
explicitly. And then create a subsequent Jira to implement the execute() 
function. 

 

I understand it's not the intention of this PR, but given the reviewer resource 
as well as the size of the suggested changes, I think we can combine them in 
one PR. What do you think?


was (Author: suez1224):
Hi [~ZhenqiuHuang], I suggest implement SqlExecutableStatement for 
Sql\{Create/Drop}Function, and throw an exception to expose the problem 
explicitly. And then create a subsequent Jira to implement the execute() 
function. 

> Add Function DDL into SqlKind DDL enum
> --
>
> Key: CALCITE-3349
> URL: https://issues.apache.org/jira/browse/CALCITE-3349
> Project: Calcite
>  Issue Type: Improvement
>  Components: core
>Reporter: Zhenqiu Huang
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently, Create Function, Drop Function are not added into SqlKind DDL 
> enum. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)