[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981998#comment-15981998
 ] 

ASF GitHub Bot commented on CALCITE-1050:
-

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica/pull/2


> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-24 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981925#comment-15981925
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. Given the javadoc, I'd expect the above to work. For a TypedValue, I should 
get an Object which is suitable to be set as an Array on the PreparedStatement. 
However, the above throws a ClassCastException (trying to cast Object[] to 
Array).

Alright, I have convinced myself that the current javadoc on TypedValue is 
wrong. The reason we have not noticed this in the past is that HSQLDB will 
"coerce" {{Object[]}} (non-primitive type arrays) and {{List}} into 
columns of type {{ARRAY}}. For correctness: {{TypedValue.toJdbc(Calendar)}} 
should return an {{Array}}, not a {{List}}. Databases that happened to still 
work are just playing "nice".

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-19 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975335#comment-15975335
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. I don't think TypedValue is wrong. Its job is to send values over the wire, 
right? Array values aren't serializable, because they contain a connection. So 
I think you should serialize the values in the array (or map or struct or 
multiset) in something close to their native values then wrap them in your 
implementation of Array at the other end.

Yes, I agree with you on the serial/local forms. I'm more trying to reconcile 
what the docs say the JDBC form is used for. Here's a snippet of code which I'm 
trying to use to reason about this:

{code}
  @Test public void testSetJavaArray() throws Exception {
try (Connection conn = DriverManager.getConnection(url)) {
  Integer[] data = new Integer[] {1, 2, 3, 4, 5};
  final Array array = conn.createArrayOf("INTEGER", data);
  final TypedValue arrayTypedValue =
  TypedValue.ofJdbc(Rep.ARRAY, array, Unsafe.localCalendar());
  final String tableName = "SET_JAVA_ARRAY";
  try (Statement stmt = conn.createStatement()) {
assertFalse(stmt.execute("DROP TABLE IF EXISTS "  + tableName));
assertFalse(stmt.execute("CREATE TABLE " + tableName + "(pk integer not 
null primary key,"
+ " numbers integer array)"));
  }
  try (PreparedStatement pstmt = conn.prepareStatement("INSERT INTO " + 
tableName
  + " values(?,?)")) {
pstmt.setInt(1, 1);
pstmt.setArray(2, (Array) 
arrayTypedValue.toJdbc(Unsafe.localCalendar()));
assertEquals(1, pstmt.executeUpdate());
  }
  }
{code}

Given the javadoc, I'd expect the above to work. For a TypedValue, I should get 
an Object which is suitable to be set as an Array on the PreparedStatement. 
However, the above throws a ClassCastException (trying to cast Object[] to 
Array).

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-19 Thread Julian Hyde (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975266#comment-15975266
 ] 

Julian Hyde commented on CALCITE-1050:
--

I don't think {{TypedValue}} is wrong. Its job is to send values over the wire, 
right? {{Array}} values aren't serializable, because they contain a connection. 
So I think you should serialize the values in the array (or map or struct or 
multiset) in something close to their native values then wrap them in your 
implementation of {{Array}} at the other end.

I see you've added logic to AvaticaConnection.createArray to map type names to 
AvaticaType instances. At some point (not yet) we will want to convert that to 
a parser and caching map that can handle complex types and parameterized types 
such as "DECIMAL(10, 4)".

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-19 Thread Julian Hyde (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975199#comment-15975199
 ] 

Julian Hyde commented on CALCITE-1050:
--

As far as I can tell, a JDBC driver is safe to assume that every {{Array}} it 
sees is one of its own. If a user creates {{class MyArrayImpl implements 
Array}} and passes it to {{PreparedStatement.setArray}} they will get an error.

As a user, if I want to create an array, I must call 
[Connection.createArrayOf|https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#createArrayOf-java.lang.String-java.lang.Object:A-].

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-18 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973884#comment-15973884
 ] 

Josh Elser commented on CALCITE-1050:
-

Yeah, agreed on the Array interface portion, James. I think I saw the code I 
was stepping through was in some PData type classes, but I'd have to pull it up 
again.

My hunch here is that I've fallen into a typo in the docs, but maybe there's a 
reason this was documented as such :). Granted, even if this was the case, we'd 
still be getting the ClassCastExceptions (trying to cast a Avatica's ArrayImpl 
into PhoenixArray, but that's for another day).

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-18 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973868#comment-15973868
 ] 

James Taylor commented on CALCITE-1050:
---

A JDBC array is represented by the java.sql.Array interface 
(https://docs.oracle.com/javase/7/docs/api/java/sql/Array.html). It's entirely 
likely that Phoenix unit tests assume the backing implementation is a 
PhoenixArray.



> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-17 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971494#comment-15971494
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. Will see if I can avoid forcing a Calcite code-change.

While some of the API/interface changes I made in Avatica were simplifications 
(unused arguments in method signatures), I reverted the removals to make the 
upgrade to avatica 1.10.0 less painful in Calcite.

There is one failing test out of the box ({{JdbcTest.testPreparedStatement}} 
which expects a very specific exception message. Due to some unnecessary 
method-calls (as alluded to in the above sentence), an Exception is triggered 
in a different part of the code, and generates a different error message. I 
think we should just change the test itself in this case.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-17 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971328#comment-15971328
 ] 

Josh Elser commented on CALCITE-1050:
-

Looks like I broke some more stuff in Calcite due to interface changes :). Will 
see if I can avoid forcing a Calcite code-change.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-17 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971308#comment-15971308
 ] 

Josh Elser commented on CALCITE-1050:
-

Just pushed an update to the existing PR which, I believe, addresses the 
comments from Julian and Maryann (thanks so much, you two).

Along the way, I also found CALCITE-1756, and fixed an existing bug with 
{{Array.getArray(long, int)}}. I'd like to get this committed (as it's rather 
large) and then go into bug-fix mode with any subsequent issues.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-11 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965002#comment-15965002
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. Not sure, but I think other than createArrayOf, setArray, and getArray are 
enough for most test cases in Phoenix. And they have already been implemented 
in the PR, thanks! 

Excellent :). Thanks for digging in, Maryann.

bq. One thing is that ResultSet.getString is also used on array fields in 
Phoenix tests to get the "toString" value of an array, I am not sure if it's 
SQL standard or if Avatica supports it that way

Yup, this is pretty normal. Essentially, just the same as you can get a String 
representation of a value of a column in the current row of a ResultSet, you 
can treat a ResultSet generated from an Array in the same manner. Makes the 
user-facing parsing a bit more consumable (thankfully, as the Array API leaves 
a bit to be desired).

bq. Another problem I found by running the Phoenix array tests was that literal 
string array values were taken as CHAR ARRAY type and could not be inserted 
into VARCHAR ARRAY columns. I think this is a Calcite issue and I'll open a 
separate JIRA.

Ok, let me know if you find otherwise, or have a test case for it.

bq. Review comments:

Thanks for looking, Julian. I need to write some test cases to catch the 
Calcite failures I fixed last night in Avatica (to prevent the "surprise, 
calcite's busted" situation). I'll look at these two suggestions as well!

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-11 Thread Julian Hyde (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964995#comment-15964995
 ] 

Julian Hyde commented on CALCITE-1050:
--

Thanks so much for this, @elserj!

Review comments:
* In {{jdbcToSerial}} it doesn't look as if it handles null {{Timestamp}} 
values.
* In {{AvaticaUtils}}, the {{getNonPrimitiveRep}} and {{getSerializedRep}} 
methods can be moved to {{Rep}}, and maybe rationalized a bit.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-11 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964919#comment-15964919
 ] 

Maryann Xue commented on CALCITE-1050:
--

Not sure, but I think other than {{createArrayOf}}, {{setArray}}, and 
{{getArray}} are enough for most test cases in Phoenix. One thing is that 
{{ResultSet.getString}} is used on array fields in Phoenix tests to get the 
"toString" value of an array, I am not sure if it's SQL standard or if Avatica 
supports it that way. [~jamestaylor], do you have any comment on this point?
 
Another problem I found by running the Phoenix array tests was that literal 
string array values were taken as CHAR ARRAY type and could not be inserted 
into VARCHAR ARRAY columns. I think this is a Calcite issue and I'll open a 
separate JIRA.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-11 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964814#comment-15964814
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. One important thing though, can you please add the interface level support 
as well, such as AvaticaConnection.createArrayOf?

Sure thing, I can look at implementing that method! Any others on Connection?

What about the other methods on {{Array}}? Only some of the {{getArray(..)}} 
and {{getResultSet(..)}} methods are implemented currently. It's been enough to 
at least run against sqlline with a couple of databases. Just curious if you 
know of any specifically that are higher priority to implement (also not sure 
how much work each will be).

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-11 Thread Maryann Xue (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964742#comment-15964742
 ] 

Maryann Xue commented on CALCITE-1050:
--

Thank you very much for doing the Array support, [~elserj]! One important thing 
though, can you please add the interface level support as well, such as 
{{AvaticaConnection.createArrayOf}}?

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-10 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963740#comment-15963740
 ] 

Josh Elser commented on CALCITE-1050:
-

bq. Argh, just realized that I broke some stuff in Calcite. Looking into 
those...

Pushed an update to the PR which at least gets a Calcite {{mvn verify}} passing 
again.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-10 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963593#comment-15963593
 ] 

Josh Elser commented on CALCITE-1050:
-

Argh, just realized that I broke some stuff in Calcite. Looking into those...

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-10 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963417#comment-15963417
 ] 

James Taylor commented on CALCITE-1050:
---

[~maryannxue] - would you have a few spare cycles to review this patch?

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-02 Thread Rajeshbabu Chintaguntla (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953026#comment-15953026
 ] 

Rajeshbabu Chintaguntla commented on CALCITE-1050:
--

[~elserj] Thank you very much for your work. Sure will take a look at it.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-04-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952410#comment-15952410
 ] 

ASF GitHub Bot commented on CALCITE-1050:
-

GitHub user joshelser opened a pull request:

https://github.com/apache/calcite-avatica/pull/2

CALCITE-1050 Array support

Tested against HSQLDB, Postgres, and Apache Phoenix

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joshelser/calcite-avatica 1050-arrays

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit 34d1016ea23492abb1e879cd3f560741e69338bc
Author: Josh Elser 
Date:   2016-01-12T21:40:18Z

[CALCITE-1050] Array support for Avatica

As best as possible, works around the limitations of JDBC's
Array class to handle arbitrarily nested Arrays. Nested-array
support differs from DB to DB, so functionality is primarily
driven from structure, rather than metadata.

commit 1097142106478605741dff77063a59bbd5f50909
Author: Josh Elser 
Date:   2017-03-30T20:34:33Z

Further cleanup

* Remove dead code
* Remove Compiler warnings
* Clarify some comments




> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-03-29 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948127#comment-15948127
 ] 

Josh Elser commented on CALCITE-1050:
-

Just wanted to drop a line: I've had some time to work on this yesterday and 
today. I think I'm close.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-03-02 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892780#comment-15892780
 ] 

Josh Elser commented on CALCITE-1050:
-

Yes, it is [~jamestaylor]. Sorry I haven't gotten to finishing it yet..

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2017-03-02 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892769#comment-15892769
 ] 

James Taylor commented on CALCITE-1050:
---

[~elserj] - is this one still on your radar? Over in Phoenix/Calcite 
integration land, this one would help a lot.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CALCITE-1050) Avatica can't serialize java.sql.Array

2016-01-12 Thread Josh Elser (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094672#comment-15094672
 ] 

Josh Elser commented on CALCITE-1050:
-

Thanks for writing this up [~lukaslalinsky]. This is a great example. I see 
what you mean now.

On the "query results" side of things, we have {{Frame}} which which contains a 
{{List}} of {{rows}}. For an array, the element in the {{rows}} would 
be a {{List}} itself, which triggers it. I'm guessing that it was just missing 
on this side.

Let me start by writing some tests to work through this. Thanks again for the 
bug report.

> Avatica can't serialize java.sql.Array
> --
>
> Key: CALCITE-1050
> URL: https://issues.apache.org/jira/browse/CALCITE-1050
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.5.0
>Reporter: Lukas Lalinsky
>Assignee: Josh Elser
>
> As far as I can see, there is no way to serialize arrays in the Avatica RPC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)