[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463160#comment-16463160 ] ASF GitHub Bot commented on CALCITE-1948: - Github user asfgit closed the pull request at: https://github.com/apache/calcite-avatica/pull/35 > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463148#comment-16463148 ] ASF GitHub Bot commented on CALCITE-1948: - Github user F21 commented on the issue: https://github.com/apache/calcite-avatica/pull/35 Thanks for the review @joshelser. I ran into the issue with dependent images before as well. I think a script as you mentioned in the best way. Perhaps we can even use our CI to run the script when a tag is created for automation. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462743#comment-16462743 ] ASF GitHub Bot commented on CALCITE-1948: - Github user joshelser commented on the issue: https://github.com/apache/calcite-avatica/pull/35 > The only thing I'm not sure about is how it will work at release time. Specifically, we'll need DockerHub to build the avatica image, then the avatica-hsqldb image. If it happens the other way around, it would fail. I'm not sure if we have any ability to control this, so we'll just see how it works out, I guess :) Reached out to a friend on the NiFi side who is navigating Docker-at-ASF problems too. He pointed me to https://issues.apache.org/jira/browse/INFRA-15526 and said that we will run into the problem I described above. Seems like, before Avatica 1.12.0, we will need to do this switch over. We'll just write a script that can publish the images for us after a release in the proper order :) > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462693#comment-16462693 ] ASF GitHub Bot commented on CALCITE-1948: - Github user joshelser commented on the issue: https://github.com/apache/calcite-avatica/pull/35 Looks OK to me, thanks @F21. The only thing I'm not sure about is how it will work at release time. Specifically, we'll need DockerHub to build the avatica image, then the avatica-hsqldb image. If it happens the other way around, it would fail. I'm not sure if we have any ability to control this, so we'll just see how it works out, I guess :) > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461755#comment-16461755 ] ASF GitHub Bot commented on CALCITE-1948: - Github user F21 commented on the issue: https://github.com/apache/calcite-avatica/pull/35 friendly ping @joshelser > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438221#comment-16438221 ] ASF GitHub Bot commented on CALCITE-1948: - Github user F21 commented on a diff in the pull request: https://github.com/apache/calcite-avatica/pull/35#discussion_r181540549 --- Diff: docker/src/main/dockerhub-hypersql/Dockerfile --- @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM apache/calcite-avatica:1.11.0 --- End diff -- I have updated the PR with the requested changes. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437538#comment-16437538 ] ASF GitHub Bot commented on CALCITE-1948: - Github user joshelser commented on a diff in the pull request: https://github.com/apache/calcite-avatica/pull/35#discussion_r181443036 --- Diff: docker/src/main/dockerhub-hypersql/Dockerfile --- @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM apache/calcite-avatica:1.11.0 --- End diff -- Needs AVATICA_VERSION in here to make sure that we release a docker container with the appropriate version of Avatica we're releasing. Looks like sure docker/src/test/scripts/verify-dockerhub-dockerfile-version.groovy also needs updates to look at this new directory. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436479#comment-16436479 ] ASF GitHub Bot commented on CALCITE-1948: - GitHub user F21 opened a pull request: https://github.com/apache/calcite-avatica/pull/35 [CALCITE-1948] Add docker hub image for HSQLDB You can merge this pull request into a Git repository by running: $ git pull https://github.com/F21/calcite-avatica add-hsqldb-to-dockerhub Alternatively you can review and apply these changes as the patch at: https://github.com/apache/calcite-avatica/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 9070b31fdd42d3c472bb052afd5296a723e0f202 Author: Francis ChuangDate: 2018-04-12T23:22:47Z Add docker hub image for HSQLDB > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436384#comment-16436384 ] Francis Chuang commented on CALCITE-1948: - [~elserj] Thanks! That makes sense, I will open a PR for that. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435699#comment-16435699 ] Josh Elser commented on CALCITE-1948: - [~francischuang] you can see the request I put up for the currently published Docker image at https://issues.apache.org/jira/browse/INFRA-13838 You would need to copy {{docker/src/main/docker/hypersql/Dockerfile}} over to a new directory (e.g. {{docker/src/main/dockerhub-hypersql}}) and update its {{FROM}} line to use [https://hub.docker.com/r/apache/calcite-avatica/] for the appropriate release (see the AVATICA_VERSION argument in the existing dockerhub Dockerfile and the validation done in {{docker/src/test/scripts/verify-dockerhub-dockerfile-version.groovy}}) > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435011#comment-16435011 ] Francis Chuang commented on CALCITE-1948: - [~elserj] [~julianhyde] Any chance you guys can make this happen? I am spinning up avatica-hsqldb docker images to run tests for avatica-go. I am currently using a self published one ([https://hub.docker.com/r/f21global/calcite-avatica/tags/),] but I would prefer to use something "official". I also have a PR updating HSQLDB in the HSQLDB avatica image: https://github.com/apache/calcite-avatica/pull/34 > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser >Priority: Major > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206650#comment-16206650 ] Francis Chuang commented on CALCITE-1948: - [~elserj]Would it be possible to take a look at this and publish the hsqldb images? > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129842#comment-16129842 ] Francis Chuang commented on CALCITE-1948: - I see. That makes sense. If HyperSQL isn't a problem, I think it would be nice to have a HyperSQL image up on docker hub so that client maintainers can easily test against it. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (CALCITE-1948) Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub
[ https://issues.apache.org/jira/browse/CALCITE-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129762#comment-16129762 ] Josh Elser commented on CALCITE-1948: - [~francischuang], these were not published intentionally. As I understand it, these would constitute a "release". I know that ASF policy would preclude us from publishing a MySQL image -- that's why it's only provided as an example. HyperSQL wouldn't be a problem, but I'm not sure if the postgres license is accepted. This requires some research to proceed. > Publish avatica-hypersql, avatica-mysql and avatica-postgres to docker hub > -- > > Key: CALCITE-1948 > URL: https://issues.apache.org/jira/browse/CALCITE-1948 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > > I am currently making a port of the tests in calcite-avatica-go to test > against the calcite-avatica image in docker hub. > Unfortunately, the calcite-avatica image only includes the avatica-server, > which makes it difficult to stand up a test environment. > It would be nice if the docker images for HyperSQL, MySQL and Postgres can be > published as well. > This can be achieved by configuring docker hub's automatic build to look in > the appropriate subfolders for the dockerfile and push tags with the > appropriate backing db, for example 1.10.0-hypersql, 1.10.0-mysql etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)