[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507112#comment-16507112 ] Laurent Goujon commented on CALCITE-2352: - Yes, it looks like I borked my push somehow and didn't push the change to not validate the generated FilteredConstants.java file. I just pushed the small patch to master > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Major > Fix For: avatica-1.12.0 > > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507102#comment-16507102 ] Kevin Risden commented on CALCITE-2352: --- [~laurentgo] - Looks like this commit is causing build issues now? [https://builds.apache.org/job/Calcite-Avatica-Master/71/] I was able to reproduce this locally as well: mvn verify javadoc:javadoc [ERROR] target/filtered-java-src/org/apache/calcite/avatica/util/FilteredConstants.java:[0] (javadoc) JavadocPackage: Missing package-info.java file. [ERROR] target/filtered-java-src/org/apache/calcite/avatica/util/FilteredConstants.java:[22,1] (design) HideUtilityClassConstructor: Utility classes should not have a public or default constructor. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (validate) on project avatica-core: You have 2 Checkstyle violations. -> [Help 1] Did the same commit from the PR get merged or something else? > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Major > Fix For: avatica-1.12.0 > > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506672#comment-16506672 ] ASF GitHub Bot commented on CALCITE-2352: - Github user laurentgo closed the pull request at: https://github.com/apache/calcite-avatica/pull/56 > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Major > Fix For: avatica-1.12.0 > > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506671#comment-16506671 ] ASF GitHub Bot commented on CALCITE-2352: - Github user laurentgo commented on the issue: https://github.com/apache/calcite-avatica/pull/56 Merged in acb675de97b9b0743c09368820a770e2ceda05f8 > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Assignee: Laurent Goujon >Priority: Major > Fix For: avatica-1.12.0 > > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505389#comment-16505389 ] ASF GitHub Bot commented on CALCITE-2352: - Github user laurentgo commented on the issue: https://github.com/apache/calcite-avatica/pull/56 Thanks for the check! unless any objection, I'll merge it tomorrow (cc @F21 )! > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505355#comment-16505355 ] ASF GitHub Bot commented on CALCITE-2352: - Github user laurentgo commented on the issue: https://github.com/apache/calcite-avatica/pull/56 From a public API perspective, there should not be: checkstyle only complains if constructor has a greater visibility than the class itself. The only exception has been the factory which is accessed through reflection (and the code assumes the constructor is public) > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502781#comment-16502781 ] Laurent Goujon commented on CALCITE-2352: - I figured out why the guava issue: checkstyle requires guava 19.0, but was getting 14.0 from maven. Posted a patch on github with the upgrade, plus all the changes to comply with the new version. > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502759#comment-16502759 ] ASF GitHub Bot commented on CALCITE-2352: - GitHub user laurentgo opened a pull request: https://github.com/apache/calcite-avatica/pull/56 [CALCITE-2352] Update to checkstyle 6.18 Update project to maven-checkstyle-plugin 3.0.0/checkstyle 6.18. Fix all new reported violations. You can merge this pull request into a Git repository by running: $ git pull https://github.com/laurentgo/calcite-avatica laurentgo/CALCITE-2352 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/calcite-avatica/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit acb675de97b9b0743c09368820a770e2ceda05f8 Author: Laurent Goujon Date: 2018-06-06T02:39:38Z [CALCITE-2352] Update to checkstyle 6.18 Update project to maven-checkstyle-plugin 3.0.0/checkstyle 6.18. Fix all new reported violations. > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502356#comment-16502356 ] Laurent Goujon commented on CALCITE-2352: - True that plugin doesn't need to be updated, but 2.17 is from 2015 and 3.0.0 is 2018, so it seemed also logical to look at it at the same time (note that 3.0.0 is based on checkstyle 6.18 which was released in May 2016, so clearly the plugin maintainer is pretty conservative too) > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502341#comment-16502341 ] Kevin Risden commented on CALCITE-2352: --- I had looked at upgrading Checkstyle to 8.x and the latest we could go to was 7.x due to hydromatic-toolbox as [~laurentgo] pointed out. This did generate a bunch of checkstyle violations due to new versions of Checkstyle. The checkstyle plugin doesn't need to be updated to update checkstyle itself. https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502184#comment-16502184 ] Laurent Goujon commented on CALCITE-2352: - At least 5.9 I believe for lambda, and probably 6.1. I did several tries and run into several issues: - maven-checkstyle-plugin 3.0.0 (which would be 6.18) has some guava issue with maven or another plugin, causing the project to fail right away. Previous plugin version (2.17) seems okay though - recent versions of checkstyle (8.2 or higher) removed FileContentHolder module, and it seems it might require a new build of hydromatic-toolbox as the checkstyle verifier is probably depending on it - depending on which checkstyle version being used, it generates betweem 100 and 200 violations. Calcite seems to be on 3.0.0 plugin/Checkstyle 6.18 btw > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2352) Upgrade checkstyle to support Java8 lambdas
[ https://issues.apache.org/jira/browse/CALCITE-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502160#comment-16502160 ] Josh Elser commented on CALCITE-2352: - [~laurentgo] do you know what version we have to go to? > Upgrade checkstyle to support Java8 lambdas > --- > > Key: CALCITE-2352 > URL: https://issues.apache.org/jira/browse/CALCITE-2352 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Laurent Goujon >Priority: Major > > Version of checkstyle used by Avatica (5.7) doesn't support constructs from > Java8 like lambdas and static methods in interfaces. > This would result in lots of small changes to adjust to the stricter rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
