[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3621/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2593/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3620/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3840/



---

[GitHub] carbondata issue #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed issues whi...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1975
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2592/



---

[GitHub] carbondata issue #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed issues whi...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1975
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3837/



---

[GitHub] carbondata issue #1985: [CARBONDATA-2185]add InputMetrics for Streaming Read...

[QiangCai]

Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/1985
  
LGTM


---

[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1969#discussion_r170180010
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java
 ---
@@ -145,6 +146,34 @@ public BitSetGroup applyFilter(BlocksChunkHolder 
blockChunkHolder, boolean useBi
 return applyNoAndDirectFilter(blockChunkHolder);
   }
 
+  /**
+   * apply range filter on a row
--- End diff --

explain the return value


---

[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1969#discussion_r170179962
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -1790,6 +1790,9 @@ public static void 
removeNullValues(DimensionColumnDataChunk dimensionColumnData
   }
 
   public static void updateIndexOfColumnExpression(Expression exp, int 
dimOridnalMax) {
+if (exp == null) {
+  return;
--- End diff --

add one comment to explain it can be null


---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2591/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3838/



---

[jira] [Resolved] (CARBONDATA-2183) fix compaction when segment is delete during compaction and remove unnecessary parameters in functions

[Manish Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manish Gupta resolved CARBONDATA-2183.
--
   Resolution: Fixed
Fix Version/s: 1.3.0
   1.3.1

> fix compaction when segment is delete during compaction and remove 
> unnecessary parameters in functions
> --
>
> Key: CARBONDATA-2183
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2183
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Minor
> Fix For: 1.3.1, 1.3.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> when compaction is started and job is running, and parallelly the segment 
> involved in the compaction is deleted using DeleteSegmentByID, then 
> compaction should be aborted and failed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #1979: [CARBONDATA-2183]fix compaction when segment ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1979


---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

[manishgupta88]

Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/1979
  
LGTM


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2590/



---

[jira] [Resolved] (CARBONDATA-2161) Compacted Segment of Streaming Table should update "mergeTo" column

[QiangCai (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai resolved CARBONDATA-2161.
--
Resolution: Fixed

> Compacted Segment of Streaming Table should update "mergeTo" column
> ---
>
> Key: CARBONDATA-2161
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2161
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Babulal
>Assignee: Babulal
>Priority: Minor
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> When Handoff is trigger , ROW file format will be converted into COLUMNAR  
> and that segment status will be updated as "Compacted". But "Merged TO" 
> column is not updated.
> +-+-+---+---+-+---+
> |SegmentSequenceId|Status   |Load Start Time|Load End Time  
> |Merged To|File Format|
> +-+-+---+---+-+---+
> |2|Success  |2018-02-11 18:17:24.157|2018-02-11 
> 18:17:25.899|NA   |COLUMNAR_V3|
> |1|Streaming|2018-02-11 18:17:24.137|null   
> |NA   |ROW_V1 |
> |0|Compacted|2018-02-11 18:15:54.262|2018-02-11 
> 18:17:24.137|NA|ROW_V1 |
> +-+-+---+---+-+---+
> Expected 
> +-+-+---+---+-+---+
> |SegmentSequenceId|Status   |Load Start Time|Load End Time  
> |Merged To|File Format|
> +-+-+---+---+-+---+
> |2|Success  |2018-02-11 18:17:24.157|2018-02-11 
> 18:17:25.899|NA   |COLUMNAR_V3|
> |1|Streaming|2018-02-11 18:17:24.137|null   
> |NA   |ROW_V1 |
> |0|Compacted|2018-02-11 18:15:54.262|2018-02-11 
> 18:17:24.137|2|ROW_V1 |
> +-+-+---+---+-+---+



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed issues whi...

[kunal642]

Github user kunal642 commented on the issue:

https://github.com/apache/carbondata/pull/1975
  
retest this please


---

[GitHub] carbondata pull request #1971: [CARBONDATA-2161]Compacted Segment of Streami...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1971


---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3833/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2589/



---

[GitHub] carbondata issue #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed issues whi...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1975
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3835/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3836/



---

[GitHub] carbondata pull request #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed iss...

[kunal642]

Github user kunal642 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1975#discussion_r170174790
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
 ---
@@ -445,11 +443,11 @@ object PreAggregateUtil {
 .fromWrapperToExternalTableInfo(wrapperTableInfo, dbName, 
tableName)
   updateSchemaInfo(carbonTable,
 thriftTable)(sparkSession)
-  LOGGER.info(s"Parent table updated is successful for table 
$dbName.$tableName")
+  LOGGER.info(s"Parent table updated is successful for table" +
+  s" 
$dbName.${childSchema.getRelationIdentifier.toString}")
 } catch {
   case e: Exception =>
 LOGGER.error(e, "Pre Aggregate Parent table update failed 
reverting changes")
-revertMainTableChanges(dbName, tableName, 
numberOfCurrentChild)(sparkSession)
--- End diff --

If updation of the parent table fails then the aggregate table will be 
dropped from undoMetadata. There is no need to revert the main table changes 
here.


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3834/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[QiangCai]

Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
retest this please


---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3619/



---

[GitHub] carbondata pull request #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed iss...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1975#discussion_r170171750
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
 ---
@@ -445,11 +443,11 @@ object PreAggregateUtil {
 .fromWrapperToExternalTableInfo(wrapperTableInfo, dbName, 
tableName)
   updateSchemaInfo(carbonTable,
 thriftTable)(sparkSession)
-  LOGGER.info(s"Parent table updated is successful for table 
$dbName.$tableName")
+  LOGGER.info(s"Parent table updated is successful for table" +
+  s" 
$dbName.${childSchema.getRelationIdentifier.toString}")
 } catch {
   case e: Exception =>
 LOGGER.error(e, "Pre Aggregate Parent table update failed 
reverting changes")
-revertMainTableChanges(dbName, tableName, 
numberOfCurrentChild)(sparkSession)
--- End diff --

Now where you are reverting the schema if updation fails?


---

[GitHub] carbondata pull request #1975: [CARBONDATA-2142] [CARBONDATA-1763] Fixed iss...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1975#discussion_r170170644
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala
 ---
@@ -65,8 +65,9 @@ case class CarbonDropDataMapCommand(
 
catalog.checkSchemasModifiedTimeAndReloadTable(TableIdentifier(tableName, 
Some(dbName)))
 val carbonLocks: scala.collection.mutable.ListBuffer[ICarbonLock] = 
ListBuffer()
 try {
+  forceDropTableFromMetaStore(sparkSession)
   locksToBeAcquired foreach {
-lock => carbonLocks += 
CarbonLockUtil.getLockObject(tableIdentifier, lock)
+  lock => carbonLocks += 
CarbonLockUtil.getLockObject(tableIdentifier, lock)
--- End diff --

correct the format


---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2588/



---

[GitHub] carbondata issue #1977: [CARBONDATA-2181] Thread Leak during compaction proc...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1977
  
@sounakr I don't think it is required to do so many file changes to change 
exception throwing to fix the issue. I think change in 
`CompactionResultSortProcessor.java`  would be enough to fix this issue.


---

[GitHub] carbondata pull request #1977: [CARBONDATA-2181] Thread Leak during compacti...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1977#discussion_r170169527
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/DimensionRawColumnChunk.java
 ---
@@ -49,7 +49,8 @@ public DimensionRawColumnChunk(int columnIndex, 
ByteBuffer rawData, long offSet,
* Convert all raw data with all pages to processed 
DimensionColumnDataChunk's
* @return
*/
-  public DimensionColumnDataChunk[] convertToDimColDataChunks() {
+  public DimensionColumnDataChunk[] convertToDimColDataChunks()
+  throws IOException, MemoryException, RuntimeException {
--- End diff --

wrap to single exception and throw it, don't throw many exceptions


---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3618/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2587/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3831/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[rahulforallp]

Github user rahulforallp commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
retest this please


---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3832/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2586/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3830/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3617/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2585/



---

[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1969
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3829/



---

[GitHub] carbondata pull request #1835: [CARBONDATA-2057] Support specifying path whe...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1835#discussion_r163775104
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonDropDataMapCommand.scala
 ---
@@ -68,18 +69,12 @@ case class CarbonDropDataMapCommand(
 lock => carbonLocks += 
CarbonLockUtil.getLockObject(tableIdentifier, lock)
   }
   LOGGER.audit(s"Deleting datamap [$dataMapName] under table 
[$tableName]")
-  var carbonTable: Option[CarbonTable] =
-catalog.getTableFromMetadataCache(dbName, tableName)
-  if (carbonTable.isEmpty) {
-try {
-  carbonTable = 
Some(catalog.lookupRelation(identifier)(sparkSession)
-.asInstanceOf[CarbonRelation].metaData.carbonTable)
-} catch {
-  case ex: NoSuchTableException =>
-if (!ifExistsSet) {
-  throw ex
-}
-}
+  val carbonTable: Option[CarbonTable] = try {
+Some(CarbonEnv.getCarbonTable(databaseNameOp, 
tableName)(sparkSession))
+  } catch {
+case ex: NoSuchTableException =>
+  if (!ifExistsSet) throw ex
--- End diff --

if add this line, when run "DROP DATAMAP IF EXISTS agg1_month ON TABLE 
mainTableNotExist", it will not throw exception if the table not exists. So we 
should remove it.  https://github.com/apache/carbondata/pull/1858/files


---

[GitHub] carbondata pull request #1654: [CARBONDATA-1856][PARTITION] Support insert/l...

[xubo245]

Github user xubo245 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1654#discussion_r170155099
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java
 ---
@@ -339,28 +345,47 @@ private static void setFileHeader(Configuration 
configuration, CarbonLoadModel m
 model.setCsvHeaderColumns(columns);
   }
 
-  private static class CarbonRecordWriter extends 
RecordWriter {
+  public static class CarbonRecordWriter extends 
RecordWriter {
 
 private CarbonOutputIteratorWrapper iteratorWrapper;
 
 private DataLoadExecutor dataLoadExecutor;
 
+private CarbonLoadModel loadModel;
+
+private ExecutorService executorService;
+
+private Future future;
+
 public CarbonRecordWriter(CarbonOutputIteratorWrapper iteratorWrapper,
-DataLoadExecutor dataLoadExecutor) {
+DataLoadExecutor dataLoadExecutor, CarbonLoadModel loadModel, 
Future future,
+ExecutorService executorService) {
   this.iteratorWrapper = iteratorWrapper;
   this.dataLoadExecutor = dataLoadExecutor;
+  this.loadModel = loadModel;
+  this.executorService = executorService;
+  this.future = future;
 }
 
-@Override
-public void write(NullWritable aVoid, StringArrayWritable strings)
+@Override public void write(NullWritable aVoid, StringArrayWritable 
strings)
 throws InterruptedException {
   iteratorWrapper.write(strings.get());
 }
 
-@Override
-public void close(TaskAttemptContext taskAttemptContext) {
+@Override public void close(TaskAttemptContext taskAttemptContext) 
throws InterruptedException {
   iteratorWrapper.close();
-  dataLoadExecutor.close();
+  try {
+future.get();
+  } catch (ExecutionException e) {
+throw new InterruptedException(e.getMessage());
--- End diff --

Why did you throw InterruptedException?


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3616/



---

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3827/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2584/



---

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2583/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3828/



---

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[xubo245]

Github user xubo245 commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
retest this please


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3615/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3614/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3613/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2582/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3826/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3611/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3610/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2581/



---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r170003740
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/partition/impl/RangePartitionerImpl.java
 ---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.processing.loading.partition.impl;
+
+import java.util.Arrays;
+import java.util.Comparator;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.datastore.row.CarbonRow;
+import org.apache.carbondata.processing.loading.partition.Partitioner;
+
+public class RangePartitionerImpl implements Partitioner {
+  private static final LogService LOGGER =
+  
LogServiceFactory.getLogService(RangePartitionerImpl.class.getName());
+  private CarbonRow[] rangeBounds;
+  private Comparator comparator;
+
+  public RangePartitionerImpl(CarbonRow[] rangeBounds, 
Comparator comparator) {
+this.rangeBounds = rangeBounds;
+LOGGER.info("Use range partitioner to distribute data to "
++ (rangeBounds.length + 1) + " ranges.");
+this.comparator = comparator;
+  }
+
+  /**
+   * learned from spark org.apache.spark.RangePartitioner
+   *
+   * @param key key
+   * @return partitionId
+   */
+  @Override public int getPartition(CarbonRow key) {
--- End diff --

put all @Override to previous line


---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r170003522
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java
 ---
@@ -231,4 +238,71 @@ public static CarbonDataLoadConfiguration 
createConfiguration(CarbonLoadModel lo
 return configuration;
   }
 
+  /**
+   * set sort column info in configuration
+   * @param carbonTable carbon table
+   * @param loadModel load model
+   * @param configuration configuration
+   */
+  private static void setSortColumnInfo(CarbonTable carbonTable, 
CarbonLoadModel loadModel,
+  CarbonDataLoadConfiguration configuration) {
+List sortCols = 
carbonTable.getSortColumns(carbonTable.getTableName());
+SortScopeOptions.SortScope sortScope = 
SortScopeOptions.getSortScope(loadModel.getSortScope());
+if (!SortScopeOptions.SortScope.LOCAL_SORT.equals(sortScope)
+|| sortCols.size() == 0
+|| StringUtils.isBlank(loadModel.getSortColumnsBoundsStr())) {
+  if (!StringUtils.isBlank(loadModel.getSortColumnsBoundsStr())) {
+LOGGER.warn("sort column bounds will be ignored");
+  }
+
+  configuration.setSortColumnRangeInfo(null);
+  return;
+}
+// column index for sort columns
+int[] sortColIndex = new int[sortCols.size()];
+boolean[] isSortColNoDict = new boolean[sortCols.size()];
+
+DataField[] outFields = configuration.getDataFields();
+int j = 0;
+boolean columnExist;
+for (String sortCol : sortCols) {
+  columnExist = false;
+
+  for (int i = 0; !columnExist && i < outFields.length; i++) {
+if 
(outFields[i].getColumn().getColName().equalsIgnoreCase(sortCol)) {
+  columnExist = true;
+
+  sortColIndex[j] = i;
+  isSortColNoDict[j] = !outFields[i].hasDictionaryEncoding();
+  j++;
+}
+  }
+
+  if (!columnExist) {
+throw new RuntimeException("Field " + sortCol + " does not 
exist.");
--- End diff --

It  is better to use DataLoadingException


---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r170003203
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
 ---
@@ -107,6 +108,7 @@
*/
   private short writingCoresCount;
 
+  private SortColumnRangeInfo sortColumnRangeInfo;
   public CarbonDataLoadConfiguration() {
--- End diff --

add one empty line


---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r170003007
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/SortColumnRangeInfo.java
 ---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.metadata.schema;
+
+import java.io.Serializable;
+import java.util.Arrays;
+
+/**
+ * column ranges specified by sort column bounds
+ */
+public class SortColumnRangeInfo implements ColumnRangeInfo, Serializable {
--- End diff --

For all public class, please annotate with `@InterfaceAudience`, in this 
PR, all newly added public class should be `@InterfaceAudience.Internal`


---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r170002493
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -370,6 +370,17 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
 ```
 NOTE: Date formats are specified by date pattern strings. The date 
pattern letters in CarbonData are same as in JAVA. Refer to 
[SimpleDateFormat](http://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html).
 
+  - **SORT COLUMN BOUNDS:** Range bounds for sort columns.
+
+```
+OPTIONS('SORT_COLUMN_BOUNDS'='v11,v21,v31;v12,v22,v32;v12,v23,v33')
--- End diff --

typo, last value range is `v13,v23,v33`


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2580/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3823/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3825/



---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r169990579
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/ColumnRangeInfo.java
 ---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.metadata.schema;
+
+/**
+ * interface for column range information. Currently we treat bucket and 
sort_column_range as
+ * column ranges.
+ */
+public interface ColumnRangeInfo {
+  int getNumOfRanges();
+}
--- End diff --

add one new line at the end of file, otherwise it breaks code style


---

[GitHub] carbondata pull request #1953: [CARBONDATA-2091][DataLoad] Support specifyin...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1953#discussion_r169989543
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/BucketingInfo.java
 ---
@@ -30,34 +30,32 @@
 /**
  * Bucketing information
  */
-public class BucketingInfo implements Serializable, Writable {
-
+public class BucketingInfo implements ColumnRangeInfo, Serializable, 
Writable {
   private static final long serialVersionUID = -0L;
-
   private List listOfColumns;
-
-  private int numberOfBuckets;
+  // number of column ranges
--- End diff --

Why is it called "column ranges"? Isn't it "value ranges"?


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3824/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3609/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3608/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3821/



---

[GitHub] carbondata issue #1984: [CARBONDATA-2187] Partition restructure

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1984
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2577/



---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1972#discussion_r169983469
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
 ---
@@ -676,6 +734,48 @@ case class CarbonLoadDataCommand(
 }
   }
 
+  private def convertData(
+  originRDD: RDD[Row],
+  sparkSession: SparkSession,
+  model: CarbonLoadModel,
+  isDataFrame: Boolean): RDD[InternalRow] = {
+model.setPartitionId("0")
+val sc = sparkSession.sparkContext
+val modelBroadcast = sc.broadcast(model)
+val partialSuccessAccum = sc.accumulator(0, "Partial Success 
Accumulator")
+
+val inputStepRowCounter = sc.accumulator(0, "Input Processor 
Accumulator")
+// 1. Input
+var convertRDD =
--- End diff --

ok


---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1972#discussion_r169983220
  
--- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
 ---
@@ -122,7 +119,11 @@ public CarbonOutputCommitter(Path outputPath, 
TaskAttemptContext context) throws
   throw new IOException(e);
 }
   }
-  CarbonLoaderUtil.recordNewLoadMetadata(newMetaEntry, loadModel, 
false, overwriteSet);
+  String uniqueId = null;
+  if (overwriteSet) {
+uniqueId = overwritePartitions(loadModel);
+  }
+  CarbonLoaderUtil.recordNewLoadMetadata(newMetaEntry, loadModel, 
false, false);
--- End diff --

ok, changed


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2578/



---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1972#discussion_r169982277
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -104,6 +104,38 @@ public static Object 
getMeasureValueBasedOnDataType(String msrValue, DataType da
 }
   }
 
+  /**
+   * This method will convert a given value to its specific type
+   *
+   * @param msrValue
+   * @param dataType
+   * @param carbonMeasure
+   * @return
+   */
+  public static Object getConvertedMeasureValueBasedOnDataType(String 
msrValue, DataType dataType,
--- End diff --

ok


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3822/



---

[GitHub] carbondata issue #1953: [CARBONDATA-2091][DataLoad] Support specifying sort ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1953
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2576/



---

[GitHub] carbondata issue #1953: [CARBONDATA-2091][DataLoad] Support specifying sort ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1953
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3820/



---

[GitHub] carbondata issue #1953: [CARBONDATA-2091][DataLoad] Support specifying sort ...

[jackylk]

Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/1953
  
retest this please


---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2575/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2574/



---

[GitHub] carbondata issue #1987: [CARBONDATA-2189] Add DataMapProvider developer inte...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1987
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3818/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1979
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3607/



---

[jira] [Resolved] (CARBONDATA-2103) Avoid 2 time lookup in ShowTables command

[Manish Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manish Gupta resolved CARBONDATA-2103.
--
   Resolution: Fixed
Fix Version/s: 1.3.0
   1.3.1

> Avoid 2 time lookup in ShowTables command 
> --
>
> Key: CARBONDATA-2103
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2103
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Babulal
>Assignee: Akash R Nilugal
>Priority: Minor
> Fix For: 1.3.1, 1.3.0
>
>  Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Currently in show table command 2 time lookup is happening . 
> Improve it with 1 lookup. 
> CarbonShowTablesCommand.scala # filterDataMaps 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #1980: [CARBONDATA-2103]optimize show tables for fil...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1980


---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

[manishgupta88]

Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/1980
  
LGTM


---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3819/



---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

[rahulforallp]

GitHub user rahulforallp opened a pull request:

https://github.com/apache/carbondata/pull/1991

[CARBONDATA-2196]carbontable should be taken from loadmodel

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rahulforallp/incubator-carbondata 
CARBONDATA-2196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1991


commit 72c7feace3a93b4cecde6beb9f17e983ea6912cb
Author: rahulforallp 
Date:   2018-02-22T12:59:57Z

carbontable should be taken from loadmodel




---

[jira] [Created] (CARBONDATA-2196) during stream sometime carbontable is null in executor side

[Rahul Kumar (JIRA)]

Rahul Kumar created CARBONDATA-2196:
---

 Summary: during stream sometime carbontable is null in executor 
side
 Key: CARBONDATA-2196
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2196
 Project: CarbonData
  Issue Type: Improvement
Reporter: Rahul Kumar
Assignee: Rahul Kumar






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3606/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1979
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2573/



---

[GitHub] carbondata issue #1979: [CARBONDATA-2183]fix compaction when segment is dele...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1979
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3817/



---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1980
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/3605/



---

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2572/



---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1980
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3815/



---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1980
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2571/



---

[GitHub] carbondata issue #1936: [CARBONDATA-2135] Documentation for Table comment an...

[sgururajshetty]

Github user sgururajshetty commented on the issue:

https://github.com/apache/carbondata/pull/1936
  
@chenliang613 kindly review 




---

[GitHub] carbondata issue #1990: [CARBONDATA-2195] Add new test case for partition fe...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1990
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3816/



---

[GitHub] carbondata pull request #1990: [CARBONDATA-2195] Add new test case for parti...

[xubo245]

GitHub user xubo245 opened a pull request:

https://github.com/apache/carbondata/pull/1990

[CARBONDATA-2195] Add new test case for partition feature and optimize old 
test case

Add new test case for partition feature and optimize old test case
This PR only contains test case

During optimize test case, find a bug and fix it in: 
https://github.com/apache/carbondata/pull/1989
Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xubo245/carbondata StandardPartition

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1990


commit c09e2ecd0c361dde26879f10b710194fc2b3863e
Author: xubo245 <601450868@...>
Date:   2018-02-22T10:18:35Z

[CARBONDATA-2195] Add new test case for partition feature and optimize old 
test case




---