[GitHub] [carbondata] Klaus-xjp commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization
Klaus-xjp commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-699975470 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (CARBONDATA-4013) NullPointerException when use ArrowCarbonReader to read carbondata created using orc ,parquet and avro files in SDK
[ https://issues.apache.org/jira/browse/CARBONDATA-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Bhat closed CARBONDATA-4013. --- Resolution: Invalid https://issues.apache.org/jira/browse/CARBONDATA-3365 *Stage2:* Deep integration with carbon vector; for this, currently carbon SDK vector doesn't support filling complex columns. As mentioned in this Jira the arrow reader SDK interfaces does not support complex type. > NullPointerException when use ArrowCarbonReader to read carbondata created > using orc ,parquet and avro files in SDK > --- > > Key: CARBONDATA-4013 > URL: https://issues.apache.org/jira/browse/CARBONDATA-4013 > Project: CarbonData > Issue Type: Bug > Components: other >Affects Versions: 2.1.0 > Environment: Spark 2.4.5 compiled jars >Reporter: Chetan Bhat >Priority: Major > > when use ArrowCarbonReader to read carbondata created using orc files in SDK- > java.lang.NullPointerException > at > org.apache.carbondata.sdk.file.arrow.ArrowUtils.toArrowSchema(ArrowUtils.java:109) > at > org.apache.carbondata.sdk.file.arrow.ArrowConverter.(ArrowConverter.java:45) > at > org.apache.carbondata.sdk.file.ArrowCarbonReader.readArrowBatch(ArrowCarbonReader.java:54) > at > com.apache.spark.LoadFromFiles.testORCFileLoadWithComplexSchemaArrowReader(LoadFromFiles.java:1401) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at org.junit.runner.JUnitCore.run(JUnitCore.java:137) > at > com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) > at > com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) > at > com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230) > at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) > > when use ArrowCarbonReader to read carbondata created using parquet and avro > files in SDK > java.lang.ClassCastException: java.lang.String cannot be cast to > [Ljava.lang.Object; > at > org.apache.carbondata.sdk.file.arrow.StructWriter.setValue(ArrowFieldWriter.java:374) > at > org.apache.carbondata.sdk.file.arrow.ArrowFieldWriter.write(ArrowFieldWriter.java:60) > at > org.apache.carbondata.sdk.file.arrow.StructWriter.setValue(ArrowFieldWriter.java:377) > at > org.apache.carbondata.sdk.file.arrow.ArrowFieldWriter.write(ArrowFieldWriter.java:60) > at > org.apache.carbondata.sdk.file.arrow.ArrowWriter.write(ArrowWriter.java:56) > at > org.apache.carbondata.sdk.file.arrow.ArrowConverter.addToArrowBuffer(ArrowConverter.java:63) > at > org.apache.carbondata.sdk.file.ArrowCarbonReader.readArrowBatch(ArrowCarbonReader.java:56) > at > com.apache.spark.LoadFromFiles.testParquetLoadAndCarbonArrowReader(LoadFromFiles.java:1775) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (CARBONDATA-4011) drop index table is failed with table not found exception
[ https://issues.apache.org/jira/browse/CARBONDATA-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-4011. -- Fix Version/s: 2.1.0 Resolution: Fixed > drop index table is failed with table not found exception > - > > Key: CARBONDATA-4011 > URL: https://issues.apache.org/jira/browse/CARBONDATA-4011 > Project: CarbonData > Issue Type: Bug >Reporter: Mahesh Raju Somalaraju >Priority: Major > Fix For: 2.1.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > h1. [drop index table is failed with table not found > exception|https://github.com/apache/carbondata/pull/3957#] > > passing index table name instead of passing main table name. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [carbondata] asfgit closed pull request #3957: [CARBONDATA-4011] drop index table is failed with table not found exception
asfgit closed pull request #3957: URL: https://github.com/apache/carbondata/pull/3957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699935155 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2508/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Klaus-xjp commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Klaus-xjp commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699980681 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495774296
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -419,6 +419,24 @@ public boolean createNewFile(FsPermission permission)
throws IOException {
}
}
+ @Override
+ public boolean createNewFile(Boolean overwrite, FsPermission permission)
throws IOException {
Review comment:
done
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission
permission) throws IOException {
return file.createNewFile();
}
+ @Override
+ public boolean createNewFile(Boolean overwrite, final FsPermission
permission)
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699938521 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4253/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3957: [CARBONDATA-4011] drop index table is failed with table not found exception
ajantha-bhat commented on pull request #3957: URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699985962 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #419: [CARBONDATA-523] Added test cases for carbon data processor util
CarbonDataQA1 commented on pull request #419: URL: https://github.com/apache/carbondata/pull/419#issuecomment-63862 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2511/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case class CarbonCreateMVCommand(
throw new MalformedCarbonCommandException(
"Cannot create mv on stream table " + table.getTableUniqueName)
}
-if (SegmentStatusManager.isLoadInProgressInTable(table)) {
+if (SegmentStatusManager.isOverwriteInProgressInTable(table)) {
Review comment:
I have reverted it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700045581 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2509/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] akashrn5 opened a new pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash
akashrn5 opened a new pull request #3962: URL: https://github.com/apache/carbondata/pull/3962 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the change and update document) ### Is any new testcase added? - No - Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700044480 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4254/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700050277 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2510/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
CarbonDataQA1 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700098125 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2512/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700142851 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4261/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700143229 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2516/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Klaus-xjp commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Klaus-xjp commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700055644 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] akashrn5 opened a new pull request #3963: [WIP]Fix CSV header validation not contains dimension columns
akashrn5 opened a new pull request #3963: URL: https://github.com/apache/carbondata/pull/3963 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the change and update document) ### Is any new testcase added? - No - Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700109547 > if alter column change nothing, the command should return directly without execution. I have modified code according to you suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case class CarbonCreateMVCommand(
throw new MalformedCarbonCommandException(
"Cannot create mv on stream table " + table.getTableUniqueName)
}
-if (SegmentStatusManager.isLoadInProgressInTable(table)) {
+if (SegmentStatusManager.isOverwriteInProgressInTable(table)) {
Review comment:
I have reverted it this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700054701 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4255/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] akashrn5 opened a new pull request #3961: [wip]Fix cdc merge when there are multiple bucket and join columns and AND or OR join expressions
akashrn5 opened a new pull request #3961: URL: https://github.com/apache/carbondata/pull/3961 Fix cdc merge when there are multiple bucket and join columns and AND or OR join expressions ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the change and update document) ### Is any new testcase added? - No - Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
CarbonDataQA1 commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700093868 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4256/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699796397 @QiangCai please help review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
Kejian-Li commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495712828
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLHelper.scala
##
@@ -230,14 +231,22 @@ object DDLHelper {
.toLowerCase,
values,
isColumnRename)
+ var newColumnComment: Option[String] = Option.empty
+ if (changeColumnCommand.newColumn.metadata != null &&
+
changeColumnCommand.newColumn.metadata.contains(CarbonCommonConstants.COLUMN_COMMENT))
{
+newColumnComment = Some(changeColumnCommand.
+ newColumn.metadata.getString(CarbonCommonConstants.COLUMN_COMMENT))
+ }
Review comment:
there is already a varibale "newColumn" that can be used above, or it
is better to make "changeColumnCommand.newColumn.metadata" as a variable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] QiangCai commented on a change in pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
QiangCai commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495757998
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case class CarbonCreateMVCommand(
throw new MalformedCarbonCommandException(
"Cannot create mv on stream table " + table.getTableUniqueName)
}
-if (SegmentStatusManager.isLoadInProgressInTable(table)) {
+if (SegmentStatusManager.isOverwriteInProgressInTable(table)) {
Review comment:
why change it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699879852 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4252/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699883892 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2507/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala
##
@@ -1135,11 +1135,7 @@ object CarbonParserUtil {
}
DataTypeInfo("decimal", precision, scale)
case _ =>
-if (isColumnRename) {
-
DataTypeInfo(DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
-} else {
- throw new MalformedCarbonCommandException("Data type provided is
invalid.")
-}
+
DataTypeInfo(DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
Review comment:
No need. It is useless to throw MalformedCarbonCommandException("Data
type provided is invalid.")
CarbonAlterTableColumnRenameCommand.validateColumnDataType will validate the
given datatype.
I have delete the parameter isColumnRename. Please have a check
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732383
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -419,6 +419,24 @@ public boolean createNewFile(FsPermission permission)
throws IOException {
}
}
+ @Override
+ public boolean createNewFile(Boolean overwrite, FsPermission permission)
throws IOException {
Review comment:
it is better if type of parameter "overwrite" is boolean
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission
permission) throws IOException {
return file.createNewFile();
}
+ @Override
+ public boolean createNewFile(Boolean overwrite, final FsPermission
permission)
Review comment:
It is goog to change Boolean to boolean
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createNewFile(final FsPermission
permission) throws IOException {
return file.createNewFile();
}
+ @Override
+ public boolean createNewFile(Boolean overwrite, final FsPermission
permission)
Review comment:
It is good to change Boolean to boolean
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
QiangCai commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699851048 better to focus on the topic in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on a change in pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case class CarbonCreateMVCommand(
throw new MalformedCarbonCommandException(
"Cannot create mv on stream table " + table.getTableUniqueName)
}
-if (SegmentStatusManager.isLoadInProgressInTable(table)) {
+if (SegmentStatusManager.isOverwriteInProgressInTable(table)) {
Review comment:
Create MV While load (LOAD or INSERT INTO) is in progress could also be
allowed, I think, and there is corresponding test to justify it in test class
"TestCreateMVWithTimeSeries", so I changed the method. What's your opinion
aboout it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
QiangCai commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699879164 if alter column change nothing, the command should return directly without execution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732160
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLHelper.scala
##
@@ -230,14 +231,22 @@ object DDLHelper {
.toLowerCase,
values,
isColumnRename)
+ var newColumnComment: Option[String] = Option.empty
+ if (changeColumnCommand.newColumn.metadata != null &&
+
changeColumnCommand.newColumn.metadata.contains(CarbonCommonConstants.COLUMN_COMMENT))
{
+newColumnComment = Some(changeColumnCommand.
+ newColumn.metadata.getString(CarbonCommonConstants.COLUMN_COMMENT))
+ }
Review comment:
I have modified code according to you suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495731759
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -150,45 +140,45 @@ private[sql] case class
CarbonAlterTableColRenameDataTypeChangeCommand(
}
val newColumnPrecision =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
val newColumnScale =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
- if (alterTableColRenameAndDataTypeChangeModel.isColumnRename) {
-// validate the columns to be renamed
-validColumnsForRenaming(carbonColumns, oldCarbonColumn.head,
carbonTable)
-// if the datatype is source datatype, then it is just a column rename
operation, else set
-// the isDataTypeChange flag to true
-if (oldCarbonColumn.head.getDataType.getName
-
.equalsIgnoreCase(alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.dataType))
{
- val newColumnPrecision =
-alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
- val newColumnScale =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
- // if the source datatype is decimal and there is change in
precision and scale, then
- // along with rename, datatype change is also required for the
command, so set the
- // isDataTypeChange flag to true in this case
- if
(oldCarbonColumn.head.getDataType.getName.equalsIgnoreCase("decimal") &&
-
(oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getPrecision !=
- newColumnPrecision ||
-
oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getScale !=
- newColumnScale)) {
-isDataTypeChange = true
- }
-} else {
+ // set isDataTypeChange flag
+ if (oldCarbonColumn.head.getDataType.getName
+
.equalsIgnoreCase(alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.dataType))
{
+val newColumnPrecision =
+ alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.precision
+val newColumnScale =
alterTableColRenameAndDataTypeChangeModel.dataTypeInfo.scale
+// if the source datatype is decimal and there is change in precision
and scale, then
+// along with rename, datatype change is also required for the
command, so set the
+// isDataTypeChange flag to true in this case
+if
(oldCarbonColumn.head.getDataType.getName.equalsIgnoreCase("decimal") &&
+
(oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getPrecision !=
+ newColumnPrecision ||
+
oldCarbonColumn.head.getDataType.asInstanceOf[DecimalType].getScale !=
+ newColumnScale)) {
isDataTypeChange = true
}
} else {
isDataTypeChange = true
}
- if (isDataTypeChange) {
-// if column datatype change operation is on partition column, then
fail the datatype change
-// operation
-if (null != carbonTable.getPartitionInfo) {
- val partitionColumns =
carbonTable.getPartitionInfo.getColumnSchemaList
- partitionColumns.asScala.foreach {
-col =>
- if (col.getColumnName.equalsIgnoreCase(oldColumnName)) {
-throw new MalformedCarbonCommandException(
- s"Alter datatype of the partition column $newColumnName is
not allowed")
- }
- }
+ // if column datatype change operation is on partition column, then fail
the
+ // chang column operation
+ if (null != carbonTable.getPartitionInfo) {
+val partitionColumns = carbonTable.getPartitionInfo.getColumnSchemaList
+partitionColumns.asScala.foreach {
+ col =>
+if (col.getColumnName.equalsIgnoreCase(oldColumnName)) {
+ throw new MalformedCarbonCommandException(
+s"Column Rename Operation failed. Renaming or ChangeType or " +
+ s"ChangeComment the partition column $newColumnName is not "
+
Review comment:
It is really hard to support changing comments of partition columns, as
spark and hive also don't support.
https://stackoverflow.com/questions/57871294/how-to-add-edit-the-comment-of-a-partitioned-column-in-hive-table
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732016 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala ## @@ -169,7 +169,8 @@ case class AlterTableDataTypeChangeModel(dataTypeInfo: DataTypeInfo, tableName: String, columnName: String, newColumnName: String, -isColumnRename: Boolean) +isColumnRename: Boolean, +newColumnComment: Option[String]) Review comment: I have modified code according to you suggestion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699854890 > 1. do we support alter column without any change? > 2. how to remove comment from column 1. now, we support alter column without any change. 2. now. we don't support remove comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala
##
@@ -1135,11 +1135,7 @@ object CarbonParserUtil {
}
DataTypeInfo("decimal", precision, scale)
case _ =>
-if (isColumnRename) {
-
DataTypeInfo(DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
-} else {
- throw new MalformedCarbonCommandException("Data type provided is
invalid.")
-}
+
DataTypeInfo(DataTypeConverterUtil.convertToCarbonType(dataType).getName.toLowerCase)
Review comment:
Yes. useless to throw MalformedCarbonCommandException("Data type
provided is invalid.")
CarbonAlterTableColumnRenameCommand.validateColumnDataType will validate the
given datatype
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699871798 > better to focus on the topic in this PR. Got it, I will follow your suggestion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash
CarbonDataQA1 commented on pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700164625 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4259/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3961: [wip]Fix cdc merge when there are multiple bucket and join columns and AND or OR join expressions
CarbonDataQA1 commented on pull request #3961: URL: https://github.com/apache/carbondata/pull/3961#issuecomment-700164154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3962: [wip]Fix the insert issue when the column name contains \ or backslash
CarbonDataQA1 commented on pull request #3962: URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700169378 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2514/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700202083 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4262/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700223919 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2519/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700157254 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2513/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3945: [CARBONDATA-3991]Fix the set modified time function on S3 and Alluxio…
CarbonDataQA1 commented on pull request #3945: URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700160169 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4258/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3963: [WIP]Fix CSV header validation not contains dimension columns
CarbonDataQA1 commented on pull request #3963: URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700226423 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4264/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700181171 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2517/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700208844 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2518/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3789: [CARBONDATA-3864] Store Size Optimization
CarbonDataQA1 commented on pull request #3789: URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700218552 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4263/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true
VenuReddy2103 commented on a change in pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659 ## File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java ## @@ -106,6 +108,11 @@ */ boolean isNaturalSorted; + /** + * date direct dictionary generator + */ + private DirectDictionaryGenerator dateDictionaryGenerator; + public RowLevelFilterExecutorImpl(List dimColEvaluatorInfoList, Review comment: Have checked this. We are using IncludeFilterExecutorImpl as long as their is no cast expression involved. Cast operation is involved only when the data type of column to compare is not same as the literal values it is compared with. Each literal value in the InFilter can be of different type. Spark chooses one datatype for the entire list of literal values. For example, i IN (3, 2, 1.0) -> all values treated as decimal i IN (3, 2.0, '1.0') -> all values are treated as string. Note: 2.0 is not same as 2 when casted as string. When the cast operation is present, `SparkUnknownExpression` with spark cast(`SparkExpression`) is used. `SparkUnknownExpression.evaluate()` takes row's column value. Using spark cast expression, validates it and converts it to datatype of literal value it chose. And then compare the converted column value against literal values. So validation and type conversions are handled with spark cast expression. IMO, IncludeFilterExecutorImpl is already used when possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3953: [CARBONDATA-4008]Fixed IN filter on date column is returning 0 results when 'carbon.push.rowfilters.for.vector' is true
VenuReddy2103 commented on a change in pull request #3953: URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659 ## File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java ## @@ -106,6 +108,11 @@ */ boolean isNaturalSorted; + /** + * date direct dictionary generator + */ + private DirectDictionaryGenerator dateDictionaryGenerator; + public RowLevelFilterExecutorImpl(List dimColEvaluatorInfoList, Review comment: Have checked this. We are using IncludeFilterExecutorImpl as long as their is no cast expression involved. Cast is involved only when the data type of column to compare is not same as the literal values it is compared with. Each literal value in the InFilter can be of different type. Spark chooses one datatype for the entire list of literal values. For example, with i as int column i IN (3, 2, 1.0) -> all values treated as decimal i IN (3, 2.0, '1.0') -> all values are treated as string. Note: 2.0 is not same as 2 when casted as string. When the cast operation is present, `SparkUnknownExpression` with spark cast(`SparkExpression`) is used. `SparkUnknownExpression.evaluate()` takes row's column value. Using spark cast expression, validates it and converts it to datatype of literal value it chose. And then compare the converted column value against literal values. So validation and type conversions are handled with spark cast expression. IMO, IncludeFilterExecutorImpl is already used when possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] Klaus-xjp commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
Klaus-xjp commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496322133
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -258,7 +262,7 @@ private[sql] case class
CarbonAlterTableColRenameDataTypeChangeCommand(
}
} catch {
case e: Exception =>
-if (carbonTable != null) {
+ if ( carbonTable != null) {
Review comment:
there has a blank between the '(' and carbonTable
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456 @ajantha-bhat @akashrn5 please help review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on a change in pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496323043
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
@@ -258,7 +262,7 @@ private[sql] case class
CarbonAlterTableColRenameDataTypeChangeCommand(
}
} catch {
case e: Exception =>
-if (carbonTable != null) {
+ if ( carbonTable != null) {
Review comment:
I have modified code according to you suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [carbondata] Kejian-Li removed a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
Kejian-Li removed a comment on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456 @ajantha-bhat @akashrn5 please help review this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] QiangCai edited a comment on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
QiangCai edited a comment on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270 please check mail list: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html How do we process the parallel compaction(not only loading) and update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3947: [CARBONDATA-4003] Improve IUD Concurrency
QiangCai commented on pull request #3947: URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270 please check mail list: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html How do you process the parallel compaction(not only loading) and update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700406306 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4265/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700440309 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4266/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700451914 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2521/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
CarbonDataQA1 commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700405441 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2520/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] marchpure commented on pull request #3960: [CARBONDATA-4014] Support Change Column Comment
marchpure commented on pull request #3960: URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700407129 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [carbondata] vikramahuja1001 commented on pull request #3952: [CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode
vikramahuja1001 commented on pull request #3952: URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700432240 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
