date:20180210

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359782#comment-16359782
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364722003
 
 
   Trillian test result (tid-2249)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32954 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2441-t2249-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 140.49 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 146.70 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.32 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_create_volume | `Failure` | 670.33 | test_volumes.py
   test_06_download_detached_volume | `Failure` | 137.66 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 322.69 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 315.54 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 338.76 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 237.61 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359713#comment-16359713
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

blueorangutan commented on issue #2411: CLOUDSTACK-10238: Fix for metalink 
support on SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364713075
 
 
   Trillian test result (tid-2246)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22664 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2411-t2246-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359607#comment-16359607
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

rhtyd commented on issue #2411: CLOUDSTACK-10238: Fix for metalink support on 
SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364681802
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10231) Detach ISO fails for direct downloaded ISO on KVM

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359609#comment-16359609
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10231:
-

blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for 
direct downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-364681815
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Detach ISO fails for direct downloaded ISO on KVM
> -
>
> Key: CLOUDSTACK-10231
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10231
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Dettach ISO fails when trying to detach a direct download ISO (KVM only)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359610#comment-16359610
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364681818
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10231) Detach ISO fails for direct downloaded ISO on KVM

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359606#comment-16359606
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10231:
-

rhtyd commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct 
downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-364681766
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Detach ISO fails for direct downloaded ISO on KVM
> -
>
> Key: CLOUDSTACK-10231
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10231
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Dettach ISO fails when trying to detach a direct download ISO (KVM only)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359608#comment-16359608
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

blueorangutan commented on issue #2411: CLOUDSTACK-10238: Fix for metalink 
support on SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364681809
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359605#comment-16359605
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create 
one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364681742
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359580#comment-16359580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

blueorangutan commented on issue #2411: CLOUDSTACK-10238: Fix for metalink 
support on SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364679269
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1699


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359582#comment-16359582
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364679275
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1697


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359579#comment-16359579
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364679270
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1701


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10231) Detach ISO fails for direct downloaded ISO on KVM

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359581#comment-16359581
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10231:
-

blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for 
direct downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-364679273
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1700


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Detach ISO fails for direct downloaded ISO on KVM
> -
>
> Key: CLOUDSTACK-10231
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10231
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Dettach ISO fails when trying to detach a direct download ISO (KVM only)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10247) L2 network not shared on projects

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359548#comment-16359548
 ] 

ASF subversion and git services commented on CLOUDSTACK-10247:
--

Commit b2a19f7587fdd86fddc6c32fa8476eeac6269116 in cloudstack's branch 
refs/heads/master from [~nicolas.vazquez]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b2a19f7 ]

CLOUDSTACK-10247: L2 network not shared on projects (#2420)

When trying to deploy a vm providing a project id and a L2 network id, this 
error is logged.

> L2 network not shared on projects
> -
>
> Key: CLOUDSTACK-10247
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10247
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> L2 networks are not shared between projects. When trying to deploy a vm 
> assigning a project id, error is logged:
> 2018-01-18 09:04:31,749 INFO  [c.c.a.ApiServer] 
> (qtp1310540333-17:ctx-7ff91c56 ctx-8c37c46b ctx-d58064ad) (logid:74e86028) 
> PermissionDenied: Unable to use network with id= 
> 5bee486a-ff20-4db2-b62e-4b4f3485cfff, permission denied on objs: []



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359547#comment-16359547
 ] 

ASF subversion and git services commented on CLOUDSTACK-10251:
--

Commit 6e09529bdee0be84cb435beef0735444b3f6f692 in cloudstack's branch 
refs/heads/master from [~nicolas.vazquez]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6e09529 ]

CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure (#2424)

Failure on HTTPS downloader for Direct Download templates on KVM.
Reason: Incorrect request caused NullPointerException getting the response 
InputStream

> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359545#comment-16359545
 ] 

ASF subversion and git services commented on CLOUDSTACK-9663:
-

Commit 38ccbfb79c0654495ab03d54f94d3cdc481ba7c6 in cloudstack's branch 
refs/heads/master from [~dhlaluku]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=38ccbfb ]

CLOUDSTACK-9663: updateRole cmd to return updated role as JSON (#2406)

This fixes updateRole to return a role response, like other update APIs.

Signed-off-by: Rohit Yadav 

> updateRole should return updated role as json
> -
>
> Key: CLOUDSTACK-9663
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9663
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.9.0
>Reporter: René Moser
>Priority: Trivial
> Fix For: Future, 4.11.0.0
>
>
> updateRole does currently only return success but one would expect it returns 
> the updated role as json like other update APIs
> Acutal results:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test 
> --region=simulator
> {
>   "success": "true"
> }
> {code}
> expected resutls:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test 
> --region=simulator
> {
>   "role": {
> "id": ...
> "description": ...
> "name": ...
> "type": ...
>   }
> }
> {code}
> similar to other update api e.g. 
> http://cloudstack.apache.org/api/apidocs-4.9/apis/updateUser.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10218) forced network update to a nuage network offering with vr fails with IllegalArgumentException

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359544#comment-16359544
 ] 

ASF subversion and git services commented on CLOUDSTACK-10218:
--

Commit 8949efe8d1bf67fda0b8deaccedc2c2d4de0f246 in cloudstack's branch 
refs/heads/master from [~sgoeminn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8949efe ]

CLOUDSTACK-10218: Fix for forced network update in a nuage network (#2445)

Fix for forced network update to a nuage network offering with vr fails with 
IllegalArgumentException.
Addressed review comments DaanHoogland.


> forced network update to a nuage network offering with vr fails with 
> IllegalArgumentException
> -
>
> Key: CLOUDSTACK-10218
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10218
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, Network Controller
>Affects Versions: 4.11.0.0
> Environment: NuageVSP
>Reporter: Raf Smeets
>Assignee: Sigert Goeminne
>Priority: Major
> Attachments: configdrivemanagement-server.log
>
>
> a forced network update from a nuage network offering without vr to a nuage 
> network offering with vr fails with  java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> It looks like this issue was introduced by recalculate broadcasturi 
> introduced by the network migration PR. Cause: 
> VspNetwork.getVirtualRouterIp() == "null" NuageVspElement:287
> Scenario to reproduce:
> update network id  networkofferingid  
> forced=true
> In failing test , existing network offering is one withoutVR, 
> newnetworkoffering is one with VR as DNS requires VR.
> The exception reported in cloudstack is : java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> Full cloudstack management server logs are attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10243) Updating metadata might hang on VR on "ip rule show"

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359546#comment-16359546
 ] 

ASF subversion and git services commented on CLOUDSTACK-10243:
--

Commit ce67726c6d3db6e7db537e76da6217c5d5f4b10e in cloudstack's branch 
refs/heads/master from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ce67726 ]

CLOUDSTACK-10243: Do not use wait() on Python subprocess (#2421)

This might (and does block) in certain situations on the VR as
also explained in the Python documentation:

https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait

  Warning This will deadlock when using stdout=PIPE and/or stderr=PIPE
  and the child process generates enough output to a pipe such that
  it blocks waiting for the OS pipe buffer to accept more data.
  Use communicate() to avoid that.

Using the check_output function handles most of this for us and
also provides better error handling.

Signed-off-by: Wido den Hollander 

> Updating metadata might hang on VR on "ip rule show"
> 
>
> Key: CLOUDSTACK-10243
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10243
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.10.0.0, 4.11.0.0
> Environment: CloudStack 4.10 - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Major
>  Labels: basic-networking, python, virtual-router
> Fix For: Future
>
>
> On a CloudStack 4.10 setup running with Basic Networking we noticed VMs being 
> in the "Starting" state.
> After investigating in the VR we show the "ip rule show" command run for ever 
> and never end. This causes Python scripts to wait and thus never start the 
> Instance.
> This seems to be a issue in CsHelper.py where it uses p.wait() which might 
> block in certain situations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10247) L2 network not shared on projects

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359538#comment-16359538
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10247:
-

rhtyd commented on issue #2420: CLOUDSTACK-10247: L2 network not shared on 
projects
URL: https://github.com/apache/cloudstack/pull/2420#issuecomment-364674084
 
 
   LGTM, merging based on reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> L2 network not shared on projects
> -
>
> Key: CLOUDSTACK-10247
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10247
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> L2 networks are not shared between projects. When trying to deploy a vm 
> assigning a project id, error is logged:
> 2018-01-18 09:04:31,749 INFO  [c.c.a.ApiServer] 
> (qtp1310540333-17:ctx-7ff91c56 ctx-8c37c46b ctx-d58064ad) (logid:74e86028) 
> PermissionDenied: Unable to use network with id= 
> 5bee486a-ff20-4db2-b62e-4b4f3485cfff, permission denied on objs: []



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10247) L2 network not shared on projects

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359539#comment-16359539
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10247:
-

rhtyd closed pull request #2420: CLOUDSTACK-10247: L2 network not shared on 
projects
URL: https://github.com/apache/cloudstack/pull/2420
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/network/NetworkModelImpl.java 
b/server/src/com/cloud/network/NetworkModelImpl.java
index e583b717a16..b8e7b53b1fa 100644
--- a/server/src/com/cloud/network/NetworkModelImpl.java
+++ b/server/src/com/cloud/network/NetworkModelImpl.java
@@ -930,7 +930,7 @@ public boolean areServicesSupportedInNetwork(long 
networkId, Service... services
 @Override
 public String getIpOfNetworkElementInVirtualNetwork(long accountId, long 
dataCenterId) {
 
-List virtualNetworks = 
_networksDao.listByZoneAndGuestType(accountId, dataCenterId, 
Network.GuestType.Isolated, false);
+List virtualNetworks = 
_networksDao.listByZoneAndGuestType(accountId, dataCenterId, 
GuestType.Isolated, false);
 
 if (virtualNetworks.isEmpty()) {
 s_logger.trace("Unable to find default Virtual network account 
id=" + accountId);
@@ -950,13 +950,13 @@ public String getIpOfNetworkElementInVirtualNetwork(long 
accountId, long dataCen
 }
 
 @Override
-public List listNetworksForAccount(long accountId, long zoneId, 
Network.GuestType type) {
+public List listNetworksForAccount(long accountId, long zoneId, 
GuestType type) {
 List accountNetworks = new ArrayList();
 List zoneNetworks = _networksDao.listByZone(zoneId);
 
 for (NetworkVO network : zoneNetworks) {
 if (!isNetworkSystem(network)) {
-if (network.getGuestType() == Network.GuestType.Shared || 
!_networksDao.listBy(accountId, network.getId()).isEmpty()) {
+if (network.getGuestType() == GuestType.Shared || 
!_networksDao.listBy(accountId, network.getId()).isEmpty()) {
 if (type == null || type == network.getGuestType()) {
 accountNetworks.add(network);
 }
@@ -967,7 +967,7 @@ public String getIpOfNetworkElementInVirtualNetwork(long 
accountId, long dataCen
 }
 
 @Override
-public List listAllNetworksInAllZonesByType(Network.GuestType 
type) {
+public List listAllNetworksInAllZonesByType(GuestType type) {
 List networks = new ArrayList();
 for (NetworkVO network : _networksDao.listAll()) {
 if (!isNetworkSystem(network)) {
@@ -1637,7 +1637,8 @@ public void checkNetworkPermissions(Account owner, 
Network network) {
 throw new CloudRuntimeException("cannot check permissions on 
(Network) ");
 }
 // Perform account permission check
-if (network.getGuestType() != Network.GuestType.Shared || 
(network.getGuestType() == Network.GuestType.Shared && network.getAclType() == 
ACLType.Account)) {
+if ((network.getGuestType() != GuestType.Shared && 
network.getGuestType() != GuestType.L2) ||
+(network.getGuestType() == GuestType.Shared && 
network.getAclType() == ACLType.Account)) {
 AccountVO networkOwner = 
_accountDao.findById(network.getAccountId());
 if (networkOwner == null)
 throw new PermissionDeniedException("Unable to use network 
with id= " + ((NetworkVO)network).getUuid() +
@@ -1802,14 +1803,14 @@ public boolean isPrivateGateway(long ntwkId) {
 public boolean isNetworkAvailableInDomain(long networkId, long domainId) {
 Long networkDomainId = null;
 Network network = getNetwork(networkId);
-if (network.getGuestType() != Network.GuestType.Shared) {
-s_logger.trace("Network id=" + networkId + " is not shared");
+if (network.getGuestType() != GuestType.Shared && 
network.getGuestType() != GuestType.L2) {
+s_logger.trace("Network id=" + networkId + " is not shared or L2");
 return false;
 }
 
 NetworkDomainVO networkDomainMap = 
_networkDomainDao.getDomainNetworkMapByNetworkId(networkId);
 if (networkDomainMap == null) {
-s_logger.trace("Network id=" + networkId + " is shared, but not 
domain specific");
+s_logger.trace("Network id=" + networkId + " is shared or L2, but 
not domain specific");
 return true;
 } else {
 networkDomainId = networkDomainMap.getDomainId();
diff --git a/server/src/com/cloud/network/NetworkServiceImpl.java 
b/server/src/com/cloud/network/NetworkServiceImpl.java
index d7ae6276f85..93f73d20a5f 100644
---

[jira] [Commented] (CLOUDSTACK-10247) L2 network not shared on projects

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359540#comment-16359540
 ] 

ASF subversion and git services commented on CLOUDSTACK-10247:
--

Commit b2a19f7587fdd86fddc6c32fa8476eeac6269116 in cloudstack's branch 
refs/heads/4.11 from [~nicolas.vazquez]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b2a19f7 ]

CLOUDSTACK-10247: L2 network not shared on projects (#2420)

When trying to deploy a vm providing a project id and a L2 network id, this 
error is logged.

> L2 network not shared on projects
> -
>
> Key: CLOUDSTACK-10247
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10247
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> L2 networks are not shared between projects. When trying to deploy a vm 
> assigning a project id, error is logged:
> 2018-01-18 09:04:31,749 INFO  [c.c.a.ApiServer] 
> (qtp1310540333-17:ctx-7ff91c56 ctx-8c37c46b ctx-d58064ad) (logid:74e86028) 
> PermissionDenied: Unable to use network with id= 
> 5bee486a-ff20-4db2-b62e-4b4f3485cfff, permission denied on objs: []



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359535#comment-16359535
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

rhtyd closed pull request #2424: CLOUDSTACK-10251: HTTPS downloader for Direct 
Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/agent/src/com/cloud/agent/direct/download/HttpsDirectTemplateDownloader.java 
b/agent/src/com/cloud/agent/direct/download/HttpsDirectTemplateDownloader.java
index 436303f71cf..664181fbda3 100644
--- 
a/agent/src/com/cloud/agent/direct/download/HttpsDirectTemplateDownloader.java
+++ 
b/agent/src/com/cloud/agent/direct/download/HttpsDirectTemplateDownloader.java
@@ -21,6 +21,9 @@
 
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
+import org.apache.commons.io.IOUtils;
+import org.apache.http.HttpEntity;
+import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpUriRequest;
 import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
@@ -33,6 +36,9 @@
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.FileOutputStream;
 import java.security.KeyManagementException;
 import java.security.KeyStore;
 import java.security.KeyStoreException;
@@ -79,11 +85,32 @@ private SSLContext getSSLContext() throws 
KeyStoreException, NoSuchAlgorithmExce
 
 @Override
 public boolean downloadTemplate() {
+CloseableHttpResponse response;
 try {
-httpsClient.execute(req);
+response = httpsClient.execute(req);
 } catch (IOException e) {
 throw new CloudRuntimeException("Error on HTTPS request: " + 
e.getMessage());
 }
-return performDownload();
+return consumeResponse(response);
 }
+
+/**
+ * Consume response and persist it on getDownloadedFilePath() file
+ */
+protected boolean consumeResponse(CloseableHttpResponse response) {
+if (response.getStatusLine().getStatusCode() != 200) {
+throw new CloudRuntimeException("Error on HTTPS response");
+}
+try {
+HttpEntity entity = response.getEntity();
+InputStream in = entity.getContent();
+OutputStream out = new FileOutputStream(getDownloadedFilePath());
+IOUtils.copy(in, out);
+} catch (Exception e) {
+s_logger.error("Error parsing response for template " + 
getTemplateId() + " due to: " + e.getMessage());
+return false;
+}
+return true;
+}
+
 }
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359536#comment-16359536
 ] 

ASF subversion and git services commented on CLOUDSTACK-10251:
--

Commit 6e09529bdee0be84cb435beef0735444b3f6f692 in cloudstack's branch 
refs/heads/4.11 from [~nicolas.vazquez]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6e09529 ]

CLOUDSTACK-10251: HTTPS downloader for Direct Download templates failure (#2424)

Failure on HTTPS downloader for Direct Download templates on KVM.
Reason: Incorrect request caused NullPointerException getting the response 
InputStream

> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10251) HTTPS downloader for Direct Download templates failure

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359534#comment-16359534
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10251:
-

rhtyd commented on issue #2424: CLOUDSTACK-10251: HTTPS downloader for Direct 
Download templates failure
URL: https://github.com/apache/cloudstack/pull/2424#issuecomment-364674049
 
 
   LGTM, merging based on test results and reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> HTTPS downloader for Direct Download templates failure 
> ---
>
> Key: CLOUDSTACK-10251
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10251
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Failure on HTTPS downloader for Direct Download templates on KVM.
> Reason: Incorrect request caused NullPointerException getting the response 
> InputStream



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359532#comment-16359532
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

rhtyd commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from bypassed 
registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364673909
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10243) Updating metadata might hang on VR on "ip rule show"

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359530#comment-16359530
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10243:
-

rhtyd closed pull request #2421: CLOUDSTACK-10243: Do not use wait() on Python 
subprocess
URL: https://github.com/apache/cloudstack/pull/2421
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/systemvm/debian/opt/cloud/bin/cs/CsHelper.py 
b/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
index 5397038fd1e..241643d9956 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsHelper.py
@@ -183,13 +183,19 @@ def get_hostname():
 
 def execute(command):
 """ Execute command """
-p = subprocess.Popen(command, stdout=subprocess.PIPE, 
stderr=subprocess.PIPE, shell=True)
-p.wait()
-rc = p.returncode
-
-logging.debug("Executed: %s - exitstatus=%s " % (command, rc))
-result = p.communicate()[0]
-return result.splitlines()
+returncode = -1
+try:
+logging.info("Executing: %s" % command)
+result = subprocess.check_output(command, shell=True)
+returncode = 0
+return result.splitlines()
+except subprocess.CalledProcessError as e:
+logging.error(e)
+returncode = e.returncode
+finally:
+logging.debug("Executed: %s - exitstatus=%s " % (command, returncode))
+
+return list()
 
 
 def save_iptables(command, iptables_file):


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Updating metadata might hang on VR on "ip rule show"
> 
>
> Key: CLOUDSTACK-10243
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10243
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.10.0.0, 4.11.0.0
> Environment: CloudStack 4.10 - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Major
>  Labels: basic-networking, python, virtual-router
> Fix For: Future
>
>
> On a CloudStack 4.10 setup running with Basic Networking we noticed VMs being 
> in the "Starting" state.
> After investigating in the VR we show the "ip rule show" command run for ever 
> and never end. This causes Python scripts to wait and thus never start the 
> Instance.
> This seems to be a issue in CsHelper.py where it uses p.wait() which might 
> block in certain situations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10250) Reinstall VM from bypassed registered template

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359533#comment-16359533
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10250:
-

blueorangutan commented on issue #2423: CLOUDSTACK-10250: Reinstall VM from 
bypassed registered template
URL: https://github.com/apache/cloudstack/pull/2423#issuecomment-364673960
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reinstall VM from bypassed registered template
> --
>
> Key: CLOUDSTACK-10250
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10250
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> This fix allows users to restore a VM from a previously registered template 
> using the Direct Download option (only for KVM currently)
> NOTE: As Reinstall VM button prompts only featured templates, to be able to 
> restore a vm to a Direct Download template, it should be registered as 
> Featured



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10243) Updating metadata might hang on VR on "ip rule show"

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359531#comment-16359531
 ] 

ASF subversion and git services commented on CLOUDSTACK-10243:
--

Commit ce67726c6d3db6e7db537e76da6217c5d5f4b10e in cloudstack's branch 
refs/heads/4.11 from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ce67726 ]

CLOUDSTACK-10243: Do not use wait() on Python subprocess (#2421)

This might (and does block) in certain situations on the VR as
also explained in the Python documentation:

https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait

  Warning This will deadlock when using stdout=PIPE and/or stderr=PIPE
  and the child process generates enough output to a pipe such that
  it blocks waiting for the OS pipe buffer to accept more data.
  Use communicate() to avoid that.

Using the check_output function handles most of this for us and
also provides better error handling.

Signed-off-by: Wido den Hollander 

> Updating metadata might hang on VR on "ip rule show"
> 
>
> Key: CLOUDSTACK-10243
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10243
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.10.0.0, 4.11.0.0
> Environment: CloudStack 4.10 - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Major
>  Labels: basic-networking, python, virtual-router
> Fix For: Future
>
>
> On a CloudStack 4.10 setup running with Basic Networking we noticed VMs being 
> in the "Starting" state.
> After investigating in the VR we show the "ip rule show" command run for ever 
> and never end. This causes Python scripts to wait and thus never start the 
> Instance.
> This seems to be a issue in CsHelper.py where it uses p.wait() which might 
> block in certain situations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10231) Detach ISO fails for direct downloaded ISO on KVM

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359528#comment-16359528
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10231:
-

blueorangutan commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for 
direct downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-364673866
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Detach ISO fails for direct downloaded ISO on KVM
> -
>
> Key: CLOUDSTACK-10231
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10231
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Dettach ISO fails when trying to detach a direct download ISO (KVM only)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10231) Detach ISO fails for direct downloaded ISO on KVM

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359525#comment-16359525
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10231:
-

rhtyd commented on issue #2408: CLOUDSTACK-10231: Detach ISO fails for direct 
downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-364673802
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Detach ISO fails for direct downloaded ISO on KVM
> -
>
> Key: CLOUDSTACK-10231
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10231
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Dettach ISO fails when trying to detach a direct download ISO (KVM only)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359526#comment-16359526
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

rhtyd commented on issue #2411: CLOUDSTACK-10238: Fix for metalink support on 
SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364673812
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10243) Updating metadata might hang on VR on "ip rule show"

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359529#comment-16359529
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10243:
-

rhtyd commented on issue #2421: CLOUDSTACK-10243: Do not use wait() on Python 
subprocess
URL: https://github.com/apache/cloudstack/pull/2421#issuecomment-364673872
 
 
   LGTM, merging this based on test results and reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Updating metadata might hang on VR on "ip rule show"
> 
>
> Key: CLOUDSTACK-10243
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10243
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Virtual Router
>Affects Versions: 4.10.0.0, 4.11.0.0
> Environment: CloudStack 4.10 - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>Priority: Major
>  Labels: basic-networking, python, virtual-router
> Fix For: Future
>
>
> On a CloudStack 4.10 setup running with Basic Networking we noticed VMs being 
> in the "Starting" state.
> After investigating in the VR we show the "ip rule show" command run for ever 
> and never end. This causes Python scripts to wait and thus never start the 
> Instance.
> This seems to be a issue in CsHelper.py where it uses p.wait() which might 
> block in certain situations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10238) Fix for metalink support on SSVM agents

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359527#comment-16359527
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10238:
-

blueorangutan commented on issue #2411: CLOUDSTACK-10238: Fix for metalink 
support on SSVM agents
URL: https://github.com/apache/cloudstack/pull/2411#issuecomment-364673865
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix for metalink support on SSVM agents
> ---
>
> Key: CLOUDSTACK-10238
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10238
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>
> Fix for metalink support



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359523#comment-16359523
 ] 

ASF subversion and git services commented on CLOUDSTACK-9663:
-

Commit 38ccbfb79c0654495ab03d54f94d3cdc481ba7c6 in cloudstack's branch 
refs/heads/4.11 from [~dhlaluku]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=38ccbfb ]

CLOUDSTACK-9663: updateRole cmd to return updated role as JSON (#2406)

This fixes updateRole to return a role response, like other update APIs.

Signed-off-by: Rohit Yadav 

> updateRole should return updated role as json
> -
>
> Key: CLOUDSTACK-9663
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9663
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Affects Versions: 4.9.0
>Reporter: René Moser
>Priority: Trivial
> Fix For: Future, 4.11.0.0
>
>
> updateRole does currently only return success but one would expect it returns 
> the updated role as json like other update APIs
> Acutal results:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test 
> --region=simulator
> {
>   "success": "true"
> }
> {code}
> expected resutls:
> {code}
>  $ cs updateRole id=0d6f4eca-cf71-47ba-81d9-aa129b38911b name=test 
> --region=simulator
> {
>   "role": {
> "id": ...
> "description": ...
> "name": ...
> "type": ...
>   }
> }
> {code}
> similar to other update api e.g. 
> http://cloudstack.apache.org/api/apidocs-4.9/apis/updateUser.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359524#comment-16359524
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10207:
-

rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix 
defaulting for option…
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-364673791
 
 
   Ping @resmo, can you comment on outstanding questions?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> updateVpnCustomerGateway: unexpected changes on optional keys
> -
>
> Key: CLOUDSTACK-10207
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: René Moser
>Assignee: René Moser
>Priority: Minor
> Fix For: 4.11.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9663) updateRole should return updated role as json

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359522#comment-16359522
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9663:


rhtyd closed pull request #2406: CLOUDSTACK-9663 return role on updateRole
URL: https://github.com/apache/cloudstack/pull/2406
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/admin/acl/RoleCmd.java 
b/api/src/main/java/org/apache/cloudstack/api/command/admin/acl/RoleCmd.java
new file mode 100644
index 000..9054ff5fada
--- /dev/null
+++ b/api/src/main/java/org/apache/cloudstack/api/command/admin/acl/RoleCmd.java
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.acl;
+
+import org.apache.cloudstack.acl.Role;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.response.RoleResponse;
+
+public abstract class RoleCmd extends BaseCmd {
+
+protected void setupResponse(final Role role) {
+final RoleResponse response = new RoleResponse();
+response.setId(role.getUuid());
+response.setRoleName(role.getName());
+response.setRoleType(role.getRoleType());
+response.setDescription(role.getDescription());
+response.setResponseName(getCommandName());
+response.setObjectName("role");
+setResponseObject(response);
+}
+}
diff --git a/api/src/org/apache/cloudstack/acl/RoleService.java 
b/api/src/org/apache/cloudstack/acl/RoleService.java
index 98d170b5853..721bef08c20 100644
--- a/api/src/org/apache/cloudstack/acl/RoleService.java
+++ b/api/src/org/apache/cloudstack/acl/RoleService.java
@@ -31,7 +31,7 @@
 boolean isEnabled();
 Role findRole(final Long id);
 Role createRole(final String name, final RoleType roleType, final String 
description);
-boolean updateRole(final Role role, final String name, final RoleType 
roleType, final String description);
+Role updateRole(final Role role, final String name, final RoleType 
roleType, final String description);
 boolean deleteRole(final Role role);
 
 RolePermission findRolePermission(final Long id);
diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java 
b/api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java
index 994573d1796..87f0288dd01 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/admin/acl/CreateRoleCmd.java
@@ -34,7 +34,7 @@
 requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
 since = "4.9.0",
 authorized = {RoleType.Admin})
-public class CreateRoleCmd extends BaseCmd {
+public class CreateRoleCmd extends RoleCmd {
 public static final String APINAME = "createRole";
 
 /
@@ -83,16 +83,6 @@ public long getEntityOwnerId() {
 return Account.ACCOUNT_ID_SYSTEM;
 }
 
-private void setupResponse(final Role role) {
-final RoleResponse response = new RoleResponse();
-response.setId(role.getUuid());
-response.setRoleName(role.getName());
-response.setRoleType(role.getRoleType());
-response.setResponseName(getCommandName());
-response.setObjectName("role");
-setResponseObject(response);
-}
-
 @Override
 public void execute() {
 CallContext.current().setEventDetails("Role: " + getRoleName() + ", 
type:" + getRoleType() + ", description: " + getRoleDescription());
diff --git 
a/api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java 
b/api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java
index e17fc6f5714..f9519aeec5a 100644
--- a/api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java
+++

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359520#comment-16359520
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create 
one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364673673
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359521#comment-16359521
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10261:
-

blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: 
only create one nuage-extension tag
URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364673708
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one 
> interface.
> ---
>
> Key: CLOUDSTACK-10261
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: cloudstack-agent
>Affects Versions: 4.11.0.0
> Environment: Nuage VSP plugin on RHEL 7.4
>Reporter: Frank Maximus
>Assignee: Frank Maximus
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there 
> is an issue with the metadata of the created VM in cloudstack. 
> It leads to password reset failure as the nuage vrs is not allowing passage 
> to DomainRouter.
> After debugging , it was found that the nuage-extension in metadata was 
> missing.
> When cloudstack-agent is preparing xml to be sent to openvswitch it contains 
> metadata with nuage-extension block as follows
> 
> 
> 
> 
> 
> In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without 
> nuage-extension block in metadata as follows:
> Jan 15 18:17:17 ovs-1 vm-monitor.log: 
> So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in 
> its metada, so the libvirt namespace needs to be adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10218) forced network update to a nuage network offering with vr fails with IllegalArgumentException

2018-02-10 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359519#comment-16359519
 ] 

ASF subversion and git services commented on CLOUDSTACK-10218:
--

Commit 8949efe8d1bf67fda0b8deaccedc2c2d4de0f246 in cloudstack's branch 
refs/heads/4.11 from [~sgoeminn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8949efe ]

CLOUDSTACK-10218: Fix for forced network update in a nuage network (#2445)

Fix for forced network update to a nuage network offering with vr fails with 
IllegalArgumentException.
Addressed review comments DaanHoogland.


> forced network update to a nuage network offering with vr fails with 
> IllegalArgumentException
> -
>
> Key: CLOUDSTACK-10218
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10218
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, Network Controller
>Affects Versions: 4.11.0.0
> Environment: NuageVSP
>Reporter: Raf Smeets
>Assignee: Sigert Goeminne
>Priority: Major
> Attachments: configdrivemanagement-server.log
>
>
> a forced network update from a nuage network offering without vr to a nuage 
> network offering with vr fails with  java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> It looks like this issue was introduced by recalculate broadcasturi 
> introduced by the network migration PR. Cause: 
> VspNetwork.getVirtualRouterIp() == "null" NuageVspElement:287
> Scenario to reproduce:
> update network id  networkofferingid  
> forced=true
> In failing test , existing network offering is one withoutVR, 
> newnetworkoffering is one with VR as DNS requires VR.
> The exception reported in cloudstack is : java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> Full cloudstack management server logs are attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10218) forced network update to a nuage network offering with vr fails with IllegalArgumentException

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359518#comment-16359518
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10218:
-

rhtyd commented on issue #2445: CLOUDSTACK-10218: fix for forced network update 
in a nuage network
URL: https://github.com/apache/cloudstack/pull/2445#issuecomment-364673627
 
 
   LGTM, merging based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> forced network update to a nuage network offering with vr fails with 
> IllegalArgumentException
> -
>
> Key: CLOUDSTACK-10218
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10218
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, Network Controller
>Affects Versions: 4.11.0.0
> Environment: NuageVSP
>Reporter: Raf Smeets
>Assignee: Sigert Goeminne
>Priority: Major
> Attachments: configdrivemanagement-server.log
>
>
> a forced network update from a nuage network offering without vr to a nuage 
> network offering with vr fails with  java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> It looks like this issue was introduced by recalculate broadcasturi 
> introduced by the network migration PR. Cause: 
> VspNetwork.getVirtualRouterIp() == "null" NuageVspElement:287
> Scenario to reproduce:
> update network id  networkofferingid  
> forced=true
> In failing test , existing network offering is one withoutVR, 
> newnetworkoffering is one with VR as DNS requires VR.
> The exception reported in cloudstack is : java.lang.IllegalArgumentException
> Message: 'null' is not an IP string literal.
> Full cloudstack management server logs are attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10282) SystemVM - filrewall rules incorrect

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359516#comment-16359516
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10282:
-

rhtyd commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab…
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364673542
 
 
   @marcaurele LGTM, can you change the base branch to 4.11?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SystemVM - filrewall rules incorrect
> 
>
> Key: CLOUDSTACK-10282
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10282
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Reporter: Marc-Aurèle Brothier
>Priority: Major
>
> The current state of the firewall on the systemVMs let all packets come in 
> due to the overwrite of the ipv6 rules on the ipv4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10282) SystemVM - filrewall rules incorrect

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359422#comment-16359422
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10282:
-

resmo commented on issue #2450: CLOUDSTACK-10282: firewall rules operation 
should be done with ip6tab…
URL: https://github.com/apache/cloudstack/pull/2450#issuecomment-364650442
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SystemVM - filrewall rules incorrect
> 
>
> Key: CLOUDSTACK-10282
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10282
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: SystemVM
>Reporter: Marc-Aurèle Brothier
>Priority: Major
>
> The current state of the firewall on the systemVMs let all packets come in 
> due to the overwrite of the ipv6 rules on the ipv4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359382#comment-16359382
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

DaanHoogland commented on issue #2449: CLOUDSTACK-10278 - WIP: this script 
needs to tested
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-364644729
 
 
   @rhtyd for avoiding an extra update script it makes sense to release it as 
4.11.0.1 otherwise i am fine with any version, even 4.12


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359381#comment-16359381
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

DaanHoogland commented on issue #2449: CLOUDSTACK-10278 - WIP: this script 
needs to tested
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-364644651
 
 
   @ernjvr  you need to really reapply this commit on 4.11 to avoid pulling in 
those newer commits.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

2018-02-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359379#comment-16359379
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

DaanHoogland commented on issue #2449: CLOUDSTACK-10278 - WIP: this script 
needs to tested
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-364644589
 
 
   @ustcweizhou did you see the report on users@?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

44 matches

Mail list logo