[jira] [Commented] (CLOUDSTACK-10025) To create a better VNC client for Cloudstack using noVNC

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712014#comment-16712014
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10025:
-

svenvogel commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC 
Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-445024138
 
 
   @syed is there any updates on the html 5 console?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> To create a better VNC client for Cloudstack using noVNC
> 
>
> Key: CLOUDSTACK-10025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10025
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.11.0.0
>Reporter: Sachin
>Priority: Minor
>  Labels: features
>
> I have implemented this feature as my GSoC'17 project. noVNC is written in 
> javascript and uses websockets to connect to VNC server. We have modified the 
> ConsoleProxy server to accept websocket request from noVNC client, which then 
> forwards the request request to VNC server.
> Javascript cannot make plain tcp request, hence the websocket request have to 
> be forwarded to the VNC server via a proxy server that basically converts 
> websocket request from client to plain tcp request for VNC server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10039) Adding IOPS/GB offering

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712011#comment-16712011
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10039:
-

svenvogel commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-445023790
 
 
   @syed is it useful for solidfire? Is there any progress in this pr?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding IOPS/GB offering
> ---
>
> Key: CLOUDSTACK-10039
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10039
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Syed Ahmed
>Priority: Major
> Fix For: Future
>
>
> We want to add a disk offering where we can specify the Min/Max IOPS as a 
> function of size. The idea is the larger volume you create, the greater your 
> IOPS will be (this is similar to the way GCE handles IOPS). We also have 
> added limits to the IOPS (min and max) so that once the volume goes beyond a 
> certain size, the IOPS won't change and are capped to the given values.
> The following parameters are added to the `createDiskOffering` API:
> 1. `miniopspergb' : Minimum IOPS/GB for the offering
> 2. `maxiopspergb`: Maximum IOPS/GB for the offering
> 3. `highestminiops`: The highest `miniops` value that is allowed for this 
> offering
> 3. `highestmaxiops`: The highest `maxiops` value that is allowed for this 
> offering



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711994#comment-16711994
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rhtyd closed pull request #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
index 39b92c3a352..ebaf23f1ca7 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
@@ -170,7 +170,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 for (File anInterface : interfaces) {
 final String fname = anInterface.getName();
 s_logger.debug("matchPifFileInDirectory: file name '" + fname + 
"'");
-if (isInterface(fname)) {
+if (LibvirtComputingResource.isInterface(fname)) {
 return fname;
 }
 }
@@ -179,33 +179,6 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-private static final String [] IF_NAME_PATTERNS = {
-"^eth",
-"^bond",
-"^vlan",
-"^vx",
-"^em",
-"^ens",
-"^eno",
-"^enp",
-"^team",
-"^enx",
-"^p\\d+p\\d+"
-};
-
-/**
- * @param fname
- * @return
- */
-private static boolean isInterface(final String fname) {
-StringBuilder commonPattern = new StringBuilder();
-for (final String ifNamePattern : IF_NAME_PATTERNS) {
-commonPattern.append("|(").append(ifNamePattern).append(".*)");
-}
-
-return fname.matches(commonPattern.toString());
-}
-
 protected boolean isBroadcastTypeVlanOrVxlan(final NicTO nic) {
 return nic != null && (nic.getBroadcastType() == 
Networks.BroadcastDomainType.Vlan
 || nic.getBroadcastType() == 
Networks.BroadcastDomainType.Vxlan);
@@ -432,7 +405,7 @@ private void deleteExistingLinkLocalRouteTable(String 
linkLocalBr) {
 }
 if (!foundLinkLocalBr) {
 Script.runSimpleBashScript("ip address add 169.254.0.1/16 dev " + 
linkLocalBr + ";" + "ip route add " + NetUtils.getLinkLocalCIDR() + " dev " + 
linkLocalBr + " src " +
-NetUtils.getLinkLocalGateway());
+NetUtils.getLinkLocalGateway());
 }
 }
 
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
index 26fcd01f63f..3b61337164a 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -26,6 +26,7 @@
 import java.net.InetAddress;
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Calendar;
@@ -278,7 +279,7 @@
 protected String _rngPath = "/dev/random";
 protected int _rngRatePeriod = 1000;
 protected int _rngRateBytes = 2048;
-private File _qemuSocketsPath;
+protected File _qemuSocketsPath;
 private final String _qemuGuestAgentSocketName = "org.qemu.guest_agent.0";
 protected WatchDogAction _watchDogAction = WatchDogAction.NONE;
 protected WatchDogModel _watchDogModel = WatchDogModel.I6300ESB;
@@ -1308,7 +1309,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 "^eth",
 "^bond",
 "^vlan",
@@ -1319,15 +1320,18 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 "^enp",
 "^team",
 "^enx",
+"^dummy",
+"^lo",
 "^p\\d+p\\d+"
 };
+
 /**
  * @param fname
  * @return
  */
-boolean isInterface(final String fname) {
+protected static boolean isInterface(final String fname) {
 StringBuffer commonPattern = new StringBuffer();
-for (final String ifNamePattern : 

[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711402#comment-16711402
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

falcon78921 commented on issue #17: CLOUDSTACK-10399: Added section regarding 
MySQL server-id
URL: 
https://github.com/apache/cloudstack-documentation/pull/17#issuecomment-444860467
 
 
   Thanks @PaulAngus for the followup.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9975) Allow customizing system VM templates for SSVM and Console Proxy

2018-12-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711306#comment-16711306
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9975:


GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing 
system VM templates for SSVM and Console Proxy
URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-444838054
 
 
   That is indeed the main goal, @DennisKonrad. Thanks for pointing that!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow customizing system VM templates for SSVM and Console Proxy
> 
>
> Key: CLOUDSTACK-9975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9975
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Gabriel Beims Bräscher
>Assignee: Gabriel Beims Bräscher
>Priority: Minor
>
> Currently, it is only possible to change the template used by virtual 
> routers, but other system VMs do not have the same feature. The virtual 
> router template is configured according to the respective global settings 
> parameters: router.template.hyperv, router.template.kvm, router.template.lxc, 
> router.template.xenserver, router.template.ovm, router.template.vmware.
> This ticket proposes the configuration of templates for storage system VMs 
> (SSVMs) and console proxy system VMs with parameters similar with the virtual 
> router template configuration: ssvm.template. and 
> consoleproxy.template.
> If a parameter is null then it keeps the current flow for that scenario 
> (systemvm/virtualization tool).
> This proposal allows users to customize virtual machines templates according 
> to specific needs of each system VM. This feature was useful in a practical 
> scenario where it was necessary to perform some changes for the console proxy 
> system VM template.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711070#comment-16711070
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

PaulAngus commented on issue #17: CLOUDSTACK-10399: Added section regarding 
MySQL server-id
URL: 
https://github.com/apache/cloudstack-documentation/pull/17#issuecomment-444775912
 
 
   Hi @falcon78921,
   Changes in the Master branch will only be seen in the next release, ie 4.12.
   The reason being that it will have information which will related to 
features that aren't available yet.
   For changes to be seen right now, they would need to be backported to the 
4.11 branch, and the current tag (4.11.2) moved to the latest commit.
   (yes it seems far more complicated that it need be, but what can you do).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-4045) IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later

2018-12-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709204#comment-16709204
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4045:


GabrielBrascher commented on issue #2382: CLOUDSTACK-4045 IP address acquired 
with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-444240916
 
 
   @houthuis can you please rebase against the latest master?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IP address acquired with associateIpAddress is marked as source NAT, causing 
> disassociateIpAddress to fail later
> 
>
> Key: CLOUDSTACK-4045
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4045
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
>Reporter: Murali Reddy
>Assignee: Henko Holtzhausen
>Priority: Major
> Fix For: Future
>
>
> When you can create network, network is in allocated state. when network is 
> implemented CloudStack implicitly should acquire a public IP for source nat. 
> But there is assumption that first IP this is associated with network is 
> always for source NAT IP. So when you do
> 1. create network (network is in allocated state)
> 2. acquire a public IP and associate with the network
> 3. disassociate ip address
> #3 will fail because CloudStack marks the IP acquired in #1 to be source NAT. 
> For users this is counter-intutive because when a IP is acquired, he/she 
> should be able to release it as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-12-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708049#comment-16708049
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

falcon78921 commented on issue #17: CLOUDSTACK-10399: Added section regarding 
MySQL server-id
URL: 
https://github.com/apache/cloudstack-documentation/pull/17#issuecomment-443933148
 
 
   Hello @GabrielBrascher @rafaelweingartner,
   
   The changes I've submitted are merged into the ```master``` branch. However, 
I've noticed they haven't been built into the latest docs. Are the docs built 
on a scheduled basis?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705538#comment-16705538
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443384085
 
 
   Trillian test result (tid-3240)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 27502 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3000-t3240-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 68 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 41.56 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 271.79 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705011#comment-16705011
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443265672
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2475


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705021#comment-16705021
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rhtyd commented on issue #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443267315
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705023#comment-16705023
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443267509
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704990#comment-16704990
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rhtyd commented on issue #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443259136
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704991#comment-16704991
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443259178
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704860#comment-16704860
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


bwsw commented on issue #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443229474
 
 
   @rhtyd Conflicts fixed. Local build and tests passed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704585#comment-16704585
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rhtyd commented on issue #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-443171264
 
 
   @bwsw can you fix the conflict, thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10039) Adding IOPS/GB offering

2018-11-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703657#comment-16703657
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10039:
-

bwsw commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-442953563
 
 
   @syed Hi, do you continue to manage this PR? I think it's very beneficial 
for 4.12.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding IOPS/GB offering
> ---
>
> Key: CLOUDSTACK-10039
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10039
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Syed Ahmed
>Priority: Major
> Fix For: Future
>
>
> We want to add a disk offering where we can specify the Min/Max IOPS as a 
> function of size. The idea is the larger volume you create, the greater your 
> IOPS will be (this is similar to the way GCE handles IOPS). We also have 
> added limits to the IOPS (min and max) so that once the volume goes beyond a 
> certain size, the IOPS won't change and are capped to the given values.
> The following parameters are added to the `createDiskOffering` API:
> 1. `miniopspergb' : Minimum IOPS/GB for the offering
> 2. `maxiopspergb`: Maximum IOPS/GB for the offering
> 3. `highestminiops`: The highest `miniops` value that is allowed for this 
> offering
> 3. `highestmaxiops`: The highest `maxiops` value that is allowed for this 
> offering



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701076#comment-16701076
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442227809
 
 
   @rhtyd @rafaelweingartner 
   Well, currently the implementation allows changing the account details only 
for admin or domain admin. Admin can set any role while domain admin can set 
only DomainAdmin, ResourceAdmin, User types. 
   I suppose that basically, it's what users need.
   
   Please, approve the basic design and then I write the tests for security 
assurance. Just don't want to spend the time if the design initially doesn't 
fit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700879#comment-16700879
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role 
for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442177935
 
 
   Trillian test result (tid-3220)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 20717 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3058-t3220-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 68 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 22.60 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 441.49 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 282.94 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 306.08 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700738#comment-16700738
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rafaelweingartner commented on issue #3058: CLOUDSTACK-3049: update dynamic 
role for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442141164
 
 
   @bwsw if you use the `authorize` field in the `@Parameter` definition for 
the new role (the role being changed/updated) I think that then you can achieve 
what @rhtyd wanted. I mean, then we would be able to allow the use of such 
parameter only for admins or root admins.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700651#comment-16700651
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on a change in pull request #3058: CLOUDSTACK-3049: update 
dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236739717
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   @rafaelweingartner ok. I'll leave as is.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700649#comment-16700649
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rafaelweingartner commented on a change in pull request #3058: CLOUDSTACK-3049: 
update dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236738293
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   good catch. I was not paying attention to this detail. Then, I would simply 
do `newAccountName != null && StringUtils.isBlank(newAccountName)`. 
   
   That is only a suggestion. You can leave the code as is if you think it is 
better this way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700640#comment-16700640
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on a change in pull request #3058: CLOUDSTACK-3049: update 
dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236736404
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   @rafaelweingartner But how it will behave if `newAccountName` is null which 
is normal if API is not intending to change that. It is a normal case and whole 
code block must be skipped.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700586#comment-16700586
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rafaelweingartner commented on a change in pull request #3058: CLOUDSTACK-3049: 
update dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236713067
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   What I am saying is the following:
   
   Instead of (the current code):
   ```
if(newAccountName != null) {
   
   if (newAccountName.isEmpty()) {
   throw new InvalidParameterValueException("The new account 
name for account '" + account.getUuid() + "' " +
   "within domain '" + domainId + "'  is empty string. 
Account will be not renamed.");
   }
   
   // check if the new proposed account name is absent in the domain
   Account existingAccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
   if (existingAccount != null && existingAccount.getId() != 
account.getId()) {
   throw new InvalidParameterValueException("The account with 
the proposed name '" +
   newAccountName + "' exists in the domain '" +
   domainId + "' with existing account id '" + 
existingAccount.getId() + "'");
   }
   
   acctForUpdate.setAccountName(newAccountName);
   }
   ```
   
   You can do the following:
   
   ```
if(StringUtils.isBlank(newAccountName)) {
throw new InvalidParameterValueException("The new account name for 
account '" + account.getUuid() + "' " +
   "within domain '" + domainId + "'  is an empty 
string. Account will be not renamed.");
   
 }
   
// check if the new proposed account name is absent in the domain
Account existingAccount = _accountDao.findActiveAccount(newAccountName, 
domainId);
if (existingAccount != null && existingAccount.getId() != 
account.getId()) {
throw new InvalidParameterValueException("The account with the 
proposed name '" +
newAccountName + "' exists in the domain '" +
domainId + "' with existing account id '" + 
existingAccount.getId() + "'");
}
   
 acctForUpdate.setAccountName(newAccountName);
   
   ```
   
   By doing that you remove one nesting level.
   
   Did you understand what I am saying now?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   

[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700575#comment-16700575
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442096532
 
 
   > It's end of my day, let me get back to you soon. In short, my hesitation 
stems from the fact that the operation in question has some security and 
privileges implications. As a general rule such an update param/operation must 
be privileged and checked. It's better to have this as separate api. Take 
example of other apis which change ownership, transfer relationships etc all 
cases which could too be solved by an update api as well.
   
   @rhtyd Well, if we decide that only global admin (not domain admin) can 
change that, then you are right, it's better to implement as a separate API 
call.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700561#comment-16700561
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rhtyd commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442094002
 
 
   Another note that there is a translation implication of accounttype that 
maybe implemented as well. Due to backward compatibility, we support both 
account type and roleid for the create api for example. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700558#comment-16700558
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rhtyd commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442093555
 
 
   It's end of my day, let me get back to you soon. In short, my hesitation 
stems from the fact that the operation in question has some security and 
privileges implications. As a general rule such an update param/operation must 
be privileged and checked. It's better to have this as separate api. Take 
example of other apis which change ownership, transfer relationships etc all 
cases which could too be solved by an update api as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700549#comment-16700549
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442091377
 
 
   > Can you instead implement a cleaner approach, say create a new API?
   
   @rhtyd I considered both alternatives. My arguments for the current 
implementation:
   1. it adds smoke tests for updateAccount and as you can see before the 
implementation there wasn't testing for the method at all.
   2. updateAccount method was strangely implemented, e.g. one has to pass 
newname mandatory, this enhancement fixes the behavior as well.
   3. It's natural, I agree with Rafael, otherwise, it's true to implement 
every `update` separately and it will be hell without 
scoping.
   
   What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700547#comment-16700547
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw commented on a change in pull request #3058: CLOUDSTACK-3049: update 
dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236702016
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   @rafaelweingartner 
   Hm, I don't think so or don't get the idea. I would like to distinguish 
three situations:
   1. newAccountName is not specified
   2. newAccountName is specified but empty string -> exception 1
   3. newAccountName is specified and not empty string -> action or exception
   
   So, don't get how `StringUtils.isEmpty()` helps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700373#comment-16700373
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role 
for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442047169
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700368#comment-16700368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role 
for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442046003
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2464


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700332#comment-16700332
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


blueorangutan commented on issue #3058: CLOUDSTACK-3049: update dynamic role 
for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442039217
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700330#comment-16700330
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


borisstoyanov commented on issue #3058: CLOUDSTACK-3049: update dynamic role 
for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442038949
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700290#comment-16700290
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher closed pull request #2595: CLOUDSTACK-10199: Support requesting 
a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 
b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
index e4fbf322b6f..667c2b9b19c 100644
--- 
a/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++ 
b/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -231,27 +231,27 @@
 @Inject
 EntityManager _entityMgr;
 @Inject
-DataCenterDao _dcDao = null;
+DataCenterDao _dcDao;
 @Inject
-VlanDao _vlanDao = null;
+VlanDao _vlanDao;
 @Inject
-IPAddressDao _ipAddressDao = null;
+IPAddressDao _ipAddressDao;
 @Inject
-AccountDao _accountDao = null;
+AccountDao _accountDao;
 @Inject
 ConfigurationDao _configDao;
 @Inject
-UserVmDao _userVmDao = null;
+UserVmDao _userVmDao;
 @Inject
 AlertManager _alertMgr;
 @Inject
 ConfigurationManager _configMgr;
 @Inject
-NetworkOfferingDao _networkOfferingDao = null;
+NetworkOfferingDao _networkOfferingDao;
 @Inject
-NetworkDao _networksDao = null;
+NetworkDao _networksDao;
 @Inject
-NicDao _nicDao = null;
+NicDao _nicDao;
 @Inject
 RulesManager _rulesMgr;
 @Inject
@@ -860,6 +860,11 @@ public void saveExtraDhcpOptions(final String networkUuid, 
final Long nicId, fin
 
 NicVO vo = new NicVO(guru.getName(), vm.getId(), network.getId(), 
vm.getType());
 
+DataCenterVO dcVo = _dcDao.findById(network.getDataCenterId());
+if (dcVo.getNetworkType() == NetworkType.Basic) {
+configureNicProfileBasedOnRequestedIp(requested, profile, network);
+}
+
 deviceId = applyProfileToNic(vo, profile, deviceId);
 
 vo = _nicDao.persist(vo);
@@ -871,6 +876,85 @@ public void saveExtraDhcpOptions(final String networkUuid, 
final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4(network.getId(), 
requestedIpv4Address);
+if (vlanVo == null) {
+throw new InvalidParameterValueException(String.format("Trying to 
configure a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the 
[network id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch 

[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700266#comment-16700266
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rafaelweingartner commented on a change in pull request #3058: CLOUDSTACK-3049: 
update dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r236619297
 
 

 ##
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##
 @@ -1714,23 +1720,37 @@ public AccountVO updateAccount(UpdateAccountCmd cmd) {
 // Check if user performing the action is allowed to modify this 
account
 checkAccess(getCurrentCallingAccount(), 
_domainMgr.getDomain(account.getDomainId()));
 
-// check if the given account name is unique in this domain for 
updating
-Account duplicateAcccount = 
_accountDao.findActiveAccount(newAccountName, domainId);
-if (duplicateAcccount != null && duplicateAcccount.getId() != 
account.getId()) {
-throw new InvalidParameterValueException(
-"There already exists an account with the name:" + 
newAccountName + " in the domain:" + domainId + " with existing account id:" + 
duplicateAcccount.getId());
+if(newAccountName != null) {
 
 Review comment:
   You can use `StringUtils.isEmpty` here. Then, you do not need all of these 
netsting


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1675#comment-1675
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


rhtyd commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an 
account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-441951638
 
 
   Can you instead implement a cleaner approach, say create a new API?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3049) marvin-nose plugin causes other nose plugins to fail when not enabled

2018-11-26 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699671#comment-16699671
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3049:


bwsw opened a new pull request #3058: CLOUDSTACK-3049: update dynamic role for 
an account
URL: https://github.com/apache/cloudstack/pull/3058
 
 
   ## Description
   
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> marvin-nose plugin causes other nose plugins to fail when not enabled
> -
>
> Key: CLOUDSTACK-3049
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3049
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Test Tools
>Affects Versions: 4.1.0, 4.2.0
>Reporter: Prasanna Santhanam
>Assignee: Prasanna Santhanam
>Priority: Major
> Fix For: 4.2.0
>
>
> enabled by default. Running regular nosetests with plugins other than marvin
> will fail because of this. Failure manifests itself as nose looking for the
> config file when using the marivn-nose plugin
> ~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
> test.py
> Traceback (most recent call last):
>   File "/usr/local/bin/nosetests", line 8, in 
> load_entry_point('nose==1.3.0', 'console_scripts', 'nosetests')()
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 118, in __init__
> **extra_args)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/main.py",
>  line 94, in __init__
> self.parseArgs(argv)
>   File "/Library/Python/2.7/site-packages/nose/core.py", line 135, in 
> parseArgs
> self.config.configure(argv, doc=self.usage())
>   File "/Library/Python/2.7/site-packages/nose/config.py", line 344, in 
> configure
> self.plugins.configure(options, self)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 284, 
> in configure
> cfg(options, config)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 99, 
> in __call__
> return self.call(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/nose/plugins/manager.py", line 167, 
> in simple
> result = meth(*arg, **kw)
>   File "/Library/Python/2.7/site-packages/marvin/marvinPlugin.py", line 61, 
> in configure
> deploy = deployDataCenter.deployDataCenters(options.config) 
>   File "/Library/Python/2.7/site-packages/marvin/deployDataCenter.py", line 
> 32, in __init__
> raise IOError("config file %s not found. please specify a valid config 
> file"%cfgFile)
> IOError: config file ./datacenter.cfg not found. please specify a valid 
> config file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9975) Allow customizing system VM templates for SSVM and Console Proxy

2018-11-22 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696253#comment-16696253
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9975:


DennisKonrad commented on issue #2275: CLOUDSTACK-9975: Allow customizing 
system VM templates for SSVM and Console Proxy
URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-441116407
 
 
   Hi @GabrielBrascher, @rhtyd,
   
   what's the status of this? The feature looks interesting. Would be nice to 
specify different templates.
   
   Also I have the feeling you both misunderstood each other. Rhtyd talked 
about changing the SystemVM-template which leaves CS no other option as to 
deploy the new template when a systemvm needs to be deployed.
   
   Gabriel talked about the possibility to specify another template to use as 
CP or SSVM i think. I think that are two different things.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow customizing system VM templates for SSVM and Console Proxy
> 
>
> Key: CLOUDSTACK-9975
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9975
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Gabriel Beims Bräscher
>Assignee: Gabriel Beims Bräscher
>Priority: Minor
>
> Currently, it is only possible to change the template used by virtual 
> routers, but other system VMs do not have the same feature. The virtual 
> router template is configured according to the respective global settings 
> parameters: router.template.hyperv, router.template.kvm, router.template.lxc, 
> router.template.xenserver, router.template.ovm, router.template.vmware.
> This ticket proposes the configuration of templates for storage system VMs 
> (SSVMs) and console proxy system VMs with parameters similar with the virtual 
> router template configuration: ssvm.template. and 
> consoleproxy.template.
> If a parameter is null then it keeps the current flow for that scenario 
> (systemvm/virtualization tool).
> This proposal allows users to customize virtual machines templates according 
> to specific needs of each system VM. This feature was useful in a practical 
> scenario where it was necessary to perform some changes for the console proxy 
> system VM template.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695337#comment-16695337
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440838806
 
 
   Trillian test result (tid-3198)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33596 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2595-t3198-vmware-65.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 67 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 79.01 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 574.32 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695258#comment-16695258
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440807668
 
 
   Trillian test result (tid-3196)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26835 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2595-t3196-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 56.55 | 
test_multipleips_per_nic.py
   test_01_scale_vm | `Error` | 13.28 | test_scale_vm.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 507.14 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695222#comment-16695222
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440795355
 
 
   Trillian test result (tid-3197)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23626 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2595-t3197-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 67 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_nic_secondaryip_add_remove | `Error` | 31.76 | 
test_multipleips_per_nic.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 499.95 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694690#comment-16694690
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440657824
 
 
   @nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-21 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694689#comment-16694689
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

nvazquez commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440657716
 
 
   Sure @GabrielBrascher 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-20 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693208#comment-16693208
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on issue #2595: CLOUDSTACK-10199: Support requesting 
a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-440267976
 
 
   @DaanHoogland @nvazquez @rhtyd @borisstoyanov All ok after packaging 
:1st_place_medal: 
   Can you please run Integration test on this one? Thanks in advance :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689624#comment-16689624
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two 
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r234264619
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @DaanHoogland +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687658#comment-16687658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


DaanHoogland commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r233754704
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   I agree with @rafaelweingartner , @GabrielBrascher , but it would be a 
separate issue. I am not sure of the consequences so I would leave it out of 
scope for this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685498#comment-16685498
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


GabrielBrascher commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r233144436
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @bwsw I think that the proposal from @rafaelweingartner  of inverting the 
logic is valid and gives us flexibility. I do not see any potential issue that 
such change would bring to us.
   +1 on following that path.
   
   Do you guys share the same thoughts @rhtyd @PaulAngus @DaanHoogland @wido 
@nvazquez?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684578#comment-16684578
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd closed pull request #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 000..6ca3ad4aa23
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+cloudstack/tools/docker/Dockerfile
+.dockerignore
+.idea
+.git
+venv
diff --git a/.gitignore b/.gitignore
index 1a73724c117..2f5c5167e2d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -99,3 +99,4 @@ plugins/hypervisors/kvm/.pydevproject
 scripts/.pydevproject
 *.qcow2
 *.raw
+venv
diff --git a/.travis.yml b/.travis.yml
index d5fd173d71e..43f2bb29035 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -78,6 +78,7 @@ env:
  smoke/test_pvlan
  smoke/test_regions
  smoke/test_reset_vm_on_reboot
+ smoke/test_resource_accounting
  smoke/test_resource_detail
  smoke/test_router_dhcphosts
  smoke/test_router_dns
diff --git 
a/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java 
b/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
index 9cc8913f8fa..1de2b65aed1 100644
--- a/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
+++ b/engine/schema/src/com/cloud/configuration/dao/ResourceCountDaoImpl.java
@@ -258,7 +258,7 @@ public long removeEntriesByOwner(long ownerId, 
ResourceOwnerType ownerType) {
 + "ELSE CONVERT(vmd.value, UNSIGNED INTEGER) "
 + "END)) as total "
 + " from vm_instance vm "
-+ " join service_offering_view so on so.id = 
vm.service_offering_id "
++ " join service_offering so on so.id = vm.service_offering_id "
 + " left join user_vm_details vmd on vmd.vm_id = vm.id and 
vmd.name = '%s' "
 + " where vm.type = 'User' and state not in ('Destroyed', 'Error', 
'Expunging') and display_vm = true and account_id = ? ";
 
diff --git a/test/integration/component/test_browse_templates.py 
b/test/integration/component/test_browse_templates.py
index 80e9a135b80..4340092b9a0 100644
--- a/test/integration/component/test_browse_templates.py
+++ b/test/integration/component/test_browse_templates.py
@@ -230,7 +230,7 @@ def gettemplatelimts(self):
 
 return(totaltemplates)
 
-def getstoragelimts(self,rtype):
+def getstoragelimits(self, rtype):
 
 cmd=updateResourceCount.updateResourceCountCmd()
 cmd.account=self.account.name
@@ -1652,7 +1652,7 @@ def 
test_07_Browser_Upload_template_secondary_storage_resource_limits(self):
 
 self.debug("= Test 22 Upload template and 
verify secondary storage limits")
 
-initialsecondarystoragelimit=self.getstoragelimts(11)
+initialsecondarystoragelimit=self.getstoragelimits(11)
 browseup_template1=self.browse_upload_template()
 
 tmpldetails=Template.list(
@@ -1662,7 +1662,7 @@ def 
test_07_Browser_Upload_template_secondary_storage_resource_limits(self):
  zoneid=self.zone.id)
 
 
-afteruploadsecondarystoragelimit=self.getstoragelimts(11)
+afteruploadsecondarystoragelimit=self.getstoragelimits(11)
 
 if 
afteruploadsecondarystoragelimit!=(initialsecondarystoragelimit+tmpldetails[0].size):
 self.fail("Secondary Storage Resouce Count is not updated")
@@ -1709,10 +1709,10 @@ def 
test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti
  templatefilter="all",

[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684472#comment-16684472
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-438065912
 
 
   Trillian test result (tid-3169)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22024 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3012-t3169-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 68 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684402#comment-16684402
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-438042898
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2435


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684379#comment-16684379
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-438034529
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2434


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684352#comment-16684352
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-438025318
 
 
   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684351#comment-16684351
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on issue #2595: CLOUDSTACK-10199: Support requesting 
a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-438025170
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684232#comment-16684232
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437988247
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2433


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684210#comment-16684210
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on a change in pull request #2595: CLOUDSTACK-10199: 
Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r232763110
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -871,6 +876,85 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4(network.getId(), 
requestedIpv4Address);
+if (vlanVo == null) {
+throw new InvalidParameterValueException(String.format("Trying to 
configure a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the 
[network id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch (InsufficientAddressCapacityException e) {
+throw new CloudRuntimeException(String.format("Cannot get next 
available mac address in [network id='%s']", network.getId()), e);
+}
+}
+}
+
+/**
+ *  Acquires lock in "user_ip_address" and checks if the requested IPv4 
address is Free.
+ */
+protected void acquireLockAndCheckIfIpv4IsFree(Network network, String 
requestedIpv4Address) {
+IPAddressVO ipVO = 
_ipAddressDao.findByIpAndSourceNetworkId(network.getId(), requestedIpv4Address);
+if (ipVO == null) {
+throw new InvalidParameterValueException(
+String.format("Cannot find IPAddressVO for guest [IPv4 
address='%s'] and [network id='%s']", requestedIpv4Address, network.getId()));
+}
+try {
+IPAddressVO lockedIpVO = 
_ipAddressDao.acquireInLockTable(ipVO.getId());
+validateLockedRequestedIp(ipVO, lockedIpVO);
+lockedIpVO.setState(IPAddressVO.State.Allocated);
+_ipAddressDao.update(lockedIpVO.getId(), lockedIpVO);
+} finally {
+_ipAddressDao.releaseFromLockTable(ipVO.getId());
 
 Review comment:
   The _finally_ block will release the lock in case of success or an exception.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view 

[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684199#comment-16684199
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437978942
 
 
   @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684198#comment-16684198
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on issue #2595: CLOUDSTACK-10199: Support requesting 
a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437978676
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684211#comment-16684211
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on a change in pull request #2595: CLOUDSTACK-10199: 
Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r232763147
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -871,6 +876,85 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4(network.getId(), 
requestedIpv4Address);
+if (vlanVo == null) {
+throw new InvalidParameterValueException(String.format("Trying to 
configure a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the 
[network id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new InvalidParameterValueException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch (InsufficientAddressCapacityException e) {
+throw new CloudRuntimeException(String.format("Cannot get next 
available mac address in [network id='%s']", network.getId()), e);
+}
+}
+}
+
+/**
+ *  Acquires lock in "user_ip_address" and checks if the requested IPv4 
address is Free.
+ */
+protected void acquireLockAndCheckIfIpv4IsFree(Network network, String 
requestedIpv4Address) {
+IPAddressVO ipVO = 
_ipAddressDao.findByIpAndSourceNetworkId(network.getId(), requestedIpv4Address);
+if (ipVO == null) {
+throw new InvalidParameterValueException(
+String.format("Cannot find IPAddressVO for guest [IPv4 
address='%s'] and [network id='%s']", requestedIpv4Address, network.getId()));
+}
+try {
+IPAddressVO lockedIpVO = 
_ipAddressDao.acquireInLockTable(ipVO.getId());
+validateLockedRequestedIp(ipVO, lockedIpVO);
+lockedIpVO.setState(IPAddressVO.State.Allocated);
+_ipAddressDao.update(lockedIpVO.getId(), lockedIpVO);
+} finally {
+_ipAddressDao.releaseFromLockTable(ipVO.getId());
+}
+}
+
+/**
+ * Validates the locked IP, throwing an exeption if the locked IP is null 
or the locked IP is not in 'Free' state.
+ */
+protected void validateLockedRequestedIp(IPAddressVO ipVO, IPAddressVO 
lockedIpVO) {
 
 Review comment:
   Created validateLockedRequestedIp to extract some verifications,  
documenting it and creating test cases. The logic stills the same. as the 
caller (method acquireLockAndCheckIfIpv4IsFree) does have a `finally` block 
that releases the lock, it is ok to throw the exceptions in this validation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please 

[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684070#comment-16684070
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437950580
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684068#comment-16684068
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437950448
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684072#comment-16684072
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd removed a comment on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437950448
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684069#comment-16684069
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437950560
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684064#comment-16684064
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437949714
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2431


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684021#comment-16684021
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437939645
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684018#comment-16684018
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437939315
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683882#comment-16683882
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw edited a comment on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437902787
 
 
   @borisstoyanov I don't care, just wanted SOs to vary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683878#comment-16683878
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation CPU, 
RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437904492
 
 
   @borisstoyanov Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683873#comment-16683873
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw edited a comment on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437902787
 
 
   @borisstoyanov I don't care, just wanted SO vary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683872#comment-16683872
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


borisstoyanov commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437903405
 
 
   @bwsw yes, you're right, issue is that blueorangutan's environment has hosts 
with 3 cores and we're requesting 4. Perhaps you could just change the offering 
to request 3? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683861#comment-16683861
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation CPU, 
RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437902499
 
 
   ```
   2018-11-12 10:24:59,254 INFO  [o.a.c.a.c.a.v.DeployVMCmdByAdmin] 
(API-Job-Executor-39:ctx-cda190fb job-1365 ctx-88aeda9f) (logid:7faecac3) 
Unable to create a deployment
for VM[User|i-127-159-VM]
   com.cloud.exception.InsufficientServerCapacityException: Unable to create a 
deployment for VM[User|i-127-159-VM]Scope=interface com.cloud.dc.DataCenter; 
id=1
   at 
org.apache.cloudstack.engine.cloud.entity.api.VMEntityManagerImpl.reserveVirtualMachine(VMEntityManagerImpl.java:215)
   at 
org.apache.cloudstack.engine.cloud.entity.api.VirtualMachineEntityImpl.reserve(VirtualMachineEntityImpl.java:200)
   at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:4492)
   at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:4057)
   at 
com.cloud.vm.UserVmManagerImpl.startVirtualMachine(UserVmManagerImpl.java:4044)
   at sun.reflect.GeneratedMethodAccessor535.invoke(Unknown Source)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
   at 
com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
   at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
   at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212)
   at com.sun.proxy.$Proxy164.startVirtualMachine(Unknown Source)
   at 
org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin.execute(DeployVMCmdByAdmin.java:50)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
   at 
com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:581)
   at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
   at 
org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:529)
   at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   at java.lang.Thread.run(Thread.java:748)
   2018-11-12 10:24:59,255 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(API-Job-Executor-39:ctx-cda190fb job-1365) (logid:7faecac3) Complete async 
job-1365, jobStatus: FAILED, resultCode: 530, result: 
org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":533,"errortext":"Unable
 to create a deployment for VM[User|i-127-159-VM]"}
   ```
   Doesn't looks like connected with the test itself, rather an env problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the 

[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683863#comment-16683863
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation CPU, 
RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437902787
 
 
   @borisstoyanov I don't care, just wanted to have the SO different.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683834#comment-16683834
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437895320
 
 
   Trillian test result (tid-3164)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23884 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3012-t3164-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 67 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_so_removal_resource_update | `Error` | 26.67 | 
test_resource_accounting.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683813#comment-16683813
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


borisstoyanov commented on a change in pull request #3012: CLOUDSTACK-3009: 
Fixed resource calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#discussion_r232662467
 
 

 ##
 File path: test/integration/smoke/test_resource_accounting.py
 ##
 @@ -0,0 +1,243 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from nose.plugins.attrib import attr
+
+# Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.base import (Domain,
+ Account,
+ ServiceOffering,
+ VirtualMachine, updateResourceCount)
+from marvin.lib.common import (get_zone,
+   get_test_template)
+from marvin.lib.utils import (cleanup_resources)
+
+
+class Services:
+"""Test Account Services
+"""
+
+def __init__(self):
+self.services = {
+"domain": {
+"name": "Domain",
+},
+"account": {
+"email": "t...@test.com",
+"firstname": "Test",
+"lastname": "User",
+"username": "test",
+# Random characters are appended for unique
+# username
+"password": "fr3sca",
+},
+"user": {
+"email": "u...@test.com",
+"firstname": "User",
+"lastname": "User",
+"username": "User",
+# Random characters are appended for unique
+# username
+"password": "fr3sca",
+},
+"service_offering_it_1": {
+"name": "InstanceType-1",
+"displaytext": "Tiny Instance",
+"cpunumber": 1,
+"cpuspeed": 100,
+"memory": 128,
+},
+"service_offering_it_2": {
+"name": "InstanceType-2",
+"displaytext": "Tiny Instance",
+"cpunumber": 4,
+"cpuspeed": 100,
+"memory": 512,
+},
+"virtual_machine_1": {
+"displayname": "Test VM1",
+"username": "root",
+"password": "password",
+"ssh_port": 22,
+"hypervisor": 'XenServer',
+"privateport": 22,
+"publicport": 22,
+"protocol": 'TCP',
+},
+"virtual_machine_2": {
+"displayname": "Test VM2",
+"username": "root",
+"password": "password",
+"ssh_port": 22,
+"hypervisor": 'XenServer',
+"privateport": 22,
+"publicport": 22,
+"protocol": 'TCP',
+},
+"template": {
+"displaytext": "Public Template",
+"name": "Public template",
+"ostype": 'CentOS 5.6 (64-bit)',
+"url": "",
+"hypervisor": '',
+"format": '',
+"isfeatured": True,
+"ispublic": True,
+"isextractable": True,
+"templatefilter": "self"
+},
+"natrule": {
+"publicport": 22,
+"privateport": 22,
+"protocol": 'TCP',
+},
+"ostype": 'CentOS 5.6 (64-bit)',
+"sleep": 60,
+"timeout": 10,
+}
+
+
+class TestRAMCPUResourceAccounting(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(
+TestRAMCPUResourceAccounting,
+cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+
+cls.services = Services().services
+cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+

[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683796#comment-16683796
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437880805
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2430


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683773#comment-16683773
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437871512
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683771#comment-16683771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

DaanHoogland commented on issue #2595: CLOUDSTACK-10199: Support requesting a 
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-437871199
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
>  Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address 
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null
> {
>   "cserrorcode": 4250,
>   "errorcode": 530,
>   "errortext": "Does not support custom ip allocation at this time: 
> NicProfile[0-0-null-null-null",
>   "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the 
> Instance will get.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683645#comment-16683645
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10199:
-

GabrielBrascher commented on a change in pull request #2595: CLOUDSTACK-10199: 
Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r232626456
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -883,6 +885,73 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP. 
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+s_logger.debug(String.format("The requested [IPv4 address=%s] is 
null", requestedIpv4Address));
+return;
+}
+if 
(org.apache.commons.lang3.StringUtils.isBlank(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is empty or blank", requestedIpv4Address));
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkId(network.getId());
+if (vlanVo == null) {
+throw new CloudRuntimeException(String.format("Trying to configure 
a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the [network 
id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (org.apache.commons.lang3.StringUtils.isBlank(ipv4Gateway) || 
!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (org.apache.commons.lang3.StringUtils.isBlank(ipv4Netmask) || 
!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch (InsufficientAddressCapacityException e) {
+e.printStackTrace();
+}
+}
+}
+
+/**
+ *  Acquires lock of in table "user_ip_address" and checks if the 
requested IPv4 address is Free.
+ */
+protected void acquireLockAndCheckIfIpv4IsFree(Network network, String 
requestedIpv4Address) {
+IPAddressVO ipVO = 
_ipAddressDao.findByIpAndSourceNetworkId(network.getId(), requestedIpv4Address);
+if (ipVO == null) {
+throw new CloudRuntimeException(String.format("Cannot find 
IPAddressVO for guest [IPv4 address='%s'] and [network id=%s]", 
requestedIpv4Address, network.getId()));
+}
+IPAddressVO lockedIpVO = 
_ipAddressDao.acquireInLockTable(ipVO.getId());
 
 Review comment:
   @marcaurele are you LGTM on this one?
   Thanks for your reviews and hard work :+1: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support requesting a specific IPv4 address in Basic Networking during 
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>   

[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683432#comment-16683432
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437804208
 
 
   Nevermind, I needed to run test quickly - have implemented minor fixes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683312#comment-16683312
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437778142
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683311#comment-16683311
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-43904
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683296#comment-16683296
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437774766
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2425


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683295#comment-16683295
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-437774568
 
 
   Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2424


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683263#comment-16683263
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437768688
 
 
   Moved to 4.11.2.0 as it sounds like a critical business issue if resource 
counts are wrong.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683255#comment-16683255
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


blueorangutan commented on issue #3012: CLOUDSTACK-3009: Fixed resource 
calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437767408
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683254#comment-16683254
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation 
CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437767351
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683252#comment-16683252
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


blueorangutan commented on issue #3000: CLOUDSTACK-2998: Added two more device 
name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-437767233
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683253#comment-16683253
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


rhtyd commented on a change in pull request #3012: CLOUDSTACK-3009: Fixed 
resource calculation CPU, RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#discussion_r232542802
 
 

 ##
 File path: test/integration/smoke/test_resource_accounting.py
 ##
 @@ -0,0 +1,252 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   Can you add this to .travis.yml as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683251#comment-16683251
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rhtyd commented on issue #3000: CLOUDSTACK-2998: Added two more device name 
patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#issuecomment-437767167
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-3009) [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), domR may not be ready yet. failure due to Exception: java.lang.Exception—when VPC/VPC

2018-11-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682507#comment-16682507
 ] 

ASF GitHub Bot commented on CLOUDSTACK-3009:


bwsw commented on issue #3012: CLOUDSTACK-3009: Fixed resource calculation CPU, 
RAM for accounts.
URL: https://github.com/apache/cloudstack/pull/3012#issuecomment-437598240
 
 
   @rafaelweingartner please review again,
   @borisstoyanov please review smoke test implemented.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VPC][VMware]Unable to execute NetworkUsage command on DomR (10.147.40.181), 
> domR may not be ready yet. failure due to Exception: java.lang.Exception—when 
> VPC/VPC VR is rebooted
> -
>
> Key: CLOUDSTACK-3009
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3009
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.2.0
>Reporter: manasaveloori
>Assignee: Kishan Kavala
>Priority: Critical
> Fix For: 4.2.0
>
> Attachments: management-server.zip
>
>
> Steps:
> 1.Have a CS with advanced zone and with VMware host.
> 2.Create VPC .
> 3.Create a private gateway and a static route to it.
> 4.Reboot  the VPC VR.
> 5.After successful reboot of VR, now restart the VPC.
>OR
> After step 3 Restart the VPC and after successful restart, now reboot VR.
> Observation:
> Observed the following exception when VPC is restarted/VR is rebooted.
> 2013-06-14 20:11:28,390 ERROR [vmware.resource.VmwareResource] 
> (DirectAgent-142:10.147.40.29) Unable to execute NetworkUsage command on DomR 
> (10.147.40.184), domR may not be ready yet. failure due to Exception: 
> java.lang.Exception
> Message:  vpc network usage get returns empty
> java.lang.Exception:  vpc network usage get returns empty
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.VPCNetworkUsage(VmwareResource.java:676)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:622)
> at 
> com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:472)
> at 
> com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:186)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
> at java.util.concurrent.FutureTask.run(FutureTask.java:166)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:679)
> 2013-06-14 20:11:28,400 DEBUG [agent.manager.DirectAgentAttache] 
> (DirectAgent-142:null) Seq 1-519307624: Response Received:
> Attaching the MS log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678543#comment-16678543
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two 
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231604385
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @rafaelweingartner what I personally like is that people will no longer be 
limited by using "bond" or "team" names for physical interfaces, but can use 
other semantic names, that they like, the same is for single NICs like 
"public", "private" instead of eth0, eth1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678539#comment-16678539
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two 
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231603522
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @rafaelweingartner they can, but not sure that they can with CloudStack. 
Actually, your idea that only "vnet" devices must be excluded is good but just 
would like to get the opinion of other persons before changing that. In theory, 
it can break someone's deployment even if our tests work well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678533#comment-16678533
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231600102
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   Is it possible for people to configure/customize the "vnet" name of the 
interfaces? I thought that was something hard coded in KVM. That is why I 
thought doing the opposite would be easier.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678524#comment-16678524
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two 
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231597922
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @rafaelweingartner I think it's a good extension, but suppose it's a 
conceptual change which requires voting from the project team. Don't you think 
so?
   Personally, I like your approach, but people "potentially" may meet 
incompatibilities in their deployments if they have weird bridging 
configurations. 
   
   @rhtyd @PaulAngus @DaanHoogland @wido @GabrielBrascher can give your 
opinions on such a change, that @rafaelweingartner suggests?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678195#comment-16678195
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

rafaelweingartner closed pull request #17: CLOUDSTACK-10399: Added section 
regarding MySQL server-id
URL: https://github.com/apache/cloudstack-documentation/pull/17
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/installguide/management-server/_database.rst 
b/source/installguide/management-server/_database.rst
index 9ec6600..46a9f13 100644
--- a/source/installguide/management-server/_database.rst
+++ b/source/installguide/management-server/_database.rst
@@ -62,6 +62,18 @@ MySQL. See :ref:`install-database-on-separate-node`.
   max_connections=350
   log-bin=mysql-bin
   binlog-format = 'ROW'
+  
+   .. note::
+  For Ubuntu 16.04 and later, make sure you specify a ``server-id`` in 
your ``.cnf`` file for binary logging. Set the ``server-id`` according 
to your database setup.
+
+   .. parsed-literal::
+   
+  server-id=master-01
+  innodb_rollback_on_timeout=1
+  innodb_lock_wait_timeout=600
+  max_connections=350
+  log-bin=mysql-bin
+  binlog-format = 'ROW'
 
.. note:: 
   You can also create a file ``/etc/mysql/conf.d/cloudstack.cnf`` 
diff --git a/source/quickinstallationguide/qig.rst 
b/source/quickinstallationguide/qig.rst
index a45962b..ac853b6 100644
--- a/source/quickinstallationguide/qig.rst
+++ b/source/quickinstallationguide/qig.rst
@@ -369,7 +369,19 @@ section:
innodb_lock_wait_timeout=600
max_connections=350
log-bin=mysql-bin
-   binlog-format = 'ROW' 
+   binlog-format = 'ROW'
+
+.. note::
+For Ubuntu 16.04 and later, make sure you specify a ``server-id`` in your 
``.cnf`` file for binary logging. Set the ``server-id`` according to your 
database setup.
+
+::
+
+   server-id=master-01
+   innodb_rollback_on_timeout=1
+   innodb_lock_wait_timeout=600
+   max_connections=350
+   log-bin=mysql-bin
+   binlog-format = 'ROW'
 
 Now that MySQL is properly configured we can start it and configure it to 
 start on boot as follows:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678143#comment-16678143
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231482349
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @bwsw, what if we invert the logic?
   
   Let me explain myself. We already have 13! (that is too much; it is indeed a 
nice magic number though) patterns to tell which ones are the valid physical 
interfaces names that we should look for. However, we can do the opposite. So, 
we can say that the physical interface is anything that is not “^vnet*”. Then, 
if I decide to use a physical interface named “XYZ”, I will not need to change 
anything else in the code.
   
   What do you think?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-2998) UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, AltGR+Keypad and AltGR+ Numerics

2018-11-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678135#comment-16678135
 ] 

ASF GitHub Bot commented on CLOUDSTACK-2998:


rafaelweingartner commented on a change in pull request #3000: CLOUDSTACK-2998: 
Added two more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r231482349
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String 
bridgeName) {
 return "";
 }
 
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
 
 Review comment:
   @bwsw, what if we invert the logic?
   
   Let me explain myself. We already have 13! (that is too much, but it is 
indeed a nice magic number) patterns to tell which ones are the valid physical 
interfaces names that we should look for. However, we can do the opposite. So, 
we can say that the physical interface is anything that is not “^vnet*”. Then, 
if I decide to use a physical interface named “XYZ”, I will not need to change 
anything else in the code.
   
   What do you think?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> UK: Exploring Testing - unexpected output occurred on Ctrl+Keypad, 
> AltGR+Keypad and AltGR+ Numerics 
> 
>
> Key: CLOUDSTACK-2998
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-2998
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VNC Proxy
>Affects Versions: 4.2.0
> Environment: Build No.#396 
> (CloudStack-non-OSS-MASTER-396-rhel6.3.tar.gz)
> XenServer6.1 for Host Server, CentOS6.3 for NFS server and CloudStack-Mgr 
> Server, Win7-x86 for Client machine. 
>Reporter: Minying Bao
>Priority: Major
> Fix For: 4.2.0
>
> Attachments: Build#4.2-241-Exploring Testing_UK Keyboard_issues.xlsx, 
> Exploring Testing_UK Keyboard_issues.xlsx
>
>
> Steps
> 1. Setup the CloudStack environments with build 4.2#396.
> 2. Bring UK Win-7 x86 VMs.
> 3. Access the VM via Console Proxy from the UK client machines, choose the 
> "UK Keyboard" for Keyboard Option.
> 4. Make a exploring testing of all the keys with UK keyboard. Just like 
> Ctrl+Keypad keys, AltGR+Keypad keys or AltGR+ Numeric keys like 1,2,3...
> Expected Result
> All the combination should not return any values.
> Actual Result
> Unexpected output or unexpected operation occurred on some Ctrl+Keypad keys, 
> AltGR+Keypad keys and AltGR+ Numerics.
> Please refer to the details as attached Excel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-11-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672047#comment-16672047
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

falcon78921 commented on issue #17: CLOUDSTACK-10399: Added section regarding 
MySQL server-id
URL: 
https://github.com/apache/cloudstack-documentation/pull/17#issuecomment-435152140
 
 
   @rafaelweingartner Thanks Rafael! :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10399) Specify MySQL server-id for later versions of CloudStack

2018-11-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672007#comment-16672007
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10399:
-

falcon78921 opened a new pull request #17: CLOUDSTACK-10399: Added section 
regarding MySQL server-id
URL: https://github.com/apache/cloudstack-documentation/pull/17
 
 
   Fixes CLOUDSTACK-10399: Specify MySQL server-id for later versions of 
CloudStack
   
   Signed-off-by: James McClune 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Specify MySQL server-id for later versions of CloudStack
> 
>
> Key: CLOUDSTACK-10399
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10399
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Doc
>Affects Versions: 4.11.1.0
> Environment: Ubuntu 16.04 LTS
>Reporter: James McClune
>Priority: Minor
>  Labels: doc
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> I created a PR for this issue on the old CloudStack documentation:
> [https://github.com/apache/cloudstack-docs-install/pull/38]
> When looking at the new documentation, I don't think this PR was migrated 
> over.
> Using Ubuntu 16.04 and MySQL 5.7.22, I found specifying a {{server-id}} is 
> critical for running the MySQL process with binary logging. I updated the 
> documentation to include a section about using the \{{server-id }}directive 
> for MySQL version 5.7 and later.
> Pages affected:
> [http://docs.cloudstack.apache.org/en/4.11.1.0/quickinstallationguide/qig.html#management-server-installation]
> http://docs.cloudstack.apache.org/en/4.11.1.0/installguide/management-server/index.html#install-the-database-server
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10310) KVM hosts reboot if there is a short transient storage error

2018-10-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668638#comment-16668638
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10310:
-

somejfn commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage 
issue
URL: https://github.com/apache/cloudstack/pull/2722#issuecomment-434280872
 
 
   On problem is while NFS is unavailable,  you wont be able to destroy the
   VM libvirt will just hang.  So if you attempt to destroy the and start
   a new VM,  when the NFS service comes back online you will get the
   duplicate VM.  That's why I would rather just wait for the NFS issue to go
   away rather than fire VM-HA in that case.
   
   On Tue, Oct 30, 2018 at 5:32 AM Paul Angus  wrote:
   
   > IMHO i'd say if a VM on that storage is marked as ha-enabled, it should be
   > powered-off and restarted somewhere else, and if it isn't HA enabled, we
   > shouldn't do anything with the running VM (as it's for the user of the VM
   > to deal with it),
   > in either case we should probably set the host to 'alert' so then an admin
   > can see it and do something about it.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> KVM hosts reboot if there is a short transient storage error
> 
>
> Key: CLOUDSTACK-10310
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10310
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Affects Versions: 4.9.0, 4.10.0.0
>Reporter: Sean Lair
>Priority: Major
>
> If the KVM heartbeat file can't be written to, the host is rebooted, and thus 
> taking down all VMs running on it.  The code does try 5x times before the 
> reboot, but the there is not a delay between the retires, so they are 5 
> simultaneous retries, which doesn't help.  Standard SAN storage HA operations 
> or quick network blip could cause this reboot to occur.
> Some discussions on the dev mailing list revealed that some people are just 
> commenting out the reboot line in their version of the CloudStack source.
> A better option (and a new PR is being issued) would be have it sleep between 
> tries so it isn't 5x almost simultaneous tries.  Plus, instead of rebooting, 
> the cloudstack-agent could just be stopped on the host instead.  This will 
> cause alerts to be issued and if the host is disconnected long-enough, 
> depending on the HA code in use, VM HA could handle the host failure.
> The built-in reboot of the host seemed drastic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-10310) KVM hosts reboot if there is a short transient storage error

2018-10-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668636#comment-16668636
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10310:
-

somejfn commented on issue #2722: CLOUDSTACK-10310 Fix KVM reboot on storage 
issue
URL: https://github.com/apache/cloudstack/pull/2722#issuecomment-434280034
 
 
   On precision about #2 With primary storage on NFS hard mounts VMs don't
   go read-only (tested with OL5/6/7) and will resume writing to disk once NFS
   server become available again even after a 25 minutes outage
   
   On Tue, Oct 30, 2018 at 5:27 AM Paul Angus  wrote:
   
   > I'll try to summarise the scenario so that we're all trying to fix the
   > same thing...
   >
   >1. A host cannot write to one of it's primary storage pools.
   >2. The some of the VMs on that host are on that pool, so their disks
   >have gone read-only, but the VM is still running.
   >3. BUT there may be VMs on other primary storage pools that are
   >absolutely fine
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> KVM hosts reboot if there is a short transient storage error
> 
>
> Key: CLOUDSTACK-10310
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10310
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM
>Affects Versions: 4.9.0, 4.10.0.0
>Reporter: Sean Lair
>Priority: Major
>
> If the KVM heartbeat file can't be written to, the host is rebooted, and thus 
> taking down all VMs running on it.  The code does try 5x times before the 
> reboot, but the there is not a delay between the retires, so they are 5 
> simultaneous retries, which doesn't help.  Standard SAN storage HA operations 
> or quick network blip could cause this reboot to occur.
> Some discussions on the dev mailing list revealed that some people are just 
> commenting out the reboot line in their version of the CloudStack source.
> A better option (and a new PR is being issued) would be have it sleep between 
> tries so it isn't 5x almost simultaneous tries.  Plus, instead of rebooting, 
> the cloudstack-agent could just be stopped on the host instead.  This will 
> cause alerts to be issued and if the host is disconnected long-enough, 
> depending on the HA code in use, VM HA could handle the host failure.
> The built-in reboot of the host seemed drastic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   3   4   5   6   7   8   9   10   >