subject:"\[jira\] \[Commented\] \(CLOUDSTACK\-10146\) Bypass Secondary Storage for KVM templates"

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358246#comment-16358246
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit 1c26b2ec2ec5f3da88b4782c365cf898cd611193 in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=1c26b2e ]

Merge remote-tracking branch 'origin/4.11'

CLOUDSTACK-10269: On deletion of role set name to null (#2444)
CLOUDSTACK-10146 checksum in java instead of script (#2405)
CLOUDSTACK-10222: Clean snaphosts from primary storage when taking (#2398)

Signed-off-by: Rohit Yadav 


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358243#comment-16358243
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit 123c20dc57d809f89bc1b012303e71b6892c8729 in cloudstack's branch 
refs/heads/master from [~dahn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=123c20d ]

CLOUDSTACK-10146 checksum in java instead of script (#2405)

* CLOUDSTACK-10146 checksum in java instead of script

* root cause passing


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358242#comment-16358242
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit 123c20dc57d809f89bc1b012303e71b6892c8729 in cloudstack's branch 
refs/heads/master from [~dahn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=123c20d ]

CLOUDSTACK-10146 checksum in java instead of script (#2405)

* CLOUDSTACK-10146 checksum in java instead of script

* root cause passing


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-07 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355225#comment-16355225
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit 123c20dc57d809f89bc1b012303e71b6892c8729 in cloudstack's branch 
refs/heads/4.11 from [~dahn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=123c20d ]

CLOUDSTACK-10146 checksum in java instead of script (#2405)

* CLOUDSTACK-10146 checksum in java instead of script

* root cause passing


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-07 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355226#comment-16355226
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit 123c20dc57d809f89bc1b012303e71b6892c8729 in cloudstack's branch 
refs/heads/4.11 from [~dahn]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=123c20d ]

CLOUDSTACK-10146 checksum in java instead of script (#2405)

* CLOUDSTACK-10146 checksum in java instead of script

* root cause passing


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-02-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355224#comment-16355224
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland closed pull request #2405: CLOUDSTACK-10146 checksum in java 
instead of script
URL: https://github.com/apache/cloudstack/pull/2405
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
index 3b6bc9a6dd3..e120d847b17 100644
--- 
a/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
+++ 
b/agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
@@ -20,10 +20,13 @@
 
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.script.Script;
-import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.cloudstack.utils.security.DigestHelper;
 import org.apache.commons.lang.StringUtils;
 
 import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.security.NoSuchAlgorithmException;
 import java.util.UUID;
 
 public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
@@ -149,36 +152,16 @@ public DirectTemplateInformation getTemplateInformation() 
{
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath,e);
+} catch (NoSuchAlgorithmException e) {
+throw new CloudRuntimeException("Unknown checksum algorithm: " 
+ checksum, e);
+}
 }
 return true;
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-19 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331966#comment-16331966
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2405: CLOUDSTACK-10146 checksum in java 
instead of script
URL: https://github.com/apache/cloudstack/pull/2405#issuecomment-358908779
 
 
   @blueoranbutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326886#comment-16326886
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland commented on a change in pull request #2405: CLOUDSTACK-10146 
checksum in java instead of script
URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161689898
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -149,36 +154,16 @@ public DirectTemplateInformation 
getTemplateInformation() {
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath);
 
 Review comment:
   ok, I thought the error is purely the chosen algorithnm so don't include the 
root cause.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326835#comment-16326835
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2405: CLOUDSTACK-10146 
checksum in java instead of script
URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161675698
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -149,36 +154,16 @@ public DirectTemplateInformation 
getTemplateInformation() {
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath);
 
 Review comment:
   IMO if the exception is due to some system/programming problem, the stack 
should be given to give a clear hint to people where to look for the error in 
the code. If the exception is aimed at the end user (API end user), then it 
does not make sens as it is a purely parameter, state,... error. So i'll keep 
the root cause for the NoSuchAlgorithmException.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326567#comment-16326567
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland commented on a change in pull request #2405: CLOUDSTACK-10146 
checksum in java instead of script
URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161610342
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -149,36 +154,16 @@ public DirectTemplateInformation 
getTemplateInformation() {
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath);
 
 Review comment:
   come to think of it it does not make as much sense in the 
NoSuchAlgorithmException case. Doe you agree @marcaurele ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326563#comment-16326563
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland commented on a change in pull request #2405: CLOUDSTACK-10146 
checksum in java instead of script
URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161609584
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -149,36 +154,16 @@ public DirectTemplateInformation 
getTemplateInformation() {
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath);
 
 Review comment:
   yes, I agree. though people have been pushing towards not including root 
causes in exception traces i will add it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326263#comment-16326263
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

marcaurele commented on a change in pull request #2405: CLOUDSTACK-10146 
checksum in java instead of script
URL: https://github.com/apache/cloudstack/pull/2405#discussion_r161527272
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -149,36 +154,16 @@ public DirectTemplateInformation 
getTemplateInformation() {
 return new DirectTemplateInformation(installPath, size, checksum);
 }
 
-/**
- * Return checksum command from algorithm
- */
-private String getChecksumCommandFromAlgorithm(String algorithm) {
-if (algorithm.equalsIgnoreCase("MD5")) {
-return "md5sum";
-} else if (algorithm.equalsIgnoreCase("SHA-1")) {
-return "sha1sum";
-} else if (algorithm.equalsIgnoreCase("SHA-224")) {
-return "sha224sum";
-} else if (algorithm.equalsIgnoreCase("SHA-256")) {
-return "sha256sum";
-} else if (algorithm.equalsIgnoreCase("SHA-384")) {
-return "sha384sum";
-} else if (algorithm.equalsIgnoreCase("SHA-512")) {
-return "sha512sum";
-} else {
-throw new CloudRuntimeException("Unknown checksum algorithm: " + 
algorithm);
-}
-}
-
 @Override
 public boolean validateChecksum() {
 if (StringUtils.isNotBlank(checksum)) {
-ChecksumValue providedChecksum = new ChecksumValue(checksum);
-String algorithm = providedChecksum.getAlgorithm();
-String checksumCommand = "echo '%s %s' | %s -c --quiet";
-String cmd = String.format(checksumCommand, 
providedChecksum.getChecksum(), downloadedFilePath, 
getChecksumCommandFromAlgorithm(algorithm));
-int result = Script.runSimpleBashScriptForExitValue(cmd);
-return result == 0;
+try {
+return DigestHelper.check(checksum, new 
FileInputStream(downloadedFilePath));
+} catch (IOException e) {
+throw new CloudRuntimeException("could not check sum for file: 
" + downloadedFilePath);
 
 Review comment:
   missing second argument to view the actual exception message/stack trace:
   `file: " + downloadedFilePath, e)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325311#comment-16325311
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland opened a new pull request #2405: CLOUDSTACK-10146 checksum in java 
instead of script
URL: https://github.com/apache/cloudstack/pull/2405
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317855#comment-16317855
 ] 

ASF subversion and git services commented on CLOUDSTACK-10146:
--

Commit e86bb41e0e3facb250cdcb984a8f8f91bf052b2b in cloudstack's branch 
refs/heads/master from [~nicolas.vazquez]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=e86bb41 ]

CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates (#2379)

This feature allows using templates and ISOs avoiding secondary storage as 
intermediate cache on KVM. The virtual machine deployment process is enhanced 
to supported bypassed registered templates and ISOs, delegating the work of 
downloading them to primary storage to the KVM agent instead of the SSVM agent.

Template and ISO registration:
- When hypervisor is KVM, a checkbox is displayed with 'Direct Download' label.
- API methods registerTemplate and registerISO are both extended with this new 
parameter directdownload.
- On template or ISO registration, no download job is sent to SSVM agent, 
CloudStack would only persist an entry on template_store_ref indicating that 
template or ISO has been marked as 'Direct Download' (bypassing Secondary 
Storage). These entries are persisted as:
template_id = Template or ISO id on vm_template table
store_id NULL
download_state = BYPASSED
state = Ready
(Note: these entries allow users to deploy virtual machine from registered 
templates or ISOs)
- An URL validation command is sent to a random KVM host to check if 
template/ISO location can be reached. Metalink are also supported by this 
feature. In case of a metalink, it is fetched and URL check is performed on 
each of its URLs.
- Checksum should be provided as indicated on #2246: {ALGORITHM}CHKSUMHASH
- After template or ISO is registered, it would be displayed in the UI

Virtual machine deployment:
When a 'Direct Download' template is selected for deployment, CloudStack would 
delegate template downloading to destination storage pool via destination host 
by a new pluggable download manager.
Download manager would handle template downloading depending on URL protocol. 
In case of HTTP, request headers can be set by the user via 
vm_template_details. Those details should be persisted as:
Key: HTTP_HEADER
Value: HEADERNAME:HEADERVALUE

In case of HTTPS, a new API method is added 
uploadTemplateDirectDownloadCertificate to allow user importing a client 
certificate into all KVM hosts' keystore before deployment.
After template or ISO is downloaded to primary storage, usual entry would be 
persisted on template_spool_ref indicating the mapping between template/ISO and 
storage pool.

> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317851#comment-16317851
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-356195834
 
 
   Tests LGTM (template related errors not seen in last run), merging this 
based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317731#comment-16317731
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-356183984
 
 
   Trillian test result (tid-2085)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32518 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t2085-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 345.94 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 391.55 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316755#comment-16316755
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-356054223
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316754#comment-16316754
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-356054086
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316388#comment-16316388
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355978710
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1623


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316342#comment-16316342
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355971822
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316340#comment-16316340
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355971751
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316314#comment-16316314
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355918590
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316315#comment-16316315
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355924687
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1620


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316313#comment-16316313
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355918410
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316000#comment-16316000
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355924687
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1620


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315942#comment-16315942
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355918590
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-08 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315941#comment-16315941
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355918410
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315810#comment-16315810
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355899839
 
 
   SSVM tests are not related to this, let me have a quick look at the template 
ones.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315513#comment-16315513
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355861731
 
 
   Trillian test result (tid-2063)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44857 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t2063-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_list_sec_storage_vm | `Failure` | 0.13 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.14 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 99.28 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 112.30 | test_ssvm.py
   test_01_register_template_direct_download_flag | `Error` | 0.04 | 
test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 0.00 | 
test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 0.04 | test_templates.py
   test_04_extract_template | `Failure` | 132.38 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 147.53 | test_volumes.py
   test_07_resize_fail | `Failure` | 15.42 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315190#comment-16315190
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355814250
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315187#comment-16315187
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355814222
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315186#comment-16315186
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355814124
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1610


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315151#comment-16315151
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355812505
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-07 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315150#comment-16315150
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355812483
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315047#comment-16315047
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355795476
 
 
   Trillian test result (tid-2046)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38525 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t2046-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_register_template_direct_download_flag | `Error` | 0.04 | 
test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 0.00 | 
test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 0.03 | test_templates.py
   test_07_resize_fail | `Failure` | 15.38 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 285.37 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314782#comment-16314782
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355763383
 
 
   Thanks @DaanHoogland I'll check again tomorrow when the results are back, 
may tackle outstanding issues myself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314781#comment-16314781
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r160031077
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   I would prefer going the script way, perhaps re-using one of the import 
keystore/cert scripts. Alternatively, `KeyStore` could be read and manipulated 
(keys imported etc) by using Java only, agreeing with what @rafaelweingartner 
suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314732#comment-16314732
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355757784
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314729#comment-16314729
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355757721
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314727#comment-16314727
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355757423
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1602


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314709#comment-16314709
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355755495
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314710#comment-16314710
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355755504
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314597#comment-16314597
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

DaanHoogland commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355749326
 
 
   adressed the final remark, awaiting ci and if our esteemed RM agrees we can 
merge.
   /cc @borisstoyanov @rafaelweingartner @rhtyd @marcaurele ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314594#comment-16314594
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355739858
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1600


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314593#comment-16314593
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355738149
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314591#comment-16314591
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355539932
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1597


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314590#comment-16314590
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355533847
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314589#comment-16314589
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355524864
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1594


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314588#comment-16314588
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355522505
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314587#comment-16314587
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355495160
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1589


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314586#comment-16314586
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355492378
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314581#comment-16314581
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355266727
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314583#comment-16314583
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355273109
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1578


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314582#comment-16314582
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355266791
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314584#comment-16314584
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355287632
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314585#comment-16314585
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355293952
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1580


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314580#comment-16314580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355109759
 
 
   Trillian test result (tid-1979)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 43379 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t1979-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314579#comment-16314579
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355087119
 
 
   Trillian test result (tid-1981)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37355 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t1981-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314570#comment-16314570
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354555758
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1530


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314569#comment-16314569
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354554446
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314577#comment-16314577
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355015320
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1558


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314578#comment-16314578
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355057208
 
 
   Trillian test result (tid-1980)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30878 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t1980-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 65 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 270.09 | 
test_privategw_acl.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314572#comment-16314572
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354581300
 
 
   Trillian test result (tid-1959)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33785 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2379-t1959-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314575#comment-16314575
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354953130
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, 
centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314573#comment-16314573
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354946827
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314574#comment-16314574
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354949660
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1549


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314576#comment-16314576
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355009737
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314571#comment-16314571
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-354556748
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314509#comment-16314509
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355739858
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1600


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314503#comment-16314503
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355738149
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314502#comment-16314502
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355738135
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313735#comment-16313735
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159961885
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,129 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.IOException;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313733#comment-16313733
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159961885
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,129 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.IOException;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313703#comment-16313703
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355641600
 
 
   Thanks @rhtyd @rafaelweingartner, I tried addressing all your comments 
before going on vacation tomorrow. Thanks @DaanHoogland for taking up the 
remaining open comment


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313130#comment-16313130
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878648
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -0,0 +1,188 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.UUID;
+
+public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
+
+private String url;
+private String destPoolPath;
+private Long templateId;
+private String downloadedFilePath;
+private String installPath;
+private String checksum;
+
+protected DirectTemplateDownloaderImpl(final String url, final String 
destPoolPath, final Long templateId, final String checksum) {
+this.url = url;
+this.destPoolPath = destPoolPath;
+this.templateId = templateId;
+this.checksum = checksum;
+}
+
+private static String directDownloadDir = "template";
+
+/**
+ * Return direct download temporary path to download template
+ * @param templateId
+ * @return
+ */
+protected static String getDirectDownloadTempPath(Long templateId) {
+String templateIdAsString = String.valueOf(templateId);
+return directDownloadDir + File.separator + 
templateIdAsString.substring(0,1) +
+File.separator + templateIdAsString;
+}
+
+/**
+ * Create folder on path if it does not exist
+ * @param path
 
 Review comment:
   @param can be removed from here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313131#comment-16313131
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159879369
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,136 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.RandomAccessFile;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+};
+}
+
+@Override
+public boolean downloadTemplate() {
+File f = new File(getDownloadedFilePath());
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313129#comment-16313129
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878537
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   I agree. You can do that, or you can do everything in Java (reading and 
writing files). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313128#comment-16313128
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878621
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -0,0 +1,188 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.UUID;
+
+public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
+
+private String url;
+private String destPoolPath;
+private Long templateId;
+private String downloadedFilePath;
+private String installPath;
+private String checksum;
+
+protected DirectTemplateDownloaderImpl(final String url, final String 
destPoolPath, final Long templateId, final String checksum) {
+this.url = url;
+this.destPoolPath = destPoolPath;
+this.templateId = templateId;
+this.checksum = checksum;
+}
+
+private static String directDownloadDir = "template";
+
+/**
+ * Return direct download temporary path to download template
+ * @param templateId
 
 Review comment:
   @param and @return can be removed from here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313122#comment-16313122
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878781
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   Yes, I prefer using this java approach for those that can be done instead of 
using a script file. If you prefer I can refactor it to a script file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313120#comment-16313120
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878184
 
 

 ##
 File path: scripts/vm/hypervisor/kvm/setup_agent.sh
 ##
 @@ -224,5 +224,17 @@ then
 setenforce 0
 fi
 
+which aria2c
+if [ $? -gt 0 ]
+then
+yum install epel-release -y
+yum install aria2 -y
 
 Review comment:
   I also added it on cloud.spec, should I remove it from here then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313119#comment-16313119
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-37598
 
 
   Thanks @rafaelweingartner @rhtyd, I had pushed a refactor commit after your 
comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313091#comment-16313091
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159874143
 
 

 ##
 File path: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateInfo.java
 ##
 @@ -25,4 +25,6 @@
 String getUniqueName();
 
 String getInstallPath();
+
+boolean isDirectDownload();
 
 Review comment:
   Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313019#comment-16313019
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355542658
 
 
   @nvazquez I believe you addressed almost everything. From my check there are 
still the following question in files:
   agent/src/com/cloud/agent/direct/download/NfsDirectTemplateDownloader.java 
   engine/orchestration/pom.xml 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313007#comment-16313007
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355539932
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1597


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312987#comment-16312987
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355533847
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312986#comment-16312986
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355533834
 
 
   @borisstoyanov @DaanHoogland fixed
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312976#comment-16312976
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355532494
 
 
   @borisstoyanov @DaanHoogland I see there are files missing, by splitting the 
single commit on multiple commits. May I push force with the single commit I'm 
using to run on my env?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312913#comment-16312913
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355525613
 
 
   @nvazquez @DaanHoogland looks like build is still broken, can you have a 
look please
   
   ```
   [INFO] BUILD FAILURE
   [INFO] 

   [INFO] Total time: 53.250s
   [INFO] Finished at: Fri Jan 05 10:35:55 UTC 2018
   [INFO] Final Memory: 50M/615M
   [INFO] 

   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check 
(cloudstack-checkstyle) on project cloud-utils: Failed during checkstyle 
execution: There is 1 error reported by Checkstyle 6.11.2 with cloud-style.xml 
ruleset. -> [Help 1]
   [ERROR] 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312907#comment-16312907
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355524864
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1594


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312891#comment-16312891
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355522505
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312890#comment-16312890
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355522375
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312659#comment-16312659
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159824288
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
 ##
 @@ -70,7 +71,7 @@
 private String format;
 
 @Parameter(name = ApiConstants.HYPERVISOR, type = CommandType.STRING, 
required = true, description = "the target hypervisor for the template")
-private String hypervisor;
+protected String hypervisor;
 
 Review comment:
   This can be retained as private.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312662#comment-16312662
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355495080
 
 
   @nvazquez can you also please fix the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312656#comment-16312656
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159824013
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -551,6 +555,10 @@ protected void processRequest(final Request request, 
final Link link) {
 answer = setupAgentKeystore((SetupKeyStoreCommand) 
cmd);
 } else if (cmd instanceof SetupCertificateCommand && 
((SetupCertificateCommand) cmd).isHandleByAgent()) {
 answer = 
setupAgentCertificate((SetupCertificateCommand) cmd);
+} else if (cmd instanceof CheckUrlCommand) {
 
 Review comment:
   This will enable any agent (cpvm, ssvm etc) to handle the command, if we 
want only the KVM agent to handle these commands they should be moved to 
libvirt computing resource.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312665#comment-16312665
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355495160
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1589


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312657#comment-16312657
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159824452
 
 

 ##
 File path: scripts/vm/hypervisor/kvm/setup_agent.sh
 ##
 @@ -224,5 +224,17 @@ then
 setenforce 0
 fi
 
+which aria2c
+if [ $? -gt 0 ]
+then
+yum install epel-release -y
+yum install aria2 -y
 
 Review comment:
   We can add aria2 dependency on rpms, see the spec files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312658#comment-16312658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159824126
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   The whole setup process could be implemented as a shell script with the java 
code calling that script to perform the job.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312638#comment-16312638
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355492378
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312637#comment-16312637
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rhtyd commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for 
KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355492347
 
 
   @blueorangutan package
   @rafaelweingartner @marcaurele can you re-review the changes/lgtm is okay?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

2018-01-04 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311409#comment-16311409
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355297973
 
 
   Thanks a lot @rafaelweingartner and @marcaurele for your valuable reviews


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

1 2 >

1 - 100 of 173 matches

Mail list logo