[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314637#comment-16314637
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-311881624
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314632#comment-16314632
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-310292379
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-783


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314625#comment-16314625
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309749397
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314621#comment-16314621
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309389877
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, 
centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314628#comment-16314628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309974852
 
 
   Trillian test result (tid-1174)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38262 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1174-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 49 look ok, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 399.08 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 366.76 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 169.88 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 71.14 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 255.48 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 264.15 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 553.62 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 528.39 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1461.12 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 591.03 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 763.44 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 151.41 | test_volumes.py
   test_08_resize_volume | Success | 156.43 | test_volumes.py
   test_07_resize_fail | Success | 161.53 | test_volumes.py
   test_06_download_detached_volume | Success | 156.30 | test_volumes.py
   test_05_detach_volume | Success | 145.74 | test_volumes.py
   test_04_delete_attached_volume | Success | 191.47 | test_volumes.py
   test_03_download_attached_volume | Success | 156.27 | test_volumes.py
   test_02_attach_volume | Success | 89.32 | test_volumes.py
   test_01_create_volume | Success | 711.89 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.86 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 168.91 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 247.68 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.87 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 30.94 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 130.88 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.82 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.14 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 35.29 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 65.59 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 5.29 | test_templates.py
   test_03_delete_template | Success | 5.11 | test_templates.py
   test_02_edit_template | Success | 90.15 | test_templates.py
   test_01_create_template | Success | 80.69 | test_templates.py
   test_10_destroy_cpvm | Success | 161.68 | test_ssvm.py
   test_09_destroy_ssvm | Success | 163.67 | test_ssvm.py
   test_08_reboot_cpvm | Success | 131.71 | test_ssvm.py
   test_07_reboot_ssvm | Success | 163.63 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.78 | test_ssvm.py
   test_05_stop_ssvm | Success | 139.45 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.16 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.57 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.90 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 11.28 | test_snapshots.py
   test_04_change_offering_small | Success | 239.79 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
  

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314626#comment-16314626
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309756549
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-781


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314623#comment-16314623
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309563188
 
 
   Trillian test result (tid-1166)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38051 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1166-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 46 look ok, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 1309.22 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 528.77 | 
test_vpc_redundant.py
   test_01_create_volume | `Failure` | 154.16 | test_volumes.py
   test_04_rvpc_privategw_static_routes | `Failure` | 610.60 | 
test_privategw_acl.py
   test_3d_gpu_support | `Failure` | 307.81 | test_deploy_vgpu_enabled_vm.py
   test_06_download_detached_volume | `Error` | 35.31 | test_volumes.py
   ContextSuite context=TestDeployVmRootSize>:setup | `Error` | 0.00 | 
test_deploy_vm_root_resize.py
   test_01_vpc_site2site_vpn | Success | 284.67 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 131.15 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 485.75 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 291.05 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 552.41 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 427.29 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 539.90 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 484.73 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 25.66 | test_volumes.py
   test_05_detach_volume | Success | 100.19 | test_volumes.py
   test_04_delete_attached_volume | Success | 15.17 | test_volumes.py
   test_03_download_attached_volume | Success | 15.20 | test_volumes.py
   test_02_attach_volume | Success | 59.72 | test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | Success | 392.81 | 
test_vm_snapshots.py
   test_03_delete_vm_snapshots | Success | 275.21 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 194.54 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 128.78 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 191.71 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 55.75 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 5.09 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 5.10 | test_vm_life_cycle.py
   test_02_start_vm | Success | 20.17 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.10 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 10.11 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 191.05 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.03 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 15.78 | test_templates.py
   test_03_delete_template | Success | 5.09 | test_templates.py
   test_02_edit_template | Success | 90.11 | test_templates.py
   test_01_create_template | Success | 100.62 | test_templates.py
   test_10_destroy_cpvm | Success | 206.35 | test_ssvm.py
   test_09_destroy_ssvm | Success | 238.34 | test_ssvm.py
   test_08_reboot_cpvm | Success | 126.23 | test_ssvm.py
   test_07_reboot_ssvm | Success | 157.92 | test_ssvm.py
   test_06_stop_cpvm | Success | 181.50 | test_ssvm.py
   test_05_stop_ssvm | Success | 208.35 | test_ssvm.py
   test_04_cpvm_internals | Success | 0.94 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.16 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.10 | 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314617#comment-16314617
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309050757
 
 
   Trillian test result (tid-1160)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 14053 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1160-xenserver-65sp1.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 22 look ok, 41 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn | `Failure` | 161.99 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 75.77 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 312.85 | test_vpc_vpn.py
   test_02_VPC_default_routes | `Failure` | 71.69 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | `Failure` | 81.83 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 162.47 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 137.18 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 157.35 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 162.41 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 152.28 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 318.71 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 167.82 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 152.75 | 
test_privategw_acl.py
   test_02_deploy_vm_root_resize | `Failure` | 0.00 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | `Failure` | 0.00 | 
test_deploy_vm_root_resize.py
   test_05_rvpc_multi_tiers | `Error` | 193.00 | test_vpc_redundant.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | 
test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 0.00 | 
test_vm_snapshots.py
   ContextSuite 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314622#comment-16314622
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309562533
 
 
   Trillian test result (tid-1165)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38213 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1165-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Test completed. 48 look ok, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 386.30 | 
test_privategw_acl.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_vpc_site2site_vpn | Success | 205.22 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 66.17 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 270.49 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 318.09 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 596.20 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 514.98 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1350.67 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 588.37 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 768.32 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1299.07 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.58 | test_volumes.py
   test_08_resize_volume | Success | 156.42 | test_volumes.py
   test_07_resize_fail | Success | 161.49 | test_volumes.py
   test_06_download_detached_volume | Success | 156.35 | test_volumes.py
   test_05_detach_volume | Success | 145.68 | test_volumes.py
   test_04_delete_attached_volume | Success | 146.20 | test_volumes.py
   test_03_download_attached_volume | Success | 156.31 | test_volumes.py
   test_02_attach_volume | Success | 89.38 | test_volumes.py
   test_01_create_volume | Success | 712.11 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.29 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.83 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 163.93 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 257.64 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.79 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 61.28 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 125.82 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.15 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 35.29 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 171.31 | test_templates.py
   test_08_list_system_templates | Success | 0.04 | test_templates.py
   test_07_list_public_templates | Success | 0.05 | test_templates.py
   test_05_template_permissions | Success | 0.07 | test_templates.py
   test_04_extract_template | Success | 5.14 | test_templates.py
   test_03_delete_template | Success | 5.12 | test_templates.py
   test_02_edit_template | Success | 90.11 | test_templates.py
   test_01_create_template | Success | 60.56 | test_templates.py
   test_10_destroy_cpvm | Success | 191.71 | test_ssvm.py
   test_09_destroy_ssvm | Success | 163.63 | test_ssvm.py
   test_08_reboot_cpvm | Success | 101.55 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.58 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.72 | test_ssvm.py
   test_05_stop_ssvm | Success | 163.91 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
   test_03_ssvm_internals | Success | 4.06 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.20 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.25 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.87 | 
test_snapshots.py
   test_01_snapshot_root_disk | 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314620#comment-16314620
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309389570
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-776


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314630#comment-16314630
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309998038
 
 
   Trillian test result (tid-1175)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44490 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1175-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Test completed. 48 look ok, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 793.79 | 
test_privategw_acl.py
   test_3d_gpu_support | `Failure` | 464.80 | test_deploy_vgpu_enabled_vm.py
   test_04_rvpc_privategw_static_routes | `Error` | 899.83 | 
test_privategw_acl.py
   ContextSuite context=TestDeployVmRootSize>:setup | `Error` | 0.00 | 
test_deploy_vm_root_resize.py
   test_01_vpc_site2site_vpn | Success | 325.88 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 151.73 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 532.19 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 347.69 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 632.01 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 489.77 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1478.12 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 607.54 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 578.05 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1219.05 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 30.94 | test_volumes.py
   test_06_download_detached_volume | Success | 85.72 | test_volumes.py
   test_05_detach_volume | Success | 100.30 | test_volumes.py
   test_04_delete_attached_volume | Success | 15.26 | test_volumes.py
   test_03_download_attached_volume | Success | 15.30 | test_volumes.py
   test_02_attach_volume | Success | 59.82 | test_volumes.py
   test_01_create_volume | Success | 525.84 | test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | Success | 507.02 | 
test_vm_snapshots.py
   test_03_delete_vm_snapshots | Success | 275.22 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 222.16 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 161.76 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 212.41 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.95 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 61.19 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
   test_02_start_vm | Success | 15.22 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.15 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 312.19 | test_templates.py
   test_08_list_system_templates | Success | 0.04 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.06 | test_templates.py
   test_04_extract_template | Success | 20.34 | test_templates.py
   test_03_delete_template | Success | 5.12 | test_templates.py
   test_02_edit_template | Success | 90.19 | test_templates.py
   test_01_create_template | Success | 181.30 | test_templates.py
   test_10_destroy_cpvm | Success | 241.84 | test_ssvm.py
   test_09_destroy_ssvm | Success | 273.87 | test_ssvm.py
   test_08_reboot_cpvm | Success | 156.54 | test_ssvm.py
   test_07_reboot_ssvm | Success | 158.59 | test_ssvm.py
   test_06_stop_cpvm | Success | 206.99 | test_ssvm.py
   test_05_stop_ssvm | Success | 208.82 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.16 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.50 | test_ssvm.py
   test_02_list_cpvm_vm | Success 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314629#comment-16314629
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309978837
 
 
   Trillian test result (tid-1173)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 39683 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1173-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 49 look ok, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 362.75 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 395.41 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 607.95 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 285.95 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 136.79 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 386.80 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 279.56 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 591.45 | test_vpc_router_nics.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1513.10 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 657.35 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 980.42 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 15.61 | test_volumes.py
   test_08_resize_volume | Success | 100.98 | test_volumes.py
   test_07_resize_fail | Success | 101.16 | test_volumes.py
   test_06_download_detached_volume | Success | 25.36 | test_volumes.py
   test_05_detach_volume | Success | 100.28 | test_volumes.py
   test_04_delete_attached_volume | Success | 10.24 | test_volumes.py
   test_03_download_attached_volume | Success | 15.30 | test_volumes.py
   test_02_attach_volume | Success | 15.81 | test_volumes.py
   test_01_create_volume | Success | 392.38 | test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | Success | 362.51 | 
test_vm_snapshots.py
   test_03_delete_vm_snapshots | Success | 280.24 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 186.50 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 133.85 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 172.25 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.84 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 101.40 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 15.20 | test_vm_life_cycle.py
   test_02_start_vm | Success | 20.24 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.15 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 30.30 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 106.14 | test_templates.py
   test_08_list_system_templates | Success | 0.10 | test_templates.py
   test_07_list_public_templates | Success | 0.10 | test_templates.py
   test_05_template_permissions | Success | 0.10 | test_templates.py
   test_04_extract_template | Success | 5.15 | test_templates.py
   test_03_delete_template | Success | 5.16 | test_templates.py
   test_02_edit_template | Success | 90.11 | test_templates.py
   test_01_create_template | Success | 85.91 | test_templates.py
   test_10_destroy_cpvm | Success | 221.76 | test_ssvm.py
   test_09_destroy_ssvm | Success | 199.26 | test_ssvm.py
   test_08_reboot_cpvm | Success | 136.39 | test_ssvm.py
   test_07_reboot_ssvm | Success | 149.00 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.75 | test_ssvm.py
   test_05_stop_ssvm | Success | 199.07 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.05 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.59 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.11 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 119.71 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 26.63 | 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314627#comment-16314627
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309866590
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, 
centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314624#comment-16314624
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309599972
 
 
   Trillian test result (tid-1164)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 49166 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1164-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 49 look ok, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 472.56 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 470.15 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 382.89 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 340.24 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 161.45 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 536.54 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 334.65 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 753.30 | test_vpc_router_nics.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1567.80 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 877.85 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 1048.81 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 15.62 | test_volumes.py
   test_08_resize_volume | Success | 90.74 | test_volumes.py
   test_07_resize_fail | Success | 95.95 | test_volumes.py
   test_06_download_detached_volume | Success | 30.36 | test_volumes.py
   test_05_detach_volume | Success | 100.28 | test_volumes.py
   test_04_delete_attached_volume | Success | 10.17 | test_volumes.py
   test_03_download_attached_volume | Success | 15.30 | test_volumes.py
   test_02_attach_volume | Success | 11.07 | test_volumes.py
   test_01_create_volume | Success | 393.52 | test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | Success | 379.64 | 
test_vm_snapshots.py
   test_03_delete_vm_snapshots | Success | 280.25 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 229.64 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 130.94 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 337.64 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 41.95 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 70.93 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.13 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 10.13 | test_vm_life_cycle.py
   test_02_start_vm | Success | 15.18 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.12 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 30.26 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 211.38 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.03 | test_templates.py
   test_05_template_permissions | Success | 0.04 | test_templates.py
   test_04_extract_template | Success | 5.16 | test_templates.py
   test_03_delete_template | Success | 5.09 | test_templates.py
   test_02_edit_template | Success | 90.17 | test_templates.py
   test_01_create_template | Success | 111.50 | test_templates.py
   test_10_destroy_cpvm | Success | 231.92 | test_ssvm.py
   test_09_destroy_ssvm | Success | 229.29 | test_ssvm.py
   test_08_reboot_cpvm | Success | 146.62 | test_ssvm.py
   test_07_reboot_ssvm | Success | 153.88 | test_ssvm.py
   test_06_stop_cpvm | Success | 196.75 | test_ssvm.py
   test_05_stop_ssvm | Success | 199.30 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.28 | test_ssvm.py
   test_03_ssvm_internals | Success | 4.16 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 146.24 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 21.38 | test_snapshots.py
   test_04_change_offering_small | Success | 81.57 | 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314619#comment-16314619
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309383646
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314618#comment-16314618
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309071499
 
 
   Trillian test result (tid-1163)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 18024 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1163-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 20 look ok, 44 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn | `Failure` | 257.32 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 161.23 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 403.13 | test_vpc_vpn.py
   test_02_VPC_default_routes | `Failure` | 177.18 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | `Failure` | 172.15 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 247.63 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 212.48 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 182.22 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 292.97 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 167.14 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 519.52 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 177.57 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 242.86 | 
test_privategw_acl.py
   test_05_rvpc_multi_tiers | `Error` | 288.16 | test_vpc_redundant.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | 
test_volumes.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 0.00 | 
test_vm_snapshots.py
   ContextSuite 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314611#comment-16314611
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308798763
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314607#comment-16314607
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308739606
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314606#comment-16314606
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308670331
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-770


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314602#comment-16314602
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308346906
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-767


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314604#comment-16314604
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308652685
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-769


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314615#comment-16314615
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-309046763
 
 
   Trillian test result (tid-1162)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 12589 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1162-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 22 look ok, 41 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn | `Failure` | 80.93 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 40.37 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 161.20 | test_vpc_vpn.py
   test_02_VPC_default_routes | `Failure` | 45.95 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | `Failure` | 45.97 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 81.17 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 86.19 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 81.22 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 81.16 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 86.20 | 
test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 166.75 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 86.39 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 86.35 | 
test_privategw_acl.py
   test_02_deploy_vm_root_resize | `Failure` | 0.00 | 
test_deploy_vm_root_resize.py
   test_01_deploy_vm_root_resize | `Failure` | 0.00 | 
test_deploy_vm_root_resize.py
   test_05_rvpc_multi_tiers | `Error` | 111.50 | test_vpc_redundant.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | 
test_volumes.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.55 | 
test_vm_snapshots.py
   ContextSuite 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314610#comment-16314610
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308756159
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-773


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314608#comment-16314608
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308745250
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-772


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314616#comment-16314616
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308999494
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, 
centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314612#comment-16314612
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308806514
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-774


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314609#comment-16314609
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308749210
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314605#comment-16314605
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308664701
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314614#comment-16314614
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308972254
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-775


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314613#comment-16314613
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308967056
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314603#comment-16314603
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308648107
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314601#comment-16314601
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308340910
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314600#comment-16314600
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308102655
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-765


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314599#comment-16314599
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-308096809
 
 
   @abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314562#comment-16314562
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355748178
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314563#comment-16314563
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355748184
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312716#comment-16312716
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355500725
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1590


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312672#comment-16312672
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355495497
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312669#comment-16312669
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355495338
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312509#comment-16312509
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355478470
 
 
   @nvazquez please check/fix the volume related errors.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311986#comment-16311986
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355391105
 
 
   Trillian test result (tid-2002)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48665 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t2002-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_3d_gpu_support | `Failure` | 333.10 | test_deploy_vgpu_enabled_vm.py
   test_00_deploy_vm_root_resize | `Error` | 0.09 | 
test_deploy_vm_root_resize.py
   test_08_migrate_vm | `Error` | 55.67 | test_vm_life_cycle.py
   test_01_create_volume | `Failure` | 197.30 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311294#comment-16311294
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files 
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355272601
 
 
   @nvazquez and @DaanHoogland no problem. I understand it is not you guys that 
are developing this from scratch. I also understand that somethings such as the 
"manual parse" of XML will not be addressed here, since it would require 
evaluating of a tool to use, then the change of the already created code, and 
so on.
   
   If you guys manage to at least address some of the remarks, it would be 
awesome!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311283#comment-16311283
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355271841
 
 
   @rafaelweingartner agree with you, it was my bad I thought we were all good 
but forgot about the open comments. I'll be addressing them as soon as possible


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311267#comment-16311267
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355268255
 
 
   @rafaelweingartner i see and agree, that's why I asked if your concerns with 
this pr where addressed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311242#comment-16311242
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files 
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355263035
 
 
   @DaanHoogland now that you saw the other remarks, the cyclomatic complexity 
is one issue for sure (most people overlook this, and this is one of the causes 
of our 1000+ lines methods). There are the others issues that we will probably 
ignore here, which are the excessive catch of generic exceptions (there is even 
a catch Throwable… this style of working is one of the causes of those nasty 
bugs that we sometimes spend hours and days debugging), the manual parse of XML 
(this trait of manually doing things and not adopting consolidated libraries is 
one of the causes of excessive code in our code base), and so on.
   
   To reinforce what I said before, I raise issues to discuss and to try 
improving the work that is being proposed. I really do not see the benefit to 
go to a PR, use my time to go over it and not have an opinion (a critique) to 
make about it. I would feel like wasting my time then. Also, I do not see the 
point in requiring a review, if it is to go to PRs and just saying LGTM just to 
mark a requirement of a protocol.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310871#comment-16310871
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355212185
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310870#comment-16310870
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355212051
 
 
   @blueorangutan test centos7 vmware-55u3
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310855#comment-16310855
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355211594
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1563


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310761#comment-16310761
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203515
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310762#comment-16310762
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203546
 
 
   test_01_create_volume failed on both vmware 55u3 and 65, we'll need another 
re-run. /cc @nvazquez @borisstoyanov 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310759#comment-16310759
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355203424
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310360#comment-16310360
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r159541001
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -1003,4 +1180,72 @@ public void addSystemVMTemplatesToSecondary(DataStore 
store) {
 }
 }
 }
+
+private class CreateDataDiskTemplateContext extends AsyncRpcContext {
+private final DataObject dataDiskTemplate;
+private final AsyncCallFuture future;
+
+public CreateDataDiskTemplateContext(AsyncCompletionCallback 
callback, DataObject dataDiskTemplate, AsyncCallFuture 
future) {
+super(callback);
+this.dataDiskTemplate = dataDiskTemplate;
+this.future = future;
+}
+
+public AsyncCallFuture getFuture() {
+return this.future;
+}
+}
+
+@Override
+public AsyncCallFuture 
createDatadiskTemplateAsync(TemplateInfo parentTemplate, TemplateInfo 
dataDiskTemplate, String path, String diskId, long fileSize, boolean bootable) {
+AsyncCallFuture future = new 
AsyncCallFuture();
+// Make an entry for disk template in template_store_ref table
+DataStore store = parentTemplate.getDataStore();
+TemplateObject dataDiskTemplateOnStore;
+if (!bootable) {
+dataDiskTemplateOnStore = 
(TemplateObject)store.create(dataDiskTemplate);
+
dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.CreateOnlyRequested);
+} else {
+dataDiskTemplateOnStore = (TemplateObject) 
imageFactory.getTemplate(parentTemplate, store);
+}
+try {
+CreateDataDiskTemplateContext context = new 
CreateDataDiskTemplateContext(null, dataDiskTemplateOnStore, 
future);
+AsyncCallbackDispatcher 
caller = AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createDatadiskTemplateCallback(null, 
null)).setContext(context);
+ImageStoreEntity tmpltStore = 
(ImageStoreEntity)parentTemplate.getDataStore();
+tmpltStore.createDataDiskTemplateAsync(dataDiskTemplate, path, 
diskId, fileSize, bootable, caller);
+} catch (CloudRuntimeException ex) {
+
dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.OperationFailed);
+TemplateApiResult result = new TemplateApiResult(dataDiskTemplate);
+result.setResult(ex.getMessage());
+if (future != null) {
+future.complete(result);
+}
+}
+return future;
+}
+
+protected Void 
createDatadiskTemplateCallback(AsyncCallbackDispatcher callback,
+CreateDataDiskTemplateContext context) {
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("MDOVA createDatadiskTemplateCallback Performing 
create datadisk template cross callback after completion");
+}
+DataObject dataDiskTemplate = context.dataDiskTemplate;
+AsyncCallFuture future = context.getFuture();
+CreateCmdResult result = callback.getResult();
+TemplateApiResult dataDiskTemplateResult = new 
TemplateApiResult((TemplateObject)dataDiskTemplate);
+try {
+if (result.isSuccess()) {
+dataDiskTemplate.processEvent(Event.OperationSuccessed, 
result.getAnswer());
+} else {
+dataDiskTemplate.processEvent(Event.OperationFailed);
+dataDiskTemplateResult.setResult(result.getResult());
+}
+} catch (Exception e) {
 
 Review comment:
   and that is serious BTW (case i inadvertently am fooling someone into 
believing it is not)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310357#comment-16310357
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r159540728
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -1003,4 +1180,72 @@ public void addSystemVMTemplatesToSecondary(DataStore 
store) {
 }
 }
 }
+
+private class CreateDataDiskTemplateContext extends AsyncRpcContext {
+private final DataObject dataDiskTemplate;
+private final AsyncCallFuture future;
+
+public CreateDataDiskTemplateContext(AsyncCompletionCallback 
callback, DataObject dataDiskTemplate, AsyncCallFuture 
future) {
+super(callback);
+this.dataDiskTemplate = dataDiskTemplate;
+this.future = future;
+}
+
+public AsyncCallFuture getFuture() {
+return this.future;
+}
+}
+
+@Override
+public AsyncCallFuture 
createDatadiskTemplateAsync(TemplateInfo parentTemplate, TemplateInfo 
dataDiskTemplate, String path, String diskId, long fileSize, boolean bootable) {
+AsyncCallFuture future = new 
AsyncCallFuture();
+// Make an entry for disk template in template_store_ref table
+DataStore store = parentTemplate.getDataStore();
+TemplateObject dataDiskTemplateOnStore;
+if (!bootable) {
+dataDiskTemplateOnStore = 
(TemplateObject)store.create(dataDiskTemplate);
+
dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.CreateOnlyRequested);
+} else {
+dataDiskTemplateOnStore = (TemplateObject) 
imageFactory.getTemplate(parentTemplate, store);
+}
+try {
+CreateDataDiskTemplateContext context = new 
CreateDataDiskTemplateContext(null, dataDiskTemplateOnStore, 
future);
+AsyncCallbackDispatcher 
caller = AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createDatadiskTemplateCallback(null, 
null)).setContext(context);
+ImageStoreEntity tmpltStore = 
(ImageStoreEntity)parentTemplate.getDataStore();
+tmpltStore.createDataDiskTemplateAsync(dataDiskTemplate, path, 
diskId, fileSize, bootable, caller);
+} catch (CloudRuntimeException ex) {
+
dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.OperationFailed);
+TemplateApiResult result = new TemplateApiResult(dataDiskTemplate);
+result.setResult(ex.getMessage());
+if (future != null) {
+future.complete(result);
+}
+}
+return future;
+}
+
+protected Void 
createDatadiskTemplateCallback(AsyncCallbackDispatcher callback,
+CreateDataDiskTemplateContext context) {
+if (s_logger.isDebugEnabled()) {
+s_logger.debug("MDOVA createDatadiskTemplateCallback Performing 
create datadisk template cross callback after completion");
+}
+DataObject dataDiskTemplate = context.dataDiskTemplate;
+AsyncCallFuture future = context.getFuture();
+CreateCmdResult result = callback.getResult();
+TemplateApiResult dataDiskTemplateResult = new 
TemplateApiResult((TemplateObject)dataDiskTemplate);
+try {
+if (result.isSuccess()) {
+dataDiskTemplate.processEvent(Event.OperationSuccessed, 
result.getAnswer());
+} else {
+dataDiskTemplate.processEvent(Event.OperationFailed);
+dataDiskTemplateResult.setResult(result.getResult());
+}
+} catch (Exception e) {
 
 Review comment:
   ok, this one is about the code changed here ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> 

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310356#comment-16310356
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355141747
 
 
   ok, I see your point now, @rafaelweingartner. github had hidden the first 
few comments. I agree with the cyclomatic compleity arguments you make but the 
rest seems not to be concerning this change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310353#comment-16310353
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r159540031
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -5463,14 +5435,15 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
 }
 }
 }
-vmResponseMap.put(name, new VmStatsEntry( 
NumberUtils.toDouble(memkb)*1024,NumberUtils.toDouble(guestMemusage)*1024,NumberUtils.toDouble(memlimit)*1024,
 maxCpuUsage, networkReadKBs, networkWriteKBs, NumberUtils.toInt(numberCPUs), 
"vm"));
+vmResponseMap.put(name, new VmStatsEntry( 
NumberUtils.toDouble(memkb)*1024,NumberUtils.toDouble(guestMemusage)*1024,NumberUtils.toDouble(memlimit)*1024,
 
 Review comment:
   I agree but the change here is an improvement and everybody is very busy. 
let's save it for a rainy day.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310349#comment-16310349
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r159539800
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -4076,8 +4059,7 @@ private void handleTargets(boolean add, List> targets, HostM
 if (targets != null && targets.size() > 0) {
 try {
 _storageProcessor.handleTargetsForHost(add, targets, host);
-}
-catch (Exception ex) {
+} catch (Exception ex) {
 
 Review comment:
   useful comment, again but not to this PR and this goes for most below as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310348#comment-16310348
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r159539682
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -4076,8 +4059,7 @@ private void handleTargets(boolean add, List> targets, HostM
 if (targets != null && targets.size() > 0) {
 
 Review comment:
   useful comment but does not apply to this PR, I think a PR to amend this PR 
would be in place here, no?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310228#comment-16310228
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355114589
 
 
   Trillian test result (tid-1984)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41901 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1984-vmware-65.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 62 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_3d_gpu_support | `Failure` | 333.82 | test_deploy_vgpu_enabled_vm.py
   test_00_deploy_vm_root_resize | `Error` | 0.14 | 
test_deploy_vm_root_resize.py
   test_08_migrate_vm | `Error` | 106.20 | test_vm_life_cycle.py
   test_01_create_volume | `Failure` | 191.96 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310143#comment-16310143
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files 
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355102557
 
 
   It is not only comments related to generic catches... There are a few 
others, for instance, there is one regarding cyclomatic complexity in 
OVFHelper.java. Then, in the same class a question regarding the excessive 
manual parse of XML (Some tool to do this might be better, there are a bunch of 
different ones that can be used for this). In DeployVMCmd.java there is also 
something else regarding cyclomatic complexity. There is also the issue of 
magic numbers and the suggestion to create a utils class to convert between 
bases (MiB, MB, KB, and so on).
   
   In summary, there are few others issues besides the catches...
   
   If you guys want to push this in the way it is I cannot do much; I normally 
do not give -1 (I did not give a -1 here), unless it is something very bad. I 
normally conduct discussions on standard and quality of the code. The idea is 
to show people that code can and should always be improved.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310122#comment-16310122
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355099685
 
 
   @rafaelweingartner I only see prior existing catchAlls. I don't think these 
warant a -1 so I wonder if the rest of your concerns was addressed as you 
expected/desired.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309924#comment-16309924
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files 
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355066066
 
 
   @DaanHoogland I am not sure. I thought @nvazquez was still working on them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309811#comment-16309811
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355043207
 
 
   @rafaelweingartner did your concerns get addressed, yet?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309726#comment-16309726
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355027421
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309299#comment-16309299
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958995
 
 
   Test LGTM. Are you lgtm on this @nvazquez @DaanHoogland ?
   I've kicked a final test round against vmware-65 as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309295#comment-16309295
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958623
 
 
   Kicking again
   @blueorangutan test centos7 vmware-55u3
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309297#comment-16309297
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


abhinandanprateek opened a new pull request #2146: CLOUDSTACK-4757: Support OVA 
files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146
 
 
   JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
   
   Updated FS here: 
   
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+OVA+files+containing+multiple+disks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309298#comment-16309298
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958623
 
 
   Kicking again
   @blueorangutan test centos7 vmware-55u3
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308143#comment-16308143
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354779662
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1545


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308016#comment-16308016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354762645
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308012#comment-16308012
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354762490
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306564#comment-16306564
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354504434
 
 
   Trillian test result (tid-1943)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47457 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1943-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 63 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_3d_gpu_support | `Failure` | 485.74 | test_deploy_vgpu_enabled_vm.py
   test_00_deploy_vm_root_resize | `Error` | 0.21 | 
test_deploy_vm_root_resize.py
   test_01_create_volume | `Failure` | 202.58 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306203#comment-16306203
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354432130
 
 
   Thanks @borisstoyanov!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306115#comment-16306115
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354416109
 
 
   @blueorangutan test centos7 vmware-55u3


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306116#comment-16306116
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354416142
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306114#comment-16306114
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354416037
 
 
   @borisstoyanov unsupported parameters provided. Supported mgmt server os 
are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, 
kvm-centos7, kvm-ubuntu, xenserver-65sp1, xenserver-62sp1, vmware-60u2, 
vmware-55u3, vmware-51u1, vmware-50u1`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306113#comment-16306113
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354415958
 
 
   @blueorangutan test centos7 vmware55


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306073#comment-16306073
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354412746
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1525


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306062#comment-16306062
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410643
 
 
   @rhtyd @nvazquez, I've manually executed the multi disk templates tests and 
they're looking good, also resolved the conflicts and will re-run the VMware 
tests, hopefully they'll look better now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306060#comment-16306060
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


borisstoyanov commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410346
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306061#comment-16306061
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354410361
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304094#comment-16304094
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354028655
 
 
   Trillian test result (tid-1924)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53733 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1924-vmware-55u3.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 59 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_3d_gpu_support | `Failure` | 369.93 | test_deploy_vgpu_enabled_vm.py
   test_00_deploy_vm_root_resize | `Error` | 0.16 | 
test_deploy_vm_root_resize.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 399.85 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 702.43 | 
test_privategw_acl.py
   test_08_migrate_vm | `Error` | 66.31 | test_vm_life_cycle.py
   test_01_create_volume | `Failure` | 159.99 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 660.13 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 1150.15 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 333.25 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 664.91 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 726.11 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Failure` | 883.96 | test_vpc_router_nics.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304019#comment-16304019
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354013055
 
 
   Trillian test result (tid-1921)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 42410 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1921-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304016#comment-16304016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354012610
 
 
   Trillian test result (tid-1925)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35911 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2146-t1925-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303671#comment-16303671
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353943835
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + 
vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303670#comment-16303670
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353943801
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303657#comment-16303657
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353942197
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1493


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303546#comment-16303546
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


blueorangutan commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353927772
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303543#comment-16303543
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353927716
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302902#comment-16302902
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158606488
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -675,6 +695,18 @@ protected Void 
createTemplateCallback(AsyncCallbackDispatcher Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302817#comment-16302817
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158599641
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -192,6 +194,10 @@
 + " Example: 
dhcpoptionsnetworklist[0].dhcp:114=url[0].networkid=networkid[0].dhcp:66=www.test.com")
 private Map dhcpOptionsNetworkList;
 
+@Parameter(name = ApiConstants.DATADISK_OFFERING_LIST, type = 
CommandType.MAP, since = "4.10", description = "datadisk template to 
disk-offering mapping;" +
+" an optional parameter used to create additional data disks from 
datadisk templates; can't be specified with diskOfferingId parameter")
+private Map dataDiskTemplateToDiskOfferingList;
 
 Review comment:
   It is always time to create new patterns :)
   
   I would suggest using a qualifying name that describes the true object. 
Also, a documentation; for instance, this is a map of maps. What is the first 
key that maps an entry to a map? What is the second key that maps a value?
   
   After having this information we can even question, do we need a map of maps 
structure? It feels a pretty complicated solution


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302798#comment-16302798
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files 
with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353775725
 
 
   @nvazquez I knew it was not yours ;)
   I will try to review the PR again once you push/replies all of the raised 
issues. I do not know if I will be able to do this week though.
   
   @nvazquez Thanks for the hard work as always...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302797#comment-16302797
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158598357
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -443,6 +449,37 @@ public String getKeyboard() {
 return dhcpOptionsMap;
 }
 
+public Map getDataDiskTemplateToDiskOfferingMap() {
+if (diskOfferingId != null && dataDiskTemplateToDiskOfferingList != 
null) {
 
 Review comment:
   Great. Then, what about changing things a little bit to reduce the number of 
lines inside an IF statement?
   
   You could do `if(CollectionUtils.isEmpty(dataDiskTemplateToDiskOfferingList 
)){return new HashMap()}`
   
   Then, you would not need the `if` statement at line 457. This reduces one 
level of cyclomatic complexity in this method.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302796#comment-16302796
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: 
Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158598235
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -324,6 +333,17 @@ public void handleTemplateSync(DataStore store) {
 }
 }
 
+for (Iterator iter = 
allTemplates.listIterator(); iter.hasNext();) {
+VMTemplateVO child_template = iter.next();
+if (child_template.getParentTemplateId() != null) {
+String uniqueName = child_template.getUniqueName();
+if (templateInfos.containsKey(uniqueName)) {
+templateInfos.remove(uniqueName);
+}
+iter.remove();
+}
+}
+
 toBeDownloaded.addAll(allTemplates);
 
 Review comment:
   Ah yes. My bad...
   I got lost with the IFs...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302705#comment-16302705
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with 
multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-353768285
 
 
   @rafaelweingartner thanks for your review! I'm grabbing this PR from 
@abhinandanprateek to include it on 4.11. Due to your findings I could improve 
some parts of the code which I had missed out on my review.
   I had refactored according to most of your comments but there are some of 
them left, I'll be addressing them soon


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302694#comment-16302694
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594660
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -324,6 +333,17 @@ public void handleTemplateSync(DataStore store) {
 }
 }
 
+for (Iterator iter = 
allTemplates.listIterator(); iter.hasNext();) {
+VMTemplateVO child_template = iter.next();
+if (child_template.getParentTemplateId() != null) {
+String uniqueName = child_template.getUniqueName();
+if (templateInfos.containsKey(uniqueName)) {
+templateInfos.remove(uniqueName);
+}
+iter.remove();
+}
+}
+
 toBeDownloaded.addAll(allTemplates);
 
 Review comment:
   As per my understanding, only parent templates (parent_template_id = null) 
will be on allTemplates after previous code


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302692#comment-16302692
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594624
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -192,6 +194,10 @@
 + " Example: 
dhcpoptionsnetworklist[0].dhcp:114=url[0].networkid=networkid[0].dhcp:66=www.test.com")
 private Map dhcpOptionsNetworkList;
 
+@Parameter(name = ApiConstants.DATADISK_OFFERING_LIST, type = 
CommandType.MAP, since = "4.10", description = "datadisk template to 
disk-offering mapping;" +
+" an optional parameter used to create additional data disks from 
datadisk templates; can't be specified with diskOfferingId parameter")
+private Map dataDiskTemplateToDiskOfferingList;
 
 Review comment:
   It is a map of maps indeed. I agree that its name is not the best, however I 
noticed the same situation on previous parameter dhcpOptionsNetworkList. I 
think this PR's author tried to follow that pattern. I hadn't changed its name 
yet, which name do you suggest for it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302695#comment-16302695
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594660
 
 

 ##
 File path: 
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##
 @@ -324,6 +333,17 @@ public void handleTemplateSync(DataStore store) {
 }
 }
 
+for (Iterator iter = 
allTemplates.listIterator(); iter.hasNext();) {
+VMTemplateVO child_template = iter.next();
+if (child_template.getParentTemplateId() != null) {
+String uniqueName = child_template.getUniqueName();
+if (templateInfos.containsKey(uniqueName)) {
+templateInfos.remove(uniqueName);
+}
+iter.remove();
+}
+}
+
 toBeDownloaded.addAll(allTemplates);
 
 Review comment:
   As per my understanding, only parent templates (parent_template_id = null) 
will be on allTemplates after the previous code


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302693#comment-16302693
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594636
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##
 @@ -443,6 +449,37 @@ public String getKeyboard() {
 return dhcpOptionsMap;
 }
 
+public Map getDataDiskTemplateToDiskOfferingMap() {
+if (diskOfferingId != null && dataDiskTemplateToDiskOfferingList != 
null) {
 
 Review comment:
   In that cases, method returns an empty map


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OVA files with multiple disks for templates
> ---
>
> Key: CLOUDSTACK-4757
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Storage Controller
>Reporter: Likitha Shetty
>Assignee: Nicolas Vazquez
>Priority: Minor
> Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of 
> XenServer/XCP and KVM hypervisors since the files used for templates and 
> volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates 
> are in OVA format, which are archives that can contain a complete VM 
> including multiple VMDKs and other files such as ISOs. And currently, 
> Cloudstack only supports Template creation based on OVA files containing a 
> single disk. If a user creates a template from a OVA file containing more 
> than 1 disk and launches an instance using this template, only the first disk 
> is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains 
> multiple disks to a VM will result in only one VMDK to being attached to the 
> VM.
> This behavior needs to be improved in VMWare to support OVA files with 
> multiple disks for both uploaded volumes and templates. i.e. If a user 
> creates a template from a OVA file containing more than 1 disk and launches 
> an instance using this template, the first disk should be attached to the new 
> instance as the ROOT disk and volumes should be created based on other VMDK 
> disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302691#comment-16302691
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594539
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -0,0 +1,333 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api.storage;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.transform.Transformer;
+import javax.xml.transform.TransformerException;
+import javax.xml.transform.TransformerFactory;
+import javax.xml.transform.dom.DOMSource;
+import javax.xml.transform.stream.StreamResult;
+
+import org.apache.log4j.Logger;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.NodeList;
+import org.xml.sax.SAXException;
+
+import com.cloud.agent.api.to.DatadiskTO;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+public class OVFHelper {
+private static final Logger s_logger = Logger.getLogger(OVFHelper.class);
+
+public List getOVFVolumeInfo(final String ovfFilePath) {
+if (ovfFilePath == null || ovfFilePath.isEmpty()) {
+return null;
+}
+ArrayList vf = new ArrayList();
+ArrayList vd = new ArrayList();
+
+File ovfFile = new File(ovfFilePath);
+try {
+final Document doc = 
DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new 
File(ovfFilePath));
+NodeList disks = doc.getElementsByTagName("Disk");
+NodeList files = doc.getElementsByTagName("File");
+NodeList items = doc.getElementsByTagName("Item");
+boolean toggle = true;
+for (int j = 0; j < files.getLength(); j++) {
+Element file = (Element)files.item(j);
+OVFFile of = new OVFFile();
+of._href = file.getAttribute("ovf:href");
+if (of._href.endsWith("vmdk") || of._href.endsWith("iso")) {
+s_logger.info("MDOVA getOVFVolumeInfo File href = " + 
of._href);
+of._id = file.getAttribute("ovf:id");
+s_logger.info("MDOVA getOVFVolumeInfo File Id = " + 
of._id);
+String size = file.getAttribute("ovf:size");
+if (size != null && !size.isEmpty()) {
+of._size = Long.parseLong(size);
+} else {
+String dataDiskPath = ovfFile.getParent() + 
File.separator + of._href;
+File this_file = new File(dataDiskPath);
+of._size = this_file.length();
+}
+of._iso = of._href.endsWith("iso");
+if (toggle && !of._iso) {
+of._bootable = true;
+toggle = !toggle;
+}
+vf.add(of);
+}
+}
+for (int i = 0; i < disks.getLength(); i++) {
+Element disk = (Element)disks.item(i);
+OVFDisk od = new OVFDisk();
+String virtualSize = disk.getAttribute("ovf:capacity");
+if (virtualSize == null || virtualSize.isEmpty()) {
+od._capacity = 0L;
+} else {
+od._capacity = Long.parseLong(virtualSize);
+}
+String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
+od._diskId = disk.getAttribute("ovf:diskId");
+s_logger.info("MDOVA getOVFVolumeInfo Disk ovf:diskId  = " + 
od._diskId);
+od._fileRef = disk.getAttribute("ovf:fileRef");
+

[jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302690#comment-16302690
 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:


nvazquez commented on a change in pull request #2146: CLOUDSTACK-4757: Support 
OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158594468
 
 

 ##
 File path: api/src/com/cloud/agent/api/storage/OVFHelper.java
 ##
 @@ -0,0 +1,333 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api.storage;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+import javax.xml.transform.Transformer;
+import javax.xml.transform.TransformerException;
+import javax.xml.transform.TransformerFactory;
+import javax.xml.transform.dom.DOMSource;
+import javax.xml.transform.stream.StreamResult;
+
+import org.apache.log4j.Logger;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.NodeList;
+import org.xml.sax.SAXException;
+
+import com.cloud.agent.api.to.DatadiskTO;
+import com.cloud.utils.exception.CloudRuntimeException;
+
+public class OVFHelper {
+private static final Logger s_logger = Logger.getLogger(OVFHelper.class);
+
+public List getOVFVolumeInfo(final String ovfFilePath) {
+if (ovfFilePath == null || ovfFilePath.isEmpty()) {
+return null;
+}
+ArrayList vf = new ArrayList();
+ArrayList vd = new ArrayList();
+
+File ovfFile = new File(ovfFilePath);
+try {
+final Document doc = 
DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new 
File(ovfFilePath));
+NodeList disks = doc.getElementsByTagName("Disk");
+NodeList files = doc.getElementsByTagName("File");
+NodeList items = doc.getElementsByTagName("Item");
+boolean toggle = true;
+for (int j = 0; j < files.getLength(); j++) {
+Element file = (Element)files.item(j);
+OVFFile of = new OVFFile();
+of._href = file.getAttribute("ovf:href");
+if (of._href.endsWith("vmdk") || of._href.endsWith("iso")) {
+s_logger.info("MDOVA getOVFVolumeInfo File href = " + 
of._href);
+of._id = file.getAttribute("ovf:id");
+s_logger.info("MDOVA getOVFVolumeInfo File Id = " + 
of._id);
+String size = file.getAttribute("ovf:size");
+if (size != null && !size.isEmpty()) {
+of._size = Long.parseLong(size);
+} else {
+String dataDiskPath = ovfFile.getParent() + 
File.separator + of._href;
+File this_file = new File(dataDiskPath);
+of._size = this_file.length();
+}
+of._iso = of._href.endsWith("iso");
+if (toggle && !of._iso) {
+of._bootable = true;
+toggle = !toggle;
+}
+vf.add(of);
+}
+}
+for (int i = 0; i < disks.getLength(); i++) {
+Element disk = (Element)disks.item(i);
+OVFDisk od = new OVFDisk();
+String virtualSize = disk.getAttribute("ovf:capacity");
+if (virtualSize == null || virtualSize.isEmpty()) {
+od._capacity = 0L;
+} else {
+od._capacity = Long.parseLong(virtualSize);
+}
+String allocationUnits = 
disk.getAttribute("ovf:capacityAllocationUnits");
+od._diskId = disk.getAttribute("ovf:diskId");
+s_logger.info("MDOVA getOVFVolumeInfo Disk ovf:diskId  = " + 
od._diskId);
+od._fileRef = disk.getAttribute("ovf:fileRef");
+