[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875877#comment-15875877 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 50147a4208f5047a6ec69239b5c8099082523eb5 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50147a4 ] Merge pull request #1882 from Accelerite/CLOUDSTACK-8737_CodeCleanup CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. * pr/1882: CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. Signed-off-by: Rajani Karuturi> Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875881#comment-15875881 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1882 > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875879#comment-15875879 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 50147a4208f5047a6ec69239b5c8099082523eb5 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50147a4 ] Merge pull request #1882 from Accelerite/CLOUDSTACK-8737_CodeCleanup CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. * pr/1882: CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. Signed-off-by: Rajani Karuturi> Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875878#comment-15875878 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 50147a4208f5047a6ec69239b5c8099082523eb5 in cloudstack's branch refs/heads/master from [~rajanik] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=50147a4 ] Merge pull request #1882 from Accelerite/CLOUDSTACK-8737_CodeCleanup CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. * pr/1882: CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. Signed-off-by: Rajani Karuturi> Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875872#comment-15875872 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 0f35241aade597be8114afff74a0b2de0b91560d in cloudstack's branch refs/heads/master from [~sureshkumar.anaparti] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0f35241 ] CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875415#comment-15875415 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1882 ### ACS CI BVT Run **Sumarry:** Build Number 367 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_non_contigiousvlan.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875225#comment-15875225 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1882 ### ACS CI BVT Run **Sumarry:** Build Number 366 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failed **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865435#comment-15865435 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1882 unused class is removed. needs BVT > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787537#comment-15787537 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1882 Code changes LGTM > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15787379#comment-15787379 ] ASF GitHub Bot commented on CLOUDSTACK-8737: GitHub user sureshanaparti opened a pull request: https://github.com/apache/cloudstack/pull/1882 CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8737_CodeCleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1882.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1882 commit bda20dec181b490fc0d2e0712fb72fb0608699df Author: Suresh Kumar AnapartiDate: 2016-12-30T10:08:08Z CLOUDSTACK-8737: Removed the missed out-of-band VR reboot code, not required based on persistent VR changes. > Remove out-of-band VR reboot code based on persistent VR configuration changes > -- > > Key: CLOUDSTACK-8737 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.6.0 >Reporter: Koushik Das >Assignee: Koushik Das > Fix For: 4.6.0 > > > VR reboot was required to reprogram rules in case it was stopped and started > outside of CS. With persistent VR configuration changes (added in 4.6) the > rules are persisted across a stop-start of VR. So no need to do VR reboot. > Refer to the following discussion on dev list. > http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699290#comment-14699290 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131756869 LGTM. one note of worry though. removing the configuration item is arguably a backwards incompatible change to the interface. I don't object to it, as stated by the first acronym used in this message. Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699308#comment-14699308 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 479733f9feb10e1660fe3262a511c838ca0d0212 in cloudstack's branch refs/heads/master from [~remibergsma] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=479733f ] Merge pull request #701 from koushik-das/CLOUDSTACK-8737 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev list (http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e) * pr/701: CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Signed-off-by: Remi Bergsma git...@remi.nl Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699311#comment-14699311 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/701 Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699307#comment-14699307 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit f2f29525aed3fa21d5f6b3c3d9399b8df70467f3 in cloudstack's branch refs/heads/master from [~koushikd] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f2f2952 ] CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699309#comment-14699309 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 479733f9feb10e1660fe3262a511c838ca0d0212 in cloudstack's branch refs/heads/master from [~remibergsma] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=479733f ] Merge pull request #701 from koushik-das/CLOUDSTACK-8737 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev list (http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e) * pr/701: CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Signed-off-by: Remi Bergsma git...@remi.nl Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699301#comment-14699301 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131761320 Thanks for picking this up @koushik-das LGTM @DaanHoogland I see your point, but the alternative is a setting that does nothing. I think that is worse. We can solve it by adding this to the release notes. Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699248#comment-14699248 ] ASF GitHub Bot commented on CLOUDSTACK-8737: GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/701 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persisten… …t VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev list (http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e) You can merge this pull request into a Git repository by running: $ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-8737 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/701.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #701 commit f2f29525aed3fa21d5f6b3c3d9399b8df70467f3 Author: Koushik Das kous...@apache.org Date: 2015-08-17T09:19:32Z CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699310#comment-14699310 ] ASF subversion and git services commented on CLOUDSTACK-8737: - Commit 479733f9feb10e1660fe3262a511c838ca0d0212 in cloudstack's branch refs/heads/master from [~remibergsma] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=479733f ] Merge pull request #701 from koushik-das/CLOUDSTACK-8737 CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Refer to the discussion on dev list (http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e) * pr/701: CLOUDSTACK-8737: Remove out-of-band VR reboot code based on persistent VR configuration changes Removed out-of-band VR reboot code Signed-off-by: Remi Bergsma git...@remi.nl Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-8737) Remove out-of-band VR reboot code based on persistent VR configuration changes
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699249#comment-14699249 ] ASF GitHub Bot commented on CLOUDSTACK-8737: Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/701#issuecomment-131741834 @remibergsma @DaanHoogland Please review Remove out-of-band VR reboot code based on persistent VR configuration changes -- Key: CLOUDSTACK-8737 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Management Server Affects Versions: 4.6.0 Reporter: Koushik Das Assignee: Koushik Das Fix For: 4.6.0 VR reboot was required to reprogram rules in case it was stopped and started outside of CS. With persistent VR configuration changes (added in 4.6) the rules are persisted across a stop-start of VR. So no need to do VR reboot. Refer to the following discussion on dev list. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%3cac13e3c1-3719-4b48-a35d-dbc4ba704...@schubergphilis.com%3e -- This message was sent by Atlassian JIRA (v6.3.4#6332)