[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731277#comment-15731277 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd this is good. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731257#comment-15731257 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 Thanks @abhinandanprateek @syed > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731258#comment-15731258 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1807 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731215#comment-15731215 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed please do a check of various snapshot functions on a upgraded setup. @rhtyd this PR can be closed. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729072#comment-15729072 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1807 @abhinandanprateek I will check this. I will start with a non-upgraded cloudstack, create snapshots, upgrade cloudstack to have #1600 and then try to delete older snapshots. From the code it looks like it should delete irrespective of weather the snapshot has the `vhd` extension or not (see [here] (https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java#L1546) ) because it does a wildcard delete of the directory before. Are you sure that delete will break? Can you point out where this might happen? > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728374#comment-15728374 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed @swill @rhtyd @serg38 I think i missed some updates. This PR will only break the original PR. The patch suggested by @serg38 looks good. @syed in a upgraded setup, I think removal of a older snapshot will fail for one, as these donot have a .vhd extension. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728324#comment-15728324 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed @swill the change is good. What needs to be considered is what happens with old snapshots, from a older version upgraded to this version, that are without the .vhd extension. If it can be checked that in a upgraded version where the older snapshots are without .vhd extension and new ones with .vhd extension, that cloudstack operations will work fine. Otherwise during upgrade we need to add .vhd to older snapshots for Xen. Another thing is that the marvin tests still assume that there is no .vhd extension and adds it. This needs to be fixed. We were seeing some marvin test fail on Xenserver due to a additonal .vhd extension. Look at the test_01_snapshot_root_disk failure for Xen in this PR for example: https://github.com/apache/cloudstack/pull/1754 and the cause that @serg38 pointed out. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726548#comment-15726548 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd If you merge this you will break #1600. We may want to do some more testing on the upgrade path, but I believe @syed has done some testing of the upgrade path. Maybe we can put together a list of items to test for the upgrade path so we can confirm that this revert is not needed. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726429#comment-15726429 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed Thanks, so just to confirm... with this PR, is your work with #1600 works and is not broken? > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726426#comment-15726426 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 @serg38 I think we can do that, but will be also need some tooling to rename the actual files on the SRs? /cc @abhinandanprateek > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726071#comment-15726071 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed @rhtyd @abhinandanprateek Why cant we simply rename all install paths in DB for existing snapshots instead. It can be as simple as adding this query to schema upgrade path UPDATE cloud.snapshots s JOIN cloud.snapshot_store_ref ssr ON ssr.snapshot_id = s.id SET ssr.install_path = CONCAT(ssr.install_path, '.vhd') WHERE s.hypervisor_type = 'XenServer' AND RIGHT(ssr.install_path, 4) != '.vhd'; > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726039#comment-15726039 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1807 @abhinandanprateek the snapshot path is something which is internal to Cloudstack, as an end user, I would not be able to tell the difference before and after the upgrade, unless I missed something. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726033#comment-15726033 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd I understand that we want to avoid breaking upgrades. But I have upgraded my setup and I did not find any problems. I am trying to understand what will break if upgrades happen, given the fact that this change will definitely break the newer functionality that we have added. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724414#comment-15724414 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 @abhinandanprateek @syed I'm seeing known intermittent failures with vpc/vr related tests, can I get LGTM on this? thanks. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724394#comment-15724394 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed yes I assume that PR in itself is good. You need to consider the broken test and broken upgrade ,where upgrading users will have path without the extension. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724215#comment-15724215 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed can you look at this 'revert' i guess this is going to be an issue with the managed storage change that has been put in. cc @rhtyd > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722439#comment-15722439 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1807 LGTM > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721746#comment-15721746 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 @blueorangutan test centos7 xenserver-65sp1 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721747#comment-15721747 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715653#comment-15715653 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715649#comment-15715649 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 @blueorangutan test centos7 xenserver-65sp1 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715648#comment-15715648 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1807 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714436#comment-15714436 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1807 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-311 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714300#comment-15714300 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714298#comment-15714298 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 Pinging for review -- @jburwell @abhinandanprateek @borisstoyanov @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714297#comment-15714297 ] ASF GitHub Bot commented on CLOUDSTACK-9633: GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1807 CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed the snapshot file name to include a `vhd` extension. With this change, CloudStack users should not hit upgrade issues. Reference: https://github.com/apache/cloudstack/pull/1600#pullrequestreview-10955963 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack xen-vhd-extension-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1807.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1807 commit 2f24ebb7773653de9e389ca6637c47530e7eba46 Author: Rohit YadavDate: 2016-12-02T07:14:16Z CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed the snapshot file name to include a `vhd` extension. With this change, CloudStack users should not hit upgrade issues. Signed-off-by: Rohit Yadav > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714186#comment-15714186 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1800 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714181#comment-15714181 ] ASF subversion and git services commented on CLOUDSTACK-9633: - Commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 in cloudstack's branch refs/heads/master from [~bstoyanov] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f1fd325 ] CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py Signed-off-by: Rohit Yadav> test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714183#comment-15714183 ] ASF subversion and git services commented on CLOUDSTACK-9633: - Commit cc73f17a75ceab4c30c7c9ee1475043061e72445 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cc73f17 ] Merge pull request #1800 from shapeblue/4.8-marvin-fix-for-snapshots-xenserver CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py * pr/1800: CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py Signed-off-by: Rohit Yadav> test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714182#comment-15714182 ] ASF subversion and git services commented on CLOUDSTACK-9633: - Commit cc73f17a75ceab4c30c7c9ee1475043061e72445 in cloudstack's branch refs/heads/master from [~rohit.ya...@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cc73f17 ] Merge pull request #1800 from shapeblue/4.8-marvin-fix-for-snapshots-xenserver CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py * pr/1800: CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py Signed-off-by: Rohit Yadav> test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714176#comment-15714176 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 Thanks @syed I'll go ahead and merge this, as the changes confirm. I'm okay that moving (4.10+) fwd we've `.vhd` extension in snapshot files. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712423#comment-15712423 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1800 Thanks, @rhtyd I've been trying to get test_snapshots.py to fail in my environment, but haven't been able to. I'll let @syed answer your question, Rohit, since that is a change he put in. If we do need/want to change that, let's do it in #1749 as I have that PR open to fix a couple issues I found with regards to snapshots on managed storage (specifically with regards to storing them on secondary storage, if that option is passed into the command). > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711773#comment-15711773 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @mike-tutkowski @nvazquez @syed ping, it seems there were some changes on master due to which snapshot file names on xenserver now have `.vhd` extension which was not seen in 4.8, 4.9 branches. I think the snapshot file name should indeed have the extension, but I wanted to check with you if this is something that you may have introduced/wanted? Any thoughts on this? Thanks. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711764#comment-15711764 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-298 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711750#comment-15711750 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 LGTM, we found the issue happens only in master branch (ref #1754). The fix is applicable only on master, the PR's base branch has been fixed and test has been verified manually by @borisstoyanov . > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711674#comment-15711674 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711547#comment-15711547 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711545#comment-15711545 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan test centos7 xenserver-65sp1 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711544#comment-15711544 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-296 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.10.0.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.10.0.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711430#comment-15711430 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711429#comment-15711429 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711339#comment-15711339 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-295 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711335#comment-15711335 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711331#comment-15711331 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711312#comment-15711312 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-294 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711304#comment-15711304 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 I guess that needs to go only in 4.10 then @rhtyd > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711265#comment-15711265 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd I've spend some time and found out what was wrong with the test_01_snapshot_root_disk the issue come from the way snapshot name has been stored in the DB: - in 4.8: snapshots/2/7/84ab1c82-13e9-44cb-8978-bc4c8c38f78f - in 4.10: snapshots/89/188/dc59f069-752e-4fb3-bcdf-2dfa15b31674.vhd so this is why we're experiencing the failure at the first place with 4.10 I'm building a 4.9 env now to check this there as well. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711190#comment-15711190 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711192#comment-15711192 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710905#comment-15710905 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov can you have a look at failure in `test_01_snapshot_root_disk`? @jburwell Jenkins is not reliable, with my latest fix Travis will do noredist build checks and RAT-license checks, which is what Jenkins was doing. As long as Travis is green, we can accept the PRs now on 4.9+ branches. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709862#comment-15709862 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Trillian test result (tid-509) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33518 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1800-t509-xenserver-65sp1.zip Test completed. 40 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 504.06 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1342.50 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 517.75 | test_vpc_redundant.py test_01_snapshot_root_disk | `Failure` | 27.27 | test_snapshots.py test_router_dhcp_opts | `Failure` | 21.96 | test_router_dhcphosts.py test_01_vpc_site2site_vpn | Success | 318.25 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 142.09 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 540.15 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 333.11 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 686.85 | test_vpc_router_nics.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 819.09 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 1014.05 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 20.79 | test_volumes.py test_08_resize_volume | Success | 106.57 | test_volumes.py test_07_resize_fail | Success | 111.50 | test_volumes.py test_06_download_detached_volume | Success | 30.48 | test_volumes.py test_05_detach_volume | Success | 105.41 | test_volumes.py test_04_delete_attached_volume | Success | 15.40 | test_volumes.py test_03_download_attached_volume | Success | 20.43 | test_volumes.py test_02_attach_volume | Success | 20.97 | test_volumes.py test_01_create_volume | Success | 393.48 | test_volumes.py test_03_delete_vm_snapshots | Success | 280.31 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 186.63 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 137.33 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 295.38 | test_vm_life_cycle.py test_deploy_vm | Success | 0.05 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.07 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 42.10 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py test_08_migrate_vm | Success | 66.41 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.18 | test_vm_life_cycle.py test_03_reboot_vm | Success | 10.33 | test_vm_life_cycle.py test_02_start_vm | Success | 15.31 | test_vm_life_cycle.py test_01_stop_vm | Success | 30.36 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 151.83 | test_templates.py test_08_list_system_templates | Success | 0.05 | test_templates.py test_07_list_public_templates | Success | 0.05 | test_templates.py test_05_template_permissions | Success | 0.09 | test_templates.py test_04_extract_template | Success | 5.24 | test_templates.py test_03_delete_template | Success | 5.14 | test_templates.py test_02_edit_template | Success | 90.09 | test_templates.py test_01_create_template | Success | 91.15 | test_templates.py test_10_destroy_cpvm | Success | 232.00 | test_ssvm.py test_09_destroy_ssvm | Success | 199.28 | test_ssvm.py test_08_reboot_cpvm | Success | 181.95 | test_ssvm.py test_07_reboot_ssvm | Success | 154.18 | test_ssvm.py test_06_stop_cpvm | Success | 141.85 | test_ssvm.py test_05_stop_ssvm | Success | 144.23 | test_ssvm.py test_04_cpvm_internals | Success | 1.24 | test_ssvm.py test_03_ssvm_internals | Success | 3.88 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.16 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py test_04_change_offering_small | Success | 64.15 | test_service_offerings.py test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py test_01_create_service_offering | Success | 0.09 | test_service_offerings.py test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.21 | test_secondary_storage.py test_01_scale_vm | Success | 5.37 | test_scale_vm.py test_09_reboot_router | Success | 80.90 |
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709526#comment-15709526 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov there is a Jenkins failure, but the results page returns a 404. Could you please re-push this PR to re-trigger the Jenkins/Travis run by running `git commit --amend --no-edit && git push -f`? > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708435#comment-15708435 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708434#comment-15708434 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan test centos7 xenserver-65sp1 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708431#comment-15708431 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-287 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708403#comment-15708403 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-286 > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708275#comment-15708275 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708270#comment-15708270 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 LGTM. @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708251#comment-15708251 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1800 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708250#comment-15708250 ] ASF GitHub Bot commented on CLOUDSTACK-9633: Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1800 @blueorangutan package > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 > Environment: https://github.com/apache/cloudstack/pull/1800 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9633) test_snapshot is failing due to incorrect string construction in utils.py
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708094#comment-15708094 ] ASF GitHub Bot commented on CLOUDSTACK-9633: GitHub user borisstoyanov opened a pull request: https://github.com/apache/cloudstack/pull/1800 CLOUDSTACK-9633:test_snapshot is failing due to incorrect string cons… …truction in utils.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.8-marvin-fix-for-snapshots-xenserver Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1800.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1800 commit dfae673e7fae02ccb9d3b8a5d7d0fb202f4d6d1d Author: BorisDate: 2016-11-30T09:38:12Z CLOUDSTACK-9633:test_snapshot is failing due to incorrect string construction in utils.py > test_snapshot is failing due to incorrect string construction in utils.py > - > > Key: CLOUDSTACK-9633 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9633 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: marvin >Affects Versions: 4.1.0, 4.8.0, 4.9.0 >Reporter: Boris Stoyanov > Fix For: 4.8.1, 4.10.0.0, 4.9.2.0 > > > When searching for the snapshot vhd on the nfs storage it adds > ([name].vhd.vhd) I've removed the extension for xenserver and it passed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)