[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979981#comment-15979981 ] ASF subversion and git services commented on CLOUDSTACK-9748: - Commit 6f168c8e1610d82719f1c4d8265fdf0bba6adaf5 in cloudstack's branch refs/heads/master from [~rajanik] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6f168c8 ] Merge pull request #1957 from Accelerite/CLOUDSTACK-9748 CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979979#comment-15979979 ] ASF subversion and git services commented on CLOUDSTACK-9748: - Commit 6f168c8e1610d82719f1c4d8265fdf0bba6adaf5 in cloudstack's branch refs/heads/master from [~rajanik] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=6f168c8 ] Merge pull request #1957 from Accelerite/CLOUDSTACK-9748 CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979976#comment-15979976 ] ASF subversion and git services commented on CLOUDSTACK-9748: - Commit 61823c24f658eb0fe3f1246e61d4a6b9f308cb00 in cloudstack's branch refs/heads/master from [~ashadeepad] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=61823c2 ] CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889663#comment-15889663 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1957 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-549 > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889617#comment-15889617 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889615#comment-15889615 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1957 LGTM (code review). @blueorangutan package > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880636#comment-15880636
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1957
Actually, my concerns are not regarding the response. Reading the name of
the method one can for sure understand what it returns. My concern is that
reading the parameter name `keyword` I really have no clue that this keyword is
part of a username. The `keyword` could be used to list users of domains that
may match it; the same can be applied for projects. Did you understand what I
mean?
I was trying to discuss if we could find a better way to document it. As
you also checked, there are other methods that this situation happens. However,
I really do not believe this is a good standard to follow.
Would not something like the following work as well?
```
...
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), Op.IN);
sb.and().op("username", sb.entity().getUsername(),
SearchCriteria.Op.EQ).or("username", "%" + sb.entity().getUsername() + "%" ,
SearchCriteria.Op.LIKE);
...
```
> VPN Users search functionality broken
> -
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879993#comment-15879993 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : Regarding that force commit, will surely keep that in mind in future. About keyword documentation, I had gone through several cloudstack apis (E.g. https://cloudstack.apache.org/api/apidocs-4.9/apis/listVirtualMachines.html, https://cloudstack.apache.org/api/apidocs-4.9/apis/listNetworks.html, https://cloudstack.apache.org/api/apidocs-4.9/apis/listZones.html, etc) , similar thing are being used. I do agree what you are suggesting. However, IMO, the API name "listVpnUser" gives an idea about the response we will get, i.e. listing the vpn user using a search keyword. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878410#comment-15878410 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1957 @Ashadeepa thanks for the information. As a tip, try to avoid opening duplicated PRs, it gets hard for reviewers to track changes and discussions. As @ustcweizhou suggested, you could have used a push force to push the new changes to the old PR branch. I think @syed has asked you before; what is this `keyword` parameter? The docs are not clear about it; it just says “List by keyword”. This property comes from `org.apache.cloudstack.api.BaseListCmd`. This parameter was not been used before here; so I am assuming you are repurposing it, or at least giving a use to a property that was already there. Looking at the code, I am I see that you use the keyword value to list any username that matches it. My question is the following: is there a way to document this use case? Otherwise, only a hand full of people will know its use. I have to tell you, reading the docs (https://cloudstack.apache.org/api/apidocs-4.9/apis/listVpnUsers.html), I would never try to use the `keyword` parameter as a filter to list all users that may match a given string. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877727#comment-15877727 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1957 LGTM on the code changes. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877660#comment-15877660 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1957 tested. LGTM btw, you can use "git push --force" to overwrite the code > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877515#comment-15877515 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877517#comment-15877517 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : This is due to the change in my remote urls. Closing the old PR https://github.com/apache/cloudstack/issues/1910. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876488#comment-15876488 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1957 @Ashadeepa why do we have 2 PRs for the same problem? It seems that one of them can be closed. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876079#comment-15876079
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
Github user Ashadeepa commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1957#discussion_r10411
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -621,6 +627,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sc.setParameters("username", username);
}
+if (keyword!= null) {
--- End diff --
@ustcweizhou : My bad. Amended the changes . Thanks.
> VPN Users search functionality broken
> -
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876047#comment-15876047 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @ustcweizhou : My bad. Amended the changes . Thanks. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875988#comment-15875988
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1957#discussion_r102209429
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -621,6 +627,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
sc.setParameters("username", username);
}
+if (keyword!= null) {
--- End diff --
it seems line 630 to 633 are not needed
> VPN Users search functionality broken
> -
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875947#comment-15875947 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Thanks. I have made the changes. New PR : https://github.com/apache/cloudstack/pull/1957. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875946#comment-15875946 ] ASF GitHub Bot commented on CLOUDSTACK-9748: GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1957 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search. Fixed the same. Parent PR : https://github.com/apache/cloudstack/pull/1910 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1957.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1957 commit 588ececd045c9175b33647375fd702e3e37f2126 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869828#comment-15869828
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1910
@Ashadeepa your comments in previous comment is not what I expect.
In my opinion, if username and keyword are both set, we should search by
both condition, but only one.
You might missed the line in your testing.
```
sb.and("keyword", sb.entity().getUsername(),
SearchCriteria.Op.LIKE);
```
it works fine in my testing.
> VPN Users search functionality broken
> -
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869796#comment-15869796 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Hi, I had tested the same and added my test results in the file TestResults_CLOUDSTACK-9748.txt. As per my previous comment, when both username & keyword are set, users with username like 'keyword' will be the expected result. Also, your suggested won't work as "keyword" in absent in the VPNUserVO class as there is no such column named as keyword. I tried it, got an exception. > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869789#comment-15869789 ] ASF GitHub Bot commented on CLOUDSTACK-9748: GitHub user Ashadeepa reopened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search. Fixed the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Ashadeepa/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1910.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1910 commit 0752ff667db09eeb3276627baef009eb414abaf4 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869788#comment-15869788 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869787#comment-15869787 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910   [TestResults_CLOUDSTACK-9748.txt](https://github.com/apache/cloudstack/files/779944/TestResults_CLOUDSTACK-9748.txt) > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869542#comment-15869542
]
ASF GitHub Bot commented on CLOUDSTACK-9748:
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1910
@Ashadeepa I just tested it. It seems it is not working as I expected if
username and keyword are both set.
I suggest to use the following
```
sb.and("username", sb.entity().getUsername(), SearchCriteria.Op.EQ);
sb.and("keyword", sb.entity().getUsername(),
SearchCriteria.Op.LIKE);
...
if (keyword!= null) {
sc.setParameters("keyword", "%" + keyword + "%");
}
```
> VPN Users search functionality broken
> -
>
> Key: CLOUDSTACK-9748
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
>Reporter: Ashadeepa Debnath
>
> VPN Users search functionality broken
> If you try to search VPN users with it’s user name, you will not be able to
> search.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869448#comment-15869448 ] ASF GitHub Bot commented on CLOUDSTACK-9748: Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1910 Code changes looks good. LGTM > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827739#comment-15827739 ] rashmidixit commented on CLOUDSTACK-9748: - GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with itâs user name, you will not be able to search. Fixed the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Ashadeepa/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1910.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1910 commit 0752ff667db09eeb3276627baef009eb414abaf4 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CLOUDSTACK-9748) VPN Users search functionality broken
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827737#comment-15827737 ] ASF GitHub Bot commented on CLOUDSTACK-9748: GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search. Fixed the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Ashadeepa/cloudstack CLOUDSTACK-9748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1910.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1910 commit 0752ff667db09eeb3276627baef009eb414abaf4 Author: root Date: 2017-01-17T18:09:17Z CLOUDSTACK-9748:VPN Users search functionality broken > VPN Users search functionality broken > - > > Key: CLOUDSTACK-9748 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9748 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Ashadeepa Debnath > > VPN Users search functionality broken > If you try to search VPN users with it’s user name, you will not be able to > search. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
