[jira] [Commented] (LANG-942) Test failure in FastDateParserTest and FastDateFormat_ParserTest when building with JDK8
[
https://issues.apache.org/jira/browse/LANG-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862274#comment-13862274
]
Joerg Schaible commented on LANG-942:
-
Hi,
I did not had a look at the code, but you mentioned that theres a map
containing the long names as well as the short names as key. Well, the short
names are unfortunately *not* unique (e.g EST - Australia/Brisbane and
America/Toronto and there are more)! Therefore they cannot be used as keys in a
map anyway.
Test failure in FastDateParserTest and FastDateFormat_ParserTest when
building with JDK8
Key: LANG-942
URL: https://issues.apache.org/jira/browse/LANG-942
Project: Commons Lang
Issue Type: Sub-task
Components: lang.time.*
Affects Versions: 3.2
Environment: JDK8
Reporter: Benedikt Ritter
Fix For: 3.2.1
The following failure is thrown when using JDK 8:
{code}
---
Test set: org.apache.commons.lang3.time.FastDateFormat_ParserTest
---
Tests run: 29, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.315 sec
FAILURE! - in org.apache.commons.lang3.time.FastDateFormat_ParserTest
testParseZone(org.apache.commons.lang3.time.FastDateFormat_ParserTest) Time
elapsed: 0.005 sec FAILURE!
java.lang.AssertionError: expected:Thu Jul 10 22:33:20 CEST 2003 but
was:Thu Jul 10 23:33:20 CEST 2003
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.commons.lang3.time.FastDateParserTest.testParseZone(FastDateParserTest.java:119)
[...]
{code}
It is caused by the following assertion in FastDateParserTest (from which
FastDateFormat_ParserTest inherits):
{code:java}
assertEquals(cal.getTime(), fdf.parse(2003-07-10T16:33:20.000 Eastern
Daylight Time));
{code}
{{FastDateParserTest}} fails with the same error.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (LANG-942) Test failure in FastDateParserTest and FastDateFormat_ParserTest when building with JDK8
[
https://issues.apache.org/jira/browse/LANG-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862369#comment-13862369
]
Benedikt Ritter commented on LANG-942:
--
{quote}
Right now, the easiest way to fix it would be removing the EDT and Eastern
Daylight Time from the tests. However, that would leave parts of the code
without test coverage (the code does different things for time zones that start
with - or +, time zones that start with GMT, and all the other time zones).
{quote}
The question here is, what is the correct result? This should be expressed in
the test and the implementation has to be changed to conform to the test. What
I don't unterstand is what exactly Eastern Daylight Time is. Is it a time zone
by itself? Or is it a grouping of time zones? It looks like IET and US/Michigan
have different times, so the question appears what the expected result is, when
parsing something like:
{code}
2003-07-10T16:33:20.000 Eastern Daylight Time
{code}
{quote}
Therefore they cannot be used as keys in a map anyway.
{quote}
Yes, but the problem is: how do we map Eastern Daylight Time in a string
representation of a Date, if Eastern Daylight Time can mean several time zones.
I'd say we should do the same like {{java.util.SimpleDateFromat}} does in this
case.
Test failure in FastDateParserTest and FastDateFormat_ParserTest when
building with JDK8
Key: LANG-942
URL: https://issues.apache.org/jira/browse/LANG-942
Project: Commons Lang
Issue Type: Sub-task
Components: lang.time.*
Affects Versions: 3.2
Environment: JDK8
Reporter: Benedikt Ritter
Fix For: 3.2.1
The following failure is thrown when using JDK 8:
{code}
---
Test set: org.apache.commons.lang3.time.FastDateFormat_ParserTest
---
Tests run: 29, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.315 sec
FAILURE! - in org.apache.commons.lang3.time.FastDateFormat_ParserTest
testParseZone(org.apache.commons.lang3.time.FastDateFormat_ParserTest) Time
elapsed: 0.005 sec FAILURE!
java.lang.AssertionError: expected:Thu Jul 10 22:33:20 CEST 2003 but
was:Thu Jul 10 23:33:20 CEST 2003
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.commons.lang3.time.FastDateParserTest.testParseZone(FastDateParserTest.java:119)
[...]
{code}
It is caused by the following assertion in FastDateParserTest (from which
FastDateFormat_ParserTest inherits):
{code:java}
assertEquals(cal.getTime(), fdf.parse(2003-07-10T16:33:20.000 Eastern
Daylight Time));
{code}
{{FastDateParserTest}} fails with the same error.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (CONFIGURATION-563) Make DefaultConfigurationEngine immutable
Oliver Heger created CONFIGURATION-563:
--
Summary: Make DefaultConfigurationEngine immutable
Key: CONFIGURATION-563
URL: https://issues.apache.org/jira/browse/CONFIGURATION-563
Project: Commons Configuration
Issue Type: Improvement
Components: Expression engine
Affects Versions: 1.10
Reporter: Oliver Heger
Fix For: 2.0
Currently, {{DefaultExpressionEngine}} has set methods for a bunch of
properties representing the various symbols it supports.
It would be better if an instance could be initialized with a set of symbols
and afterwards is immutable. Then an instance of {{DefaultExpressionEngine}}
can be shared between multiple configuration instances.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (LANG-942) Test failure in FastDateParserTest and FastDateFormat_ParserTest when building with JDK8
[
https://issues.apache.org/jira/browse/LANG-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell updated LANG-942:
---
Fix Version/s: Patch Needed
Test failure in FastDateParserTest and FastDateFormat_ParserTest when
building with JDK8
Key: LANG-942
URL: https://issues.apache.org/jira/browse/LANG-942
Project: Commons Lang
Issue Type: Sub-task
Components: lang.time.*
Affects Versions: 3.2
Environment: JDK8
Reporter: Benedikt Ritter
Fix For: 3.2.1, Patch Needed
The following failure is thrown when using JDK 8:
{code}
---
Test set: org.apache.commons.lang3.time.FastDateFormat_ParserTest
---
Tests run: 29, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.315 sec
FAILURE! - in org.apache.commons.lang3.time.FastDateFormat_ParserTest
testParseZone(org.apache.commons.lang3.time.FastDateFormat_ParserTest) Time
elapsed: 0.005 sec FAILURE!
java.lang.AssertionError: expected:Thu Jul 10 22:33:20 CEST 2003 but
was:Thu Jul 10 23:33:20 CEST 2003
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.commons.lang3.time.FastDateParserTest.testParseZone(FastDateParserTest.java:119)
[...]
{code}
It is caused by the following assertion in FastDateParserTest (from which
FastDateFormat_ParserTest inherits):
{code:java}
assertEquals(cal.getTime(), fdf.parse(2003-07-10T16:33:20.000 Eastern
Daylight Time));
{code}
{{FastDateParserTest}} fails with the same error.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (LANG-939) Move Documentation from user guide to package-info files
[ https://issues.apache.org/jira/browse/LANG-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862410#comment-13862410 ] Henri Yandell commented on LANG-939: Down side of this btw is that it ties our documentation to the release. Making a change means a release roll out and only new users get the improvements. Move Documentation from user guide to package-info files Key: LANG-939 URL: https://issues.apache.org/jira/browse/LANG-939 Project: Commons Lang Issue Type: Task Components: General Affects Versions: 3.2 Reporter: Benedikt Ritter Fix For: 3.3, Patch Needed As discussed on the ML [1], the user guide on the website currently contains documentation that would better suite in the corresponding package-info files. The Documentation should be split up and moved to those files. [1] http://markmail.org/message/jgyacp3pv3t43s4h -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (LANG-939) Move Documentation from user guide to package-info files
[ https://issues.apache.org/jira/browse/LANG-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862410#comment-13862410 ] Henri Yandell edited comment on LANG-939 at 1/4/14 8:38 PM: Down side of this btw is that it ties our user guide to the release. Making a change means a release roll out and only new users get the improvements. Probably not a big issue though. was (Author: bayard): Down side of this btw is that it ties our documentation to the release. Making a change means a release roll out and only new users get the improvements. Move Documentation from user guide to package-info files Key: LANG-939 URL: https://issues.apache.org/jira/browse/LANG-939 Project: Commons Lang Issue Type: Task Components: General Affects Versions: 3.2 Reporter: Benedikt Ritter Fix For: 3.3, Patch Needed As discussed on the ML [1], the user guide on the website currently contains documentation that would better suite in the corresponding package-info files. The Documentation should be split up and moved to those files. [1] http://markmail.org/message/jgyacp3pv3t43s4h -- This message was sent by Atlassian JIRA (v6.1.5#6160)
