[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604006#comment-16604006 ] ASF GitHub Bot commented on LANG-1416: -- Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/353 In general it's hard to review gigantic change sets which have been created automatically, so I'd welcome an approach where we migrate one test case after another. > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #353: WIP: LANG-1416: Update tests to JUnit5 via @boyarsk...
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/353 In general it's hard to review gigantic change sets which have been created automatically, so I'd welcome an approach where we migrate one test case after another. ---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603967#comment-16603967 ] ASF GitHub Bot commented on LANG-1416: -- Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/353 It looks like an approach that can potentially some some work. I personally would do it by hand. There is a lot of stuff that can't be detected automatically. For example we have some tests that run for loops. Those could be converted to be parameterized. > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #353: WIP: LANG-1416: Update tests to JUnit5 via @boyarsk...
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/353 It looks like an approach that can potentially some some work. I personally would do it by hand. There is a lot of stuff that can't be detected automatically. For example we have some tests that run for loops. Those could be converted to be parameterized. ---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603825#comment-16603825 ] ASF GitHub Bot commented on LANG-1416: -- Github user smoyer64 commented on the issue: https://github.com/apache/commons-lang/pull/353 @kinow I've found several areas where I think the tool can be improved but as an example of what a head start it provides I've spent a few minutes getting all the .../builder/... tests running. The ``@Test`` annotation for the failing tests all contain an ``expect`` attribute and were fixed by wrapping the test body in an ``assertThrows`` statement. Some of the formatting changes are really unnecessary ... it seems that the tool analyzes all classes (not just those match the conventional naming patterns for tests. It also rewrites classes that have no ``@Test`` annotations at all. Jeanne presented this tool at JavaOne last year and she knew that it could be improved. Perhaps I can convince her to move it to the JUnit Pioneer project! > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #353: WIP: LANG-1416: Update tests to JUnit5 via @boyarsk...
Github user smoyer64 commented on the issue: https://github.com/apache/commons-lang/pull/353 @kinow I've found several areas where I think the tool can be improved but as an example of what a head start it provides I've spent a few minutes getting all the .../builder/... tests running. The ``@Test`` annotation for the failing tests all contain an ``expect`` attribute and were fixed by wrapping the test body in an ``assertThrows`` statement. Some of the formatting changes are really unnecessary ... it seems that the tool analyzes all classes (not just those match the conventional naming patterns for tests. It also rewrites classes that have no ``@Test`` annotations at all. Jeanne presented this tool at JavaOne last year and she knew that it could be improved. Perhaps I can convince her to move it to the JUnit Pioneer project! ---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603811#comment-16603811 ] ASF GitHub Bot commented on LANG-1416: -- Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/353 @smoyer64 it looks interesting! Still have to update some projects at work as well, so keen to investigate it later. But, do you know if there's a way to disable some formatting changes? I noticed several files have diffs consisting mainly of blank lines being removed... without those changes I think it would be much easier to review it. Thanks! > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #353: WIP: LANG-1416: Update tests to JUnit5 via @boyarsk...
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/353 @smoyer64 it looks interesting! Still have to update some projects at work as well, so keen to investigate it later. But, do you know if there's a way to disable some formatting changes? I noticed several files have diffs consisting mainly of blank lines being removed... without those changes I think it would be much easier to review it. Thanks! ---
[GitHub] commons-lang pull request #353: WIP: Update tests to JUnit5 via @boyarsky's ...
GitHub user smoyer64 opened a pull request: https://github.com/apache/commons-lang/pull/353 WIP: Update tests to JUnit5 via @boyarsky's converter This PR updates many of the commons-lang tests to JUnit5. I'm providing this PR simply to illustrate how much of the work can be done via the automated tool but this is clearly __NOT__ ready to merge. If this looks promising to the commons-lang maintainers, I'll work on fixing the portion of the tests that didn't convert properly. Better yet, if others are interested in helping with this effort and believe that the converter gives us a pretty good head start, I'd be happy to collaborate on the branch I've created. You can merge this pull request into a Git repository by running: $ git pull https://github.com/selesy/commons-lang master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #353 commit ee5b9289565649638f201c762f0857b67a8762aa Author: Steve Moyer Date: 2018-09-05T01:00:40Z Update tests to JUnit5 via @boyarsky's converter ---
[jira] [Commented] (DAEMON-390) PATH environment variable is not properly set if using LibraryPath option
[ https://issues.apache.org/jira/browse/DAEMON-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603664#comment-16603664 ] Sebb commented on DAEMON-390: - Added alternate patch which drops the unnecessary +1 and adds some comments > PATH environment variable is not properly set if using LibraryPath option > - > > Key: DAEMON-390 > URL: https://issues.apache.org/jira/browse/DAEMON-390 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.1.0 >Reporter: Robert Krzeminski >Priority: Major > Labels: easyfix, patch, windows > Attachments: apxAddToPathW-1-1-1-0.patch, utils.patch > > > The PATH environment variable is not properly set if command line option > LibraryPath is used. It shall extend the existing PATH variable with > additional directories defined as library path. In the current implementation > the wrong buffer size for the retrieved environment variable is passed during > the call to GetEnvironmentVariableW from utility function apxAddToPathW > (utils.c). Attached a patch that contains the fix for this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (DAEMON-390) PATH environment variable is not properly set if using LibraryPath option
[ https://issues.apache.org/jira/browse/DAEMON-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated DAEMON-390: Attachment: utils.patch > PATH environment variable is not properly set if using LibraryPath option > - > > Key: DAEMON-390 > URL: https://issues.apache.org/jira/browse/DAEMON-390 > Project: Commons Daemon > Issue Type: Bug > Components: Procrun >Affects Versions: 1.1.0 >Reporter: Robert Krzeminski >Priority: Major > Labels: easyfix, patch, windows > Attachments: apxAddToPathW-1-1-1-0.patch, utils.patch > > > The PATH environment variable is not properly set if command line option > LibraryPath is used. It shall extend the existing PATH variable with > additional directories defined as library path. In the current implementation > the wrong buffer size for the retrieved environment variable is passed during > the call to GetEnvironmentVariableW from utility function apxAddToPathW > (utils.c). Attached a patch that contains the fix for this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DAEMON-390) PATH environment variable is not properly set if using LibraryPath option
[
https://issues.apache.org/jira/browse/DAEMON-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603598#comment-16603598
]
Sebb commented on DAEMON-390:
-
The size of the wsAdd buffer is al + rc + 1
So I would expect the method call at line 73 to use the buffer length
{code}
al + rc +1 - al
{code}
i.e.
{code}
rc + 1
{code}
Or am I missing something here?
Note: the return from GetEnvironmentVariable is the length (excluding
terminating null) if it succeeds, and length +1 (for terminating null) if the
buffer is too short. [1]
Since the call that sets up rc uses a buffer length of 0, it will fail and thus
return the length +1, i.e. the code does not need to add + 1 at line 68.
However having done so, logically line 73 should include the + 1 in the buffer
length.
[1]
https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-getenvironmentvariable
> PATH environment variable is not properly set if using LibraryPath option
> -
>
> Key: DAEMON-390
> URL: https://issues.apache.org/jira/browse/DAEMON-390
> Project: Commons Daemon
> Issue Type: Bug
> Components: Procrun
>Affects Versions: 1.1.0
>Reporter: Robert Krzeminski
>Priority: Major
> Labels: easyfix, patch, windows
> Attachments: apxAddToPathW-1-1-1-0.patch
>
>
> The PATH environment variable is not properly set if command line option
> LibraryPath is used. It shall extend the existing PATH variable with
> additional directories defined as library path. In the current implementation
> the wrong buffer size for the retrieved environment variable is passed during
> the call to GetEnvironmentVariableW from utility function apxAddToPathW
> (utils.c). Attached a patch that contains the fix for this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] commons-lang issue #294: Added indexesOf method
Github user kedar-joshi commented on the issue:
https://github.com/apache/commons-lang/pull/294
Also, length of the `source` can be cached for better performance e.g.
```java
for (int i = 0, length = source.length(); i < length; i++)
{
if (searchKey.equals(source.charAt(i)))
{
indexList.add(i);
}
}
```
---
[GitHub] commons-lang issue #294: Added indexesOf method
Github user kedar-joshi commented on the issue:
https://github.com/apache/commons-lang/pull/294
I think the method should return an empty collection instead of `null`
```java
if(isEmpty(source) || searchKey == null ) {
return Collections.emptyList();
}
```
---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603127#comment-16603127 ] ASF GitHub Bot commented on LANG-1416: -- Github user sbrannen commented on the issue: https://github.com/apache/commons-lang/pull/352 👍 > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #352: LANG-1416: Update to JUnit 5
Github user sbrannen commented on the issue: https://github.com/apache/commons-lang/pull/352 ð ---
[jira] [Resolved] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter resolved LANG-1416. --- Resolution: Fixed Assignee: Benedikt Ritter Fixed in 6ec01a633ceaa24eb476540644460497045ef7ea > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603100#comment-16603100 ] ASF GitHub Bot commented on LANG-1416: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/352 > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang pull request #352: LANG-1416: Update to JUnit 5
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/352 ---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603053#comment-16603053 ] ASF GitHub Bot commented on LANG-1416: -- Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/352 [](https://coveralls.io/builds/18818431) Coverage decreased (-0.007%) to 95.246% when pulling **2bcf86d8af125b45d39bd1d43b8375911c551d78 on britter:LANG-1416** into **3e44d26342654c8b2d8caba924ff468dd0e6e700 on apache:master**. > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #352: LANG-1416: Update to JUnit 5
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/352 [](https://coveralls.io/builds/18818431) Coverage decreased (-0.007%) to 95.246% when pulling **2bcf86d8af125b45d39bd1d43b8375911c551d78 on britter:LANG-1416** into **3e44d26342654c8b2d8caba924ff468dd0e6e700 on apache:master**. ---
[GitHub] commons-lang pull request #352: LANG-1416: Update to JUnit 5
GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/352 LANG-1416: Update to JUnit 5 - Add dependencies required for JUnit 5 - Update one test (ValidateTest) to use the JUnit 5 test API You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-lang LANG-1416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit 83b472b754df1d4f8392490296d2467be7ce8855 Author: Benedikt Ritter Date: 2018-09-04T09:30:17Z LANG-1416: Update to JUnit 5.3.0 commit 2bcf86d8af125b45d39bd1d43b8375911c551d78 Author: Benedikt Ritter Date: 2018-09-04T09:30:39Z LANG-1416: Update ValidateTest to JUnit 5 API commit 3287f3100f5940c254130192fb442077755477f6 Author: Benedikt Ritter Date: 2018-09-04T13:07:47Z LANG-1416: Use latest Apache Maven Surefire Plugin release ---
[jira] [Commented] (LANG-1416) Update to JUnit 5
[ https://issues.apache.org/jira/browse/LANG-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603027#comment-16603027 ] ASF GitHub Bot commented on LANG-1416: -- GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/352 LANG-1416: Update to JUnit 5 - Add dependencies required for JUnit 5 - Update one test (ValidateTest) to use the JUnit 5 test API You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-lang LANG-1416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit 83b472b754df1d4f8392490296d2467be7ce8855 Author: Benedikt Ritter Date: 2018-09-04T09:30:17Z LANG-1416: Update to JUnit 5.3.0 commit 2bcf86d8af125b45d39bd1d43b8375911c551d78 Author: Benedikt Ritter Date: 2018-09-04T09:30:39Z LANG-1416: Update ValidateTest to JUnit 5 API commit 3287f3100f5940c254130192fb442077755477f6 Author: Benedikt Ritter Date: 2018-09-04T13:07:47Z LANG-1416: Use latest Apache Maven Surefire Plugin release > Update to JUnit 5 > - > > Key: LANG-1416 > URL: https://issues.apache.org/jira/browse/LANG-1416 > Project: Commons Lang > Issue Type: Task >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Once LANG-1415 is resolved we can start using the latest and greatest JUnit > version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter resolved LANG-1417. --- Resolution: Fixed Assignee: Benedikt Ritter Fixed in 3e44d26342654c8b2d8caba924ff468dd0e6e700 > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Assignee: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can add the > @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. > > Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit > vom Predicate is not possible since we have implementations that would then > inherit from both Predicate and Predicate which is not > possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602824#comment-16602824 ] ASF GitHub Bot commented on LANG-1417: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/351 > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can add the > @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. > > Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit > vom Predicate is not possible since we have implementations that would then > inherit from both Predicate and Predicate which is not > possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang pull request #351: LANG-1417: Add @FunctionalInterface to Threa...
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/351 ---
[jira] [Commented] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602823#comment-16602823 ] ASF GitHub Bot commented on LANG-1417: -- Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/351 [](https://coveralls.io/builds/18814766) Coverage remained the same at 95.253% when pulling **54f8d3c02abe04765ffe957e7d412bde2adf58c1 on britter:LANG-1417** into **3ee9cc840088762c875a9c02531077279f7c237f on apache:master**. > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can add the > @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. > > Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit > vom Predicate is not possible since we have implementations that would then > inherit from both Predicate and Predicate which is not > possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #351: LANG-1417: Add @FunctionalInterface to ThreadPredic...
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/351 [](https://coveralls.io/builds/18814766) Coverage remained the same at 95.253% when pulling **54f8d3c02abe04765ffe957e7d412bde2adf58c1 on britter:LANG-1417** into **3ee9cc840088762c875a9c02531077279f7c237f on apache:master**. ---
[jira] [Commented] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602808#comment-16602808 ] ASF GitHub Bot commented on LANG-1417: -- GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/351 LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGrou… …pPredicate You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-lang LANG-1417 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/351.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #351 commit 54f8d3c02abe04765ffe957e7d412bde2adf58c1 Author: Benedikt Ritter Date: 2018-09-04T09:16:55Z LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can add the > @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. > > Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit > vom Predicate is not possible since we have implementations that would then > inherit from both Predicate and Predicate which is not > possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang pull request #351: LANG-1417: Add @FunctionalInterface to Threa...
GitHub user britter opened a pull request: https://github.com/apache/commons-lang/pull/351 LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGrou⦠â¦pPredicate You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-lang LANG-1417 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/351.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #351 commit 54f8d3c02abe04765ffe957e7d412bde2adf58c1 Author: Benedikt Ritter Date: 2018-09-04T09:16:55Z LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate ---
[jira] [Updated] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1417: -- Description: Since we upgraded the Java language requirement to Java 8, we can add the @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit vom Predicate is not possible since we have implementations that would then inherit from both Predicate and Predicate which is not possible. was: Since we upgraded the Java language requirement to Java 8, we can deprecate our custom ThreadPredicate and ThreadGroupPredicate implementations. It looks like our initial plan to let ThreadPredicate and ThreadGroupPredicate extend java.util.function.Predicate is not possible. This is because auf AlwaysTruePredicate and NamePredicate extending both interfaces. This leads to the situation that these classes would inherit from both Predicate and Predicate, which is not possible. > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can add the > @FunctionalInterface annotation to ThreadGroupPredicate and ThreadPredicate. > > Our initial plan of letting ThreadGroupPredicate and ThreadPredicate inherit > vom Predicate is not possible since we have implementations that would then > inherit from both Predicate and Predicate which is not > possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (LANG-1417) Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedikt Ritter updated LANG-1417: -- Summary: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate (was: Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate) > Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate > > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can deprecate > our custom ThreadPredicate and ThreadGroupPredicate implementations. > It looks like our initial plan to let ThreadPredicate and > ThreadGroupPredicate extend java.util.function.Predicate is not possible. > This is because auf AlwaysTruePredicate and NamePredicate extending both > interfaces. This leads to the situation that these classes would inherit from > both Predicate and Predicate, which is not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LANG-1417) Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602795#comment-16602795 ] ASF GitHub Bot commented on LANG-1417: -- Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/349 We agreed to just add `@FunctionalInterface` to `ThreadPredicate` and `ThreadGroupPredicate` > Deprecate ThreadPredicate and ThreadGroupPredicate in favor of > java.util.function.Predicate > --- > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can deprecate > our custom ThreadPredicate and ThreadGroupPredicate implementations. > It looks like our initial plan to let ThreadPredicate and > ThreadGroupPredicate extend java.util.function.Predicate is not possible. > This is because auf AlwaysTruePredicate and NamePredicate extending both > interfaces. This leads to the situation that these classes would inherit from > both Predicate and Predicate, which is not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (LANG-1417) Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate
[ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602797#comment-16602797 ] ASF GitHub Bot commented on LANG-1417: -- Github user britter closed the pull request at: https://github.com/apache/commons-lang/pull/349 > Deprecate ThreadPredicate and ThreadGroupPredicate in favor of > java.util.function.Predicate > --- > > Key: LANG-1417 > URL: https://issues.apache.org/jira/browse/LANG-1417 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Reporter: Benedikt Ritter >Priority: Major > Fix For: 3.9 > > > Since we upgraded the Java language requirement to Java 8, we can deprecate > our custom ThreadPredicate and ThreadGroupPredicate implementations. > It looks like our initial plan to let ThreadPredicate and > ThreadGroupPredicate extend java.util.function.Predicate is not possible. > This is because auf AlwaysTruePredicate and NamePredicate extending both > interfaces. This leads to the situation that these classes would inherit from > both Predicate and Predicate, which is not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang pull request #349: LANG-1417: Deprecate ThreadPredicate and Thr...
Github user britter closed the pull request at: https://github.com/apache/commons-lang/pull/349 ---
[GitHub] commons-lang issue #349: LANG-1417: Deprecate ThreadPredicate and ThreadGrou...
Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/349 We agreed to just add `@FunctionalInterface` to `ThreadPredicate` and `ThreadGroupPredicate` ---
