[jira] [Resolved] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko resolved SCXML-284. -- Resolution: Fixed Thank you very much for the contribution, [~mureinik]! Kind regards, Woonsan > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Improvement >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Minor > Fix For: 2.0 > > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCXML-283) Upgrade testing framework to JUnit Jupiter
[ https://issues.apache.org/jira/browse/SCXML-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated SCXML-283: - Priority: Major (was: Minor) > Upgrade testing framework to JUnit Jupiter > -- > > Key: SCXML-283 > URL: https://issues.apache.org/jira/browse/SCXML-283 > Project: Commons SCXML > Issue Type: Improvement >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Major > Fix For: 2.0 > > > commons-scxml already requires Java 8, so there's nothing inhibiting the > upgrade to a modern JUnit version, and taking advantage of Jupiter's newer > features. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated SCXML-284: - Fix Version/s: 2.0 Issue Type: Improvement (was: Task) > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Improvement >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Minor > Fix For: 2.0 > > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCXML-283) Upgrade testing framework to JUnit Jupiter
[ https://issues.apache.org/jira/browse/SCXML-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated SCXML-283: - Issue Type: Improvement (was: Task) > Upgrade testing framework to JUnit Jupiter > -- > > Key: SCXML-283 > URL: https://issues.apache.org/jira/browse/SCXML-283 > Project: Commons SCXML > Issue Type: Improvement >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Minor > Fix For: 2.0 > > > commons-scxml already requires Java 8, so there's nothing inhibiting the > upgrade to a modern JUnit version, and taking advantage of Jupiter's newer > features. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645419#comment-16645419 ] ASF GitHub Bot commented on SCXML-284: -- Github user asfgit closed the pull request at: https://github.com/apache/commons-scxml/pull/4 > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Task >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Minor > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-scxml pull request #4: SCXML-284 Clean up exception handling in test...
Github user asfgit closed the pull request at: https://github.com/apache/commons-scxml/pull/4 ---
[jira] [Updated] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated SCXML-284: - Assignee: Woonsan Ko > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Task >Reporter: Allon Mureinik >Assignee: Woonsan Ko >Priority: Minor > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allon Mureinik updated SCXML-284: - Flags: Patch > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Task >Reporter: Allon Mureinik >Priority: Minor > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCXML-284) Clear up exception handling in tests
[ https://issues.apache.org/jira/browse/SCXML-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645388#comment-16645388 ] ASF GitHub Bot commented on SCXML-284: -- GitHub user mureinik opened a pull request: https://github.com/apache/commons-scxml/pull/4 SCXML-284 Clean up exception handling in tests This PR cleans up the handling of exceptions in the test code: 1. The cumbersome idiom of `try`-`catch` with a `fail` call in the `try` block and additional assertions in the `catch` block were replaced with Jupiter's elegant `Assertions#assertThrows` call. 2. Redudant `throws` clauses were removed 3. `Issue112Test#test01issue112`'s code was cleaned up so it actually fails if an exception is thrown instead of catching it and printing it to `System.err`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mureinik/commons-scxml test-exceptions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-scxml/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit a59d8f1b4504e30b36c7a22ef2e087cbd98a7553 Author: Allon Mureinik Date: 2018-10-10T16:38:30Z SCXML-284 Issue112Test#test01issue112 catch In case an event can't be fired, something is wrong, and the test should fail, not catch and ignore the exception. commit 6c5932ac952a1b3d335fa7217f3b54799321dd95 Author: Allon Mureinik Date: 2018-10-10T16:45:44Z SCXML-284 Replace try-catch with assertThrows Use JUnit Jupiter's new mechanism of assertThrows instead of try-catch blocks in order to clean up the code and make it easier to follow. Since the questionable piece of code is now run inside a lambda and is caught by asserThrows itself, there's no need to declare these exceptions in the throws clause of the mehod declarations, and they were cleaned up to avoid adding compiler warnings. commit b2b670f8b8e0ff1a673d692be2ea38cb5fc54e66 Author: Allon Mureinik Date: 2018-10-10T16:50:17Z SCXML-284 Remove redundant throws declarations in tests > Clear up exception handling in tests > > > Key: SCXML-284 > URL: https://issues.apache.org/jira/browse/SCXML-284 > Project: Commons SCXML > Issue Type: Task >Reporter: Allon Mureinik >Priority: Minor > > Following SCXML-283, JUnit Jupiter provides some tools to handle exception > testing in a more elegant way than catching an exception and asserting its > properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-scxml pull request #4: SCXML-284 Clean up exception handling in test...
GitHub user mureinik opened a pull request: https://github.com/apache/commons-scxml/pull/4 SCXML-284 Clean up exception handling in tests This PR cleans up the handling of exceptions in the test code: 1. The cumbersome idiom of `try`-`catch` with a `fail` call in the `try` block and additional assertions in the `catch` block were replaced with Jupiter's elegant `Assertions#assertThrows` call. 2. Redudant `throws` clauses were removed 3. `Issue112Test#test01issue112`'s code was cleaned up so it actually fails if an exception is thrown instead of catching it and printing it to `System.err`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mureinik/commons-scxml test-exceptions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-scxml/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit a59d8f1b4504e30b36c7a22ef2e087cbd98a7553 Author: Allon Mureinik Date: 2018-10-10T16:38:30Z SCXML-284 Issue112Test#test01issue112 catch In case an event can't be fired, something is wrong, and the test should fail, not catch and ignore the exception. commit 6c5932ac952a1b3d335fa7217f3b54799321dd95 Author: Allon Mureinik Date: 2018-10-10T16:45:44Z SCXML-284 Replace try-catch with assertThrows Use JUnit Jupiter's new mechanism of assertThrows instead of try-catch blocks in order to clean up the code and make it easier to follow. Since the questionable piece of code is now run inside a lambda and is caught by asserThrows itself, there's no need to declare these exceptions in the throws clause of the mehod declarations, and they were cleaned up to avoid adding compiler warnings. commit b2b670f8b8e0ff1a673d692be2ea38cb5fc54e66 Author: Allon Mureinik Date: 2018-10-10T16:50:17Z SCXML-284 Remove redundant throws declarations in tests ---
[jira] [Created] (SCXML-284) Clear up exception handling in tests
Allon Mureinik created SCXML-284: Summary: Clear up exception handling in tests Key: SCXML-284 URL: https://issues.apache.org/jira/browse/SCXML-284 Project: Commons SCXML Issue Type: Task Reporter: Allon Mureinik Following SCXML-283, JUnit Jupiter provides some tools to handle exception testing in a more elegant way than catching an exception and asserting its properties in that block -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (EMAIL-182) Apache email forwarding not working
Rafael Novello created EMAIL-182: Summary: Apache email forwarding not working Key: EMAIL-182 URL: https://issues.apache.org/jira/browse/EMAIL-182 Project: Commons Email Issue Type: Bug Reporter: Rafael Novello Hi guys! I would like to ask your help because my email @[apache.org|http://apache.org/] aren't sending any message to my personal email (rafa.reis.nove...@gmail.com). I need it to access the Slack and other platforms. I tried to use the [https://id.apache.org/reset/enter] facility but I don't receive the message. My SVN id is rafaelnovello as listed here: http://people.apache.org/committer-index.html Could you help with it please? Thanks a lot! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/374 Thanks! ð ---
[GitHub] commons-lang pull request #374: Update time tests to JUnit Jupiter
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/374 ---
[GitHub] commons-lang issue #374: Update time tests to JUnit Jupiter
Github user mureinik commented on the issue: https://github.com/apache/commons-lang/pull/374 Updated the patch to fix the scoping issue in `pom.xml` @PascalSchumacher commented about. ---
[GitHub] commons-lang pull request #374: Update time tests to JUnit Jupiter
Github user mureinik commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/374#discussion_r224144394 --- Diff: pom.xml --- @@ -543,6 +543,11 @@ junit-vintage-engine test + + org.junit-pioneer + junit-pioneer + 0.2.0 --- End diff -- Good catch, thanks. ---
[GitHub] commons-lang pull request #374: Update time tests to JUnit Jupiter
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/374#discussion_r224137193 --- Diff: pom.xml --- @@ -543,6 +543,11 @@ junit-vintage-engine test + + org.junit-pioneer + junit-pioneer + 0.2.0 --- End diff -- This dependency should have `test` scope. ---
[jira] [Comment Edited] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction
[
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644898#comment-16644898
]
Vladimir Konkov edited comment on DBCP-454 at 10/10/18 12:19 PM:
-
Temporal workaround for Karaf with Pax Wrap protocol:
wrap:mvn:org.apache.commons/commons-dbcp2/2.5.0$overwrite=merge{color:#6d9cbe}&{color}Import-Package=javax.transaction;version="1.1.0",javax.transaction.xa;version="1.1.0",javax.management,javax.naming,javax.naming.spi,javax.sql,org.apache.commons.logging,org.apache.commons.pool2,org.apache.commons.pool2.impl
was (Author: vladimirfx):
Temporal workaround for Karaf with Pax Wrap protocol:
{{wrap:mvn:org.apache.commons/commons-dbcp2/2.5.0$overwrite=merge{color:#6d9cbe}&{color}Import-Package=javax.transaction.xa;version="1.1.0"}}
> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons DBCP
> Issue Type: Bug
>Affects Versions: 2.2.0
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.4.1
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed.
> Though with the fix for this issue the import-packages will contain
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
> ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
> org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
> ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
> ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are
> prohibited and i.e. Felix will complain about this and refuse to install the
> bundle. The fix is quite simple by appending the '*' to the end (see attached
> patch).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction
[
https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644898#comment-16644898
]
Vladimir Konkov commented on DBCP-454:
--
Temporal workaround for Karaf with Pax Wrap protocol:
{{wrap:mvn:org.apache.commons/commons-dbcp2/2.5.0$overwrite=merge{color:#6d9cbe}&{color}Import-Package=javax.transaction.xa;version="1.1.0"}}
> OSGi declarations contain multiple import headers for javax.transaction
> ---
>
> Key: DBCP-454
> URL: https://issues.apache.org/jira/browse/DBCP-454
> Project: Commons DBCP
> Issue Type: Bug
>Affects Versions: 2.2.0
> Environment: OSGi
>Reporter: Philipp Marx
>Assignee: Matt Sicker
>Priority: Blocker
> Fix For: 2.4.1
>
> Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed.
> Though with the fix for this issue the import-packages will contain
> "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
> ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
> org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
> ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
> ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are
> prohibited and i.e. Felix will complain about this and refuse to install the
> bundle. The fix is quite simple by appending the '*' to the end (see attached
> patch).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEOMETRY-17) Euclidean Vector Method Follow-Up
[ https://issues.apache.org/jira/browse/GEOMETRY-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644721#comment-16644721 ] Gilles commented on GEOMETRY-17: Well, I raised my concern that we may be loosing a performance opportunity; but this can always be added later, I guess. > Euclidean Vector Method Follow-Up > - > > Key: GEOMETRY-17 > URL: https://issues.apache.org/jira/browse/GEOMETRY-17 > Project: Apache Commons Geometry > Issue Type: Improvement >Reporter: Matt Juntunen >Priority: Major > > This is a follow-up issue to GEOMETRY-9. The following tasks should be > completed: > # Vector2D - needs an orthogonal() method like Vector3D > # Vector#getMagnitude() should be removed. I originally added this as part > of GEOMETRY-9 as an alias for getNorm(), but after thinking about it more and > working with it, I believe it's more confusing than useful to have multiple > names in the code base for the same idea. > # Vector#withMagnitude() should be renamed to Vector#withNorm() for the same > reason as above. > # Vector#getRealNonZeroNorm() - This is currently a private method in the > Vector implementation classes but I believe it is useful enough to be made > public. The idea is that this would return the vector norm but throw an > IllegalNormException if the norm is zero, NaN, or infinite. I've already come > across some places in other classes (such as Rotation) where I want to use > this. > > Pull request: https://github.com/apache/commons-geometry/pull/11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644713#comment-16644713 ] Gilles commented on GEOMETRY-14: bq. I'm not going to have any time available for at least a week. Thanks for letting me know. :) > AffineTransform?D Classes > - > > Key: GEOMETRY-14 > URL: https://issues.apache.org/jira/browse/GEOMETRY-14 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > Labels: pull-request-available > > We should create AffineTransform?D classes that implement matrix-based affine > transforms. They should have simple methods for creating translations, > rotations, and scaling and calculating the inverse. > > Pull Request #1: https://github.com/apache/commons-geometry/pull/14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEOMETRY-14) AffineTransform?D Classes
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644710#comment-16644710 ] Gilles commented on GEOMETRY-14: bq. Currently, I think I just want to keep it the way it is and maybe ponder if there are any better options. Since I cannot offer a concrete alternative, it's quite fine as an attempt to improve on the previous implementation, but since part of the design is not "mathematically pure" (because of the Cartesian system of coordinates being so high in the class hierarchy), I deem it necessary that you write a summary of the design decisions (with known advantages and shortcomings) so that we don't flip-flop every time someone thinks there is some "obvious" flaw in the code structure. bq. Rotation be a separate class that implements Transform from core but is not part of the AffineTransform hierarchy Why? It would also seem to be going away from the goal of "mathematically pure". > AffineTransform?D Classes > - > > Key: GEOMETRY-14 > URL: https://issues.apache.org/jira/browse/GEOMETRY-14 > Project: Apache Commons Geometry > Issue Type: New Feature >Reporter: Matt Juntunen >Priority: Major > Labels: pull-request-available > > We should create AffineTransform?D classes that implement matrix-based affine > transforms. They should have simple methods for creating translations, > rotations, and scaling and calculating the inverse. > > Pull Request #1: https://github.com/apache/commons-geometry/pull/14 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
