[GitHub] [commons-collections] dependabot[bot] commented on pull request #169: Bump checkstyle from 8.32 to 8.34
dependabot[bot] commented on pull request #169: URL: https://github.com/apache/commons-collections/pull/169#issuecomment-664137019 Superseded by #171. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] closed pull request #169: Bump checkstyle from 8.32 to 8.34
dependabot[bot] closed pull request #169: URL: https://github.com/apache/commons-collections/pull/169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-collections] dependabot[bot] opened a new pull request #171: Bump checkstyle from 8.32 to 8.35
dependabot[bot] opened a new pull request #171: URL: https://github.com/apache/commons-collections/pull/171 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.32 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 checkstyle-8.34 https://checkstyle.org/releasenotes.html#Release_8.34;>https://checkstyle.org/releasenotes.html#Release_8.34 checkstyle-8.33 https://checkstyle.org/releasenotes.html#Release_8.33;>https://checkstyle.org/releasenotes.html#Release_8.33 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.32...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] opened a new pull request #106: Bump checkstyle from 8.27 to 8.35
dependabot[bot] opened a new pull request #106: URL: https://github.com/apache/commons-vfs/pull/106 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.27 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 checkstyle-8.34 https://checkstyle.org/releasenotes.html#Release_8.34;>https://checkstyle.org/releasenotes.html#Release_8.34 checkstyle-8.33 https://checkstyle.org/releasenotes.html#Release_8.33;>https://checkstyle.org/releasenotes.html#Release_8.33 checkstyle-8.32 https://checkstyle.org/releasenotes.html#Release_8.32;>https://checkstyle.org/releasenotes.html#Release_8.32 checkstyle-8.31 https://checkstyle.org/releasenotes.html#Release_8.31;>https://checkstyle.org/releasenotes.html#Release_8.31 checkstyle-8.30 https://checkstyle.org/releasenotes.html#Release_8.30;>https://checkstyle.org/releasenotes.html#Release_8.30 checkstyle-8.29 https://checkstyle.org/releasenotes.html#Release_8.29;>https://checkstyle.org/releasenotes.html#Release_8.29 checkstyle-8.28 https://checkstyle.org/releasenotes.html#Release_8.28;>https://checkstyle.org/releasenotes.html#Release_8.28 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.27...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this
[GitHub] [commons-vfs] dependabot[bot] commented on pull request #101: Bump checkstyle from 8.27 to 8.34
dependabot[bot] commented on pull request #101: URL: https://github.com/apache/commons-vfs/pull/101#issuecomment-664136903 Superseded by #106. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] dependabot[bot] closed pull request #101: Bump checkstyle from 8.27 to 8.34
dependabot[bot] closed pull request #101: URL: https://github.com/apache/commons-vfs/pull/101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbutils] dependabot[bot] opened a new pull request #20: Bump checkstyle from 8.34 to 8.35
dependabot[bot] opened a new pull request #20: URL: https://github.com/apache/commons-dbutils/pull/20 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.34 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.34...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] commented on pull request #53: Bump checkstyle from 8.26 to 8.34
dependabot[bot] commented on pull request #53: URL: https://github.com/apache/commons-configuration/pull/53#issuecomment-664136032 Superseded by #59. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] opened a new pull request #59: Bump checkstyle from 8.26 to 8.35
dependabot[bot] opened a new pull request #59: URL: https://github.com/apache/commons-configuration/pull/59 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.26 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 checkstyle-8.34 https://checkstyle.org/releasenotes.html#Release_8.34;>https://checkstyle.org/releasenotes.html#Release_8.34 checkstyle-8.33 https://checkstyle.org/releasenotes.html#Release_8.33;>https://checkstyle.org/releasenotes.html#Release_8.33 checkstyle-8.32 https://checkstyle.org/releasenotes.html#Release_8.32;>https://checkstyle.org/releasenotes.html#Release_8.32 checkstyle-8.31 https://checkstyle.org/releasenotes.html#Release_8.31;>https://checkstyle.org/releasenotes.html#Release_8.31 checkstyle-8.30 https://checkstyle.org/releasenotes.html#Release_8.30;>https://checkstyle.org/releasenotes.html#Release_8.30 checkstyle-8.29 https://checkstyle.org/releasenotes.html#Release_8.29;>https://checkstyle.org/releasenotes.html#Release_8.29 checkstyle-8.28 https://checkstyle.org/releasenotes.html#Release_8.28;>https://checkstyle.org/releasenotes.html#Release_8.28 checkstyle-8.27 https://checkstyle.org/releasenotes.html#Release_8.27;>https://checkstyle.org/releasenotes.html#Release_8.27 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.26...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or
[GitHub] [commons-configuration] dependabot[bot] closed pull request #53: Bump checkstyle from 8.26 to 8.34
dependabot[bot] closed pull request #53: URL: https://github.com/apache/commons-configuration/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] opened a new pull request #58: Bump servlet-api from 2.4 to 2.5
dependabot[bot] opened a new pull request #58: URL: https://github.com/apache/commons-configuration/pull/58 Bumps servlet-api from 2.4 to 2.5. [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] dependabot[bot] opened a new pull request #141: Bump checkstyle from 8.34 to 8.35
dependabot[bot] opened a new pull request #141: URL: https://github.com/apache/commons-text/pull/141 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.34 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.34...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] dependabot[bot] opened a new pull request #594: Bump checkstyle from 8.34 to 8.35
dependabot[bot] opened a new pull request #594: URL: https://github.com/apache/commons-lang/pull/594 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.34 to 8.35. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's releases. checkstyle-8.35 https://checkstyle.org/releasenotes.html#Release_8.35;>https://checkstyle.org/releasenotes.html#Release_8.35 Commits https://github.com/checkstyle/checkstyle/commit/b7e04c36deb1299b71c3141539304ed721393d60;>b7e04c3 [maven-release-plugin] prepare release checkstyle-8.35 https://github.com/checkstyle/checkstyle/commit/d2c205c137f732f6660b9b597e64453742bd1b0c;>d2c205c doc: release notes 8.35 https://github.com/checkstyle/checkstyle/commit/c77d725e6903455845a546b4a2de12742d62ad30;>c77d725 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (xdocs non-checks) https://github.com/checkstyle/checkstyle/commit/a72fc7227a79d010a52b89f022b4b4146ecb0de5;>a72fc72 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8544;>#8544: format xml sources (checkstyle config) https://github.com/checkstyle/checkstyle/commit/73170abdf14a15870f53cb972c934805c18d8f4e;>73170ab Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8543;>#8543: check that all xml sources are well formed https://github.com/checkstyle/checkstyle/commit/ec3259fc4265ab0b38387ec75c80d4c02e75726f;>ec3259f minor: indentation and renaming in diff_report.yml https://github.com/checkstyle/checkstyle/commit/ba1f9ccae18b4c6cf740fc212a0100b986fa964b;>ba1f9cc Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8539;>#8539: change diff trigger https://github.com/checkstyle/checkstyle/commit/6e65ddf942fc95ea47a2cba21b0a98727ea0cb5a;>6e65ddf Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8533;>#8533: add to top button https://github.com/checkstyle/checkstyle/commit/8c4a4b0b33c4fcaa4ce3bbe43838fb0d0422dd10;>8c4a4b0 dependency: bump junit-pioneer from 0.6.0 to 0.7.0 https://github.com/checkstyle/checkstyle/commit/89a4cda50ea2c8cb52677dbee74c9ccd21d1a6b4;>89a4cda Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/8394;>#8394: extend InnerTypeLast to work with ctors and init blocks Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-8.34...checkstyle-8.35;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-configuration] dependabot[bot] opened a new pull request #57: Bump maven-checkstyle-plugin from 3.1.0 to 3.1.1
dependabot[bot] opened a new pull request #57: URL: https://github.com/apache/commons-configuration/pull/57 Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.1.0 to 3.1.1. Commits https://github.com/apache/maven-checkstyle-plugin/commit/104b560b37f906fa843d2235d23ff9be5948f3eb;>104b560 [maven-release-plugin] prepare release maven-checkstyle-plugin-3.1.1 https://github.com/apache/maven-checkstyle-plugin/commit/eb47facb0cba61a5df9baa534e11e21170f05c46;>eb47fac added reproducible build output timestamp property https://github.com/apache/maven-checkstyle-plugin/commit/bc0785d5985ed214d717c555ef6586f55a249d92;>bc0785d [MCHECKSTYLE-391] Update parent to 34 https://github.com/apache/maven-checkstyle-plugin/commit/de614e3ce5f4b4b7fc12e6cbd54189638e58a551;>de614e3 [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change back to '... https://github.com/apache/maven-checkstyle-plugin/commit/c427a30030649947c0780d81517a30f188760541;>c427a30 [MCHECKSTYLE-390] Upgrade to checkstyle 8.29 https://github.com/apache/maven-checkstyle-plugin/commit/e1e2f28620e2baed8351fea5fa524e98749df55c;>e1e2f28 MCHECKSTYLE-384 Bump checkstyle to 8.28 https://github.com/apache/maven-checkstyle-plugin/commit/f0b96ab98437149486771df879a23e5740090f0c;>f0b96ab [MCHECKSTYLE-388] Upgrade dependencies https://github.com/apache/maven-checkstyle-plugin/commit/eae07f99f01584bfd3da90a8c5eb32364e8ee82b;>eae07f9 [MCHECKSTYLE-381] make call to checker.setClassLoader() optional. https://github.com/apache/maven-checkstyle-plugin/commit/26848dca567bf64cf2d26a5cb099d76c01792879;>26848dc Merge pull request https://github-redirect.dependabot.com/apache/maven-checkstyle-plugin/issues/12;>#12 from srdo/MCHECKSTYLE-371 https://github.com/apache/maven-checkstyle-plugin/commit/2485ea76e8b5b95a77fcc1b2e15cbab575f32ac3;>2485ea7 Merge pull request https://github-redirect.dependabot.com/apache/maven-checkstyle-plugin/issues/20;>#20 from elharo/patch-1 Additional commits viewable in https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.1.0...maven-checkstyle-plugin-3.1.1;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request #24: Bump slf4j-jdk14 from 1.7.7 to 1.7.30
dependabot[bot] opened a new pull request #24: URL: https://github.com/apache/commons-email/pull/24 Bumps [slf4j-jdk14](https://github.com/qos-ch/slf4j) from 1.7.7 to 1.7.30. Commits https://github.com/qos-ch/slf4j/commit/0b97c416e42a184ff9728877b461c616187c58f7;>0b97c41 move to 1.7.30 https://github.com/qos-ch/slf4j/commit/c6c7a98a7ee1e71382348ae3e41ff7818dfafd65;>c6c7a98 fix SLF4J-469 https://github.com/qos-ch/slf4j/commit/ca93154c79d7489ccc36a6957ebc2e74c34181ba;>ca93154 do not deploy slf4j-site https://github.com/qos-ch/slf4j/commit/d061e25477fa6928fbe1290a200c9a3442156b2b;>d061e25 this module is Apache 2.0 licensed https://github.com/qos-ch/slf4j/commit/e8ce694e2e05999185479875e9f93aeaf7570b99;>e8ce694 preapre release 1.7.29 https://github.com/qos-ch/slf4j/commit/125e7cca190c48fedcb92f377fd7361661f7537c;>125e7cc Merge pull request https://github-redirect.dependabot.com/qos-ch/slf4j/issues/219;>#219 from delgurth/1.7-maintenance-with-slf4j-466 https://github.com/qos-ch/slf4j/commit/a7562cb4b928c225192405b4d849246db60107d4;>a7562cb SLF4J-466: backport changes to 1.7 https://github.com/qos-ch/slf4j/commit/9752c892fdf4d9d13ea020ac95fca2284ccbf68e;>9752c89 specify jdk8 in travis https://github.com/qos-ch/slf4j/commit/b44fbd53cc8bc87f40e5412e60495b19bbf07bb0;>b44fbd5 prepare release 1.7.28 https://github.com/qos-ch/slf4j/commit/2a1374691f394b85b7da4a98d2b61105ba19e1b1;>2a13746 correct Automatic-Module-Name: org.apache.log4j Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v1.7.7...v_1.7.30;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-email] dependabot[bot] opened a new pull request #23: Bump commons-release-plugin from 1.0 to 1.7
dependabot[bot] opened a new pull request #23: URL: https://github.com/apache/commons-email/pull/23 Bumps commons-release-plugin from 1.0 to 1.7. [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463445
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 27/Jul/20 01:41
Start Date: 27/Jul/20 01:41
Worklog Time Spent: 10m
Work Description: thc202 commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460605904
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
JMH samples talk about this, e.g.:
https://hg.openjdk.java.net/code-tools/jmh/file/4a420afe8a9e/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_08_DeadCode.java
https://hg.openjdk.java.net/code-tools/jmh/file/tip/jmh-samples/src/main/java/org/openjdk/jmh/samples/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 463445)
Time Spent: 3h (was: 2h 50m)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 3h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] thc202 commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
thc202 commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460605904
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
JMH samples talk about this, e.g.:
https://hg.openjdk.java.net/code-tools/jmh/file/4a420afe8a9e/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_08_DeadCode.java
https://hg.openjdk.java.net/code-tools/jmh/file/tip/jmh-samples/src/main/java/org/openjdk/jmh/samples/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463436=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463436 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:45 Start Date: 26/Jul/20 23:45 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32331050) Coverage increased (+0.0003%) to 94.666% when pulling **04dff56b617cf6b02ac0859c3cd6e749764e2182 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463436) Time Spent: 2h 50m (was: 2h 40m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32331050) Coverage increased (+0.0003%) to 94.666% when pulling **04dff56b617cf6b02ac0859c3cd6e749764e2182 on XenoAmess:refine_chomp** into **cf0bc2b5dbb08ee1f5c0c8d54df307e23345544d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463435 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:40 Start Date: 26/Jul/20 23:40 Worklog Time Spent: 10m Work Description: sebbASF commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664055647 The JMH results are very long and obscure the thread of the PR. Is it possible to post just the summary inline, with a link to the full results in an attachment? That would make it much easier to follow the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463435) Time Spent: 2h 40m (was: 2.5h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] sebbASF commented on pull request #565: [LANG-1576] refine StringUtils.chomp
sebbASF commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664055647 The JMH results are very long and obscure the thread of the PR. Is it possible to post just the summary inline, with a link to the full results in an attachment? That would make it much easier to follow the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463434=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463434
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 26/Jul/20 23:37
Start Date: 26/Jul/20 23:37
Worklog Time Spent: 10m
Work Description: sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460587706
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
The JVM is free to discard code that does nothing useful.
https://stackoverflow.com/questions/4871550/how-can-i-be-sure-that-the-compiler-doesnt-optimize-away-my-performance-test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 463434)
Time Spent: 2.5h (was: 2h 20m)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] sebbASF commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
sebbASF commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460587706
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
The JVM is free to discard code that does nothing useful.
https://stackoverflow.com/questions/4871550/how-can-i-be-sure-that-the-compiler-doesnt-optimize-away-my-performance-test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463433=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463433
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 26/Jul/20 23:29
Start Date: 26/Jul/20 23:29
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586849
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
@aherbert
> Otherwise there is nothing to prevent the JVM from not running your chomp
methods as the result is discarded.
Is there some material/document about this?
I ask because seems I never observed this kind of thing happened...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 463433)
Time Spent: 2h 20m (was: 2h 10m)
> refine StringUtils.chomp
>
>
> Key: LANG-1576
> URL: https://issues.apache.org/jira/browse/LANG-1576
> Project: Commons Lang
> Issue Type: Sub-task
>Reporter: Jin Xu
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/565]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586849
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
@aherbert
> Otherwise there is nothing to prevent the JVM from not running your chomp
methods as the result is discarded.
Is there some material/document about this?
I ask because seems I never observed this kind of thing happened...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: @aherbert > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) will delete it now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463432 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:26 Start Date: 26/Jul/20 23:26 Worklog Time Spent: 10m Work Description: XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: @aherbert > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) will delete it now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463432) Time Spent: 2h 10m (was: 2h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463430 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:25 Start Date: 26/Jul/20 23:25 Worklog Time Spent: 10m Work Description: XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463430) Time Spent: 1h 50m (was: 1h 40m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463431=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463431 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:25 Start Date: 26/Jul/20 23:25 Worklog Time Spent: 10m Work Description: XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) will delete it now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463431) Time Spent: 2h (was: 1h 50m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) will delete it now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on a change in pull request #565: URL: https://github.com/apache/commons-lang/pull/565#discussion_r460586417 ## File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.lang3; + +import java.util.concurrent.TimeUnit; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.BenchmarkMode; +import org.openjdk.jmh.annotations.Mode; +import org.openjdk.jmh.annotations.OutputTimeUnit; +import org.openjdk.jmh.annotations.Scope; +import org.openjdk.jmh.annotations.State; +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.commons.lang3.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.length; + +/** + * Test to show whether using BitSet for removeAll() methods is faster than using HashSet. Review comment: > This is not what the benchmark is doing. Ah yes, this class is copied from HashSetvBitSetTest then modified. But forgot to delete this doc by mistake :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32330862) Coverage increased (+0.0003%) to 94.666% when pulling **28f0fa7336879e6da4e3f85e4ab8feec6dc9d55b on XenoAmess:refine_chomp** into **8577e0c3295ae4d933c5dff22bd034487adcd23b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463428 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:13 Start Date: 26/Jul/20 23:13 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32330862) Coverage increased (+0.0003%) to 94.666% when pulling **28f0fa7336879e6da4e3f85e4ab8feec6dc9d55b on XenoAmess:refine_chomp** into **8577e0c3295ae4d933c5dff22bd034487adcd23b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463428) Time Spent: 1h 40m (was: 1.5h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-354) VerhoeffCheckDigit.isValid("0") == true but .calculate("") fails
[
https://issues.apache.org/jira/browse/VALIDATOR-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-354.
Resolution: Abandoned
> VerhoeffCheckDigit.isValid("0") == true but .calculate("") fails
>
>
> Key: VALIDATOR-354
> URL: https://issues.apache.org/jira/browse/VALIDATOR-354
> Project: Commons Validator
> Issue Type: Bug
>Reporter: Sebb
>Priority: Minor
>
> VerhoeffCheckDigit.isValid("0") is true but .calculate("") fails.
> SInce isValid() includes the check digit that implies the empty string has a
> CD of "0". However calculate throws CDE when presented with the empty string.
> This is assymetric. I would expect to be able to redo the process to generate
> a code which is valid.
> Perhaps isValid() needs to return false if the original string is empty.
> One could just add a check for includesCheckDigit && length <= 1 but I wonder
> whether the algorithm could have a problem?
> Needs further research.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (VALIDATOR-442) EmailValidator and zero-width space
[
https://issues.apache.org/jira/browse/VALIDATOR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165359#comment-17165359
]
Sebb commented on VALIDATOR-442:
This is caused by DomainValidator, which ignores zero-width space.
The code uses java.net.IDN.toASCII which drops such characters, following the
rules in rfc3454.
It's not clear to me that zero-width space should be disallowed.
> EmailValidator and zero-width space
> ---
>
> Key: VALIDATOR-442
> URL: https://issues.apache.org/jira/browse/VALIDATOR-442
> Project: Commons Validator
> Issue Type: Bug
>Affects Versions: 1.6
>Reporter: Alessandro Cataldo
>Priority: Minor
>
> EmailValidator does not take into account category "Cf" in the Unicode
> specification.
> String test = "t...@email.com*\u200b*"; //Unicode zero-width space
> boolean valid = EmailValidator.getInstance().isValid(test);
> System.out.println("Is valid: "+valid);
> //Returns true
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051325 yes, it is not a very significant refine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463424=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463424 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 23:00 Start Date: 26/Jul/20 23:00 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051325 yes, it is not a very significant refine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463424) Time Spent: 1.5h (was: 1h 20m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463423=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463423 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 22:59 Start Date: 26/Jul/20 22:59 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051177 jmh ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/ 1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1New # Run progress: 0.00% complete, ETA 01:23:20 # Fork: 1 of 5 # Warmup Iteration 1: 0.489 ns/op # Warmup Iteration 2: 0.429 ns/op # Warmup Iteration 3: 0.693 ns/op # Warmup Iteration 4: 0.609 ns/op # Warmup Iteration 5: 0.553 ns/op Iteration 1: 0.535 ns/op Iteration 2: 0.543 ns/op Iteration 3: 0.540 ns/op Iteration 4: 0.540 ns/op Iteration 5: 0.544 ns/op # Run progress: 2.00% complete, ETA 01:22:05 # Fork: 2 of 5 # Warmup Iteration 1: 0.412 ns/op # Warmup Iteration 2: 0.404 ns/op # Warmup Iteration 3: 0.548 ns/op # Warmup Iteration 4: 0.530 ns/op # Warmup Iteration 5: 0.536 ns/op Iteration 1: 0.539 ns/op Iteration 2: 0.556 ns/op Iteration 3: 0.540 ns/op Iteration 4: 0.545 ns/op Iteration 5: 0.536 ns/op # Run progress: 4.00% complete, ETA 01:20:21 # Fork: 3 of 5 # Warmup Iteration 1: 0.408 ns/op # Warmup Iteration 2: 0.403 ns/op # Warmup Iteration 3: 0.535 ns/op # Warmup Iteration 4: 0.543 ns/op # Warmup Iteration 5: 0.539 ns/op Iteration 1: 0.547 ns/op Iteration 2: 0.544 ns/op Iteration 3: 0.544 ns/op Iteration 4: 0.536 ns/op Iteration 5: 0.549 ns/op # Run progress: 6.00% complete, ETA 01:18:40 # Fork: 4 of 5 # Warmup Iteration 1: 0.427 ns/op # Warmup Iteration 2: 0.425 ns/op # Warmup Iteration 3: 0.546 ns/op # Warmup Iteration 4: 0.533 ns/op # Warmup Iteration 5: 0.542 ns/op Iteration 1: 0.533 ns/op Iteration 2: 0.529 ns/op Iteration 3: 0.537 ns/op Iteration 4: 0.531 ns/op Iteration 5: 0.533 ns/op # Run progress: 8.00% complete, ETA 01:16:59 # Fork: 5 of 5 # Warmup Iteration 1: 0.400 ns/op # Warmup Iteration 2: 0.400 ns/op # Warmup Iteration 3: 0.534 ns/op # Warmup Iteration 4: 0.536 ns/op # Warmup Iteration 5: 0.536 ns/op Iteration 1: 0.534 ns/op Iteration 2: 0.534 ns/op Iteration 3: 0.536 ns/op Iteration 4: 0.541 ns/op Iteration 5: 0.540 ns/op Result "org.apache.commons.lang3.StringUtilsChompTest.test1New": 0.539 ?99.9%) 0.005 ns/op [Average] (min, avg, max) = (0.529, 0.539, 0.556), stdev = 0.006 CI (99.9%): [0.535, 0.544] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1Old # Run progress: 10.00% complete, ETA 01:15:19 # Fork: 1 of 5 # Warmup Iteration 1: 0.408 ns/op # Warmup Iteration 2: 0.406 ns/op # Warmup Iteration 3: 0.540 ns/op # Warmup Iteration 4: 0.530 ns/op # Warmup Iteration 5: 0.539 ns/op Iteration 1: 0.544 ns/op Iteration 2: 0.551 ns/op Iteration 3: 0.536 ns/op Iteration 4: 0.549 ns/op Iteration 5: 0.542 ns/op # Run progress: 12.00% complete, ETA 01:13:39 # Fork: 2 of 5 # Warmup Iteration 1: 0.400 ns/op # Warmup Iteration 2: 0.411 ns/op # Warmup Iteration 3: 0.569 ns/op # Warmup Iteration 4: 0.587 ns/op
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051177 jmh ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/ 1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1New # Run progress: 0.00% complete, ETA 01:23:20 # Fork: 1 of 5 # Warmup Iteration 1: 0.489 ns/op # Warmup Iteration 2: 0.429 ns/op # Warmup Iteration 3: 0.693 ns/op # Warmup Iteration 4: 0.609 ns/op # Warmup Iteration 5: 0.553 ns/op Iteration 1: 0.535 ns/op Iteration 2: 0.543 ns/op Iteration 3: 0.540 ns/op Iteration 4: 0.540 ns/op Iteration 5: 0.544 ns/op # Run progress: 2.00% complete, ETA 01:22:05 # Fork: 2 of 5 # Warmup Iteration 1: 0.412 ns/op # Warmup Iteration 2: 0.404 ns/op # Warmup Iteration 3: 0.548 ns/op # Warmup Iteration 4: 0.530 ns/op # Warmup Iteration 5: 0.536 ns/op Iteration 1: 0.539 ns/op Iteration 2: 0.556 ns/op Iteration 3: 0.540 ns/op Iteration 4: 0.545 ns/op Iteration 5: 0.536 ns/op # Run progress: 4.00% complete, ETA 01:20:21 # Fork: 3 of 5 # Warmup Iteration 1: 0.408 ns/op # Warmup Iteration 2: 0.403 ns/op # Warmup Iteration 3: 0.535 ns/op # Warmup Iteration 4: 0.543 ns/op # Warmup Iteration 5: 0.539 ns/op Iteration 1: 0.547 ns/op Iteration 2: 0.544 ns/op Iteration 3: 0.544 ns/op Iteration 4: 0.536 ns/op Iteration 5: 0.549 ns/op # Run progress: 6.00% complete, ETA 01:18:40 # Fork: 4 of 5 # Warmup Iteration 1: 0.427 ns/op # Warmup Iteration 2: 0.425 ns/op # Warmup Iteration 3: 0.546 ns/op # Warmup Iteration 4: 0.533 ns/op # Warmup Iteration 5: 0.542 ns/op Iteration 1: 0.533 ns/op Iteration 2: 0.529 ns/op Iteration 3: 0.537 ns/op Iteration 4: 0.531 ns/op Iteration 5: 0.533 ns/op # Run progress: 8.00% complete, ETA 01:16:59 # Fork: 5 of 5 # Warmup Iteration 1: 0.400 ns/op # Warmup Iteration 2: 0.400 ns/op # Warmup Iteration 3: 0.534 ns/op # Warmup Iteration 4: 0.536 ns/op # Warmup Iteration 5: 0.536 ns/op Iteration 1: 0.534 ns/op Iteration 2: 0.534 ns/op Iteration 3: 0.536 ns/op Iteration 4: 0.541 ns/op Iteration 5: 0.540 ns/op Result "org.apache.commons.lang3.StringUtilsChompTest.test1New": 0.539 ?99.9%) 0.005 ns/op [Average] (min, avg, max) = (0.529, 0.539, 0.556), stdev = 0.006 CI (99.9%): [0.535, 0.544] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1Old # Run progress: 10.00% complete, ETA 01:15:19 # Fork: 1 of 5 # Warmup Iteration 1: 0.408 ns/op # Warmup Iteration 2: 0.406 ns/op # Warmup Iteration 3: 0.540 ns/op # Warmup Iteration 4: 0.530 ns/op # Warmup Iteration 5: 0.539 ns/op Iteration 1: 0.544 ns/op Iteration 2: 0.551 ns/op Iteration 3: 0.536 ns/op Iteration 4: 0.549 ns/op Iteration 5: 0.542 ns/op # Run progress: 12.00% complete, ETA 01:13:39 # Fork: 2 of 5 # Warmup Iteration 1: 0.400 ns/op # Warmup Iteration 2: 0.411 ns/op # Warmup Iteration 3: 0.569 ns/op # Warmup Iteration 4: 0.587 ns/op # Warmup Iteration 5: 0.556 ns/op Iteration 1: 0.536 ns/op Iteration 2: 0.534 ns/op Iteration 3: 0.536 ns/op Iteration 4: 0.543 ns/op Iteration 5: 0.530 ns/op # Run progress: 14.00% complete, ETA 01:11:58 # Fork: 3 of 5 # Warmup Iteration 1: 0.399 ns/op # Warmup Iteration 2: 0.402 ns/op # Warmup Iteration 3: 0.530 ns/op # Warmup Iteration 4: 0.534 ns/op #
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463421=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463421 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 22:58 Start Date: 26/Jul/20 22:58 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051092 I add more things to the test. see the new commit and the result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463421) Time Spent: 1h 10m (was: 1h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664051092 I add more things to the test. see the new commit and the result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] coveralls edited a comment on pull request #126: Bump actions/checkout from v1 to v2.3.1
coveralls edited a comment on pull request #126: URL: https://github.com/apache/commons-io/pull/126#issuecomment-663105902 [](https://coveralls.io/builds/32330479) Coverage decreased (-0.06%) to 89.72% when pulling **e985d9b0eb97ae553cbc646d29d325fcbd0274f7 on dependabot/github_actions/actions/checkout-v2.3.1** into **a6ab10973861bf7e68cfd7417440c9fcd0826c3b on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] kinow merged pull request #138: Bump actions/checkout from v1 to v2.3.1
kinow merged pull request #138: URL: https://github.com/apache/commons-text/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-text] coveralls edited a comment on pull request #138: Bump actions/checkout from v1 to v2.3.1
coveralls edited a comment on pull request #138: URL: https://github.com/apache/commons-text/pull/138#issuecomment-663105313 [](https://coveralls.io/builds/32330427) Coverage remained the same at 98.67% when pulling **b6279786937c2cd96f39735968933932aac20a70 on dependabot/github_actions/actions/checkout-v2.3.1** into **557ec22edd93126b731fe6cf427f76ed804db913 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] kinow merged pull request #30: Bump actions/checkout from v1 to v2.3.1
kinow merged pull request #30: URL: https://github.com/apache/commons-fileupload/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] coveralls edited a comment on pull request #30: Bump actions/checkout from v1 to v2.3.1
coveralls edited a comment on pull request #30: URL: https://github.com/apache/commons-fileupload/pull/30#issuecomment-663099793 [](https://coveralls.io/builds/32330377) Coverage remained the same at 78.357% when pulling **a045ca441c267eec621ffd9938cf0259a49352f2 on dependabot/github_actions/actions/checkout-v2.3.1** into **6f428e42c4781c5ab6fd2ef969a1ddcd78e6c6a8 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (VALIDATOR-238) Add scales (not the reptile kind) to double/float validations
[ https://issues.apache.org/jira/browse/VALIDATOR-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-238. Resolution: Abandoned > Add scales (not the reptile kind) to double/float validations > - > > Key: VALIDATOR-238 > URL: https://issues.apache.org/jira/browse/VALIDATOR-238 > Project: Commons Validator > Issue Type: Improvement >Affects Versions: 1.3.1 Release >Reporter: Paul Benedict >Priority: Major > > I have a DECIMAL(10, 8) column that I am trying to capture as user input. > This is very hard to represent with the validator because the length of the > scale is very large. I am currently using a maxlength=8,min=0,max= > but it is not exact. > I propose retrofitting double/float validations that may include length of > the scale. For another example, with a scale of two, a user may enter 2, 2.5, > 2.55 but not 2.555. This will allow me to remove any inexact usage of > maxlength. > > > scale > 8 > > > min > -90 > > > max > 90 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-228) allow to cite the offending value if a validation fails as argument (Trusted-Input vs. Filter Concept)
[ https://issues.apache.org/jira/browse/VALIDATOR-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-228. Resolution: Abandoned > allow to cite the offending value if a validation fails as argument > (Trusted-Input vs. Filter Concept) > -- > > Key: VALIDATOR-228 > URL: https://issues.apache.org/jira/browse/VALIDATOR-228 > Project: Commons Validator > Issue Type: Improvement > Components: Framework > Environment: any >Reporter: Ralf Hauser >Priority: Major > Fix For: 2.0 > > > for example if an email recipient in a webmail form is deemed to be wrong, it > is useful to cite which recipient it was since there could have been several > recipients in the form. > To do this safely, the email needs to be considered untrusted, since it may > contain a cross-site-script XSS . > For inspiration, have a look how we paired untrusted inputs (should be the > default) with filtering in org.bouncycastle.i18n > (if you use it for example in tomcat, there are also some tricky class-loader > issues that are solved by now...) > previous discussions on this are in > https://issues.apache.org/struts/browse/STR-1946 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-text] coveralls edited a comment on pull request #138: Bump actions/checkout from v1 to v2.3.1
coveralls edited a comment on pull request #138: URL: https://github.com/apache/commons-text/pull/138#issuecomment-663105313 [](https://coveralls.io/builds/32330276) Coverage remained the same at 98.67% when pulling **acd7d3b3baffaf49d2b63c705cba86b0d4d4cab5 on dependabot/github_actions/actions/checkout-v2.3.1** into **d3777d859caf7feb61f770ab9e40727f32b3a1ce on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[
https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463404=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463404
]
ASF GitHub Bot logged work on LANG-1576:
Author: ASF GitHub Bot
Created on: 26/Jul/20 20:36
Start Date: 26/Jul/20 20:36
Worklog Time Spent: 10m
Work Description: aherbert commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460568874
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
Review comment:
This is not what the benchmark is doing.
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
You should return String from all your benchmark methods. Otherwise
there is nothing to prevent the JVM from not running your chomp methods as the
result is discarded. If you return the chomped String then the JMH framework
will consume it thus forcing the JVM to run the method.
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
[GitHub] [commons-lang] aherbert commented on a change in pull request #565: [LANG-1576] refine StringUtils.chomp
aherbert commented on a change in pull request #565:
URL: https://github.com/apache/commons-lang/pull/565#discussion_r460568874
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
Review comment:
This is not what the benchmark is doing.
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3;
+
+import java.util.concurrent.TimeUnit;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.length;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+public class StringUtilsChompTest {
+
+private static final String string1 = "\r";
+private static final String string2 = buildString2();
+
+private static String buildString2() {
+StringBuilder stringBuilder = new StringBuilder();
+for (int i = 0; i < 10; i++) {
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('0');
+stringBuilder.append('\n');
+stringBuilder.append('0');
+stringBuilder.append('\r');
+stringBuilder.append('\n');
+}
+return stringBuilder.toString();
+}
+
+@Benchmark
+public void test1Old() {
+chompOld(string1);
Review comment:
You should return String from all your benchmark methods. Otherwise
there is nothing to prevent the JVM from not running your chomp methods as the
result is discarded. If you return the chomped String then the JMH framework
will consume it thus forcing the JVM to run the method.
##
File path: src/test/java/org/apache/commons/lang3/StringUtilsChompTest.java
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664015324 > Does not seem like a huge gain. Yes, it isn't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463374=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463374 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 17:13 Start Date: 26/Jul/20 17:13 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664015324 > Does not seem like a huge gain. Yes, it isn't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463374) Time Spent: 50m (was: 40m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463373=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463373 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 17:12 Start Date: 26/Jul/20 17:12 Worklog Time Spent: 10m Work Description: sebbASF commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664015190 If I understand the benchmark correctly, the New method is approx 3% slower for Test1 and about 2% faster for Test2. Does not seem like a huge gain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463373) Time Spent: 40m (was: 0.5h) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-452) Validation of URL containing IPv4-mapped IPv6 address
[ https://issues.apache.org/jira/browse/VALIDATOR-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-452. Resolution: Fixed Fixed in commit 1f2e113e90b20de2c6b8efe6f52a33e78dfcdce0 VALIDATOR-452 IPv4-mapped IPv6 address --- src/changes/changes.xml | 3 +++ .../java/org/apache/commons/validator/routines/UrlValidator.java | 3 ++- .../java/org/apache/commons/validator/routines/UrlValidatorTest.java | 5 + 3 files changed, 10 insertions(+), 1 deletion(-) > Validation of URL containing IPv4-mapped IPv6 address > - > > Key: VALIDATOR-452 > URL: https://issues.apache.org/jira/browse/VALIDATOR-452 > Project: Commons Validator > Issue Type: Bug >Affects Versions: 1.4.1 Release, 1.5.0, 1.6 >Reporter: devson >Priority: Major > > Hello, > UrlValidator.isValid treats url containing ipv4-mapped ipv6 address as > invalid. For instance, this is valid url that is returned as invalid by the > validator- "http://[:::129.144.52.38]:80/index.html; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] sebbASF commented on pull request #565: [LANG-1576] refine StringUtils.chomp
sebbASF commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664015190 If I understand the benchmark correctly, the New method is approx 3% slower for Test1 and about 2% faster for Test2. Does not seem like a huge gain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463372 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 17:09 Start Date: 26/Jul/20 17:09 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32328557) Coverage increased (+0.0003%) to 94.666% when pulling **cedce8b716f554eef5a088536869253e8f572047 on XenoAmess:refine_chomp** into **8577e0c3295ae4d933c5dff22bd034487adcd23b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463372) Time Spent: 0.5h (was: 20m) > refine StringUtils.chomp > > > Key: LANG-1576 > URL: https://issues.apache.org/jira/browse/LANG-1576 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/565] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #565: [LANG-1576] refine StringUtils.chomp
coveralls edited a comment on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-650908222 [](https://coveralls.io/builds/32328557) Coverage increased (+0.0003%) to 94.666% when pulling **cedce8b716f554eef5a088536869253e8f572047 on XenoAmess:refine_chomp** into **8577e0c3295ae4d933c5dff22bd034487adcd23b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #565: [LANG-1576] refine StringUtils.chomp
XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664013772 jmh ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/ 1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1New # Run progress: 0.00% complete, ETA 00:33:20 # Fork: 1 of 5 # Warmup Iteration 1: 0.455 ns/op # Warmup Iteration 2: 0.426 ns/op # Warmup Iteration 3: 0.591 ns/op # Warmup Iteration 4: 0.568 ns/op # Warmup Iteration 5: 0.627 ns/op Iteration 1: 0.629 ns/op Iteration 2: 0.607 ns/op Iteration 3: 0.574 ns/op Iteration 4: 0.575 ns/op Iteration 5: 0.562 ns/op # Run progress: 5.00% complete, ETA 00:31:49 # Fork: 2 of 5 # Warmup Iteration 1: 0.413 ns/op # Warmup Iteration 2: 0.417 ns/op # Warmup Iteration 3: 0.563 ns/op # Warmup Iteration 4: 0.552 ns/op # Warmup Iteration 5: 0.565 ns/op Iteration 1: 0.558 ns/op Iteration 2: 0.562 ns/op Iteration 3: 0.559 ns/op Iteration 4: 0.550 ns/op Iteration 5: 0.555 ns/op # Run progress: 10.00% complete, ETA 00:30:09 # Fork: 3 of 5 # Warmup Iteration 1: 0.414 ns/op # Warmup Iteration 2: 0.409 ns/op # Warmup Iteration 3: 0.561 ns/op # Warmup Iteration 4: 0.554 ns/op # Warmup Iteration 5: 0.555 ns/op Iteration 1: 0.553 ns/op Iteration 2: 0.558 ns/op Iteration 3: 0.557 ns/op Iteration 4: 0.560 ns/op Iteration 5: 0.556 ns/op # Run progress: 15.00% complete, ETA 00:28:28 # Fork: 4 of 5 # Warmup Iteration 1: 0.415 ns/op # Warmup Iteration 2: 0.418 ns/op # Warmup Iteration 3: 0.574 ns/op # Warmup Iteration 4: 0.581 ns/op # Warmup Iteration 5: 0.581 ns/op Iteration 1: 0.674 ns/op Iteration 2: 0.791 ns/op Iteration 3: 0.630 ns/op Iteration 4: 0.630 ns/op Iteration 5: 0.575 ns/op # Run progress: 20.00% complete, ETA 00:26:47 # Fork: 5 of 5 # Warmup Iteration 1: 0.416 ns/op # Warmup Iteration 2: 0.415 ns/op # Warmup Iteration 3: 0.555 ns/op # Warmup Iteration 4: 0.567 ns/op # Warmup Iteration 5: 0.566 ns/op Iteration 1: 0.557 ns/op Iteration 2: 0.552 ns/op Iteration 3: 0.557 ns/op Iteration 4: 0.571 ns/op Iteration 5: 0.559 ns/op Result "org.apache.commons.lang3.StringUtilsChompTest.test1New": 0.584 ?99.9%) 0.040 ns/op [Average] (min, avg, max) = (0.550, 0.584, 0.791), stdev = 0.054 CI (99.9%): [0.544, 0.625] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1Old # Run progress: 25.00% complete, ETA 00:25:07 # Fork: 1 of 5 # Warmup Iteration 1: 0.416 ns/op # Warmup Iteration 2: 0.422 ns/op # Warmup Iteration 3: 0.559 ns/op # Warmup Iteration 4: 0.557 ns/op # Warmup Iteration 5: 0.560 ns/op Iteration 1: 0.561 ns/op Iteration 2: 0.568 ns/op Iteration 3: 0.555 ns/op Iteration 4: 0.564 ns/op Iteration 5: 0.567 ns/op # Run progress: 30.00% complete, ETA 00:23:26 # Fork: 2 of 5 # Warmup Iteration 1: 0.432 ns/op # Warmup Iteration 2: 0.415 ns/op # Warmup Iteration 3: 0.580 ns/op # Warmup Iteration 4: 0.564 ns/op # Warmup Iteration 5: 0.557 ns/op Iteration 1: 0.554 ns/op Iteration 2: 0.555 ns/op Iteration 3: 0.561 ns/op Iteration 4: 0.561 ns/op Iteration 5: 0.609 ns/op # Run progress: 35.00% complete, ETA 00:21:46 # Fork: 3 of 5 # Warmup Iteration 1: 0.452 ns/op # Warmup Iteration 2: 0.439 ns/op # Warmup Iteration 3: 0.559 ns/op # Warmup Iteration 4: 0.553 ns/op
[jira] [Work logged] (LANG-1576) refine StringUtils.chomp
[ https://issues.apache.org/jira/browse/LANG-1576?focusedWorklogId=463370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463370 ] ASF GitHub Bot logged work on LANG-1576: Author: ASF GitHub Bot Created on: 26/Jul/20 17:00 Start Date: 26/Jul/20 17:00 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #565: URL: https://github.com/apache/commons-lang/pull/565#issuecomment-664013772 jmh ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk/jmh/jmh-core/ 1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1New # Run progress: 0.00% complete, ETA 00:33:20 # Fork: 1 of 5 # Warmup Iteration 1: 0.455 ns/op # Warmup Iteration 2: 0.426 ns/op # Warmup Iteration 3: 0.591 ns/op # Warmup Iteration 4: 0.568 ns/op # Warmup Iteration 5: 0.627 ns/op Iteration 1: 0.629 ns/op Iteration 2: 0.607 ns/op Iteration 3: 0.574 ns/op Iteration 4: 0.575 ns/op Iteration 5: 0.562 ns/op # Run progress: 5.00% complete, ETA 00:31:49 # Fork: 2 of 5 # Warmup Iteration 1: 0.413 ns/op # Warmup Iteration 2: 0.417 ns/op # Warmup Iteration 3: 0.563 ns/op # Warmup Iteration 4: 0.552 ns/op # Warmup Iteration 5: 0.565 ns/op Iteration 1: 0.558 ns/op Iteration 2: 0.562 ns/op Iteration 3: 0.559 ns/op Iteration 4: 0.550 ns/op Iteration 5: 0.555 ns/op # Run progress: 10.00% complete, ETA 00:30:09 # Fork: 3 of 5 # Warmup Iteration 1: 0.414 ns/op # Warmup Iteration 2: 0.409 ns/op # Warmup Iteration 3: 0.561 ns/op # Warmup Iteration 4: 0.554 ns/op # Warmup Iteration 5: 0.555 ns/op Iteration 1: 0.553 ns/op Iteration 2: 0.558 ns/op Iteration 3: 0.557 ns/op Iteration 4: 0.560 ns/op Iteration 5: 0.556 ns/op # Run progress: 15.00% complete, ETA 00:28:28 # Fork: 4 of 5 # Warmup Iteration 1: 0.415 ns/op # Warmup Iteration 2: 0.418 ns/op # Warmup Iteration 3: 0.574 ns/op # Warmup Iteration 4: 0.581 ns/op # Warmup Iteration 5: 0.581 ns/op Iteration 1: 0.674 ns/op Iteration 2: 0.791 ns/op Iteration 3: 0.630 ns/op Iteration 4: 0.630 ns/op Iteration 5: 0.575 ns/op # Run progress: 20.00% complete, ETA 00:26:47 # Fork: 5 of 5 # Warmup Iteration 1: 0.416 ns/op # Warmup Iteration 2: 0.415 ns/op # Warmup Iteration 3: 0.555 ns/op # Warmup Iteration 4: 0.567 ns/op # Warmup Iteration 5: 0.566 ns/op Iteration 1: 0.557 ns/op Iteration 2: 0.552 ns/op Iteration 3: 0.557 ns/op Iteration 4: 0.571 ns/op Iteration 5: 0.559 ns/op Result "org.apache.commons.lang3.StringUtilsChompTest.test1New": 0.584 ?99.9%) 0.040 ns/op [Average] (min, avg, max) = (0.550, 0.584, 0.791), stdev = 0.054 CI (99.9%): [0.544, 0.625] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.StringUtilsChompTest.test1Old # Run progress: 25.00% complete, ETA 00:25:07 # Fork: 1 of 5 # Warmup Iteration 1: 0.416 ns/op # Warmup Iteration 2: 0.422 ns/op # Warmup Iteration 3: 0.559 ns/op # Warmup Iteration 4: 0.557 ns/op # Warmup Iteration 5: 0.560 ns/op Iteration 1: 0.561 ns/op Iteration 2: 0.568 ns/op Iteration 3: 0.555 ns/op Iteration 4: 0.564 ns/op Iteration 5: 0.567 ns/op # Run progress: 30.00% complete, ETA 00:23:26 # Fork: 2 of 5 # Warmup Iteration 1: 0.432 ns/op # Warmup Iteration 2: 0.415 ns/op # Warmup Iteration 3: 0.580 ns/op # Warmup Iteration 4: 0.564
[jira] [Commented] (VFS-756) Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3
[ https://issues.apache.org/jira/browse/VFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165264#comment-17165264 ] Gary D. Gregory commented on VFS-756: - I guess releasing "unstable" software as versioned releases is normal for JR, very messy and confusing, isn't that what snapshots are for or versions that end with "-Mnumber" or "-alpna" or "-beta" or "-giveMeAClue!"? > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3 > --- > > Key: VFS-756 > URL: https://issues.apache.org/jira/browse/VFS-756 > Project: Commons VFS > Issue Type: Improvement >Reporter: Gary D. Gregory >Assignee: Gary D. Gregory >Priority: Major > Fix For: 2.7.0 > > Attachments: RECORD20200208203041.3gpp, Screenshot_20200208-194408.png > > > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (VFS-756) Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3
[ https://issues.apache.org/jira/browse/VFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165257#comment-17165257 ] Julian Reschke commented on VFS-756: [~ggregory] - please do not use odd-numbered Jackrabbit releases except for experiments (see https://issues.apache.org/jira/browse/VFS-756?focusedCommentId=17072794=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17072794). The latest stable Jackrabbit release is 2.20.1. > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3 > --- > > Key: VFS-756 > URL: https://issues.apache.org/jira/browse/VFS-756 > Project: Commons VFS > Issue Type: Improvement >Reporter: Gary D. Gregory >Assignee: Gary D. Gregory >Priority: Major > Fix For: 2.7.0 > > Attachments: RECORD20200208203041.3gpp, Screenshot_20200208-194408.png > > > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (VFS-756) Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3
[ https://issues.apache.org/jira/browse/VFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated VFS-756: Description: Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3. was: Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.0. > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3 > --- > > Key: VFS-756 > URL: https://issues.apache.org/jira/browse/VFS-756 > Project: Commons VFS > Issue Type: Improvement >Reporter: Gary D. Gregory >Assignee: Gary D. Gregory >Priority: Major > Fix For: 2.7.0 > > Attachments: RECORD20200208203041.3gpp, Screenshot_20200208-194408.png > > > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (VFS-756) Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3
[ https://issues.apache.org/jira/browse/VFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated VFS-756: Summary: Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.3 (was: Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to 2.21.0) > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.3 > --- > > Key: VFS-756 > URL: https://issues.apache.org/jira/browse/VFS-756 > Project: Commons VFS > Issue Type: Improvement >Reporter: Gary D. Gregory >Assignee: Gary D. Gregory >Priority: Major > Fix For: 2.7.0 > > Attachments: RECORD20200208203041.3gpp, Screenshot_20200208-194408.png > > > Update org.apache.jackrabbit:jackrabbit-standalone-components from 2.19.6 to > 2.21.0. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-vfs] garydgregory commented on pull request #102: Bump sshd-core from 0.8.0 to 2.5.1
garydgregory commented on pull request #102: URL: https://github.com/apache/commons-vfs/pull/102#issuecomment-664003065 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #105: Bump mina-core from 2.0.20 to 2.1.3
garydgregory commented on pull request #105: URL: https://github.com/apache/commons-vfs/pull/105#issuecomment-664003018 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #104: Bump slf4j-log4j12 from 1.5.11 to 1.7.30
garydgregory commented on pull request #104: URL: https://github.com/apache/commons-vfs/pull/104#issuecomment-664003034 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #103: Bump hadoop.version from 3.2.1 to 3.3.0
garydgregory commented on pull request #103: URL: https://github.com/apache/commons-vfs/pull/103#issuecomment-664003006 @dependabot rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (VALIDATOR-287) Allow names to be assigned to args inside a field
[ https://issues.apache.org/jira/browse/VALIDATOR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-287. Resolution: Abandoned > Allow names to be assigned to args inside a field > - > > Key: VALIDATOR-287 > URL: https://issues.apache.org/jira/browse/VALIDATOR-287 > Project: Commons Validator > Issue Type: Improvement > Components: Framework >Affects Versions: 1.3.1 Release >Reporter: John Lindal >Priority: Minor > > In the XML configuration, args for a field can only be given a position. It > would be really nice if each arg could also be given a name, because smarter > parameter replacement algorithms (smarter than the Java default > MessageFormat) allow named parameters, not merely positional parameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-244) Validator post-processing
[
https://issues.apache.org/jira/browse/VALIDATOR-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-244.
Resolution: Abandoned
> Validator post-processing
> -
>
> Key: VALIDATOR-244
> URL: https://issues.apache.org/jira/browse/VALIDATOR-244
> Project: Commons Validator
> Issue Type: New Feature
> Components: Framework
>Reporter: Paul Benedict
>Priority: Major
> Fix For: 2.0
>
>
> A new feature in Struts 1.4 is the ability to post-process the configuration
> before it is set. I believe the Validator Framework should allow the same. As
> a benefit, a developer could code substitution variables -- ${variable-name}
> -- and then read them in from a property file or database. This would allow
> easy aligning with data constraints that are already in place but in a remote
> resource.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-237) Abstract Validation framework to Actions framework.
[ https://issues.apache.org/jira/browse/VALIDATOR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-237. Resolution: Abandoned > Abstract Validation framework to Actions framework. > --- > > Key: VALIDATOR-237 > URL: https://issues.apache.org/jira/browse/VALIDATOR-237 > Project: Commons Validator > Issue Type: New Feature > Components: Framework >Affects Versions: 1.4.0 Release > Environment: All >Reporter: Bhupesh Naik >Priority: Minor > Attachments: test.actionframework.zip > > > Apache Commons validator can be ABSTRACTED to a common framework called > ACTIONS framework. > > The Actions framework will act in similar manner as validation framework but > will be independent of the way in which actions are execute on the value. > > Abstraction points. > 1.Validation can be treated as any action > 2.The value to be validated is treated as source value > 3.The return value true/false can be treated as a target value > 4.Source Value ---pass to--- > list of actions to be executed results > in---> Target Value > > We have already done this in our enterprise product, we use apache validation > framework even for transforming values in our custom ETL framework. > > Once the apache validator is abstracted as actions framework one can use the > same to not only validate the source value but to transform the value or even > in describing and modifying styles of controls in UI and much more. The > advantage here is we use the same digester , loading of elements, extending > forms and stuff, this code remains common. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-186) Enhance the IndexedListProperty to handle nested lists.
[
https://issues.apache.org/jira/browse/VALIDATOR-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-186.
Resolution: Abandoned
> Enhance the IndexedListProperty to handle nested lists.
> ---
>
> Key: VALIDATOR-186
> URL: https://issues.apache.org/jira/browse/VALIDATOR-186
> Project: Commons Validator
> Issue Type: Improvement
> Components: Framework
>Affects Versions: Nightly Builds
> Environment: Operating System: All
> Platform: All
>Reporter: Peter Oldershaw
>Priority: Minor
> Fix For: 2.0
>
>
> Allowing lists to be validated helps a great deal but the code that is
> supplied
> with the commons-validator 1.0 could be simplified and enhanced. There are
> two
> features that it would be nice to have:
> 1) When the IndexedListProperty is used it would be nice if all the fields in
> the list were validated, i.e. the validation did not stop at the first error.
>
> This would need a different loop mechanism and the key to be set to the fully
> qualified path, e.g list[0].value and not list[].value.
> 2) It would be very nice if the IndexedListProperty could be nested, e.g. the
> size for all the doors on all the rooms must be greater than n. I am not
> sure of the syntax in the configuration file that makes sense but offer
> list1.list2.list3. as a suggestion. The PropertyUtils could then be called
> on the bean using the "list1" property to get the first list and then called
> on each of the returned objects using the "list2" property, etc. So, if you
> had two rooms, the first with one door, the second with two and the
> validation.xml Field looked like:
>property="size"
> indexedListProperty="rooms.doors"
> depends="min">
>
>
> min
> ${n}
>
>
> The validator waould in effect be called for:
> rooms[0].doors[0].size
> rooms[1].doors[0].size
> rooms[1].doors[1].size
> The code below provides an example of how this could be done. It uses the
> IndexedProperty to pass information down a reentrant stack because I did not
> want to change the parameters to the Validator.validate method but that would
> obviously be safer. Also, by putting this code snipit in place, all the
> other
> isIndexed code could be removed so you don't have to loop twice (as it does
> in
> version 1.0).
> Thanks...Peter
> //
> // These snippits are out of the Validator class. There is a one line
> // change to validate, one new method and one tidied up method.
> // The code has been tested and works but you may not like the way it
> // changes the BEAN_KEY and uses the IndexProperty.
> //
> /**
> * Performs validations based on the configured resources.
> * Needed as we cannot access (override) the private methods.
> *
> * @returnThe Map returned uses the property
> *of the Field for the key and the value
> *is the number of error the field had.
> */
> public ValidatorResults validate() throws ValidatorException
> {
> ValidatorResults results = new ValidatorResults();
> Locale locale = null;
> if (hResources.containsKey(LOCALE_KEY))
> {
> locale = (Locale)hResources.get(LOCALE_KEY);
> }
> hResources.put(VALIDATOR_KEY, this);
> if (locale == null)
> {
> locale = Locale.getDefault();
> }
> Form form = null;
> if (resources == null)
> {
> throw new ValidatorException("Resources not defined for
> Validator");
> }
> if ((form = resources.get(locale, formName)) != null)
> {
> for (Iterator i = form.getFields().iterator(); i.hasNext(); )
> {
> Field field = (Field)i.next();
> if (field.getPage() <= page)
> {
> // *
> // This is the only line that changed in this method.
> // *
> validateFieldNested(field, results);
> // *
> }
> }
> }
> return results;
> }
> /**
> * Validate field nested. This method handles nested list validation
> * of the form IndexedListProperty = list1.list2.list3. It gets all the
> * instances in list1 off the BEAN_KEY (root bean) using the PropertyUtils
> * then gets all the list2
[jira] [Resolved] (VALIDATOR-170) Validating Arrays of simple Objects
[
https://issues.apache.org/jira/browse/VALIDATOR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-170.
Resolution: Abandoned
> Validating Arrays of simple Objects
> ---
>
> Key: VALIDATOR-170
> URL: https://issues.apache.org/jira/browse/VALIDATOR-170
> Project: Commons Validator
> Issue Type: Improvement
> Components: Framework
>Affects Versions: 1.3.0 Release
> Environment: Operating System: Windows 2000
> Platform: PC
>Reporter: William Ferguson
>Priority: Minor
> Fix For: 2.0
>
>
> The Validator needs the ability to validate an array of simple Objects such
> as
> Strings. Ie it should be possible to define a bean like:
> class foo {
> public String getBar();
> public void setBar(String[] values);
> }
> and have the values of Bar validated.
> Currently (validator 1.1.3 as ships with Struts 1.2.8, and looks same in
> 1.1.4),
> to validate an array of properties you need to specify
> property='somePropertyName'
> indexedListProperty='propertyAtWhichCollectionIsFound'
> This will iterate through the collection found at
> 'propertyAtWhichCollectionisFound',
> and will validate the 'somePropertyName' property on each element.
> But if it is a collection of Strings then there is no valid property name to
> define.
> Ie you don't seem to be able to validate a collection of Strings.
> To fix it, either 'property' needs to be optional (not recommended), or a new
> approach to indexed properties needs to be taken. Perhaps by allowing
> 'property'
> to define where the array of values can be found as well as any property to
> validate on the elements (using dot notation), and having the Validator
> introspect the values at each step and determine whether ot needs to iterate
> over a collection. This would also solve some of the enhancements requests
> that have been made for the Validator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-169) Field validation for a list of fields
[
https://issues.apache.org/jira/browse/VALIDATOR-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-169.
Resolution: Abandoned
> Field validation for a list of fields
> -
>
> Key: VALIDATOR-169
> URL: https://issues.apache.org/jira/browse/VALIDATOR-169
> Project: Commons Validator
> Issue Type: Improvement
> Components: Framework
> Environment: Operating System: other
> Platform: Other
>Reporter: Jovovich
>Priority: Minor
> Fix For: 2.0
>
> Attachments: ASF.LICENSE.NOT.GRANTED--patch.txt
>
>
> I have a JSP with a list of fields and I'm using the Validator in combination
> with Struts for validating the field entries. The current behaviour of the
> Validator in case of a failed validation is stopping the validation for the
> whole list of fields. It would be much better, if the validator is processing
> the list of fields in any case. As a JSP programmer, I am able to show an
> error message for _each_ wrong field of the list.
> This can be fixed with a small change in class Validator.java method
> validateField. Instead of doing a return statement in the inner loop, just
> call the break statement, so the outer loop can continue its work.
> private void validateField(Field field, ValidatorResults allResults)
> throws ValidatorException {
> Map actions = resources.getValidatorActions();
> if (field.isIndexed()) {
> Object oIndexed;
> try {
> oIndexed =
> PropertyUtils.getProperty(
> hResources.get(BEAN_KEY),
> field.getIndexedListProperty());
> } catch (Exception e) {
> log.error("in validateField", e);
> return;
> }
> Object indexedList[] = new Object[0];
> if (oIndexed instanceof Collection) {
> indexedList = ((Collection) oIndexed).toArray();
> } else if (oIndexed.getClass().isArray()) {
> indexedList = (Object[]) oIndexed;
> }
> for (int pos = 0; pos < indexedList.length; pos++) {
> ValidatorResults results = new ValidatorResults();
> StringTokenizer st = new StringTokenizer(field.getDepends(),
> ",");
> while (st.hasMoreTokens()) {
> String depend = st.nextToken().trim();
> ValidatorAction action = (ValidatorAction)
> actions.get(depend);
> if (action == null) {
> log.error(
> "No ValidatorAction called "
> + depend
> + " found for field "
> + field.getProperty());
> return;
> }
>
> boolean good =
> validateFieldForRule(field, action, results, actions,
> pos);
> allResults.merge(results);
> if (!good) {
> break;
> }
> }
> }
> Thanks,
> Tobias
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-400) IBANValidator should validate print format
[ https://issues.apache.org/jira/browse/VALIDATOR-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-400. Resolution: Won't Fix It's trivial to strip spaces. This would add extra code and maintenance for little gain > IBANValidator should validate print format > -- > > Key: VALIDATOR-400 > URL: https://issues.apache.org/jira/browse/VALIDATOR-400 > Project: Commons Validator > Issue Type: Improvement >Affects Versions: 1.5.0 >Reporter: Björn Raupach >Priority: Minor > > At the moment the IBANValidator only validates the electronic format. > It would be nice to include print format, too. Print format splits the > symbols in groups of four and separates them by a single space. Saves > stripping the whitespace in the logic before submitting the result to the > validator. > electronic format format example: AL4721211009000235698741 > print format example: AL47 2121 1009 0002 3569 8741 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-429) UrlValidator - path is invalid due to using java.net.URI for validation (regression)
[
https://issues.apache.org/jira/browse/VALIDATOR-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-429.
Fix Version/s: 1.7
Resolution: Duplicate
> UrlValidator - path is invalid due to using java.net.URI for validation
> (regression)
>
>
> Key: VALIDATOR-429
> URL: https://issues.apache.org/jira/browse/VALIDATOR-429
> Project: Commons Validator
> Issue Type: Bug
> Components: Routines
>Affects Versions: 1.6
>Reporter: limpygnome
>Priority: Major
> Labels: easyfix
> Fix For: 1.7
>
>
> h1. Summary
> We've been hit by a bug in a real world application after upgrading 1.4.1 to
> 1.6, where previously valid URLs are no longer valid, which looks to be due
> to using java.net.URI for validating the path of a URL.
> h1. Steps to Reproduce
> Our application went to validate URLs similar to the following:
> * http://example.com//_test
> This is no longer valid in 1.6.1, but the following cases are:
> * http://example.com//test
> * http://example.com/_test
> h1. Impact
> It seems paths in UrlValidator are being parsed/validated as host-names, per
> java.net.URI's validation.
> h1. Technical
> It looks like this may have been introduced by the following change:
> https://github.com/apache/commons-validator/commit/03bf0d33143ebd13e4f389cd4ecac8aec17c2057
> Specifically due to now using java.net.URI to validate a path. The usage is
> as follows in org.apache.commons.validator.routines.UrlValidator:
> {code}
> URI uri = new URI(null,null,path,null);
> {code}
> It looks like URI is trying to parse the path as a hostname when the schema
> and hostname are not specified.
> Example to reproduce:
> {code}
> new URI(null, null, "//_test", null); // throws URISyntaxException
> {code}
> Same example with other parts, no longer throwing exception:
> {code}
> new URI(null, "test", "//_test", null);
> {code}
> Even though java.net.URI states string components can be null, it seems the
> URL built internally, which is validated, is slightly different. So when
> specifying a hostname with URI, internally it constructs:
> * //test//_test
> Using no hostname, in the same way as UrlValidator, the following is
> constructed and validated internally:
> * //_test
> Therefore it looks like there's either a bug in java.net.URI, or its usage is
> not correctly documented.
> h1. Fix
> A potential fix is to change
> org.apache.commons.validator.routines.UrlValidator to pass an empty string in
> the hostname. Internally, in java.net.URI, this produces:
> * _test
> Thus the hostname is empty, which is considered empty, and the correct path
> is validated.
> Would this fix be appropriate, or considered too fragile?
> Alternatively the fix could be to extract similar logic to java.net.URI, to
> validate the path, which appears to be just checking the characters are valid
> and between a certain range. This logic can be seen in
> java.net.URI.parseHierarchical, which calls upon checkChars.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-pool] dependabot[bot] closed pull request #34: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.1
dependabot[bot] closed pull request #34: URL: https://github.com/apache/commons-pool/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-pool] dependabot[bot] commented on pull request #34: Bump maven-checkstyle-plugin from 3.0.0 to 3.1.1
dependabot[bot] commented on pull request #34: URL: https://github.com/apache/commons-pool/pull/34#issuecomment-663993488 Looks like org.apache.maven.plugins:maven-checkstyle-plugin is up-to-date now, so this is no longer needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (VALIDATOR-470) EmailValidator does not recognize IP-Adresses
[ https://issues.apache.org/jira/browse/VALIDATOR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-470. Resolution: Invalid 123.123.123.123 is not valid as a hostname; the path segments must start with a letter according to RFC 1035. However email@[123.123.123.123] is valid, because that uses the domain literal format: https://tools.ietf.org/html/rfc5321#section-4.1.3 > EmailValidator does not recognize IP-Adresses > - > > Key: VALIDATOR-470 > URL: https://issues.apache.org/jira/browse/VALIDATOR-470 > Project: Commons Validator > Issue Type: Bug >Reporter: Lonzak >Priority: Major > > email@123.123.123.123 > is considered an invalid. This is not correct. > Strangely "email@[123.123.123.123]" is considered to be valid... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-269) warn if object validated is not the object inspected
[ https://issues.apache.org/jira/browse/VALIDATOR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-269. Resolution: Abandoned > warn if object validated is not the object inspected > > > Key: VALIDATOR-269 > URL: https://issues.apache.org/jira/browse/VALIDATOR-269 > Project: Commons Validator > Issue Type: Improvement >Affects Versions: 1.3.1 Release >Reporter: Ralf Hauser >Priority: Major > > some help could come from BEANUTILS-323 , but it would be better to > proactively > issue a warning by saying what form class was expected and what validatorForm > subclass was found > ERROR [http-www.privasphere.com%2F212.25.12.194-8443-Processor10] > (ValidatorUtils.java:112) - Unknown property 'xyz' > java.lang.NoSuchMethodException: Unknown property 'xyz' > at > org.apache.commons.beanutils.PropertyUtilsBean.getSimpleProperty(PropertyUtilsBean.java:1122) > at > org.apache.commons.beanutils.PropertyUtilsBean.getNestedProperty(PropertyUtilsBean.java:686) > at > org.apache.commons.beanutils.PropertyUtilsBean.getProperty(PropertyUtilsBean.java:715) > at > org.apache.commons.beanutils.PropertyUtils.getProperty(PropertyUtils.java:290) > at > org.apache.commons.validator.util.ValidatorUtils.getValueAsString(ValidatorUtils.java:102) > at org.apache.struts.validator.FieldChecks.evaluateBean(FieldChecks.java:336) > at > org.apache.struts.validator.FieldChecks.validateMinLength(FieldChecks.java:1156) > at sun.reflect.GeneratedMethodAccessor109.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.commons.validator.ValidatorAction.executeValidationMethod(ValidatorAction.java:544) > at org.apache.commons.validator.Field.validateForRule(Field.java:796) > at org.apache.commons.validator.Field.validate(Field.java:876) > at org.apache.commons.validator.Form.validate(Form.java:288) > at org.apache.commons.validator.Validator.validate(Validator.java:351) > at org.apache.struts.validator.ValidatorForm.validate(ValidatorForm.java:116) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-279) Create an implementation of the JSR-303 Bean Validation Spec
[ https://issues.apache.org/jira/browse/VALIDATOR-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-279. Resolution: Abandoned > Create an implementation of the JSR-303 Bean Validation Spec > > > Key: VALIDATOR-279 > URL: https://issues.apache.org/jira/browse/VALIDATOR-279 > Project: Commons Validator > Issue Type: New Feature >Affects Versions: 2.0 >Reporter: Donald Woods >Assignee: Donald Woods >Priority: Major > Fix For: 2.0 > > > Upgrade/rework the validator code to create a JSR-303 compliant > implementation, which can then be used by Apache Geronimo, OpenJPA and > MyFaces, instead of the RedHat Hibernate RI. > Work will be performed in the sandbox as 2.0-SNAPSHOT, until we have made > enough progress to consider moving it to trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-217) org.apache.commons.validator.ValidatorResults should contain a method which will tell whether all the validators are true
[ https://issues.apache.org/jira/browse/VALIDATOR-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-217. Resolution: Abandoned > org.apache.commons.validator.ValidatorResults should contain a method which > will tell whether all the validators are true > - > > Key: VALIDATOR-217 > URL: https://issues.apache.org/jira/browse/VALIDATOR-217 > Project: Commons Validator > Issue Type: Improvement > Components: Framework > Environment: All >Reporter: raj >Priority: Major > Fix For: 2.0 > > > The org.apache.commons.validator.ValidatorResults does not contain any method > which gives me a consolidated result. As a developer i am interested in > knowing whether all the validations are true. Only if there is any failure i > will go through the individual ValidatorResult. But ValidatorResults doesnt > provide me such a method. Because of this each time i run the > Validator.validate method i get a ValidatorResults and i need to parse > through each ValidatorResult in ValidatorResults to know whether the > validation is successful. > If there is a method in ValidatorResults which will give me a consolidated > result probably a boolean true then i need not parse the ValidatorResults for > each field and check whether it is validated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-326) Configure DomainValidator to accept any well-formed TLDs
[ https://issues.apache.org/jira/browse/VALIDATOR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-326. Resolution: Abandoned > Configure DomainValidator to accept any well-formed TLDs > > > Key: VALIDATOR-326 > URL: https://issues.apache.org/jira/browse/VALIDATOR-326 > Project: Commons Validator > Issue Type: Improvement >Reporter: Max Gilead >Priority: Major > Labels: patch > Attachments: VALIDATOR-326.patch > > > Currently DomainValidator can be put into 'allowLocal' mode which accepts any > well-formed host names (like 'myhostname') but does not accept subdomains > (like 'myhostname.mynetwork'). Intranet networks are sometimes configured > with unusual internal top-level domains and for such cases it's necessary to > relax the check for a TLD to allow pretty much any well-formed domain. > The attached patch does that by adding another flag to the UrlValidator and > exposing a new constructor in DomainValidator and EmailValidator. The patch > is against the latest SVN as of 2013.12.09 (rev 1549539). > Please note this patch does not add any missing top-level domains or > otherwise alter the existing behaviour. > Legal: I release this code into the public domain for anyone to use and > relicense as they see fit; with no warranties of any kind. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-430) Local domain TLDs should include "test"
[ https://issues.apache.org/jira/browse/VALIDATOR-430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-430. Resolution: Won't Fix See VALIDATOR-471 for a work-round > Local domain TLDs should include "test" > --- > > Key: VALIDATOR-430 > URL: https://issues.apache.org/jira/browse/VALIDATOR-430 > Project: Commons Validator > Issue Type: Improvement > Components: Routines >Affects Versions: 1.6 >Reporter: Jason Klapste >Priority: Major > > In addition to "localhost" and "localdomain", it would be helpful if "test" > was added to the list of allowed local domains: > * https://en.wikipedia.org/wiki/.test -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-456) provide an extractor of routingNo and AccountNo for a valid IBAN
[
https://issues.apache.org/jira/browse/VALIDATOR-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved VALIDATOR-456.
Resolution: Won't Fix
Looks to be too difficult to define a suitable API
> provide an extractor of routingNo and AccountNo for a valid IBAN
>
>
> Key: VALIDATOR-456
> URL: https://issues.apache.org/jira/browse/VALIDATOR-456
> Project: Commons Validator
> Issue Type: New Feature
>Reporter: Eugen Hanussek
>Priority: Major
>
> for a validated iban, we can extract the routingNo and AccountNo
> example for Austria
> {{ATkk bccc }} - {{b}} is the routingNo and {{ccc...c}} is
> the AccountNo
> Benifit : with routingNo we can find the bank the iban belongs to.
> Example : AT611904300234573201 - the routingNo is 19043 - this is UniCredit
> Bank AG
> regards
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (VALIDATOR-471) Allow DomainValidator overrides at run-time
[ https://issues.apache.org/jira/browse/VALIDATOR-471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved VALIDATOR-471. Resolution: Fixed Fixed: commit 2ca205750ad3e0a02b180369d2a36a39d3103796 VALIDATOR-471 Allow DomainValidator overrides --- src/changes/changes.xml| 6 +- .../validator/routines/DomainValidator.java| 161 ++--- .../routines/DomainValidatorStartupTest.java | 33 + 3 files changed, 177 insertions(+), 23 deletions(-) > Allow DomainValidator overrides at run-time > --- > > Key: VALIDATOR-471 > URL: https://issues.apache.org/jira/browse/VALIDATOR-471 > Project: Commons Validator > Issue Type: Bug >Reporter: Sebb >Priority: Major > > It would be useful to allow DomainValidator instances to be created with > different overrides. > Currently this is not possible because there are only two cached instances. > As such, it's not possible to make changes after initialisation. > The class could be extended allow further instances to be created, whilst > still keeping the existing behaviour for the cached instances. > This would allow users to create further instances with local changes to the > Generic and CountryCode lists. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (MATH-1551) Compute Percentile with Weighted Samples
[ https://issues.apache.org/jira/browse/MATH-1551?focusedWorklogId=463332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463332 ] ASF GitHub Bot logged work on MATH-1551: Author: ASF GitHub Bot Created on: 26/Jul/20 11:28 Start Date: 26/Jul/20 11:28 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #157: URL: https://github.com/apache/commons-math/pull/157#issuecomment-663976272 [](https://coveralls.io/builds/32326259) Coverage decreased (-0.1%) to 90.825% when pulling **88e07f599dacac7d226c68ea2d9e6d3807defcdb on iii-org-tw:MATH-1551-WeightedPercentile** into **d0ed03c953bf436fc4dc32260c6018a7791c9efc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463332) Time Spent: 20m (was: 10m) > Compute Percentile with Weighted Samples > > > Key: MATH-1551 > URL: https://issues.apache.org/jira/browse/MATH-1551 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: institute for information industry >Priority: Major > Labels: features, newbie > Fix For: 4.0 > > Attachments: Percentile.java > > Time Spent: 20m > Remaining Estimate: 0h > > The class Percentile only support estimation on non-weighted samples. > I've implement some function to estimate percentiles of weighted samples. > here is the reference: > [https://stats.stackexchange.com/questions/13169/defining-quantiles-over-a-weighted-sample]!https://mail.google.com/mail/u/0?ui=2=6059a2f2a6=0.1=msg-a:r-8896240918589631988=1737bdaafc3e228f=fimg=s0-l75-ft=ANGjdJ_GwCQ-hqi0o7ZJTEqcl6JLYbFiR2Y1sqxPL8jDNzheraAkX0beEUtAM4BYI2v_5XGvzCPj2gTBQutHT9bF8hYh7MgdiGYZhn0HtDuVswuCSuwy8aJVsvy3EqI=emb=ii_kcyrjgea0! > > When all weights are equal to each other, it works like estimation on > non-weighted samples under R-7. > I can't find formulas for other rules but at least, now it can evaluate > percentile for weighted samples. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-math] coveralls commented on pull request #157: MATH-1551: Add Weighted percentile features
coveralls commented on pull request #157: URL: https://github.com/apache/commons-math/pull/157#issuecomment-663976272 [](https://coveralls.io/builds/32326259) Coverage decreased (-0.1%) to 90.825% when pulling **88e07f599dacac7d226c68ea2d9e6d3807defcdb on iii-org-tw:MATH-1551-WeightedPercentile** into **d0ed03c953bf436fc4dc32260c6018a7791c9efc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-math] iii-org-tw opened a new pull request #157: MATH-1551: Add Weighted percentile features
iii-org-tw opened a new pull request #157: URL: https://github.com/apache/commons-math/pull/157 Add weighted percentile features to o.a.c.m.stat.descriptive.rank.Percentile. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (MATH-1551) Compute Percentile with Weighted Samples
[ https://issues.apache.org/jira/browse/MATH-1551?focusedWorklogId=463331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463331 ] ASF GitHub Bot logged work on MATH-1551: Author: ASF GitHub Bot Created on: 26/Jul/20 11:19 Start Date: 26/Jul/20 11:19 Worklog Time Spent: 10m Work Description: iii-org-tw opened a new pull request #157: URL: https://github.com/apache/commons-math/pull/157 Add weighted percentile features to o.a.c.m.stat.descriptive.rank.Percentile. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 463331) Remaining Estimate: 0h Time Spent: 10m > Compute Percentile with Weighted Samples > > > Key: MATH-1551 > URL: https://issues.apache.org/jira/browse/MATH-1551 > Project: Commons Math > Issue Type: New Feature >Affects Versions: 4.0 >Reporter: institute for information industry >Priority: Major > Labels: features, newbie > Fix For: 4.0 > > Attachments: Percentile.java > > Time Spent: 10m > Remaining Estimate: 0h > > The class Percentile only support estimation on non-weighted samples. > I've implement some function to estimate percentiles of weighted samples. > here is the reference: > [https://stats.stackexchange.com/questions/13169/defining-quantiles-over-a-weighted-sample]!https://mail.google.com/mail/u/0?ui=2=6059a2f2a6=0.1=msg-a:r-8896240918589631988=1737bdaafc3e228f=fimg=s0-l75-ft=ANGjdJ_GwCQ-hqi0o7ZJTEqcl6JLYbFiR2Y1sqxPL8jDNzheraAkX0beEUtAM4BYI2v_5XGvzCPj2gTBQutHT9bF8hYh7MgdiGYZhn0HtDuVswuCSuwy8aJVsvy3EqI=emb=ii_kcyrjgea0! > > When all weights are equal to each other, it works like estimation on > non-weighted samples under R-7. > I can't find formulas for other rules but at least, now it can evaluate > percentile for weighted samples. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (LANG-1575) remake StringUtils.capitalize
[ https://issues.apache.org/jira/browse/LANG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed LANG-1575. Resolution: Won't Do nope, this pr is meaningless. will close it. > remake StringUtils.capitalize > - > > Key: LANG-1575 > URL: https://issues.apache.org/jira/browse/LANG-1575 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/563] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-180) Minor improvements
[ https://issues.apache.org/jira/browse/TEXT-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-180. --- Resolution: Fixed > Minor improvements > -- > > Key: TEXT-180 > URL: https://issues.apache.org/jira/browse/TEXT-180 > Project: Commons Text > Issue Type: Improvement >Reporter: Jin Xu >Priority: Minor > > Minor improvements to Commons Text -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-181) Fix Javadocs
[ https://issues.apache.org/jira/browse/TEXT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-181. --- > Fix Javadocs > > > Key: TEXT-181 > URL: https://issues.apache.org/jira/browse/TEXT-181 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/135] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-183) Make ConstantStringLookup.constantCache final
[ https://issues.apache.org/jira/browse/TEXT-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-183. --- > Make ConstantStringLookup.constantCache final > - > > Key: TEXT-183 > URL: https://issues.apache.org/jira/browse/TEXT-183 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/136] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-182) Fix typos
[ https://issues.apache.org/jira/browse/TEXT-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-182. --- > Fix typos > - > > Key: TEXT-182 > URL: https://issues.apache.org/jira/browse/TEXT-182 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-text/pull/137 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (TEXT-184) Simplify if in CaseUtils
[ https://issues.apache.org/jira/browse/TEXT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu closed TEXT-184. --- > Simplify if in CaseUtils > > > Key: TEXT-184 > URL: https://issues.apache.org/jira/browse/TEXT-184 > Project: Commons Text > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Fix For: 1.9 > > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-text/pull/134] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1551) Compute Percentile with Weighted Samples
[
https://issues.apache.org/jira/browse/MATH-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165193#comment-17165193
]
Gilles Sadowski commented on MATH-1551:
---
bq. I have fixed the errors you mentioned and add test functions.
Thanks.
Could open a pull request?
Please take care that it is based on the more recent "master" branch and that
all commits are squashed (i.e. the PR should contain a single commit).
If the PR's title contains this issue's id, it will hopefully be automatically
linked to this report.
bq. FastMath should implement all StrictMath methods.
This appears when running the tests with a JDK with more functions than those
implemented in Commons Math.
Under Java 8, there will be no error (if you have several JDKs installed, you
can set the {{JAVA_HOME}} environment variable), e.g.
{noformat}
$ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 mvn test
{noformat}
bq. Is it regarded as passing test?
Yes.
If you create a PR, then Travis should automatically build the project and
signal if all went fine or not.
bq. I found the original code will cause unexpected results.
Please create another JIRA report.
> Compute Percentile with Weighted Samples
>
>
> Key: MATH-1551
> URL: https://issues.apache.org/jira/browse/MATH-1551
> Project: Commons Math
> Issue Type: New Feature
>Affects Versions: 4.0
>Reporter: institute for information industry
>Priority: Major
> Labels: features, newbie
> Fix For: 4.0
>
> Attachments: Percentile.java
>
>
> The class Percentile only support estimation on non-weighted samples.
> I've implement some function to estimate percentiles of weighted samples.
> here is the reference:
> [https://stats.stackexchange.com/questions/13169/defining-quantiles-over-a-weighted-sample]!https://mail.google.com/mail/u/0?ui=2=6059a2f2a6=0.1=msg-a:r-8896240918589631988=1737bdaafc3e228f=fimg=s0-l75-ft=ANGjdJ_GwCQ-hqi0o7ZJTEqcl6JLYbFiR2Y1sqxPL8jDNzheraAkX0beEUtAM4BYI2v_5XGvzCPj2gTBQutHT9bF8hYh7MgdiGYZhn0HtDuVswuCSuwy8aJVsvy3EqI=emb=ii_kcyrjgea0!
>
> When all weights are equal to each other, it works like estimation on
> non-weighted samples under R-7.
> I can't find formulas for other rules but at least, now it can evaluate
> percentile for weighted samples.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-imaging] kinow closed pull request #83: Bump animal-sniffer-maven-plugin from 1.17 to 1.19
kinow closed pull request #83: URL: https://github.com/apache/commons-imaging/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-imaging] kinow merged pull request #83: Bump animal-sniffer-maven-plugin from 1.17 to 1.19
kinow merged pull request #83: URL: https://github.com/apache/commons-imaging/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
