[
https://issues.apache.org/jira/browse/MATH-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165193#comment-17165193
]
Gilles Sadowski commented on MATH-1551:
---------------------------------------
bq. I have fixed the errors you mentioned and add test functions.
Thanks.
Could open a pull request?
Please take care that it is based on the more recent "master" branch and that
all commits are squashed (i.e. the PR should contain a single commit).
If the PR's title contains this issue's id, it will hopefully be automatically
linked to this report.
bq. FastMath should implement all StrictMath methods.
This appears when running the tests with a JDK with more functions than those
implemented in Commons Math.
Under Java 8, there will be no error (if you have several JDKs installed, you
can set the {{JAVA_HOME}} environment variable), e.g.
{noformat}
$ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 mvn test
{noformat}
bq. Is it regarded as passing test?
Yes.
If you create a PR, then Travis should automatically build the project and
signal if all went fine or not.
bq. I found the original code will cause unexpected results.
Please create another JIRA report.
> Compute Percentile with Weighted Samples
> ----------------------------------------
>
> Key: MATH-1551
> URL: https://issues.apache.org/jira/browse/MATH-1551
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 4.0
> Reporter: institute for information industry
> Priority: Major
> Labels: features, newbie
> Fix For: 4.0
>
> Attachments: Percentile.java
>
>
> The class Percentile only support estimation on non-weighted samples.
> I've implement some function to estimate percentiles of weighted samples.
> here is the reference:
> [https://stats.stackexchange.com/questions/13169/defining-quantiles-over-a-weighted-sample]!https://mail.google.com/mail/u/0?ui=2&ik=6059a2f2a6&attid=0.1&permmsgid=msg-a:r-8896240918589631988&th=1737bdaafc3e228f&view=fimg&sz=s0-l75-ft&attbid=ANGjdJ_GwCQ-hqi0o7ZJTEqcl6JLYbFiR2Y1sqxPL8jDNzheraAkX0beEUtAM4BYI2v_5XGvzCPj2gTBQutHT9bF8hYh7MgdiGYZhn0HtDuVswuCSuwy8aJVsvy3EqI&disp=emb&realattid=ii_kcyrjgea0!
>
> When all weights are equal to each other, it works like estimation on
> non-weighted samples under R-7.
> I can't find formulas for other rules but at least, now it can evaluate
> percentile for weighted samples.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
