[jira] [Closed] (LANG-1636) Add missing boolean[] join method
[ https://issues.apache.org/jira/browse/LANG-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed LANG-1636. --- Resolution: Fixed in master > Add missing boolean[] join method > - > > Key: LANG-1636 > URL: https://issues.apache.org/jira/browse/LANG-1636 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Join Implementation it's missing for primitive of type boolean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1634) ObjectUtils - apply Consumer with non-null value
[
https://issues.apache.org/jira/browse/LANG-1634?focusedWorklogId=532243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532243
]
ASF GitHub Bot logged work on LANG-1634:
Author: ASF GitHub Bot
Created on: 07/Jan/21 02:57
Start Date: 07/Jan/21 02:57
Worklog Time Spent: 10m
Work Description: coveralls edited a comment on pull request #684:
URL: https://github.com/apache/commons-lang/pull/684#issuecomment-751870250
[](https://coveralls.io/builds/36143331)
Coverage increased (+0.005%) to 94.986% when pulling
**7684dac30487198644269a9979248b80ca0680a1 on
bindul:LANG-1634_ObjectUtils-applyIfNonNull** into
**e739844b11c32a88bc04ebb39c9b433d364832cd on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 532243)
Time Spent: 3h (was: 2h 50m)
> ObjectUtils - apply Consumer with non-null value
>
>
> Key: LANG-1634
> URL: https://issues.apache.org/jira/browse/LANG-1634
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Reporter: Bindul Bhowmik
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> There are multiple places in code where we have to check if a value is
> {{null}} before using it in a setter or other method, like:
> {code:java}
> if (valueX != null) {
> bean.setValue(valueX);
> someObject.compute(valueX, "bar");
> }
> {code}
> This enhancement request is to add a couple of methods in {{ObjectUtils}} to
> wrap this logic, like the following:
> {code:java}
> public static void applyIfNonNull(final Consumer consumer, final T
> object)
> public static void applyFirstNonNull(final Consumer consumer, final
> T... objects)
> {code}
> With this the two statements above could be used as:
> {code:java}
> ObjectUtils.applyIfNonNull(bean::setValue, valueX);
> ObjectUtils.appyIfNonNull(v -> someObject.compute(v, "bar"), valueX);
> {code}
> The benefit of this should increase with more such null checks we need in the
> code that can be replaced by single statements.
> Pull request forthcoming.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #684: [LANG-1634] Add ObjectUtils #applyIfNonNull and #applyFirstNonNull
coveralls edited a comment on pull request #684: URL: https://github.com/apache/commons-lang/pull/684#issuecomment-751870250 [](https://coveralls.io/builds/36143331) Coverage increased (+0.005%) to 94.986% when pulling **7684dac30487198644269a9979248b80ca0680a1 on bindul:LANG-1634_ObjectUtils-applyIfNonNull** into **e739844b11c32a88bc04ebb39c9b433d364832cd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1634) ObjectUtils - apply Consumer with non-null value
[
https://issues.apache.org/jira/browse/LANG-1634?focusedWorklogId=532162=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532162
]
ASF GitHub Bot logged work on LANG-1634:
Author: ASF GitHub Bot
Created on: 06/Jan/21 22:04
Start Date: 06/Jan/21 22:04
Worklog Time Spent: 10m
Work Description: bindul commented on pull request #684:
URL: https://github.com/apache/commons-lang/pull/684#issuecomment-755741326
@garydgregory Done!
Please let me know if you want me to squash commits into logical groups (I
am thinking 1 with the change and the changes for review comments and another
where the new method is used elsewhere in lang)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 532162)
Time Spent: 2h 50m (was: 2h 40m)
> ObjectUtils - apply Consumer with non-null value
>
>
> Key: LANG-1634
> URL: https://issues.apache.org/jira/browse/LANG-1634
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Reporter: Bindul Bhowmik
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> There are multiple places in code where we have to check if a value is
> {{null}} before using it in a setter or other method, like:
> {code:java}
> if (valueX != null) {
> bean.setValue(valueX);
> someObject.compute(valueX, "bar");
> }
> {code}
> This enhancement request is to add a couple of methods in {{ObjectUtils}} to
> wrap this logic, like the following:
> {code:java}
> public static void applyIfNonNull(final Consumer consumer, final T
> object)
> public static void applyFirstNonNull(final Consumer consumer, final
> T... objects)
> {code}
> With this the two statements above could be used as:
> {code:java}
> ObjectUtils.applyIfNonNull(bean::setValue, valueX);
> ObjectUtils.appyIfNonNull(v -> someObject.compute(v, "bar"), valueX);
> {code}
> The benefit of this should increase with more such null checks we need in the
> code that can be replaced by single statements.
> Pull request forthcoming.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] bindul commented on pull request #684: [LANG-1634] Add ObjectUtils #applyIfNonNull and #applyFirstNonNull
bindul commented on pull request #684: URL: https://github.com/apache/commons-lang/pull/684#issuecomment-755741326 @garydgregory Done! Please let me know if you want me to squash commits into logical groups (I am thinking 1 with the change and the changes for review comments and another where the new method is used elsewhere in lang) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (LANG-1637) FastDatePrinter formatting using YY pattern yields junk digits
[
https://issues.apache.org/jira/browse/LANG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-1637.
---
Fix Version/s: 3.12
Resolution: Fixed
[~ugonen]
In git master, please verify and close this ticket.
TY!
> FastDatePrinter formatting using YY pattern yields junk digits
> --
>
> Key: LANG-1637
> URL: https://issues.apache.org/jira/browse/LANG-1637
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.11
>Reporter: Uri Gonen
>Priority: Minor
> Fix For: 3.12
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> {code:java}
> final GregorianCalendar cal = new GregorianCalendar(2020, 12, 31, 0, 0, 0);
> final DatePrinter printer2Digits = getInstance("YY");
> assertEquals("21", printer2Digits.format(cal));
> {code}
> the above test fails
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1634) ObjectUtils - apply Consumer with non-null value
[
https://issues.apache.org/jira/browse/LANG-1634?focusedWorklogId=532132=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532132
]
ASF GitHub Bot logged work on LANG-1634:
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:56
Start Date: 06/Jan/21 20:56
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #684:
URL: https://github.com/apache/commons-lang/pull/684#issuecomment-755682248
@bindul Please rebase on master. TY!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 532132)
Time Spent: 2h 40m (was: 2.5h)
> ObjectUtils - apply Consumer with non-null value
>
>
> Key: LANG-1634
> URL: https://issues.apache.org/jira/browse/LANG-1634
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.*
>Reporter: Bindul Bhowmik
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> There are multiple places in code where we have to check if a value is
> {{null}} before using it in a setter or other method, like:
> {code:java}
> if (valueX != null) {
> bean.setValue(valueX);
> someObject.compute(valueX, "bar");
> }
> {code}
> This enhancement request is to add a couple of methods in {{ObjectUtils}} to
> wrap this logic, like the following:
> {code:java}
> public static void applyIfNonNull(final Consumer consumer, final T
> object)
> public static void applyFirstNonNull(final Consumer consumer, final
> T... objects)
> {code}
> With this the two statements above could be used as:
> {code:java}
> ObjectUtils.applyIfNonNull(bean::setValue, valueX);
> ObjectUtils.appyIfNonNull(v -> someObject.compute(v, "bar"), valueX);
> {code}
> The benefit of this should increase with more such null checks we need in the
> code that can be replaced by single statements.
> Pull request forthcoming.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #684: [LANG-1634] Add ObjectUtils #applyIfNonNull and #applyFirstNonNull
garydgregory commented on pull request #684: URL: https://github.com/apache/commons-lang/pull/684#issuecomment-755682248 @bindul Please rebase on master. TY! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1637) FastDatePrinter formatting using YY pattern yields junk digits
[
https://issues.apache.org/jira/browse/LANG-1637?focusedWorklogId=532130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532130
]
ASF GitHub Bot logged work on LANG-1637:
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:51
Start Date: 06/Jan/21 20:51
Worklog Time Spent: 10m
Work Description: garydgregory merged pull request #688:
URL: https://github.com/apache/commons-lang/pull/688
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 532130)
Time Spent: 4h 50m (was: 4h 40m)
> FastDatePrinter formatting using YY pattern yields junk digits
> --
>
> Key: LANG-1637
> URL: https://issues.apache.org/jira/browse/LANG-1637
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.11
>Reporter: Uri Gonen
>Priority: Minor
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> {code:java}
> final GregorianCalendar cal = new GregorianCalendar(2020, 12, 31, 0, 0, 0);
> final DatePrinter printer2Digits = getInstance("YY");
> assertEquals("21", printer2Digits.format(cal));
> {code}
> the above test fails
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #688: [LANG-1637] Fix 2 digit week year formatting
garydgregory merged pull request #688: URL: https://github.com/apache/commons-lang/pull/688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532126 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 20:42 Start Date: 06/Jan/21 20:42 Worklog Time Spent: 10m Work Description: garydgregory edited a comment on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT ``` instead of `2.9.0-SNAPSHOT`. Am I reading these results right? `IOUtilsContentEqualsPerformanceTest.testBufferedInputStream2` is 0.001% faster than `IOUtilsContentEqualsPerformanceTest.testBufferedInputStream` which is within the margin of error? If so, it's not worth it especially since the highest "2" score is higher than the highest normal score (using the error margin). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 532126) Time Spent: 1h 40m (was: 1.5h) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory edited a comment on pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and performanc
garydgregory edited a comment on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT ``` instead of `2.9.0-SNAPSHOT`. Am I reading these results right? `IOUtilsContentEqualsPerformanceTest.testBufferedInputStream2` is 0.001% faster than `IOUtilsContentEqualsPerformanceTest.testBufferedInputStream` which is within the margin of error? If so, it's not worth it especially since the highest "2" score is higher than the highest normal score (using the error margin). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[
https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532114=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532114
]
ASF GitHub Bot logged work on IO-698:
-
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:25
Start Date: 06/Jan/21 20:25
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552944750
##
File path:
src/test/java/org/apache/commons/io/performance/IOUtilsContentEqualsPerformanceTest.java
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.performance;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringReader;
+import java.util.concurrent.TimeUnit;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedInputStream;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedReader;
+import org.apache.commons.lang3.StringUtils;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server"})
+public class IOUtilsContentEqualsPerformanceTest {
+static String[] STRINGS = new String[1];
+
+static {
+STRINGS[0] = StringUtils.repeat("ab", 1 << 24);
+}
+
+@Benchmark
+public void testBufferedInputStream(Blackhole blackhole) throws
IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedInputStream(Blackhole blackhole)
throws IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testBufferedReader(Blackhole blackhole) throws IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+BufferedReader bufferedReader = new BufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedReader(Blackhole blackhole) throws
IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+UnsynchronizedBufferedReader bufferedReader =
[GitHub] [commons-io] garydgregory commented on a change in pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and perfo
garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552944750
##
File path:
src/test/java/org/apache/commons/io/performance/IOUtilsContentEqualsPerformanceTest.java
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.performance;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringReader;
+import java.util.concurrent.TimeUnit;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedInputStream;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedReader;
+import org.apache.commons.lang3.StringUtils;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server"})
+public class IOUtilsContentEqualsPerformanceTest {
+static String[] STRINGS = new String[1];
+
+static {
+STRINGS[0] = StringUtils.repeat("ab", 1 << 24);
+}
+
+@Benchmark
+public void testBufferedInputStream(Blackhole blackhole) throws
IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedInputStream(Blackhole blackhole)
throws IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testBufferedReader(Blackhole blackhole) throws IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+BufferedReader bufferedReader = new BufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedReader(Blackhole blackhole) throws
IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+UnsynchronizedBufferedReader bufferedReader = new
UnsynchronizedBufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+@Benchmark
+public void
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[
https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532109=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532109
]
ASF GitHub Bot logged work on IO-698:
-
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:22
Start Date: 06/Jan/21 20:22
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552943274
##
File path:
src/test/java/org/apache/commons/io/performance/IOUtilsContentEqualsPerformanceTest.java
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.performance;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringReader;
+import java.util.concurrent.TimeUnit;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedInputStream;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedReader;
+import org.apache.commons.lang3.StringUtils;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server"})
+public class IOUtilsContentEqualsPerformanceTest {
+static String[] STRINGS = new String[1];
+
+static {
+STRINGS[0] = StringUtils.repeat("ab", 1 << 24);
+}
+
+@Benchmark
+public void testBufferedInputStream(Blackhole blackhole) throws
IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedInputStream(Blackhole blackhole)
throws IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testBufferedReader(Blackhole blackhole) throws IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+BufferedReader bufferedReader = new BufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedReader(Blackhole blackhole) throws
IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+UnsynchronizedBufferedReader bufferedReader =
[GitHub] [commons-io] garydgregory commented on a change in pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and perfo
garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552943274
##
File path:
src/test/java/org/apache/commons/io/performance/IOUtilsContentEqualsPerformanceTest.java
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.performance;
+
+import java.io.BufferedInputStream;
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringReader;
+import java.util.concurrent.TimeUnit;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedInputStream;
+import org.apache.commons.io.input.buffer.UnsynchronizedBufferedReader;
+import org.apache.commons.lang3.StringUtils;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+
+/**
+ * Test to show whether using BitSet for removeAll() methods is faster than
using HashSet.
+ */
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@State(Scope.Thread)
+@Warmup(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Measurement(iterations = 1, time = 10, timeUnit = TimeUnit.SECONDS)
+@Fork(value = 1, jvmArgs = {"-server"})
+public class IOUtilsContentEqualsPerformanceTest {
+static String[] STRINGS = new String[1];
+
+static {
+STRINGS[0] = StringUtils.repeat("ab", 1 << 24);
+}
+
+@Benchmark
+public void testBufferedInputStream(Blackhole blackhole) throws
IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+BufferedInputStream bufferedInputStream = new
BufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedInputStream(Blackhole blackhole)
throws IOException {
+try (
+InputStream inputStream = IOUtils.toInputStream(STRINGS[0]);
+UnsynchronizedBufferedInputStream bufferedInputStream = new
UnsynchronizedBufferedInputStream(inputStream)
+) {
+while (true) {
+int nowI = bufferedInputStream.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testBufferedReader(Blackhole blackhole) throws IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+BufferedReader bufferedReader = new BufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+@Benchmark
+public void testUnsynchronizedBufferedReader(Blackhole blackhole) throws
IOException {
+try (
+StringReader inputReader = new StringReader(STRINGS[0]);
+UnsynchronizedBufferedReader bufferedReader = new
UnsynchronizedBufferedReader(inputReader)
+) {
+while (true) {
+int nowI = bufferedReader.read();
+// do nothing
+blackhole.consume(nowI);
+if (nowI != -1) {
+break;
+}
+}
+}
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+@Benchmark
+public void
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[
https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532108
]
ASF GitHub Bot logged work on IO-698:
-
Author: ASF GitHub Bot
Created on: 06/Jan/21 20:13
Start Date: 06/Jan/21 20:13
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552939523
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedInputStream.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.InputStream;
+import org.apache.commons.io.IOUtils;
+import static org.apache.commons.io.IOUtils.EOF;
+
+/**
+ * A BufferedReader class who does not care about thread safety, but very much
faster.
+ *
+ * Should be able to replace java.io.BufferedReader in nearly every use-cases
when you
+ * need the Reader be buffered, but do not need it have thread safety.
+ */
+public class UnsynchronizedBufferedInputStream extends InputStream {
+private final InputStream inputStream;
+private final byte[] byteBuffer;
+
+private int nowIndex = 0;
Review comment:
Don't initialize values to their defaults.
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedInputStream.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.InputStream;
+import org.apache.commons.io.IOUtils;
+import static org.apache.commons.io.IOUtils.EOF;
+
+/**
+ * A BufferedReader class who does not care about thread safety, but very much
faster.
+ *
+ * Should be able to replace java.io.BufferedReader in nearly every use-cases
when you
+ * need the Reader be buffered, but do not need it have thread safety.
+ */
+public class UnsynchronizedBufferedInputStream extends InputStream {
+private final InputStream inputStream;
+private final byte[] byteBuffer;
+
+private int nowIndex = 0;
+private int nowLimit = 0;
Review comment:
Don't initialize values to their defaults.
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedReader.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.Reader;
+import
[GitHub] [commons-io] garydgregory commented on a change in pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and perfo
garydgregory commented on a change in pull request #184:
URL: https://github.com/apache/commons-io/pull/184#discussion_r552939523
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedInputStream.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.InputStream;
+import org.apache.commons.io.IOUtils;
+import static org.apache.commons.io.IOUtils.EOF;
+
+/**
+ * A BufferedReader class who does not care about thread safety, but very much
faster.
+ *
+ * Should be able to replace java.io.BufferedReader in nearly every use-cases
when you
+ * need the Reader be buffered, but do not need it have thread safety.
+ */
+public class UnsynchronizedBufferedInputStream extends InputStream {
+private final InputStream inputStream;
+private final byte[] byteBuffer;
+
+private int nowIndex = 0;
Review comment:
Don't initialize values to their defaults.
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedInputStream.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.InputStream;
+import org.apache.commons.io.IOUtils;
+import static org.apache.commons.io.IOUtils.EOF;
+
+/**
+ * A BufferedReader class who does not care about thread safety, but very much
faster.
+ *
+ * Should be able to replace java.io.BufferedReader in nearly every use-cases
when you
+ * need the Reader be buffered, but do not need it have thread safety.
+ */
+public class UnsynchronizedBufferedInputStream extends InputStream {
+private final InputStream inputStream;
+private final byte[] byteBuffer;
+
+private int nowIndex = 0;
+private int nowLimit = 0;
Review comment:
Don't initialize values to their defaults.
##
File path:
src/main/java/org/apache/commons/io/input/buffer/UnsynchronizedBufferedReader.java
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.io.input.buffer;
+
+import java.io.IOException;
+import java.io.Reader;
+import org.apache.commons.io.IOUtils;
+import static org.apache.commons.io.IOUtils.EOF;
+
+/**
+ * A BufferedReader class who does not care about thread safety, but very much
faster.
+ *
+ * Should be able to replace java.io.BufferedReader in nearly every use-cases
when you
+ * need the Reader be buffered, but do not need it have thread safety.
+ */
+public class UnsynchronizedBufferedReader extends Reader {
+private
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532107 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 20:12 Start Date: 06/Jan/21 20:12 Worklog Time Spent: 10m Work Description: garydgregory commented on a change in pull request #184: URL: https://github.com/apache/commons-io/pull/184#discussion_r552939257 ## File path: pom.xml ## @@ -469,5 +482,44 @@ file comparators, endian transformation classes, and much more. true + + benchmark + +true +org.apache + + + + +org.codehaus.mojo +exec-maven-plugin +1.6.0 Review comment: Why did you pick a seemingly random old version? Why not 3.0.0, which is the current version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 532107) Time Spent: 1h (was: 50m) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and perfo
garydgregory commented on a change in pull request #184: URL: https://github.com/apache/commons-io/pull/184#discussion_r552939257 ## File path: pom.xml ## @@ -469,5 +482,44 @@ file comparators, endian transformation classes, and much more. true + + benchmark + +true +org.apache + + + + +org.codehaus.mojo +exec-maven-plugin +1.6.0 Review comment: Why did you pick a seemingly random old version? Why not 3.0.0, which is the current version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532106 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 20:11 Start Date: 06/Jan/21 20:11 Worklog Time Spent: 10m Work Description: garydgregory commented on a change in pull request #184: URL: https://github.com/apache/commons-io/pull/184#discussion_r552938903 ## File path: pom.xml ## @@ -300,6 +312,7 @@ file comparators, endian transformation classes, and much more. true Gary Gregory 86fdc7e2a11262cb +1.21 Review comment: Why did you pick a seemingly random old version? Why not 1.27, which is the current version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 532106) Time Spent: 50m (was: 40m) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory commented on a change in pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and perfo
garydgregory commented on a change in pull request #184: URL: https://github.com/apache/commons-io/pull/184#discussion_r552938903 ## File path: pom.xml ## @@ -300,6 +312,7 @@ file comparators, endian transformation classes, and much more. true Gary Gregory 86fdc7e2a11262cb +1.21 Review comment: Why did you pick a seemingly random old version? Why not 1.27, which is the current version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532103=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532103 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 20:09 Start Date: 06/Jan/21 20:09 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT" ``` instead of `2.9.0-SNAPSHOT`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 532103) Time Spent: 0.5h (was: 20m) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=532104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532104 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 20:09 Start Date: 06/Jan/21 20:09 Worklog Time Spent: 10m Work Description: garydgregory edited a comment on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT ``` instead of `2.9.0-SNAPSHOT`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 532104) Time Spent: 40m (was: 0.5h) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] garydgregory edited a comment on pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and performanc
garydgregory edited a comment on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT ``` instead of `2.9.0-SNAPSHOT`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and performance tests
garydgregory commented on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755618217 Something is not quite right with this set up because the output starts with: ``` Building Apache Commons IO 2.7.1-SNAPSHOT" ``` instead of `2.9.0-SNAPSHOT`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-dbcp] garydgregory merged pull request #83: Bump japicmp-maven-plugin from 0.14.4 to 0.15.1
garydgregory merged pull request #83: URL: https://github.com/apache/commons-dbcp/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1637) FastDatePrinter formatting using YY pattern yields junk digits
[
https://issues.apache.org/jira/browse/LANG-1637?focusedWorklogId=532083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532083
]
ASF GitHub Bot logged work on LANG-1637:
Author: ASF GitHub Bot
Created on: 06/Jan/21 19:25
Start Date: 06/Jan/21 19:25
Worklog Time Spent: 10m
Work Description: michael-o commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r552917466
##
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##
@@ -1118,7 +1118,7 @@ public void appendTo(final Appendable buffer, final
Calendar calendar) throws IO
*/
@Override
public final void appendTo(final Appendable buffer, final int value)
throws IOException {
-appendDigits(buffer, value);
+appendDigits(buffer, value % 100);
Review comment:
I think for the ease of use we have to use this one because my solution
leaks abstraction. It makes too many assumptions about in the delegated
`NumberRule`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 532083)
Time Spent: 4h 40m (was: 4.5h)
> FastDatePrinter formatting using YY pattern yields junk digits
> --
>
> Key: LANG-1637
> URL: https://issues.apache.org/jira/browse/LANG-1637
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.11
>Reporter: Uri Gonen
>Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> {code:java}
> final GregorianCalendar cal = new GregorianCalendar(2020, 12, 31, 0, 0, 0);
> final DatePrinter printer2Digits = getInstance("YY");
> assertEquals("21", printer2Digits.format(cal));
> {code}
> the above test fails
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] michael-o commented on a change in pull request #688: [LANG-1637] Fix 2 digit week year formatting
michael-o commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r552917466
##
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##
@@ -1118,7 +1118,7 @@ public void appendTo(final Appendable buffer, final
Calendar calendar) throws IO
*/
@Override
public final void appendTo(final Appendable buffer, final int value)
throws IOException {
-appendDigits(buffer, value);
+appendDigits(buffer, value % 100);
Review comment:
I think for the ease of use we have to use this one because my solution
leaks abstraction. It makes too many assumptions about in the delegated
`NumberRule`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-pool] garydgregory merged pull request #59: Bump spotbugs-maven-plugin from 4.1.4 to 4.2.0
garydgregory merged pull request #59: URL: https://github.com/apache/commons-pool/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=531969=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531969 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 16:47 Start Date: 06/Jan/21 16:47 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755419454 Detailed performance tests results: https://pastebin.ubuntu.com/p/TtDxYw4WVG/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531969) Time Spent: 20m (was: 10m) > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=531968=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531968 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Created on: 06/Jan/21 16:47 Start Date: 06/Jan/21 16:47 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-755419401 > Hello @XenoAmess > We already have a lot of changes for the next release, so I want to manage expectations such that I would I prefer to get out 3.12 before making even more big changes like these. > > But still, let's continue this thread. Starting with the lowest-level bits: we need to justify the addition of the misnamed `Unsync*` classes, the prefix should be `Unsynchronized` like our existing `UnsynchronizedByteArrayInputStream`, which I've already mentioned. Perhaps our addition of UnsynchronizedByteArrayInputStream was a mistake since the Java folks make it sounds like these are superfluous in https://bugs.openjdk.java.net/browse/JDK-4097272, so I think we need to see a performance test that shows there is a clear performance benefit to adding those as valuable on their own. > > We need performances test that show the differences, if any, between the JRE's classes and our proposed `Unsynchronized` versions. Since you propose two such classes `UnsyncBufferedInputStream` and `UnsyncBufferedReader`, that's two new tests. Or did I miss these here? > > I think you should create a new PR for just these two new classes and their tests. This will make the work simpler for everyone when reviewing and testing. > > TY. @garydgregory Hi. I done the performance test at https://github.com/apache/commons-io/pull/184. The two classes is faster, but not as that faster as we thought. Detailed performance tests results: https://pastebin.ubuntu.com/p/TtDxYw4WVG/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531968) Time Spent: 14h (was: 13h 50m) > IOUtils.contentEquals is of low performance. I will refine it. > -- > > Key: IO-670 > URL: https://issues.apache.org/jira/browse/IO-670 > Project: Commons IO > Issue Type: Improvement >Reporter: Jin Xu >Priority: Critical > Attachments: jmh-result.org.apache.json > > Time Spent: 14h > Remaining Estimate: 0h > > [https://github.com/apache/commons-io/pull/118] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess commented on pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and performance tests.
XenoAmess commented on pull request #184: URL: https://github.com/apache/commons-io/pull/184#issuecomment-755419454 Detailed performance tests results: https://pastebin.ubuntu.com/p/TtDxYw4WVG/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-755419401 > Hello @XenoAmess > We already have a lot of changes for the next release, so I want to manage expectations such that I would I prefer to get out 3.12 before making even more big changes like these. > > But still, let's continue this thread. Starting with the lowest-level bits: we need to justify the addition of the misnamed `Unsync*` classes, the prefix should be `Unsynchronized` like our existing `UnsynchronizedByteArrayInputStream`, which I've already mentioned. Perhaps our addition of UnsynchronizedByteArrayInputStream was a mistake since the Java folks make it sounds like these are superfluous in https://bugs.openjdk.java.net/browse/JDK-4097272, so I think we need to see a performance test that shows there is a clear performance benefit to adding those as valuable on their own. > > We need performances test that show the differences, if any, between the JRE's classes and our proposed `Unsynchronized` versions. Since you propose two such classes `UnsyncBufferedInputStream` and `UnsyncBufferedReader`, that's two new tests. Or did I miss these here? > > I think you should create a new PR for just these two new classes and their tests. This will make the work simpler for everyone when reviewing and testing. > > TY. @garydgregory Hi. I done the performance test at https://github.com/apache/commons-io/pull/184. The two classes is faster, but not as that faster as we thought. Detailed performance tests results: https://pastebin.ubuntu.com/p/TtDxYw4WVG/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LANG-1631) Add short circuits in CharSequenceUtils if a character is not defined
[
https://issues.apache.org/jira/browse/LANG-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259873#comment-17259873
]
Arturo Bernal commented on LANG-1631:
-
In master.
TY
> Add short circuits in CharSequenceUtils if a character is not defined
> -
>
> Key: LANG-1631
> URL: https://issues.apache.org/jira/browse/LANG-1631
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
>Reporter: Arturo Bernal
>Priority: Major
> Fix For: 3.12
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
>
> Crash when the the char to be searched value it's out of range >= '\u'
> <= '\u'
> Getting the next error -->
>
> {code:java}
> java.lang.IllegalArgumentException: Not a valid Unicode code point:
> 0xF936{code}
>
>
> Basically the problem is that when it is verified that the character to
> search is less than MIN_SUPPLEMENTARY_CODE_POINT, the search is not exited of
> the loop. It continues searching but this time values less than or equal to
> Character.MAX_CODE_POINT
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?focusedWorklogId=531952=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531952 ] ASF GitHub Bot logged work on IO-698: - Author: ASF GitHub Bot Created on: 06/Jan/21 16:23 Start Date: 06/Jan/21 16:23 Worklog Time Spent: 10m Work Description: XenoAmess opened a new pull request #184: URL: https://github.com/apache/commons-io/pull/184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531952) Remaining Estimate: 0h Time Spent: 10m > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
[ https://issues.apache.org/jira/browse/IO-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated IO-698: -- Description: https://github.com/apache/commons-io/pull/184 > add UnsyncBufferedInputStream and UnsyncBufferedReader and tests > > > Key: IO-698 > URL: https://issues.apache.org/jira/browse/IO-698 > Project: Commons IO > Issue Type: Improvement > Components: Streams/Writers >Reporter: Jin Xu >Priority: Minor > > https://github.com/apache/commons-io/pull/184 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] XenoAmess opened a new pull request #184: [IO-698] add Unsynchronized version of UnsynchronizedBufferedInputStream and UnsynchronizedBufferedInputStream, and performance tests.
XenoAmess opened a new pull request #184: URL: https://github.com/apache/commons-io/pull/184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (IO-698) add UnsyncBufferedInputStream and UnsyncBufferedReader and tests
Jin Xu created IO-698: - Summary: add UnsyncBufferedInputStream and UnsyncBufferedReader and tests Key: IO-698 URL: https://issues.apache.org/jira/browse/IO-698 Project: Commons IO Issue Type: Improvement Components: Streams/Writers Reporter: Jin Xu -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1636) Add missing boolean[] join method
[ https://issues.apache.org/jira/browse/LANG-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated LANG-1636: -- Summary: Add missing boolean[] join method (was: Boolean Join Function) > Add missing boolean[] join method > - > > Key: LANG-1636 > URL: https://issues.apache.org/jira/browse/LANG-1636 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Join Implementation it's missing for primitive of type boolean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1636) Boolean Join Function
[ https://issues.apache.org/jira/browse/LANG-1636?focusedWorklogId=531940=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531940 ] ASF GitHub Bot logged work on LANG-1636: Author: ASF GitHub Bot Created on: 06/Jan/21 16:01 Start Date: 06/Jan/21 16:01 Worklog Time Spent: 10m Work Description: garydgregory merged pull request #686: URL: https://github.com/apache/commons-lang/pull/686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531940) Time Spent: 50m (was: 40m) > Boolean Join Function > - > > Key: LANG-1636 > URL: https://issues.apache.org/jira/browse/LANG-1636 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Join Implementation it's missing for primitive of type boolean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory merged pull request #686: [LANG-1636] - Boolean Join Function
garydgregory merged pull request #686: URL: https://github.com/apache/commons-lang/pull/686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1636) Boolean Join Function
[ https://issues.apache.org/jira/browse/LANG-1636?focusedWorklogId=531932=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531932 ] ASF GitHub Bot logged work on LANG-1636: Author: ASF GitHub Bot Created on: 06/Jan/21 15:53 Start Date: 06/Jan/21 15:53 Worklog Time Spent: 10m Work Description: garydgregory commented on pull request #686: URL: https://github.com/apache/commons-lang/pull/686#issuecomment-755382046 Indeed, boolean[] is missing for this API, thanks @arturobernalg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531932) Time Spent: 40m (was: 0.5h) > Boolean Join Function > - > > Key: LANG-1636 > URL: https://issues.apache.org/jira/browse/LANG-1636 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Join Implementation it's missing for primitive of type boolean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on pull request #686: [LANG-1636] - Boolean Join Function
garydgregory commented on pull request #686: URL: https://github.com/apache/commons-lang/pull/686#issuecomment-755382046 Indeed, boolean[] is missing for this API, thanks @arturobernalg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1637) FastDatePrinter formatting using YY pattern yields junk digits
[
https://issues.apache.org/jira/browse/LANG-1637?focusedWorklogId=531919=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531919
]
ASF GitHub Bot logged work on LANG-1637:
Author: ASF GitHub Bot
Created on: 06/Jan/21 15:29
Start Date: 06/Jan/21 15:29
Worklog Time Spent: 10m
Work Description: garydgregory commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r552716201
##
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##
@@ -1118,7 +1118,7 @@ public void appendTo(final Appendable buffer, final
Calendar calendar) throws IO
*/
@Override
public final void appendTo(final Appendable buffer, final int value)
throws IOException {
-appendDigits(buffer, value);
+appendDigits(buffer, value % 100);
Review comment:
Well... which way is this one going to go? @ugonen Are you going to
update your PR or @michael-o do you want to provide a different PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 531919)
Time Spent: 4.5h (was: 4h 20m)
> FastDatePrinter formatting using YY pattern yields junk digits
> --
>
> Key: LANG-1637
> URL: https://issues.apache.org/jira/browse/LANG-1637
> Project: Commons Lang
> Issue Type: Bug
>Affects Versions: 3.11
>Reporter: Uri Gonen
>Priority: Minor
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> {code:java}
> final GregorianCalendar cal = new GregorianCalendar(2020, 12, 31, 0, 0, 0);
> final DatePrinter printer2Digits = getInstance("YY");
> assertEquals("21", printer2Digits.format(cal));
> {code}
> the above test fails
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-lang] garydgregory commented on a change in pull request #688: [LANG-1637] Fix 2 digit week year formatting
garydgregory commented on a change in pull request #688:
URL: https://github.com/apache/commons-lang/pull/688#discussion_r552716201
##
File path: src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java
##
@@ -1118,7 +1118,7 @@ public void appendTo(final Appendable buffer, final
Calendar calendar) throws IO
*/
@Override
public final void appendTo(final Appendable buffer, final int value)
throws IOException {
-appendDigits(buffer, value);
+appendDigits(buffer, value % 100);
Review comment:
Well... which way is this one going to go? @ugonen Are you going to
update your PR or @michael-o do you want to provide a different PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #692: Bump spotbugs-maven-plugin from 4.1.4 to 4.2.0
garydgregory merged pull request #692: URL: https://github.com/apache/commons-lang/pull/692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #183: Bump jimfs from 1.1 to 1.2
garydgregory merged pull request #183: URL: https://github.com/apache/commons-io/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #180: Bump spotbugs-maven-plugin from 4.1.4 to 4.2.0
garydgregory merged pull request #180: URL: https://github.com/apache/commons-io/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (BEANUTILS-543) Failed to marshal EJB parameters
ali akbar Shahriari Garaei created BEANUTILS-543:
Summary: Failed to marshal EJB parameters
Key: BEANUTILS-543
URL: https://issues.apache.org/jira/browse/BEANUTILS-543
Project: Commons BeanUtils
Issue Type: Bug
Environment: I use Wildfly 11 as server and Vaadin 18 with java 8.
*{{@Stateless@Remote(QueriesRemote.class)@org.jboss.ejb3.annotation.TransactionTimeout(value
= 20, unit = TimeUnit.MINUTES)public class Queries extends Base implements
QueriesRemote{@PersistenceContextprivate EntityManager manager;
@Resource(mappedName="java:/TedingDS")private javax.sql.DataSource db;
@ResourceSessionContext ctx;public List
findRecordsInTable(String querySource){
List beanList = Collections.EMPTY_LIST;try (ResultSet
myResult =
db.getConnection().createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
ResultSet.CONCUR_READ_ONLY).executeQuery(querySource)) {
RowSetDynaClass rsdc = new RowSetDynaClass(myResult, false);
beanList = rsdc.getRows();
closeAllViaResultSet(myResult);
} catch (SQLException e) {
logger.log(Level.SEVERE, "From
class:".concat(this.getClass().getName()));
}return beanList;
}
}}}*
{{@Route(value = QueriesView.ROUTE, layout =
MainLayout.class)@PageTitle(QueriesView.TITLE)public class QueriesView extends
VerticalLayout implements BeforeEnterObserver, BeforeLeaveObserver,
AfterNavigationObserver, LocaleChangeObserver, HasUrlParameter {
private final Logger LOGGER = Logger.getLogger(this.getClass().getName());
public static final String ROUTE = "queryView";public static final String
TITLE = "Query";@EJBpublic QueriesRemote remote;public
QueriesView() {}@Overridepublic void beforeEnter(BeforeEnterEvent
beforeEnterEvent) {
LOGGER.info("beforeEnter queryView");if(remote == null)
Notification.show("beforeEnter remote == null");else {
List list = remote.findRecordsInTable("select * from
attached limit 5");
Notification.show("Size
beforeEnter:".concat(String.valueOf(list.size())), 5000,
Notification.Position.MIDDLE);
}
}
}}}
Reporter: ali akbar Shahriari Garaei
I have added a new method to {{EJB3}} and I get the following error. I know it
is due to serializable issue, but I can't change the object because it is from
external library {{org.apache.commons.beanutils}}.
Furthermore, I use Wildfly 11 as server and Vaadin 18 with java 8.
*Is there any workaround for it?*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-daemon] markt-asf merged pull request #19: JUnit v4.13.1
markt-asf merged pull request #19: URL: https://github.com/apache/commons-daemon/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-daemon] markt-asf commented on pull request #19: JUnit v4.13.1
markt-asf commented on pull request #19: URL: https://github.com/apache/commons-daemon/pull/19#issuecomment-755261898 I'll note that there aren't any unit tests in Commons Daemon and that the JUnit library is not used. I'm tempted to remove it entirely but a) I suspect that might be more complex than it first appears and b) I don't want to create unnecessary barriers for any future contributions of unit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-geometry] arturobernalg opened a new pull request #127: Minor Performance Improvement:
arturobernalg opened a new pull request #127: URL: https://github.com/apache/commons-geometry/pull/127 * avoid Add Empty String --> https://pmd.github.io/pmd-6.27.0/pmd_rules_java_performance.html#addemptystring * Redundant Field Initializer --> https://pmd.github.io/pmd-6.27.0/pmd_rules_java_performance.html#redundantfieldinitializer * Append Character With Char --> https://pmd.github.io/pmd 6.27.0/pmd_rules_java_performance.html#appendcharacterwithchar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DAEMON-428) apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE
[ https://issues.apache.org/jira/browse/DAEMON-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-428. Fix Version/s: 1.2.4 Resolution: Fixed > apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE > -- > > Key: DAEMON-428 > URL: https://issues.apache.org/jira/browse/DAEMON-428 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.0.8 >Reporter: Paul Smith >Priority: Major > Fix For: 1.2.4 > > Attachments: prunsrv.patch > > > The same issue as reported in DAEMON-163 is also present in the > apxMultiSzToArrayW() method in src/native/windows/src/utils.c. > Patch to fix is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1614) Split fixed-length elements
[ https://issues.apache.org/jira/browse/LANG-1614?focusedWorklogId=531818=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531818 ] ASF GitHub Bot logged work on LANG-1614: Author: ASF GitHub Bot Created on: 06/Jan/21 11:08 Start Date: 06/Jan/21 11:08 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #693: URL: https://github.com/apache/commons-lang/pull/693#issuecomment-755237313 [](https://coveralls.io/builds/36122960) Coverage increased (+0.01%) to 95.002% when pulling **d0b7ead1674ae3f4ed26ad22e75194869c458f42 on arturobernalg:feature/LANG-1614** into **3ba01073f647da53e4ee662a491be88728cb8b6c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531818) Time Spent: 1h 20m (was: 1h 10m) > Split fixed-length elements > --- > > Key: LANG-1614 > URL: https://issues.apache.org/jira/browse/LANG-1614 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* >Affects Versions: 3.11 >Reporter: Arturo Bernal >Priority: Minor > Labels: StringUtils, improvement, pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Create a new method that split a string into an array of fixed-length elements -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #693: [LANG-1614] - Split fixed-length elements
coveralls commented on pull request #693: URL: https://github.com/apache/commons-lang/pull/693#issuecomment-755237313 [](https://coveralls.io/builds/36122960) Coverage increased (+0.01%) to 95.002% when pulling **d0b7ead1674ae3f4ed26ad22e75194869c458f42 on arturobernalg:feature/LANG-1614** into **3ba01073f647da53e4ee662a491be88728cb8b6c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #687: Minor improvements
coveralls edited a comment on pull request #687: URL: https://github.com/apache/commons-lang/pull/687#issuecomment-752029030 [](https://coveralls.io/builds/36122168) Coverage remained the same at 94.991% when pulling **d8bce1b86a155e607238b1342cbdd5950f72173d on arturobernalg:feature/minor_improvement** into **3ba01073f647da53e4ee662a491be88728cb8b6c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1636) Boolean Join Function
[ https://issues.apache.org/jira/browse/LANG-1636?focusedWorklogId=531799=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531799 ] ASF GitHub Bot logged work on LANG-1636: Author: ASF GitHub Bot Created on: 06/Jan/21 10:33 Start Date: 06/Jan/21 10:33 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #686: URL: https://github.com/apache/commons-lang/pull/686#issuecomment-752009669 [](https://coveralls.io/builds/36122135) Coverage increased (+0.004%) to 94.995% when pulling **864e62b85726ec04821e727e575f311ce530d2a6 on arturobernalg:feature/LANG-1636** into **3ba01073f647da53e4ee662a491be88728cb8b6c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 531799) Time Spent: 0.5h (was: 20m) > Boolean Join Function > - > > Key: LANG-1636 > URL: https://issues.apache.org/jira/browse/LANG-1636 > Project: Commons Lang > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Join Implementation it's missing for primitive of type boolean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DAEMON-428) apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE
[ https://issues.apache.org/jira/browse/DAEMON-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259582#comment-17259582 ] Mark Thomas commented on DAEMON-428: Thanks for the report. A search of the code base found a second instance just above the one you reported in apxSetEnvironmentVariable. I have a fix fro both and should be committing it shortly. > apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE > -- > > Key: DAEMON-428 > URL: https://issues.apache.org/jira/browse/DAEMON-428 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.0.8 >Reporter: Paul Smith >Priority: Major > Attachments: prunsrv.patch > > > The same issue as reported in DAEMON-163 is also present in the > apxMultiSzToArrayW() method in src/native/windows/src/utils.c. > Patch to fix is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls edited a comment on pull request #686: [LANG-1636] - Boolean Join Function
coveralls edited a comment on pull request #686: URL: https://github.com/apache/commons-lang/pull/686#issuecomment-752009669 [](https://coveralls.io/builds/36122135) Coverage increased (+0.004%) to 94.995% when pulling **864e62b85726ec04821e727e575f311ce530d2a6 on arturobernalg:feature/LANG-1636** into **3ba01073f647da53e4ee662a491be88728cb8b6c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DAEMON-427) Lack of JvmOptions causes crash
[ https://issues.apache.org/jira/browse/DAEMON-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-427. Resolution: Duplicate > Lack of JvmOptions causes crash > --- > > Key: DAEMON-427 > URL: https://issues.apache.org/jira/browse/DAEMON-427 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.2.3 >Reporter: Grzegorz Niemirowski >Priority: Major > Labels: documentation > > When --JvmOptions parameter is not specified, a NULL pointer is passed to > setInprocEnvironmentOptions(). The function doesn't check for NULL pointer > and tries to dereference it. > From the documentation I guess JvmOptions is not a mandatory parameter. It > says the parameter has default value and the parameter is not mentioned in > the install example. prunsrv should work without this parameter. Now it > crashes and Windows returns an error: _Error 1067_: The process terminated > unexpectedly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (DAEMON-428) apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE
[ https://issues.apache.org/jira/browse/DAEMON-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas reopened DAEMON-428: > apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE > -- > > Key: DAEMON-428 > URL: https://issues.apache.org/jira/browse/DAEMON-428 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.0.8 >Reporter: Paul Smith >Priority: Major > Attachments: prunsrv.patch > > > The same issue as reported in DAEMON-163 is also present in the > apxMultiSzToArrayW() method in src/native/windows/src/utils.c. > Patch to fix is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (DAEMON-428) apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE
[ https://issues.apache.org/jira/browse/DAEMON-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-428. Resolution: Duplicate > apxMultiSzToArrayW has incorrect use of IS_INVALID_HANDLE > -- > > Key: DAEMON-428 > URL: https://issues.apache.org/jira/browse/DAEMON-428 > Project: Commons Daemon > Issue Type: Bug > Components: prunsrv >Affects Versions: 1.0.8 >Reporter: Paul Smith >Priority: Major > Attachments: prunsrv.patch > > > The same issue as reported in DAEMON-163 is also present in the > apxMultiSzToArrayW() method in src/native/windows/src/utils.c. > Patch to fix is attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-io] coveralls commented on pull request #183: Bump jimfs from 1.1 to 1.2
coveralls commented on pull request #183: URL: https://github.com/apache/commons-io/pull/183#issuecomment-755170080 [](https://coveralls.io/builds/36119813) Coverage decreased (-0.01%) to 88.715% when pulling **ef2cc549bee8a33baff04959326e8a793db210a0 on dependabot/maven/com.google.jimfs-jimfs-1.2** into **fc6a548fe9003ad783ce35f5a5c526472eb0720f on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
